From nobody Sat Apr 4 01:34:08 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 035C738B147 for ; Sat, 21 Mar 2026 11:51:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774093883; cv=none; b=OFYDY6BjU7WHdH/PSXWoQRcnAwLCAERUAx4dP3wMPy35dp/Pf+H+/4sNihXJ7h8O1a1qbNt4KLhZmSF3btKjCYaCMK25iob0+33VeaZJBS9yH7lXW8t3wDu9sFnTbM+9352AdfuKPs4WLTEQShg5tM7FWuvPG1l0dKZLpnrKcZU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774093883; c=relaxed/simple; bh=3eh1OT9D9BpUpvEjoVisoWRX18q+qGa+eoXu3OkBq4c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IGulShDtq4oTqGJt+cD6ljOIksp3sYoSScZYOiomvkm+fkJ15FavT04MBWAHp60ipbU3qtr7MHAp370LvRybpYjId35z85bol9IL2I7d/pxfQQX2r0eU1lVOGxmgAcbG1V/MI0dq19X3NZ9u0Y7LaX98ffWjl6Gq2tldfpPdKn0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OM3sOxiy; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OM3sOxiy" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2ad9f316d68so13893465ad.2 for ; Sat, 21 Mar 2026 04:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774093880; x=1774698680; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=oyLTWwt1nTioiwAe9v9UZu9ANFhBTLIrCwfF5jN5Q80=; b=OM3sOxiydeXhfcbcK4R5UBu6OvwfBvW5k0pPwN14pREV1XlseTJihDpqgjOU3/g/ga t1EC7NvIeKlHSWHOMSXEFBSpUpjV1KWB72xO76JRQPqaffXAZvvEuBzddwqb9TBUHxsj EW7bmdFm6CyJDqufqFoj4141+oJA8j5vLTi9QwBvQ/u9FDAwotpp258iwOM0gdUzLAF1 ozol7y8Tbbi7Ktuyo0Mzlkvwk2gDisNUjDYgMH95RkAlutGqUzPaCH5LuMAISlzxzVYb B9BMa7DeNTgVF7Mg/21WXEF/4mOEOQDsNYBYWgji4foOB4aGrDiRD+c268djPWYvfZiB 5lcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774093880; x=1774698680; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oyLTWwt1nTioiwAe9v9UZu9ANFhBTLIrCwfF5jN5Q80=; b=SgSgLZw98IcnSD19F/SA5rQyt+mgH8JlGiVQ30MqpNh+Z6F84HnpHBWnLEoRfVWoeE FQZpaitSsUP01kwDyOaxyGSNxYPlmrcA+DPbHw4pGfPWmXabVQjcymXmZPaixaRXZAzH LtlHmApQ7rbt235gz8N3+HTT4RO5lOjBfOw8ejGGhgHL6S0xJVydO2RFl/BkCuZFoslT 2d9MEh1NUESkfxgnPQtUJDGaGPb85w6OY0DaJhZ7KBuKO5tvTREfCLN2+HF7bVOMMqJV z8n8o5+QYXoOxFTsf8GsKEhH+Hq8u+zdNKSPLPRcajryof4Y0ANrHnJGHSYN6LxLCQFY 3w2A== X-Forwarded-Encrypted: i=1; AJvYcCUuKADMb8meUnx0reu9Pd2+YId+W4TLPQSrvewH6956OFXW+6dEptTkTXk5Vv0/MHIQNJNraN38IDUWd4w=@vger.kernel.org X-Gm-Message-State: AOJu0YxRCMshAUbX7/uhYACkb/qe7mPpTDJlPOh1TjUYMXaxVaTQU8Zn wpUZwFJ+wAop48tpWpIubLyyxf/yW0znrUlEeEsbqJtexBicjmmMUT4p X-Gm-Gg: ATEYQzwqg0exOGJS9VrkhPy5dYe1am29nT7lr3rp6tm0eA+r9HRQmIpRWUF8Btk6rzZ xChiTcpToP3fHTiqVEagWa2B1CSLUKsjN16RcxHRP3h4JOJkAO6dOellkNbsXT06q8t/pe5tSfo wlqXZA/PaF2mZyh5shb+T8o54VC+22ODHeIeiMSMb+IqsgyWTAqQVGnHOJ4WClRLNmiKMyPOYUn badEkkCNownGq7gXujgSO7OZGfeHky168vhhnoBaynEn6mHabNfjh4mzVTfmvwEoMoSlOJsixsP oxg1MDqPCEfd0ngbNJI9GK14cGUQBHCmA+hYEkdcuAheXL1YkfZN1+0y5YwSjtfc+/ugEyymfms cLYKce0SZ/OOKdOU6ZzzS4ezPDQQV/FX9nEEJVNr1Zr5SW6NgoKSO07tGigpwhsy3eyffVR/403 OM9FQQI43m4ZtbQSNQP61mmcYt/x/uY2Y= X-Received: by 2002:a17:903:986:b0:2b0:5548:7d80 with SMTP id d9443c01a7336-2b08278afd1mr50197575ad.27.1774093880318; Sat, 21 Mar 2026 04:51:20 -0700 (PDT) Received: from lgs.. ([223.80.110.53]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b083516ab1sm67487685ad.5.2026.03.21.04.51.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 04:51:19 -0700 (PDT) From: Guangshuo Li To: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Joshua Hay , Madhu Chittim , Tatyana Nikolova , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] dpf: fix UAF and double free in idpf_plug_vport_aux_dev() error path Date: Sat, 21 Mar 2026 19:51:03 +0800 Message-ID: <20260321115103.815004-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If auxiliary_device_add() fails, idpf_plug_vport_aux_dev() calls auxiliary_device_uninit(adev), whose release callback idpf_vport_adev_release() frees the containing struct iidc_rdma_vport_auxiliary_dev. The current error path then accesses adev->id and later frees iadev again, which may lead to a use-after-free and double free. Fix it by storing the allocated auxiliary device id in a local variable and avoiding direct freeing of iadev after auxiliary_device_uninit(). Fixes: be91128c579c ("idpf: implement RDMA vport auxiliary dev create, init= , and destroy") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/net/ethernet/intel/idpf/idpf_idc.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/idpf/idpf_idc.c b/drivers/net/ether= net/intel/idpf/idpf_idc.c index 6dad0593f7f2..a5e7c42a9e6c 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_idc.c +++ b/drivers/net/ethernet/intel/idpf/idpf_idc.c @@ -59,6 +59,7 @@ static int idpf_plug_vport_aux_dev(struct iidc_rdma_core_= dev_info *cdev_info, char name[IDPF_IDC_MAX_ADEV_NAME_LEN]; struct auxiliary_device *adev; int ret; + int adev_id; =20 iadev =3D kzalloc(sizeof(*iadev), GFP_KERNEL); if (!iadev) @@ -73,12 +74,15 @@ static int idpf_plug_vport_aux_dev(struct iidc_rdma_cor= e_dev_info *cdev_info, pr_err("failed to allocate unique device ID for Auxiliary driver\n"); goto err_ida_alloc; } - adev->id =3D ret; + adev_id =3D ret; + adev->id =3D adev_id; + adev->dev.release =3D idpf_vport_adev_release; adev->dev.parent =3D &cdev_info->pdev->dev; sprintf(name, "%04x.rdma.vdev", cdev_info->pdev->vendor); adev->name =3D name; - + /* iadev is owned by the auxiliary device */ + iadev =3D NULL; ret =3D auxiliary_device_init(adev); if (ret) goto err_aux_dev_init; @@ -92,7 +96,7 @@ static int idpf_plug_vport_aux_dev(struct iidc_rdma_core_= dev_info *cdev_info, err_aux_dev_add: auxiliary_device_uninit(adev); err_aux_dev_init: - ida_free(&idpf_idc_ida, adev->id); + ida_free(&idpf_idc_ida, adev_id); err_ida_alloc: vdev_info->adev =3D NULL; kfree(iadev); --=20 2.43.0