From nobody Sat Apr 4 01:37:21 2026 Received: from smtpbguseast2.qq.com (smtpbguseast2.qq.com [54.204.34.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90AF936A01A for ; Sat, 21 Mar 2026 10:58:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.204.34.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774090707; cv=none; b=idO4dr+ChAWwUJ+inOrtsRIiAxjmlKk9+EZkrOAKrjtBhRvTOzPR4g5fAFangkZaWsJdZxe6pbjJe1zTIZIgp/EIxOEGn35mUXYTsqXKY8vnxAdCmfZobk7Vq6SeY1nLLDHy+PZNLl3+7E+APNwpKS1VxPUhhHnpEkXd6XQpRPI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774090707; c=relaxed/simple; bh=PVZfoSEY21//DA27hnK50y5S1cLV+98eFwfslECySPo=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=h5pCG5fY0gUxFx6WfmcJgybSCGaLDe2DFhtjxOoHOkEf1kE45I+v/WhOKumwJedjEEQ5rF2JI4c5X2SaUvcyQic7iFNTkgk1MvSua+JVAQ8YvjlRHALlBeBCSHuz3N8WT9LSwwY+TPqFurK8IFn3HHg8P8WYQ0nGR0XyPFv1pAM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=smail.nju.edu.cn; spf=pass smtp.mailfrom=smail.nju.edu.cn; dkim=pass (1024-bit key) header.d=smail.nju.edu.cn header.i=@smail.nju.edu.cn header.b=h1L0ZIm2; arc=none smtp.client-ip=54.204.34.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=smail.nju.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=smail.nju.edu.cn Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=smail.nju.edu.cn header.i=@smail.nju.edu.cn header.b="h1L0ZIm2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smail.nju.edu.cn; s=iohv2404; t=1774090701; bh=oR7/taKa02ak4M7U1k8zDcir8rfHGE1O5n8xEZ7jI5c=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=h1L0ZIm2COGs4G799Lh/DEL6iEBLrdLayJU4rj76agwz5V31+ZbLDUepYnLKV39bx s2efQBccKkT6Vj1y8JPxXL7/owKIN6AcKXQb7QKfJsVctpSuihF6RVzQKdB84vWShj 9EHPZirEd5q2beXkAVmCE4+mRfztzV5D6RUFav8Y= X-QQ-mid: esmtpsz11t1774090698t874c55b9 X-QQ-Originating-IP: UCCHATCo+fkZj52uVTSv7poe6w02/BFI6ujd/On2YH4= Received: from localhost.localdomain ( [116.172.93.199]) by bizesmtp.qq.com (ESMTP) with id ; Sat, 21 Mar 2026 18:58:14 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 1 X-BIZMAIL-ID: 2501166162289827961 EX-QQ-RecipientCnt: 23 From: Kexin Sun To: akpm@linux-foundation.org, chrisl@kernel.org, kasong@tencent.com, shikemeng@huaweicloud.com, nphamcs@gmail.com, bhe@redhat.com, baohua@kernel.org, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, hannes@cmpxchg.org, david@kernel.org, mhocko@kernel.org, zhengqi.arch@bytedance.com, shakeel.butt@linux.dev, lorenzo.stoakes@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: julia.lawall@inria.fr, xutong.ma@inria.fr, kexinsun@smail.nju.edu.cn, yunbolyu@smu.edu.sg, ratnadiraw@smu.edu.sg Subject: [PATCH] mm: update outdated comments for removed scan_swap_map_slots() Date: Sat, 21 Mar 2026 18:58:14 +0800 Message-Id: <20260321105814.7053-1-kexinsun@smail.nju.edu.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: esmtpsz:smail.nju.edu.cn:qybglogicsvrgz:qybglogicsvrgz5b-0 X-QQ-XMAILINFO: MBA0Q7b4Uo1hHtI60BXzW8ZHaXSxyQat1vCOxFk+fNA8rBHCXBSyxYMv lp++0aTNydFo967FlxxL+UePv/vShRh5eof7XVAsDm6JpJsWzNBZMKn6uocmfgKBcDz6+eL fJQq62AxsgAKnlinFXeRnFx7aXismPqK0DJUbLAef9xGXvN7WyLMGU8PIoD6fOU3MF+xg45 5M/LnMYHlxhqkof0EB+vc/kPKpC4xXDL679kZg30VuXx4Ql5YdXJ7w5WMGQbv8JUxj4AXiP OdNrJeXyJZk5zCU5dQt/9JHqxQ7Z+qZRcPnxNp2v5W2q3JRAXoSIvutTcX857/yT013OpDq /aGWDkcM998lVBRFApHBLn2qcapzoHTSP9/npNrc9kAwr7s682feqnrb0WHP2fJDvuVgMJH CAI9T6r34yVQNK3kcIX5nFs5ID6y7hUSVqBlSX/rRBrah+0CNh59lfKw5KllrPYUqJXyEFD f8l+Io9U2F/YrobjHs7qNo73qV6rSUI+WBEoyMzGiPGvqJU3Fa5PH6e7JJA8xpHSMpOODjE E7VT20sj1j9TzCUFAdYDr3lYvePu6Lx0AvVA7EUm/2noiIDrxWjSVtLGO2NFk7oTtLNbYUw Bh1K7piDmB6wFQX07JjYGmFsbHuFIbpAZSDtu0GWXVfF8lG2b4aTfhZkDwG2IDjbp9wcq0s gH6/+EBIVhrAQ5BlZrCL1iweE39giP8H9w1vmZtKw8TiIAYFrF0U8huRQ5Sn1jVRJU9PZzs J4PM+QfcEl7NBfx37OQCQ/o2IAvwGooAsDlGHMMCnXoC9y1cmtajL7ncpk4buOoFk4Ytvb7 XzoZ4Ep+KFCOXkJXAbad990i6inZxv0PsQRabp9xWsxtmLCqcTQ0cqD7oNsuMMIDiHkGc3o IksWKp04ynlL5dLqkK+XUDWdnJLBO31ERrf3tBlZ0XJRT6Oq+f9D18zOM60+EWq+IwhXysF V/cj6lLqD10TvlLOiR1xmaYtVqGztFdJT/wbWMGwBlyVqlacAwZWQe8MqzCrdmRh/Vb1N22 Qj/qGY9pDvuntghKuESuktA4DeIoqcshW9st9oDtFYAVTGJcF7g3QRH11VMj7f21t4DVVtZ xsKqAXYVHxErmCOKMU5rWc+VBgjZwLQcfDcSt7gZM34 X-QQ-XMRINFO: Nq+8W0+stu50tPAe92KXseR0ZZmBTk3gLg== X-QQ-RECHKSPAM: 0 Content-Type: text/plain; charset="utf-8" The function scan_swap_map_slots() was removed in commit 0ff67f990bd4 ("mm, swap: remove swap slot cache"). The three comments referencing it simply noted that ->flags can be updated non-atomically by scan_swap_map_slots() to justify a data_race() annotation. Since the function no longer exists, drop the parenthetical reference while keeping the data_race() justification intact: ->flags can still be updated non-atomically by other paths (e.g., swapoff clearing SWP_WRITEOK). Assisted-by: unnamed:deepseek-v3.2 coccinelle Signed-off-by: Kexin Sun Acked-by: David Hildenbrand (Arm) Reviewed-by: Lorenzo Stoakes (Oracle) --- mm/page_io.c | 4 ++-- mm/vmscan.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/page_io.c b/mm/page_io.c index a2c034660c80..330abc5ab7b4 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -450,14 +450,14 @@ void __swap_writepage(struct folio *folio, struct swa= p_iocb **swap_plug) =20 VM_BUG_ON_FOLIO(!folio_test_swapcache(folio), folio); /* - * ->flags can be updated non-atomically (scan_swap_map_slots), + * ->flags can be updated non-atomically, * but that will never affect SWP_FS_OPS, so the data_race * is safe. */ if (data_race(sis->flags & SWP_FS_OPS)) swap_writepage_fs(folio, swap_plug); /* - * ->flags can be updated non-atomically (scan_swap_map_slots), + * ->flags can be updated non-atomically, * but that will never affect SWP_SYNCHRONOUS_IO, so the data_race * is safe. */ diff --git a/mm/vmscan.c b/mm/vmscan.c index 0fc9373e8251..0758ef3b100b 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1070,7 +1070,7 @@ static bool may_enter_fs(struct folio *folio, gfp_t g= fp_mask) /* * We can "enter_fs" for swap-cache with only __GFP_IO * providing this isn't SWP_FS_OPS. - * ->flags can be updated non-atomically (scan_swap_map_slots), + * ->flags can be updated non-atomically, * but that will never affect SWP_FS_OPS, so the data_race * is safe. */ --=20 2.25.1