From nobody Sat Apr 4 01:37:21 2026 Received: from smtpbgsg2.qq.com (smtpbgsg2.qq.com [54.254.200.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A174936BCE6 for ; Sat, 21 Mar 2026 10:59:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.254.200.128 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774090784; cv=none; b=ViSXbT4sOJBPhbL1XVDxCtMaYmfRNITszi04XFZTyr+biySeYFDKev5uwbh5Yy3YduRHYKn5R0NIiYZVdBQP0nKnaqjigHhoC5tMLkMnGBCAWafzNEwOSi1iVghkTm7dTHlOOm431ST/iQXRmQoBpta5mg/h1cq7iSA5rAorWHo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774090784; c=relaxed/simple; bh=9LQJfH52FDZ8MXuByx3WDc23R4IFP6H6NM3MmWWZZGE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=QzHBbgoNZzvoxl4tkaA/FeVb7IjyeiytXrlz6dmTXlqZAnfQKMnBjoQXGyOMMU5/Tq7MWk7ZIvVjmN4C5uKtWbcMjszfrjRpFHPj84JqynZnEdF/oIXsjO6BvT8oTu21vzGXkWoTZ2q0tcGZJpKJCaeRZNpw3QJUlxM2WkLapJE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=smail.nju.edu.cn; spf=pass smtp.mailfrom=smail.nju.edu.cn; dkim=pass (1024-bit key) header.d=smail.nju.edu.cn header.i=@smail.nju.edu.cn header.b=UWjFQz9J; arc=none smtp.client-ip=54.254.200.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=smail.nju.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=smail.nju.edu.cn Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=smail.nju.edu.cn header.i=@smail.nju.edu.cn header.b="UWjFQz9J" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smail.nju.edu.cn; s=iohv2404; t=1774090698; bh=px/jsi2ceHANvWRDMk70XYPmw0W0Wncr7oochLctQAg=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=UWjFQz9JC1pyaXWO4c+C1OcFPwT4cOBlpWCcdO2flHVjD2xlrqGPgYYF4vkXAQvKT DKptuDQuJ/kKdVzMvm7uKulDzIAhiumL85RATodgt5gGUQeACDWqYizlaIIV8K1Up9 fgsqSzD8A66iUi7AbN5UTUNizRRUACbtB2aZKmQg= X-QQ-mid: esmtpsz10t1774090691t20e7d6a2 X-QQ-Originating-IP: Lb3A0U6FJ+AtZqjzH6fWJMaCH5e9GwsFQ6LxYf9aEMs= Received: from localhost.localdomain ( [116.172.93.199]) by bizesmtp.qq.com (ESMTP) with id ; Sat, 21 Mar 2026 18:58:08 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 18108469352507179237 EX-QQ-RecipientCnt: 19 From: Kexin Sun To: tglx@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, jason.wessel@windriver.com, danielt@kernel.org, dianders@chromium.org, sohil.mehta@intel.com, seanjc@google.com, xin@zytor.com, linux-kernel@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net Cc: julia.lawall@inria.fr, xutong.ma@inria.fr, kexinsun@smail.nju.edu.cn, yunbolyu@smu.edu.sg, ratnadiraw@smu.edu.sg Subject: [PATCH] kgdb: update outdated references to kgdb_wait() Date: Sat, 21 Mar 2026 18:58:08 +0800 Message-Id: <20260321105808.6939-1-kexinsun@smail.nju.edu.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: esmtpsz:smail.nju.edu.cn:qybglogicsvrgz:qybglogicsvrgz5b-0 X-QQ-XMAILINFO: MWN2NjqHd6+NNcl6sIWCWjqZwjrGo4VxQhyeoOI6fXqhy9AVGH0twTIp PQaM09o9uitgRireyHRhjqP3MsftNVnpIfbQfLhrlpZOYRsOPE0PSiQTuC1xUaUyk4qKvc/ LLafAp+T1HvNGakzJCtJNQcgKLGMCpbPORljXes4FSfRy99dUP3vIBBNV7UP7FjBOVFNlKk XXbdaMjMcj70rIJjiFKwxzIrw1CN7nmhzgGqOuj77F/2Rz2CyBhBEcAI4zMvkO1986SNMaV 0NtEFAoz34xLCpIHWevIEzLHGO+3QGblsxeGVHo+UYnBQkr3gt4qBIzW+jOdNb+ydvn/oIv klyZFa7h2DF5uuPjwZ1CBfoT+gVGlPlXFtG2HfaaO95JLu5tTW+O3HtygKS9nQy3sOtJpNV 8/dlXnqGEF1Ob4tPZgLm9NMqST8SKfsmmE68IfBRM3CXLNZ9Mi+8rSMK5L5fl83Jg3sKqx8 4kU2makx7WxX+FzuL0PQ4h5a8pI9+q9RrXQLZmT11U4v5VGdKw3z7KilImYLyZfbTd7Fzck XkWYqhi9YONjrk1jUYeXWhzERWdty7+5P3nSDYL12LOVDpm9gM9vXXOb+8A8gKwdkhvzptZ rXYuuIi03YO/k781GXU6p0QZnE0HehLgqs1WM947hGWD2nDpIiWDd75OQuoOD/rz2IUb8U7 VlScT73j+k0MY6LJ9d5oJfuJqi+xITogOaDVPQ5KO4o+nSJ0TpzNmCGDyYr6rZUOgQogU84 OcbYCTqdDCfhryMHDUhKPKmpzjDZuWt6lFRs7W2Es9SR1gnr/66VxML35IWg2D2urXMaoXP l81wPCg6M3I5Qy25QYp5RQI0xEnoEOhzWrVvwO43veJEhz1MwUizk0QJKCDjufbcb/3m3f5 GygVv02UKOtNbVWZKZOf2jOhSpA7rQK9jdkXWdzeJwzXBkJIgAb2kg29kXCK6faCRdFaLt0 Dyr1rlwfFCyhExz/taecWGOEphFzTgSneWkXqGxHAHPiPla16ui4AyH38Vv58i5KNWUwDw8 Cnz/hqrbXr88klcojScN9mT5V5KHOg66sAyadMWWE7fLEO6gqbUMcf6xpd3IEBQGyxaia3Q g0GU2OXmQBSt+EOSp2RePkVpbPGgZ9M8Q== X-QQ-XMRINFO: NS+P29fieYNwqS3WCnRCOn9D1NpZuCnCRA== X-QQ-RECHKSPAM: 0 Content-Type: text/plain; charset="utf-8" The function kgdb_wait() was replaced by kgdb_cpu_enter() in commit 62fae312197a ("kgdb: eliminate kgdb_wait(), all cpus enter the same way"). Update the four stale references: - include/linux/kgdb.h: kgdb_roundup_cpus() kdoc - arch/x86/kernel/kgdb.c: kgdb_roundup_cpus() kdoc; also fix pre-existing grammar error ("get them be" -> "get them into") - kernel/debug/debug_core.c: inline comment - kernel/debug/gdbstub.c: inline comment Assisted-by: unnamed:deepseek-v3.2 coccinelle Signed-off-by: Kexin Sun --- arch/x86/kernel/kgdb.c | 5 +++-- include/linux/kgdb.h | 3 ++- kernel/debug/debug_core.c | 2 +- kernel/debug/gdbstub.c | 2 +- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c index 8b1a9733d13e..f50a39818223 100644 --- a/arch/x86/kernel/kgdb.c +++ b/arch/x86/kernel/kgdb.c @@ -407,8 +407,9 @@ static void kgdb_disable_hw_debug(struct pt_regs *regs) * kgdb_roundup_cpus - Get other CPUs into a holding pattern * * On SMP systems, we need to get the attention of the other CPUs - * and get them be in a known state. This should do what is needed - * to get the other CPUs to call kgdb_wait(). Note that on some arches, + * and get them into a known state. This should do what is needed + * to get the other CPUs to call kgdb_cpu_enter(). Note that on + * some arches, * the NMI approach is not used for rounding up all the CPUs. For example, * in case of MIPS, smp_call_function() is used to roundup CPUs. * diff --git a/include/linux/kgdb.h b/include/linux/kgdb.h index 22b3f3839f30..bbe9b54a57c9 100644 --- a/include/linux/kgdb.h +++ b/include/linux/kgdb.h @@ -202,7 +202,8 @@ extern void kgdb_call_nmi_hook(void *ignored); * * On SMP systems, we need to get the attention of the other CPUs * and get them into a known state. This should do what is needed - * to get the other CPUs to call kgdb_wait(). Note that on some arches, + * to get the other CPUs to call kgdb_cpu_enter(). Note that on + * some arches, * the NMI approach is not used for rounding up all the CPUs. Normally * those architectures can just not implement this and get the default. * diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c index 0b9495187fba..1a2f0297a80c 100644 --- a/kernel/debug/debug_core.c +++ b/kernel/debug/debug_core.c @@ -704,7 +704,7 @@ static int kgdb_cpu_enter(struct kgdb_state *ks, struct= pt_regs *regs, if (ks->send_ready) atomic_set(ks->send_ready, 1); =20 - /* Signal the other CPUs to enter kgdb_wait() */ + /* Signal the other CPUs to enter kgdb_cpu_enter() */ else if ((!kgdb_single_step) && kgdb_do_roundup) kgdb_roundup_cpus(); #endif diff --git a/kernel/debug/gdbstub.c b/kernel/debug/gdbstub.c index f586afd76c80..aafd8da5d7fc 100644 --- a/kernel/debug/gdbstub.c +++ b/kernel/debug/gdbstub.c @@ -517,7 +517,7 @@ static void gdb_get_regs_helper(struct kgdb_state *ks) /* * All threads that don't have debuggerinfo should be * in schedule() sleeping, since all other CPUs - * are in kgdb_wait, and thus have debuggerinfo. + * are in kgdb_cpu_enter, and thus have debuggerinfo. */ if (local_debuggerinfo) { pt_regs_to_gdb_regs(gdb_regs, local_debuggerinfo); --=20 2.25.1