From nobody Sat Apr 4 01:49:05 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42A7533D6C1 for ; Sat, 21 Mar 2026 07:42:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774078978; cv=none; b=ZVxLdujrDT9EFA69AHvh1vdYXw+Iq8F09IL9BmlGBFs2rTuTIpi34FetNJD2KxMUFCn/FeTkpS/uEu3YrCo2ZO70og7P5q6wkoNc1W4Ijr7pLAYdK4oqSubyVbs2wXJlNT9REhpSVt43vg/OF7cc2TwQKrPExSSe/VLpsDGccTs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774078978; c=relaxed/simple; bh=/fcUHnLNge6SFLxWrM+8HK1LoLEPvUarIqtfQwLEGr4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gyajipNxCegEQeaJozYfniLuBdp5af/62sfJAPE6ZCWkT6fdJuwMb5WqfY+YHfugD81KrjGpgYXZSStB+rFyINuXCnpQdRSb4RuKufRWpWqNYnLHEFtXUrkOCLsmX6JExDdlv1qnYaEq1zOnD3ajMAFLJa36lpRaRzkq4BTju3s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P9sJq04d; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P9sJq04d" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-8299f1ca894so1681031b3a.2 for ; Sat, 21 Mar 2026 00:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774078975; x=1774683775; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+aCGxNHjQ3qWf5BFAN3CZ7YhrlhC9KiBN8YYYpfvlgw=; b=P9sJq04dZxfWtXbIKWXrakom2/SlFtQKQ4nujOlYU4AZi7AY8+sPGLTekXMccqFrlF yMPtK7bRXbRdwmWnGIzGU+FGg8ZmtKJxLgO1C2+S1jbpTYx6J5/G3A2VmDV5+FuizOcN H8AJv0K4uZErU9ruIl4TRojh+6Sr1inWgSlnb6UhB5i2kc0hNVnIp6dwPVxt9aHMO1Qn aeeJ5w3Us0fQTtCyk/3hM9HikyMTG44PMkgESrRQPXsRdiktjyXRwBgb4SlU1S8hd+KS ejAcCsP+r84F/DxlXoLnRpYROwgsJrmRdxefFRLG3xPOPU1eONjkkB0/19FhbdCUhBFa eLSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774078975; x=1774683775; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+aCGxNHjQ3qWf5BFAN3CZ7YhrlhC9KiBN8YYYpfvlgw=; b=lGapsJIYuXe5SErTG4y1hZ0IuVO4GhA3ziBpi5yFG2+AXAGS9WSZDEDhr4RjA0qef6 MZc1OcM3AfB/C5961YWCFhJ4mej3JLQbJNol46NRkyHjZ/u2PjXJu5mVMR6oGgN2ayE2 uiY9Z5JokApnL8SIDsK04FFZW+XUi+Bj1es1d+WvyoJyfTNewaPm+1TWdpgMF8w+JlHb XxUUBipXOdhwm4g9hN8rOGi1Ovi5qsG2+zsKt2ko12XMImrzlt55Op/piqWlqtcfrK7g VW/jlODVUOzoRaqizmtrNdoscgx5Qyu0u8ssLr5h9UTXWrwf/vadhML/ucwwUWXt8Q31 5B6A== X-Forwarded-Encrypted: i=1; AJvYcCVcQ20NZTPzUDVanSYxiBiLreMMrTQwOK/6G2h3CyA3U1D3h8sAl6WO2HLQymDWpTC/YhNpA4wveo40B7M=@vger.kernel.org X-Gm-Message-State: AOJu0YxKVWNvLh5VsFx753jLoKca6nx3PGPQWN9ThrhlN3Ppa7fO7NaJ 8CiFTdhLjrdHREeZ+5eMe78Wl4waOS4lWdbwt/cKZhq11GTExD0JIKID X-Gm-Gg: ATEYQzw16S1SDALi51niSPnTuL+aiS4DWGIRpYOsuBJo25rJjmSzjA4IYjgqqueF4oH HfNSQ33mnRJ+cwlf6ACdBvdswwrk4gljpctLq8c53R6BiK5lrpqKu1S179sdRxNEC7oh5opmosB lGgLIIy1MtMFx1jCaDHvruSDzV8fwuA4vzIc3oQTXBNmUTpEVzCrhMRCPEHiaXa2HbeXn++6HaJ XFrvR8H1N5AyCduXf13GbY1xjR0Ub4FFo9aFA3A01rRD/csoNu5nqFEiqXOT7+CuIdR9uAAQNnh t3FZfAiNt+r/HgG+XnT00oGmoc72tzcRxfnDdvxl9ldN+K3CEMfpN1Gk2uuv2/7e5wVdrPt29DA CQlGsOsag56TGvNXBoALK/uEb45chax0BRzmYkKurSK8Xh3swX+7dow4l1dnr7M3cGDasIi6BSF ebV6WXSzRMLw0/Zmg= X-Received: by 2002:aa7:9e41:0:b0:82b:4a85:3e2f with SMTP id d2e1a72fcca58-82b4a854131mr2881784b3a.41.1774078975582; Sat, 21 Mar 2026 00:42:55 -0700 (PDT) Received: from lgs.. ([199.182.234.55]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82c212ac8a2sm3503489b3a.17.2026.03.21.00.42.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 00:42:55 -0700 (PDT) From: Guangshuo Li To: Philipp Zabel , Linus Walleij , Greg Kroah-Hartman , Bartosz Golaszewski , linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] reset: gpio: fix double free in reset_add_gpio_aux_device() error path Date: Sat, 21 Mar 2026 15:42:40 +0800 Message-ID: <20260321074240.796922-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When __auxiliary_device_add() fails, reset_add_gpio_aux_device() calls auxiliary_device_uninit(adev). The device release callback reset_gpio_aux_device_release() frees adev, but the current error path then calls kfree(adev) again, causing a double free. Keep kfree(adev) for the auxiliary_device_init() failure path, but avoid freeing adev after auxiliary_device_uninit(). Fixes: 5fc4e4cf7a22 ("reset: gpio: use software nodes to setup the GPIO loo= kup") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Reviewed-by: Bartosz Golaszewski --- drivers/reset/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/reset/core.c b/drivers/reset/core.c index 0135dd0ae204..58ecde760b6e 100644 --- a/drivers/reset/core.c +++ b/drivers/reset/core.c @@ -856,7 +856,6 @@ static int reset_add_gpio_aux_device(struct device *par= ent, ret =3D __auxiliary_device_add(adev, "reset"); if (ret) { auxiliary_device_uninit(adev); - kfree(adev); return ret; } =20 --=20 2.43.0