From nobody Sat Apr 4 03:19:57 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD3233793A1 for ; Sat, 21 Mar 2026 13:13:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774098803; cv=none; b=aDRhHzzA6pFe/mjgpdTCIj7RJtnKYsUAPeJTHD98tzdy1yOLjOaD8DRYPJ5vp4n5kA6VzAEcVRvO65IZkYmFTy5cVDmPOqBLEvQcKeLH3veXLR0PvmOupkbT6gdT2SYdWa+iDhMvORIoJVT2BO54nbgy4FOsLibHvtQnJAsv5d0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774098803; c=relaxed/simple; bh=xhqsNW0RSGOFQlLETW3JNoAcxPNioCRHF+jg/V1+zc4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fa8uGpXrxKa8VmuWhqGSYxVIFhdP0XDsc2pgLGRU1a8fPFdEwnRvNEd/Sozlo4R3DX2NJkrclf0c9SmzWog0SzjljzkfbYcGoKoKqEv9AUICz1d+kXNcOdsTaT6Vs32JO9Ww87/qNFHj8B+FyBpeSbuyn+8/n5ZWkRGy4j9MS90= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CxxN0ArA; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CxxN0ArA" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-82c20b9f989so535298b3a.0 for ; Sat, 21 Mar 2026 06:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774098792; x=1774703592; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=30JWXI5M/0VC1tRdE9GO1EEw3ts+P00/JLYqrTA/kb4=; b=CxxN0ArAwzGtH+8pz2cgq4akJkPNuBpdGe0waV/RrOFEcYNWqLjEl0Zcd67PblG86U XVauyUH2qzjYIn8vFurwFW2TRN8hVsfEhZcWbdBxmgcvr53/5xEHOnP3S05pvskarOKX DcX2a7P8IiOf0XtXXzEBtag7Jrv7wKXJb6so3y3CEPFJF4h0KIVr17f0EdliS12svdCT B2dosTo/uu/ArBiu9Assgvt5oN6ylpaIaxl4oGtD1eBvjfkAvTKJ1mpuXd1CXjnfT5W/ DUQZ0zKl/hPljzb6doWk10G9nFrdyROxL+JCxxukNBSDNhMX8TX74UEY1tmSzzR4al97 0fhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774098792; x=1774703592; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=30JWXI5M/0VC1tRdE9GO1EEw3ts+P00/JLYqrTA/kb4=; b=W6TJ/X7hLDsXxg6oI7TNAA01Vp4Mjfqih26r3QvrwC5bPWl+kgsoUIOnFZVI9A0Y1H YCjOF2nxshAVNVM+TSydfpEzvnI19n3I/IRQ2XtThgeEaaatjN7wnIZH6crjFBHNud4y hfeb+rMesy1Q76P3SiK8sy7Fqb+nOUVWpqvN/ht0o2/w/gn31cd1Rql9fDkmJ5fVprVH J5VSUHleIBY6NZ059TORdrpPEoFALVQxqDVzD3eO4Y8HuSDyYY/LtrdCjG/RsC3Nd2hU STmgb+P3BF78Jw8AZHQm2SEBD9Tucv49R4GgJM5rvng8QLniMMdtB0y+qC5PYfbtcLXv 3XXQ== X-Forwarded-Encrypted: i=1; AJvYcCUuEerPZiA3hhk7j4Kmrv7u2f8+D3O2hDkPxXBKqMrDGQOaVe/+Z5kD5EyRIfkwYvKRIyVXay/ggZPRaLk=@vger.kernel.org X-Gm-Message-State: AOJu0YwFMWnPqcacONq6DpP/1vt+nIYDW5IJPnDt8tYLXQnTSW5LVPHx 7LnLCbLBR7JlTdoJfK42EENl4OA+7xPzew8mj+546t7dnjMVgUMIqkRT X-Gm-Gg: ATEYQzwO9D3Mq41CqRoZ8RtbZRp2wGbsoJLNY5wDKSlM36AjSWWWOpqVArnNc1wyyOZ tzRiZ2HQMOhAQW3Z743jUieoYPP/XadHURWA5o0pX+2Ysz2M/wKbJ9mPHxypDOVLN2QCNnIxTIL XK9JRmTz3htJmHB3yKE1SO+tNSIMoXk+jyTcjO2CIBVZiyhoj/m2B4ClkNxoVK7pWxi4hyjhMmk PMtFiDFyJrmZnOY6jnZLMeMp4i5PxZDV2vuoNJD6Q/wCTNdB/5/fYPWR3u4S6vovAA3k1mv80Yc l+vFuin0gD/BxWdPNcmZ/uy9ChMSisYSufwcjtjMSyhwzRiU3E1TB6yfdXkQQybPKvk0yzn2in/ Z3UixsYPXquO+2CNvZPNWn8lvPNnpLbmSBv61m0TTWNM+Km9F9NKWSTTMeBeqMjmjMI9eVACQnW xBGwVtlJmrD8m9cIPkRr8yLiSjtAsH/F4YE4NN X-Received: by 2002:a05:6a00:14c3:b0:82a:6b97:34a7 with SMTP id d2e1a72fcca58-82a8c34bc26mr5333166b3a.39.1774098792018; Sat, 21 Mar 2026 06:13:12 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b040db767sm5000809b3a.51.2026.03.21.06.13.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 06:13:11 -0700 (PDT) From: Felix Gu Date: Sat, 21 Mar 2026 21:12:56 +0800 Subject: [PATCH v2 3/3] media: ti: vpe: Fix the error code of devm_kzalloc() in vip_probe_slice() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260321-vip-v2-3-d502c1954817@gmail.com> References: <20260321-vip-v2-0-d502c1954817@gmail.com> In-Reply-To: <20260321-vip-v2-0-d502c1954817@gmail.com> To: Yemike Abhilash Chandra , Mauro Carvalho Chehab , Dale Farnsworth , Benoit Parrot , Hans Verkuil , Sukrut Bellary Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774098779; l=1683; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=xhqsNW0RSGOFQlLETW3JNoAcxPNioCRHF+jg/V1+zc4=; b=0mQYY2EiMLv0D2yZWxY1gQQ5hi2O62y1QJCgAANatc+mI8SvfOnxRM8rpT/9hMG2082mypd73 tjn+i5IzWM5CwiJgqrSwfUxJ114fOkrXJOWs4OTQ2U91za+0/v0Kqfx X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In vip_probe_slice(), the error check for devm_kzalloc() incorrectly uses PTR_ERR_OR_ZERO() which returns 0 for NULL pointer. Return -ENOMEM for devm_kzalloc() failure. Fixes: fc2873aa4a21 ("media: ti: vpe: Add the VIP driver") Signed-off-by: Felix Gu --- drivers/media/platform/ti/vpe/vip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/ti/vpe/vip.c b/drivers/media/platform/t= i/vpe/vip.c index ea65b7ec9b09..c2da11cc5cfa 100644 --- a/drivers/media/platform/ti/vpe/vip.c +++ b/drivers/media/platform/ti/vpe/vip.c @@ -3489,7 +3489,7 @@ static int vip_probe_slice(struct platform_device *pd= ev, int slice) =20 parser =3D devm_kzalloc(&pdev->dev, sizeof(*dev->parser), GFP_KERNEL); if (!parser) - return PTR_ERR_OR_ZERO(parser); + return -ENOMEM; =20 parser->base =3D dev->base + (slice ? VIP_SLICE1_PARSER : VIP_SLICE0_PARS= ER); if (IS_ERR(parser->base)) @@ -3501,7 +3501,7 @@ static int vip_probe_slice(struct platform_device *pd= ev, int slice) dev->sc_assigned =3D VIP_NOT_ASSIGNED; sc =3D devm_kzalloc(&pdev->dev, sizeof(*dev->sc), GFP_KERNEL); if (!sc) - return PTR_ERR_OR_ZERO(sc); + return -ENOMEM; =20 sc->base =3D dev->base + (slice ? VIP_SLICE1_SC : VIP_SLICE0_SC); if (IS_ERR(sc->base)) @@ -3513,7 +3513,7 @@ static int vip_probe_slice(struct platform_device *pd= ev, int slice) dev->csc_assigned =3D VIP_NOT_ASSIGNED; csc =3D devm_kzalloc(&pdev->dev, sizeof(*dev->csc), GFP_KERNEL); if (!csc) - return PTR_ERR_OR_ZERO(csc); + return -ENOMEM; =20 csc->base =3D dev->base + (slice ? VIP_SLICE1_CSC : VIP_SLICE0_CSC); if (IS_ERR(csc->base)) --=20 2.43.0