From nobody Sat Apr 4 01:33:00 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2FCD37CD29 for ; Sat, 21 Mar 2026 13:13:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774098788; cv=none; b=fgUBAVj6V3Ea4uH285gVgHaN8fkgN+/WQCXUSBfXotB4G4t3NsKoXH9o2SHGLdKG3rlgLtQVA/ileUBD2d4jrf6gosGtIbKT4V/JnCku1oOxt0pDgyyq4zvXD1+PL8/6pEfHFa/T2NVfIEixYcJlkcf5awfJ6h7X7vDBdc31KLo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774098788; c=relaxed/simple; bh=XCNqqyh87Kly70H6sujbdS2tPQXNb5tJjEy3opU1vkU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=orpZkkAyF0VdXMo3F4DbqXWsc/GtfSZv2B4tr0sWmGebYWCytqQd7TYnl93/S639/4MtvxJoF8M6+bKBgfhYmBmLazdKr1riwW1fPtO/F27ZJTj/g6yk6VJUZMdYZGRXb8OLymXGFzIr3eKaHND5b5xVD/cunnjEezzjTnkEmNc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BdBeeZwk; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BdBeeZwk" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-82c2239140aso425887b3a.0 for ; Sat, 21 Mar 2026 06:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774098786; x=1774703586; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GtCnn+XGQnhaTcOtbdLAx0qlU0NBtVLiSxgKFKna5i4=; b=BdBeeZwkgVPmm8RD9D5AZ/dSa5j+jpqytWpuKaNU40aeGI9Wafzc55zWdNmyloxsTt 1+W8+KykukRElTgFs+kK41A6SN/606BhCHzJnXM++ss8rKLU8slEpfRnGRaa+ZC+weuQ N9lBaHae1MWmcq5swYhP5Q/WYAB1xTQsWCLnKo1t1sS/xi2h/Q7fut7RniZiuHqXdiZb zmHLdZGLbfN+gP7Rh1FoHrW5roXJ5BHjZtbIMkbjPf+gwUhk247KMZjN01t4Fj7Fm90k Fb2/MCoVJuYPSJYFf972LWXHVTiZcpp7yvbxcNwSkri0tTjOsIyx04u21TmYS5LVkhAm crKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774098786; x=1774703586; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GtCnn+XGQnhaTcOtbdLAx0qlU0NBtVLiSxgKFKna5i4=; b=gpcDctSTAzrWELG86rNCkYgZa/mrT1Vxft+Gajr17ZbUVwWRmG4uiOvQ/bkpuEmK/x yzW6oGb26+qwZnLcJF74SaZBkxbZ/yQ6CzoRNcjIHwEzz/v1iAKV0cS3AUC1b4s3fpkg NdHxUD8pUYz/z8dg/Pne0+RIom1OVqt5KNUrCMRNzhnChOEA8GQCBmmmq5vXHeRXvTbq GzaHRlYuVuY1D6G1yc8bcxNCXFXnLJwtlhxasDCcrV8xv73n2V+u01ASYyG++Dwi0TNM cktNzDLEMXsiIG4stj40+X+1f7/5gaNOxMwC1aZoK47h0E6xwqDLp0mq/ne9mUfbwZ0R hMKA== X-Forwarded-Encrypted: i=1; AJvYcCW/NehIVVowut9z6v11z6O4/bMQVsuGNSfnDyRrmUbkqTH8TMk0C7b0l2CeIq/JnjeMjOPfqdiDfWJgWGg=@vger.kernel.org X-Gm-Message-State: AOJu0YxlPwWYgwOTaFbKGf4VubkEYe9qO4l7EjIaV+fJGmiZFlbWt7ER 26dfXCtwy54txZHlZHIq/L64Ufph3XAtwk5hh3nezMECDTNYGM+5k+Zp X-Gm-Gg: ATEYQzxIud69yC1Qi3xvyiQtBA73OPkKeeS2buzeU0h67dnadcpwDhLA9L+Gqg8Yl/9 xnX/Af1e+gwHTfKeVsHaGrVnTNCaz8hhNILrsdacbimkZCCZTiVDXkUiHIgpysxv3plpfDH0sW7 Y20GdtFqj2d2/tPNxWVq287g8pvFNoH4SlDK4ZZqs3sRL2x3Wh0aQKf+LGYe2Zd/hQp5tu+utZT myfwDN/fMq/fbGWCPpHfIh1tjFUGy1nRCmmrwopSvXwQ9FNs8MX0kt2Etuy0wcG9E2RUwxPFD2M xpJzsv/2Efh6foNybOb+9QjG6dBM1Pjhvo2oh+A8uYRqTwCUyFlv9ViqRuCI1ury4SgEhoX9E+v v6fnnxnQd4XA1oeD0ERTuwQnVMNXOD2EPnYrQDz6UgyfpFucppRVvg2I17NRfO3W5JnM6/sTuQV +HQM6kL2lezqXR39cqqM57w/HSSbTSMX5Zv4dy X-Received: by 2002:a05:6a00:230a:b0:829:8a84:b9fc with SMTP id d2e1a72fcca58-82a8c247dfdmr4710830b3a.8.1774098785986; Sat, 21 Mar 2026 06:13:05 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b040db767sm5000809b3a.51.2026.03.21.06.13.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 06:13:05 -0700 (PDT) From: Felix Gu Date: Sat, 21 Mar 2026 21:12:54 +0800 Subject: [PATCH v2 1/3] media: ti: vpe: Fix fwnode_handle leak in vip_probe_complete() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260321-vip-v2-1-d502c1954817@gmail.com> References: <20260321-vip-v2-0-d502c1954817@gmail.com> In-Reply-To: <20260321-vip-v2-0-d502c1954817@gmail.com> To: Yemike Abhilash Chandra , Mauro Carvalho Chehab , Dale Farnsworth , Benoit Parrot , Hans Verkuil , Sukrut Bellary Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774098779; l=1901; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=XCNqqyh87Kly70H6sujbdS2tPQXNb5tJjEy3opU1vkU=; b=5g2ESZGMyyViAi1vN4AcflT55JV1iBiyWJpV3haue90raHopH+DJUPw1CAnscAO79jDYSBX7R 25tIMYYB3iAAAfG2Urd3r4arnxuu1n+3v/01X2WMHEKmPgNPG9y7Rix X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In vip_probe_complete(), the fwnode_handle reference is not released if the loop continues via the default switch case or if alloc_port() fails. This results in a reference count leak. Switch to using the __free(fwnode_handle) cleanup attribute to ensure the reference is automatically released when the handle goes out of scope. Fixes: fc2873aa4a21 ("media: ti: vpe: Add the VIP driver") Signed-off-by: Felix Gu --- drivers/media/platform/ti/vpe/vip.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/ti/vpe/vip.c b/drivers/media/platform/t= i/vpe/vip.c index a4b616a5ece7..4fe9e059313b 100644 --- a/drivers/media/platform/ti/vpe/vip.c +++ b/drivers/media/platform/ti/vpe/vip.c @@ -9,6 +9,7 @@ */ =20 #include +#include #include #include #include @@ -3389,7 +3390,6 @@ static int vip_probe_complete(struct platform_device = *pdev) struct vip_port *port; struct vip_dev *dev; struct device_node *parent =3D pdev->dev.of_node; - struct fwnode_handle *ep =3D NULL; unsigned int syscon_args[5]; int ret, i, slice_id, port_id, p; =20 @@ -3411,8 +3411,8 @@ static int vip_probe_complete(struct platform_device = *pdev) ctrl->syscon_bit_field[i] =3D syscon_args[i + 1]; =20 for (p =3D 0; p < (VIP_NUM_PORTS * VIP_NUM_SLICES); p++) { - ep =3D fwnode_graph_get_next_endpoint_by_regs(of_fwnode_handle(parent), - p, 0); + struct fwnode_handle *ep __free(fwnode_handle) =3D + fwnode_graph_get_next_endpoint_by_regs(of_fwnode_handle(parent), p, 0); if (!ep) continue; =20 @@ -3447,7 +3447,6 @@ static int vip_probe_complete(struct platform_device = *pdev) port =3D dev->ports[port_id]; =20 vip_register_subdev_notify(port, ep); - fwnode_handle_put(ep); } return 0; } --=20 2.43.0 From nobody Sat Apr 4 01:33:00 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9B5C37B3EC for ; Sat, 21 Mar 2026 13:13:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774098790; cv=none; b=kwDZwT0+UZzx7nv7XU5BO+r+8fgWIlnf9Md3U6dX/BXJTQqn5jrwBuRwRe7OstehF2Berj2xfxqPiLlRiS98zSKMCWJ42Qdn6pzFW3Dd7ocATu6dGQ3EyGQhAxZYwQuJJdu/SjEw9zGbFhN+yTRXIdWXBWK7s96GizwigFwMBbI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774098790; c=relaxed/simple; bh=Lf0s0Fcik0dvR4AtpKW3/RTsPV3IsfB65rE+J909tAw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CAyOwskubmRHdQ8ozYZHNJ5nlTSEUWlGDKbAaVhuj+vcPaxJvBImGoPnhnsoNpOrMjdsJ3NEqSfiWBYUrB3k+OorCP1i1760+BFYqWhQQt10cpDRVi2U80lFNCxCXfmk4/RzmlEvXw6y5vky91wZ4Rje8t5tQNUGi5LSqa3XMcQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XwRQDhi/; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XwRQDhi/" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-82735a41920so1175191b3a.2 for ; Sat, 21 Mar 2026 06:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774098789; x=1774703589; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6pz23bkdf2LTLBeYwmuaoc4PB3larGLWkHam76/mv9U=; b=XwRQDhi/bdYFR71RTsw2hh//aKW55bOQ00KBRpZR3YvgbQ19kReCWujAe04/1fPtQO DftC9yhN2rCwBpxX17p8ekUPQdxrwmlDxsdvYioyz1jh01bjUpFy8Ju09g705PfKAAqH ukXOJDfP+smSvfkfGvmVvrqVrtFeyKm1OFzYIk/ubfovfSuWvcIYswv6/d2HHCNmzjz3 digNzvtT/ONFNgWdCD1rAEekkSWeQWAQ4/nEEiOz7QmzZWm2GagzGvMghdTm5r8QLTan iwM8J85ZTH9xiv2ZO6PD3TtT/uFaJrlcX6Uxx9XP57vCvsAqMcPWQmWmQ4gB1HOjsir5 5M/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774098789; x=1774703589; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=6pz23bkdf2LTLBeYwmuaoc4PB3larGLWkHam76/mv9U=; b=Gilbx6cBpSWghD+6SYhujADH6ceCqZrpULYe8mVv+h80XF3R+3mwjQP6+ejw15tWMV qpvGd/ybf7O1Ipg3/gIGivQEmsXDeW1hc5EH/8HD0NcOvV/Y2h423oMnvEiV16qlbexz P+/Sjxcuyr4oQB2j+yyfN1SOlsdJ4BruoTSUKQa7hUS+cKMOZHWOVctRxQ6VMitAkxEy Gwj15UMdMBH6p+tsE0X32mQYnRL5vDYSb1UYEfFFD0/k9t2dhFFlXc+9hTnnG1Qmv3Ek B6bUNB+q6IvMKpNq8S1CpLjcvA23to6eNn2gXQR0APmeKzNW76SSbJkSYKjeWxM5TyO4 Jk2g== X-Forwarded-Encrypted: i=1; AJvYcCX+N3+3f+nZBQwe3nJsuL9D/LU2loSjNbU6qLJsx8mc83scGJ2NtPSErG7PTPJQygDtfwadBDdFMOy+mxQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzKza5qlH9eOWdEn7rdlsz6qlWltDdv5LvD+YS2d/egvNNynqxm 4yVhQP8JWZA7w2z7sE7uGrfLAfaf7L2tzCI1mYnRFTTYqLqfKOWrJpqo X-Gm-Gg: ATEYQzzXirpx1xQ2BZJqKD2pkM6JG9wn058TAcOxX/hmMf/SmuffA4E6ew3QS0eb26F 4ZV+fadhCrYnvI/Ls88X5dygIc+gImo+cdzhX0Vp1l2v/M5y9mMD7C1ttoL6CUQGRho++WIdPtQ GcnKoOAwbJ1VTx/m60/MJsZVRImyUUCQHWebOBLZ26VoLsi0yDmovRQBE8HQ1OOnsGbUjIxkw21 gqCdAEYMxfduYxm0cnRZ4agkPIaBggMuiYRrjAeWo2eOWS28W+nQ+PBVdAcq1SOSFc1eUgEj0XP 2vCoqOb/6GQUCI8hgRrH77Pgh54tZPgsajMq/JCDuvZNdm/3V5Nn2zB/C9mVtGOqvdvEs2AKQ/D X42PPuerwFXVbb9bDD9B+tCFSrElTmhwqt8SOEj5+eVjepneRY17oV95Z9/1qU7q0DTCRn+7MAy AB+q4WoclUq0kUsPGg9iPGyGB79xg/iOcU3s/y X-Received: by 2002:a05:6a00:ac8f:b0:82a:7471:eb90 with SMTP id d2e1a72fcca58-82a8c35cfb1mr4934444b3a.30.1774098788969; Sat, 21 Mar 2026 06:13:08 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b040db767sm5000809b3a.51.2026.03.21.06.13.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 06:13:08 -0700 (PDT) From: Felix Gu Date: Sat, 21 Mar 2026 21:12:55 +0800 Subject: [PATCH v2 2/3] media: ti: vpe: Fix the error code of devm_request_irq() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260321-vip-v2-2-d502c1954817@gmail.com> References: <20260321-vip-v2-0-d502c1954817@gmail.com> In-Reply-To: <20260321-vip-v2-0-d502c1954817@gmail.com> To: Yemike Abhilash Chandra , Mauro Carvalho Chehab , Dale Farnsworth , Benoit Parrot , Hans Verkuil , Sukrut Bellary Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774098779; l=835; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=Lf0s0Fcik0dvR4AtpKW3/RTsPV3IsfB65rE+J909tAw=; b=LNUt3jU+IOmy4tWNsPQ8Q/7s6T67Yjd1MiUD1UBFaujT1/jr6vN+077ILsnmvPHJ0itMmsuFb I5LgrkZ0pL8DRSVrba1HeC1E/8CCzk0EbhTwr1nxAz5g8cNUjSLokUn X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= Return the actual error code from devm_request_irq() instead of incorrectly returning -ENOMEM. Fixes: fc2873aa4a21 ("media: ti: vpe: Add the VIP driver") Signed-off-by: Felix Gu --- drivers/media/platform/ti/vpe/vip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/ti/vpe/vip.c b/drivers/media/platform/t= i/vpe/vip.c index 4fe9e059313b..ea65b7ec9b09 100644 --- a/drivers/media/platform/ti/vpe/vip.c +++ b/drivers/media/platform/ti/vpe/vip.c @@ -3471,7 +3471,7 @@ static int vip_probe_slice(struct platform_device *pd= ev, int slice) ret =3D devm_request_irq(&pdev->dev, dev->irq, vip_irq, 0, VIP_MODULE_NAME, dev); if (ret < 0) - return -ENOMEM; + return ret; =20 spin_lock_init(&dev->slock); mutex_init(&dev->mutex); --=20 2.43.0 From nobody Sat Apr 4 01:33:00 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD3233793A1 for ; Sat, 21 Mar 2026 13:13:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774098803; cv=none; b=aDRhHzzA6pFe/mjgpdTCIj7RJtnKYsUAPeJTHD98tzdy1yOLjOaD8DRYPJ5vp4n5kA6VzAEcVRvO65IZkYmFTy5cVDmPOqBLEvQcKeLH3veXLR0PvmOupkbT6gdT2SYdWa+iDhMvORIoJVT2BO54nbgy4FOsLibHvtQnJAsv5d0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774098803; c=relaxed/simple; bh=xhqsNW0RSGOFQlLETW3JNoAcxPNioCRHF+jg/V1+zc4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fa8uGpXrxKa8VmuWhqGSYxVIFhdP0XDsc2pgLGRU1a8fPFdEwnRvNEd/Sozlo4R3DX2NJkrclf0c9SmzWog0SzjljzkfbYcGoKoKqEv9AUICz1d+kXNcOdsTaT6Vs32JO9Ww87/qNFHj8B+FyBpeSbuyn+8/n5ZWkRGy4j9MS90= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CxxN0ArA; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CxxN0ArA" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-82c20b9f989so535298b3a.0 for ; Sat, 21 Mar 2026 06:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774098792; x=1774703592; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=30JWXI5M/0VC1tRdE9GO1EEw3ts+P00/JLYqrTA/kb4=; b=CxxN0ArAwzGtH+8pz2cgq4akJkPNuBpdGe0waV/RrOFEcYNWqLjEl0Zcd67PblG86U XVauyUH2qzjYIn8vFurwFW2TRN8hVsfEhZcWbdBxmgcvr53/5xEHOnP3S05pvskarOKX DcX2a7P8IiOf0XtXXzEBtag7Jrv7wKXJb6so3y3CEPFJF4h0KIVr17f0EdliS12svdCT B2dosTo/uu/ArBiu9Assgvt5oN6ylpaIaxl4oGtD1eBvjfkAvTKJ1mpuXd1CXjnfT5W/ DUQZ0zKl/hPljzb6doWk10G9nFrdyROxL+JCxxukNBSDNhMX8TX74UEY1tmSzzR4al97 0fhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774098792; x=1774703592; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=30JWXI5M/0VC1tRdE9GO1EEw3ts+P00/JLYqrTA/kb4=; b=W6TJ/X7hLDsXxg6oI7TNAA01Vp4Mjfqih26r3QvrwC5bPWl+kgsoUIOnFZVI9A0Y1H YCjOF2nxshAVNVM+TSydfpEzvnI19n3I/IRQ2XtThgeEaaatjN7wnIZH6crjFBHNud4y hfeb+rMesy1Q76P3SiK8sy7Fqb+nOUVWpqvN/ht0o2/w/gn31cd1Rql9fDkmJ5fVprVH J5VSUHleIBY6NZ059TORdrpPEoFALVQxqDVzD3eO4Y8HuSDyYY/LtrdCjG/RsC3Nd2hU STmgb+P3BF78Jw8AZHQm2SEBD9Tucv49R4GgJM5rvng8QLniMMdtB0y+qC5PYfbtcLXv 3XXQ== X-Forwarded-Encrypted: i=1; AJvYcCUuEerPZiA3hhk7j4Kmrv7u2f8+D3O2hDkPxXBKqMrDGQOaVe/+Z5kD5EyRIfkwYvKRIyVXay/ggZPRaLk=@vger.kernel.org X-Gm-Message-State: AOJu0YwFMWnPqcacONq6DpP/1vt+nIYDW5IJPnDt8tYLXQnTSW5LVPHx 7LnLCbLBR7JlTdoJfK42EENl4OA+7xPzew8mj+546t7dnjMVgUMIqkRT X-Gm-Gg: ATEYQzwO9D3Mq41CqRoZ8RtbZRp2wGbsoJLNY5wDKSlM36AjSWWWOpqVArnNc1wyyOZ tzRiZ2HQMOhAQW3Z743jUieoYPP/XadHURWA5o0pX+2Ysz2M/wKbJ9mPHxypDOVLN2QCNnIxTIL XK9JRmTz3htJmHB3yKE1SO+tNSIMoXk+jyTcjO2CIBVZiyhoj/m2B4ClkNxoVK7pWxi4hyjhMmk PMtFiDFyJrmZnOY6jnZLMeMp4i5PxZDV2vuoNJD6Q/wCTNdB/5/fYPWR3u4S6vovAA3k1mv80Yc l+vFuin0gD/BxWdPNcmZ/uy9ChMSisYSufwcjtjMSyhwzRiU3E1TB6yfdXkQQybPKvk0yzn2in/ Z3UixsYPXquO+2CNvZPNWn8lvPNnpLbmSBv61m0TTWNM+Km9F9NKWSTTMeBeqMjmjMI9eVACQnW xBGwVtlJmrD8m9cIPkRr8yLiSjtAsH/F4YE4NN X-Received: by 2002:a05:6a00:14c3:b0:82a:6b97:34a7 with SMTP id d2e1a72fcca58-82a8c34bc26mr5333166b3a.39.1774098792018; Sat, 21 Mar 2026 06:13:12 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b040db767sm5000809b3a.51.2026.03.21.06.13.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 06:13:11 -0700 (PDT) From: Felix Gu Date: Sat, 21 Mar 2026 21:12:56 +0800 Subject: [PATCH v2 3/3] media: ti: vpe: Fix the error code of devm_kzalloc() in vip_probe_slice() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260321-vip-v2-3-d502c1954817@gmail.com> References: <20260321-vip-v2-0-d502c1954817@gmail.com> In-Reply-To: <20260321-vip-v2-0-d502c1954817@gmail.com> To: Yemike Abhilash Chandra , Mauro Carvalho Chehab , Dale Farnsworth , Benoit Parrot , Hans Verkuil , Sukrut Bellary Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774098779; l=1683; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=xhqsNW0RSGOFQlLETW3JNoAcxPNioCRHF+jg/V1+zc4=; b=0mQYY2EiMLv0D2yZWxY1gQQ5hi2O62y1QJCgAANatc+mI8SvfOnxRM8rpT/9hMG2082mypd73 tjn+i5IzWM5CwiJgqrSwfUxJ114fOkrXJOWs4OTQ2U91za+0/v0Kqfx X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In vip_probe_slice(), the error check for devm_kzalloc() incorrectly uses PTR_ERR_OR_ZERO() which returns 0 for NULL pointer. Return -ENOMEM for devm_kzalloc() failure. Fixes: fc2873aa4a21 ("media: ti: vpe: Add the VIP driver") Signed-off-by: Felix Gu --- drivers/media/platform/ti/vpe/vip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/ti/vpe/vip.c b/drivers/media/platform/t= i/vpe/vip.c index ea65b7ec9b09..c2da11cc5cfa 100644 --- a/drivers/media/platform/ti/vpe/vip.c +++ b/drivers/media/platform/ti/vpe/vip.c @@ -3489,7 +3489,7 @@ static int vip_probe_slice(struct platform_device *pd= ev, int slice) =20 parser =3D devm_kzalloc(&pdev->dev, sizeof(*dev->parser), GFP_KERNEL); if (!parser) - return PTR_ERR_OR_ZERO(parser); + return -ENOMEM; =20 parser->base =3D dev->base + (slice ? VIP_SLICE1_PARSER : VIP_SLICE0_PARS= ER); if (IS_ERR(parser->base)) @@ -3501,7 +3501,7 @@ static int vip_probe_slice(struct platform_device *pd= ev, int slice) dev->sc_assigned =3D VIP_NOT_ASSIGNED; sc =3D devm_kzalloc(&pdev->dev, sizeof(*dev->sc), GFP_KERNEL); if (!sc) - return PTR_ERR_OR_ZERO(sc); + return -ENOMEM; =20 sc->base =3D dev->base + (slice ? VIP_SLICE1_SC : VIP_SLICE0_SC); if (IS_ERR(sc->base)) @@ -3513,7 +3513,7 @@ static int vip_probe_slice(struct platform_device *pd= ev, int slice) dev->csc_assigned =3D VIP_NOT_ASSIGNED; csc =3D devm_kzalloc(&pdev->dev, sizeof(*dev->csc), GFP_KERNEL); if (!csc) - return PTR_ERR_OR_ZERO(csc); + return -ENOMEM; =20 csc->base =3D dev->base + (slice ? VIP_SLICE1_CSC : VIP_SLICE0_CSC); if (IS_ERR(csc->base)) --=20 2.43.0