From nobody Sat Apr 4 03:19:57 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC0B52E54AA for ; Fri, 20 Mar 2026 19:12:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774033945; cv=none; b=LbZo36nV170S+rCr51TK3V0jAEZnl3uYOMpcRg1uwhVNv1tifeSiisLZUxiXuhnxl3kq/uUJ220vvEvV8bcqjYxt2NvpEAIFlHFFF5CZkNoymEc8P/h7CXHr7gGYDCdJEJYAIYCW9RKJ2d2nePwuVkssPHuL3QeKxb2nJXgFahA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774033945; c=relaxed/simple; bh=4F+Ll1PWHhd/QixktSYleAKOUdmCyNteN2mj0AKQq7Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hn3C3LbW32NtQRzuUO7vzizqv6nbUs6UoqLzEEJvhacf7q8S2Bgl1O0BPZR0FhRLyOl6dGsm1LD2q/fsgSDb9yz2WQ90bP4tvAEulfVEkq0d9C2CtFuISGwr9LPrjGtmStnBAGP/2OIrDMOkwaZ9h6SmvzRKGFWK/+Djgory7X0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BICIZNaO; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BICIZNaO" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2adff872068so4613705ad.1 for ; Fri, 20 Mar 2026 12:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774033944; x=1774638744; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GzUsZ0V+OsYZzU5hFHvU5ER39DG7821lBv6s9PN+5+U=; b=BICIZNaOyvhfJSaPog/+NEcy+RuAo2nEoW0uXX5irN2HbhXkG9Ez9bm+UwwNQIFiG0 UOE9JI2ImW523rsfR+YlQlUpZgfBbElwRK6cdgNotoU7ICoMkbAf8diVbSUruSdpx0Bw 9ABzyXz4gbnICQ8SdCVpm+Ji51wBUp9rbTXXBhsAGUyAuVfeDPUqVicgiHYkbC4mPOTi Q23LRnvnllNKSWe8fBpFGMPAz73a2KXno3Z8qLhtaFnWT1SUgupKLxrnDznUl3dl7Vx1 a/ghXvjvoz0fEocsdL8SVr0WOeIDXsv6XrnaE9MC4mGntD0OfZk3uZH0fO6jd18H+p1t J2Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774033944; x=1774638744; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GzUsZ0V+OsYZzU5hFHvU5ER39DG7821lBv6s9PN+5+U=; b=SP4Ozv73PxZ3EelHCnz0AuHMONEdKiHJYDsfXxtp+IgsBSROOvfAVGqge2O2FrkRBK Ue9KkAyad9tFWJrcudvb8eYr9Da8ZBgcfxsbgkX1hFgPjuptiuEDX1O48BgfSPxOcfEz sTBjJrGcEkp7OAbo2r2wv/afSZA3S9VjguHnU24FrGQilBMK+/UV5OuXOLKPGG7oxVIC l+AU/PnpDhMZx4+c+PSksFtudRuSLkEta8ERwxk0+IvrkkePt6DEh20ZCIlOsMcfxgkj elvGdKa7h6c/aeFGtI8vikMpz3qrdXVkF6ApcS7dZnyuaFZOlvBO/JWukMO5sakhq7Yv 77iA== X-Forwarded-Encrypted: i=1; AJvYcCWBYBYV4RFtG/NeqSbf0zd1Yb/PjkAxD6VK4++IkPhm4tob5oV4Pq0fs9C8LN7sDYqGgDiAoog6w470sAQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyOT2nXmBDHqUyuE3BpLVRydfTbZ4w2fRYG6zDRXiJkjAXNSD16 gFbjDw8+a/1Vxw44ImA7bmqaq9C7C9ldXxEyIXafIgmC++agxq00lHPS X-Gm-Gg: ATEYQzzPB42n5zi1tLQ5gf+M8bP1QbsU5foJ7p4xZI7LYrVwB2vkk+w9rSc3TIgSpza lxMk2o8vktoLN5YJA45XtSUVE0RjAN1JhZUVA8qxuKbMEjro1IxzsX/2rME1zD8PiaZ5sa/cm5t 9Spc+tE1c1xDRdodadABmYfMUjFw0wnSlj+LP8CZgdDlIOn5Xk6049God1HAipUhk86fIeupff5 c8Kao+j2QIGenCyT+40mrE20TVfY+2/uU82qJIvmW91A66UI4hHHWWtulfSlGCQP8P2wyjEY7zh imBsIHy0L6fXMSFlQlcbyeDoNS+F8+W5S59S9R5+NpXW+m3uxA0rd/ZToq12lrDesImdVN6tfXW PxK6MhDGyIAyunrJEEy9H8PRTxNIAXW7DItmN+6I3aBmOQJb321XfA8AqmY5J8VS7nkNXA785F1 AEvnko3BKMkCSRLeuDuee7T3HUvC91lEBSIj8R X-Received: by 2002:a17:903:38cf:b0:2b0:6961:150a with SMTP id d9443c01a7336-2b0827d7e20mr37519215ad.38.1774033944094; Fri, 20 Mar 2026 12:12:24 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b083688ca4sm39599915ad.67.2026.03.20.12.12.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 12:12:23 -0700 (PDT) From: Felix Gu Date: Sat, 21 Mar 2026 03:12:10 +0800 Subject: [PATCH 1/2] drm/bridge: th1520-dw-hdmi: Fix error check on dw_hdmi_probe() return value Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260321-th1520-v1-1-ec877197770d@gmail.com> References: <20260321-th1520-v1-0-ec877197770d@gmail.com> In-Reply-To: <20260321-th1520-v1-0-ec877197770d@gmail.com> To: Drew Fustini , Guo Ren , Fu Wei , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Icenowy Zheng Cc: linux-riscv@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774033935; l=995; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=4F+Ll1PWHhd/QixktSYleAKOUdmCyNteN2mj0AKQq7Y=; b=1wKT8Nsz2Paz9DLjSvFMhtNlNWSOreFb8Roupg24Rg5qwt9FTGGanMq1ALok9+x2liB+HzDBH 13ucLSz6c/ECAxSLCoMI4i+CbOdxMEYfXaNVwZGrBm0CPKJkIRxF64J X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The error check after calling dw_hdmi_probe() was incorrectly checking the struct pointer hdmi instead of the probe result hdmi->dw_hdmi. Fix this by checking the correct variable. Fixes: 96f30ee0fb9d ("drm/bridge: add a driver for T-Head TH1520 HDMI contr= oller") Signed-off-by: Felix Gu Reviewed-by: Dmitry Baryshkov Reviewed-by: Icenowy Zheng --- drivers/gpu/drm/bridge/th1520-dw-hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/th1520-dw-hdmi.c b/drivers/gpu/drm/brid= ge/th1520-dw-hdmi.c index 389eead5f1c4..c9968ec1823c 100644 --- a/drivers/gpu/drm/bridge/th1520-dw-hdmi.c +++ b/drivers/gpu/drm/bridge/th1520-dw-hdmi.c @@ -136,8 +136,8 @@ static int th1520_dw_hdmi_probe(struct platform_device = *pdev) plat_data->priv_data =3D hdmi; =20 hdmi->dw_hdmi =3D dw_hdmi_probe(pdev, plat_data); - if (IS_ERR(hdmi)) - return PTR_ERR(hdmi); + if (IS_ERR(hdmi->dw_hdmi)) + return PTR_ERR(hdmi->dw_hdmi); =20 platform_set_drvdata(pdev, hdmi); =20 --=20 2.43.0 From nobody Sat Apr 4 03:19:57 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00B6833438F for ; Fri, 20 Mar 2026 19:12:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774033950; cv=none; b=lZo98iFlNJ+RN/I6rKluJ/WUT+z3oe4n1IdGOY6YhENv0CrM7706uyQHnFBzDjWoPc7RsUPr21UK7ujiGZz/C+lCTlbBXLnki44u3JEThH1nzsCApJd1N4gTHZdg6VIhsNXasQ2vXdYohG5kbSVHswF5xarZzRTf1fyGJt4zG+4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774033950; c=relaxed/simple; bh=Iq/IF6LUudYr57iCsECUorrqheDDpz1NtopP1SQaLhI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PKpjiBvtkTZqp9nxquCq/433f2RcNqUsu5hlj5Dda+Kpj1z8hvbknaMoyvsc2iBMsj3C/sz5qkryKYwgXF0yYkgOParzkuxkF64UWrds469YxsFxtTEAL0qzlb/pWcCkMB4qosNY+bq+DFrgfPfGDB24zam4PydZXCWnVs2xXbI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q/TyQakj; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q/TyQakj" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-359fea895b5so1581169a91.0 for ; Fri, 20 Mar 2026 12:12:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774033948; x=1774638748; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ux+DVa2N+/JaIwDNhsnggYM4bsW17uE79GBmRoiXmjI=; b=Q/TyQakjHcl1dV9lWDa3S1sCehWcLJVKRl1Fmxz+p5ji28frp5H0s7M1NlQlrrrfge /Li8SkYli58MPXgQwEIrJXslCzDlf9qIULzc/TyorN/OHp1ibsYiATa7vWahjr7vlvrh ePSFp+Vw7gNpCIICIWPWySVdGZEUP8YpJ3/0Y7298l/Pro1sUcXLtiU/jg1pD4/Vsyy9 02mLdyL/NyP26po0kN8QIbeBogm8j8P10EmSzKnbEQ0MDQ5mXTpNcOCs0mIa8f86nhgc gufOAVZoR8vT1JFPPLUSYEyviKkyZxJWff0tTSmhMlKOXHmey2W7B5jlsOC/ViTC601F 5HYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774033948; x=1774638748; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ux+DVa2N+/JaIwDNhsnggYM4bsW17uE79GBmRoiXmjI=; b=EieW7c+PCIcHrXI9EsAxFxrmvuM8XtnuUSsbpywfpOoch0TT2a2GpwV8lCi19NhA9/ /Iq2fE8OhPXa5UgiTgeuXkp5DNRgL22hXITaDwWZU+f9uBkLHtdHbMwBm0cVnAuIveqp lhZ4UjZBYblxUArcFb9Uai0hx1Z1fNhHSWiTLKdsvPbK2D3UUqJGsp6yx2/Skq7vhL59 WVRhJDBslKthgzjlkzb94QP43imbSvLppzl66nECP/ZhBXVuStfU148c+3FKKR7JjNxW K3g77GCWMGseNrHATkVXSVtM6wuPFyPp7uKHNXioa+0YOsKLycyv+QWMOXoBrWQU61+6 fxvw== X-Forwarded-Encrypted: i=1; AJvYcCXpJo2+mgsUuuPF5Sb+YM3ZbDGh1BqvHV5j6ARuc+Scz9dgFyA5DbP56pz5FWyZm7peu+NQgcA+rxnYHSA=@vger.kernel.org X-Gm-Message-State: AOJu0YwHvCfHzkji1lXpjYx5ACo6giFFZyC1SOMWuYEp4x/Gy6iYaezB /Kus8ze8qTlm/3uOIOMvjLF8cX3BHl0n4gZnrdYQVu8opYdWdRz7jF8I X-Gm-Gg: ATEYQzyOwwfttlMB0NtBLcOYaQO6ft5Xp9DnHz3VhTeu41V3Qjh1KyYbXr+r7qNtwn1 VuY5K/sDsC8ZEXl3b7WAxQZetYeOaNA/kSqE2EFpEIvwnTd7eSUb9g7wSKX+xuzUfY22aIVhh4j ENqB7I+xyvoqFoxTZrCtIeJZe4f5n+0CCVo58bW+CtXwVYH951fdNhCWTxoZbHsh34zB+BKS9By 4wtwZUIt/tjPoPxeS29fE9IG6WcWK8y419Gti1Z9pFXSSAXcZWJ14Y5F1Ke1fqAdnKSmCN6vVcb Kp0LBg7GtQ8AGoV4LZjcwbukd116Q/6Vz56GaZluQ9iUpg16mgT5AUHTSibWaKRiWjbYVVxE/Ej nTDdwWcQRKeADkKaaxfismQZAz2tftckSWvf1WjByHIEq8yGE17XB/NScJjSqG9hr/4j/25Z7+X qb4ocCqHhVukVweRWsTZdyxxOSwjdHF3l7UDRq X-Received: by 2002:a17:902:ef52:b0:2b0:663f:6b4b with SMTP id d9443c01a7336-2b0827054d4mr34682875ad.18.1774033948205; Fri, 20 Mar 2026 12:12:28 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b083688ca4sm39599915ad.67.2026.03.20.12.12.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 12:12:27 -0700 (PDT) From: Felix Gu Date: Sat, 21 Mar 2026 03:12:11 +0800 Subject: [PATCH 2/2] drm/bridge: th1520-dw-hdmi: Fix remove() callback Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260321-th1520-v1-2-ec877197770d@gmail.com> References: <20260321-th1520-v1-0-ec877197770d@gmail.com> In-Reply-To: <20260321-th1520-v1-0-ec877197770d@gmail.com> To: Drew Fustini , Guo Ren , Fu Wei , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Icenowy Zheng Cc: linux-riscv@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774033935; l=1195; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=Iq/IF6LUudYr57iCsECUorrqheDDpz1NtopP1SQaLhI=; b=GX+DTp9uRhkW8/vmyR0grrfU+rSZbqh4XWzlbmadXi2TWUSN0llN144L4kkBfk70i1b317S+3 2XHAcJkfyuMDz9PgvWt7KQzxoWiCgZ+TY3AUqycUY7w+DTZGVesfOAQ X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= This driver stores struct th1520_hdmi * in platform drvdata, but th1520_dw_hdmi_remove() was reading it back as struct dw_hdmi * and passing it to dw_hdmi_remove(), so teardown runs on the wrong pointer. Retrieve struct th1520_hdmi * from platform drvdata and pass hdmi->dw_hdmi to dw_hdmi_remove(). Fixes: 96f30ee0fb9d ("drm/bridge: add a driver for T-Head TH1520 HDMI contr= oller") Signed-off-by: Felix Gu Reviewed-by: Dmitry Baryshkov Reviewed-by: Icenowy Zheng --- drivers/gpu/drm/bridge/th1520-dw-hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/th1520-dw-hdmi.c b/drivers/gpu/drm/brid= ge/th1520-dw-hdmi.c index c9968ec1823c..6ec9003a8f3f 100644 --- a/drivers/gpu/drm/bridge/th1520-dw-hdmi.c +++ b/drivers/gpu/drm/bridge/th1520-dw-hdmi.c @@ -146,9 +146,9 @@ static int th1520_dw_hdmi_probe(struct platform_device = *pdev) =20 static void th1520_dw_hdmi_remove(struct platform_device *pdev) { - struct dw_hdmi *hdmi =3D platform_get_drvdata(pdev); + struct th1520_hdmi *hdmi =3D platform_get_drvdata(pdev); =20 - dw_hdmi_remove(hdmi); + dw_hdmi_remove(hdmi->dw_hdmi); } =20 static const struct of_device_id th1520_dw_hdmi_of_table[] =3D { --=20 2.43.0