From nobody Sat Apr 4 03:20:29 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 719B23B3882 for ; Fri, 20 Mar 2026 16:33:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774024422; cv=none; b=YitoN9SptBOsjsL1tFWs51NBaexr1YXH+KjGCKKOsNDHpzkjqTnMBDZjw1MW7Mrv2ZI9KjopFi7+dzRa1MuKqudY63RIq5rlLQngGjDI1g/4wEGKf1UL0/svcGSbDmPI8zeXOihMvJVCUV/wwvft1kF65yG9FVb4zkA+zxx3n0E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774024422; c=relaxed/simple; bh=aR+lmIyxdCmSGPLX8RZVLT5kQykRNGcPaMNJlitc93M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=dJ/HatrwZ8DZYjTly3cQPzG87XqCvGmHvSL9DcjpGQCGVhzs6vTsTzOSTJogNE9u92VxK/tH7MjwiVUkfyLL2Wa8ZEL4OC58nS4BjB6OYvwbcUmNZPWtCtMq6w/1Z0+QFle5uDKIVJ5SxOCmpPvb5eztj9P/XdkaTH7iUcLTDGA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DRBE1D62; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DRBE1D62" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ad9a9be502so5027915ad.0 for ; Fri, 20 Mar 2026 09:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774024421; x=1774629221; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=dfmjJ6c8eGMhzWErFCRUQJ0ZlgQhdVdCn3Ze9qpx/ww=; b=DRBE1D62ykdoBPcTU0Hsmbf464lu8XGAeMttghjy9P0F4RTNyFFbCYueVPLHH/9jzJ cdlvC7kAdsUs8yHe/SNIk4Nzhi6t1RPyySDJi/9q3l/3ID/KlrY51jxu8pdCLbyNHd93 IBu7uN3r9Pwa4CeClGRY+MbOj3WRnEE+ihH5DcoFZp66VXueoSU+SvbrU70w/Bd5mvYu JlijYHvs54kKRPnAsvvanf3tyT7+CrxV+MYJrly7QewzRXShvWwJO4utZKI+DdBQWv6Y kkrpb2OeN5OsTk5lZ+EpjwkD4SBU2GBEVvFjjCpkwuW6L5AmvB140oWJdznG4DBdwH49 p7nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774024421; x=1774629221; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dfmjJ6c8eGMhzWErFCRUQJ0ZlgQhdVdCn3Ze9qpx/ww=; b=rpIAU/XPoJ2fPdudLk5vdrMreyWCN764RInngzi2oN+Fcm2kecoikxNGkWsvpTIgJ9 kbF9qVbFhkboxJafRd4dPJXlxtTSPY1lY2FG4BkI2VKH/ypJqeVVklRZMvHlr5roP3Mq jr9zbIXaiVmGSnMBwIzeLEDCxo+W7fpCifQkaAnh1sAjB/GkZN3nrBY0Tb7dDSkLmJMW Ec4tDBl69m+RCk621XKiKePRN49profCmHYv1Q9mdwi6mu9PKMnSggMqy/OlF9zbmWV3 VgN9GkO9K73zcgk83hDbKir8yS5YxU+NhclxDR30r+zNj56tEo2v4uABX4UV7pNhTyv5 MMWg== X-Forwarded-Encrypted: i=1; AJvYcCUoHOFSUebEu+YJ5NfxFK0+Z56FcLYvj56SDI38IY1SCFP6VAeUtz7l8Hz1t8tc/AtPtCKswRmxVSj5S4s=@vger.kernel.org X-Gm-Message-State: AOJu0YydKzYucYYgec3w37MrTN2HX4BTeATAp56cAoGgXGr5fXa3aw8d Mvf+/JmdkGcFRsVH1i0UzqWtUi0UwR4DupgzsQFXZr/veDhQPWGWQc6jB3hGHXh6 X-Gm-Gg: ATEYQzxYLidKL8YP7IZyWtSg8FJ6MkbGxcSE399GZhrr/+G/QDlq5sPzWkgn5kfBjX8 wrQOO+wrrvTQJ2IHYc3b9Khfos+zVOz/mdpbO3QNkVAsBJKtzM7Xl78QfKZlOaCT6hOXDuKf2Wl dtyD9YMhfpANE15ee41Pt6ovc1T4YBw0Mn23ER8yfuqjgvY0qvmac4bLRTlbPGWcJTL/920BqIM 04to0Os9mogl2XhIkr0xMjl/XJqSLBtxmJ21gUhx2AbwQok4/cB1oPVUt1OrK9R6jtZlcgZLh7W OPocSJW+FdpUwWXlZSr5hhfmizlnFosUciTmiKMDctS/gvcn6JAssyLw3ahdrhHh98uJu+QcaZo he4Uh8H+SwYMKmFIOYWOrLSleWmnAVozCvxyFu2toqzo91fbbf/5VAknxN9hsD075q9+ahSVEkE IMQQ8qfb+vqqMG6qEIaUFQmULHykFps4IqFgSe X-Received: by 2002:a17:903:3890:b0:2b0:6638:b357 with SMTP id d9443c01a7336-2b0826c751dmr38677055ad.11.1774024420634; Fri, 20 Mar 2026 09:33:40 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b083655718sm27803345ad.39.2026.03.20.09.33.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 09:33:40 -0700 (PDT) From: Felix Gu Date: Sat, 21 Mar 2026 00:33:38 +0800 Subject: [PATCH] pinctrl: rtd: Fix error handling for devm_platform_ioremap_resource() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260321-rtd-v1-1-9c2022f73826@gmail.com> X-B4-Tracking: v=1; b=H4sIAOF2vWkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDYyND3aKSFN3UNMukNMs0y+TURHMloMqCotS0zAqwKdGxtbUAyyHzO1U AAAA= X-Change-ID: 20260321-rtd-ef9bf9f9cea7 To: Linus Walleij , Yu-Chun Lin Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774024420; l=1164; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=aR+lmIyxdCmSGPLX8RZVLT5kQykRNGcPaMNJlitc93M=; b=it7pbsbghx0plHCQLPBz8e00h2FZ5zS35ZXSw+qkKY8sbh+QNUlSzGixvhqpQGMYm4sKDjcBx 9+cez223GNqAySw3nxidxk4+ksCJbaj4+dA7vosVPWKJ9baR9MyOZy0 X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= devm_platform_ioremap_resource() returns ERR_PTR() on failure, not NULL. The incorrect NULL check would fail to detect actual errors from the ioremap operation. Fix by using IS_ERR() and PTR_ERR() as documented for this API. Fixes: b7f698b22b8b ("pinctrl: realtek: Switch to use devm functions") Signed-off-by: Felix Gu --- drivers/pinctrl/realtek/pinctrl-rtd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/realtek/pinctrl-rtd.c b/drivers/pinctrl/realte= k/pinctrl-rtd.c index 60dfb39bc986..429c94b79c49 100644 --- a/drivers/pinctrl/realtek/pinctrl-rtd.c +++ b/drivers/pinctrl/realtek/pinctrl-rtd.c @@ -574,8 +574,8 @@ int rtd_pinctrl_probe(struct platform_device *pdev, con= st struct rtd_pinctrl_des return -ENOMEM; =20 data->base =3D devm_platform_ioremap_resource(pdev, 0); - if (!data->base) - return -ENOMEM; + if (IS_ERR(data->base)) + return PTR_ERR(data->base); =20 data->dev =3D &pdev->dev; data->info =3D desc; --- base-commit: b5d083a3ed1e2798396d5e491432e887da8d4a06 change-id: 20260321-rtd-ef9bf9f9cea7 Best regards, --=20 Felix Gu