From nobody Sat Apr 4 00:24:55 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E751138D683 for ; Sat, 21 Mar 2026 14:43:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774104189; cv=none; b=h+1mQrJ+qqG8qVA65ie0yC6cDmj1cYSy6PdmTOyMCIfACIVJ92cOy207S+QoM7qZZ9VqdfMaeXhbkJSr37mWs3pu3BHfZAOuARtm7rqenq3gVJuuHW7s6LLzIMvBF1MgH1av0S7rQ7QecdGeUN6FbQ790UyRArJbNctiJ3KFLbY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774104189; c=relaxed/simple; bh=LRlmzz1XeqeUUInoAsGgnLrmUwLG6GuLyAoYGuhNM9c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=rdjWcaWsuQdbljCzF0f0orx3KhCWpIWU6/ZkO8dfRXo8nVHKv0okA9Nv8KzsT7Dr4CIbJvNdrT7OO5npfg0nQlkcqDWmZ8XbVSgHC6CBgfElcnXDmZB4ZTq+CRrIRhmHTWADdyDLe83gRJ6i6I8A9w9ZE6bWGB6bp7bRwXxE2jo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MUekf+Md; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MUekf+Md" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-439bcec8613so965429f8f.3 for ; Sat, 21 Mar 2026 07:43:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774104186; x=1774708986; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=ksXHlPTGSPp+8tlpOXfWaZMv93V/rMflZn8+7Gm04pc=; b=MUekf+MdgaOFW4lQh5zVzd+dscOgPgXfU9vd/rEkumqnvAO5BNzM8pXId7bj4I3kcj A9brLAco68vp8uq4YQTCqti8B1ij0S4piwekZmpWp1D0TVI6AZwONSdYJhtFkYVQdzwE qgGxzQoJjlxM8kA7in2IlstnAskd/f/L3SUqEypVQ6aRYOwKBQQbh3Qke/qA20MGxNwM UQg2FdLKRW/UU5Z+PPtdk0v1pnt1HlBBOsdIcw0sr6BMTXQkBt+U38A3kv1w+Gi/vywB G7z2lV2ApU9EZDUEkK3Gw50nihEDKTV1hhIrbnL3Ka84xCS8uOyKwAWPEx2RNRXVDSE4 rpKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774104186; x=1774708986; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ksXHlPTGSPp+8tlpOXfWaZMv93V/rMflZn8+7Gm04pc=; b=ozl0Mr3f+5sHyDe+/wJZGVl4cpUfxScrwrFHrSR1VKEdrcP7sf1xa1IhLezYa1KQUc bQ/RVxUoRrYJHuXDcQ4sxS1vqGctsVnk6X4g7L+XBmfmQUEyYsT+5e4WG2/h0uXqKbwo TqjvUGeKTBz/qIqUpVU9eOUsUQQeIwoghbdGHDY7IY8d74mucoNvzDWUAaowGn/FpSHa S8kDgrt+65ZwYUsFTSzFIHm480Gp3gOq2pNuCpehFZ7YW27BWRwY8CgwX9RpITP2awiS +7I/boTw6DTcxiKdINGwsFYHyB9YaMov3Btq70r/uUNDsPaS+N87uol+JjVLkAaJhkal m3IQ== X-Forwarded-Encrypted: i=1; AJvYcCXfKW/HpCQuSFJ3hCu8TU35r6uPzyph0eEVbb575/UwBwmYpC89+kxRwU3tQFaLOv2v2dc9KPoQceqbP+I=@vger.kernel.org X-Gm-Message-State: AOJu0YzN/wdcrHxTjyhbJoirvfpZ5qk2AjShw8KEu0TyY/0kFFtpeCnN Z7Vh1oNPIgEjWubXtHvSsgM3U48lAYzi7/xFvUFpsk0ED1zM9WLPmqc8UZgAwA== X-Gm-Gg: ATEYQzxXk8IpPxU0IEQy8NGvcD7FWTkZrScZga9AQz7UjUh4xtcfIS+3orjCpOwCNFW 1+Hm64H/hvrspjZ7444aIYOpMtpIsUJ6ZzkYWXV/ZW6WlF7jKGCb4xQyz3SSUA9D5OfpDbEn3tH fNEMI37zv6WhJuy3VBu5y6xjpzC+r4EvqRsZqhMNDfbKP5lzu8B0NWkBLgvufTOhV7UbtbqV+m+ mAuv3PDLIjEfTgC3ZJwDdZgQwPYSfc5GNd48l6ApMNpVa2p0MIAYm9ADn/HFxj4uZH5/Ps5MKHI bQo+P7Put75miyIaiVyiXQH+UMGVNMleNMa1m197KxQIUzyjjoFoEzB/jMpJ2oymvAXrqs1ernW 2uY+keomBQ0Nnfwm2IdzxCJozoKQqYrtNDX2BVlfYl3vXaGh8FsOKMHuVugzOsJcVnBgG1I9h5B sGl1PE/FULdUHJsCy3cekDV1aw6fkz0GOCb9MdRGJSjvnq1+D5dAoM X-Received: by 2002:a05:6000:2303:b0:439:b6d6:723 with SMTP id ffacd0b85a97d-43b64287251mr10183654f8f.42.1774104185922; Sat, 21 Mar 2026 07:43:05 -0700 (PDT) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-43b647120a1sm15096099f8f.30.2026.03.21.07.43.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 07:43:05 -0700 (PDT) From: Gabor Juhos Date: Sat, 21 Mar 2026 15:42:32 +0100 Subject: [PATCH phy-fixes] phy: marvell: mvebu-a3700-utmi: fix incorrect USB2_PHY_CTRL register access Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260321-a3700-utmi-fix-usb2_phy_ctrl-access-v1-1-6005ff4b5058@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXNWwrCQAyF4a2UPBuYC3WoWxEpYybagNYyaYtSu neDPn7wc84GylVY4dRsUHkVlddo8IcGaMjjnVGKGYILRxeDxxyTc7jMT8GbvHHRa+in4dPTXB+ YiVgVU9vl4kuiLrZgS1Nla38vZ7AY/7rs+xcrDHobgAAAAA== X-Change-ID: 20260321-a3700-utmi-fix-usb2_phy_ctrl-access-759ad1d7c935 To: Miquel Raynal , Vinod Koul , Neil Armstrong , Igal Liberman , Kishon Vijay Abraham I Cc: linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 The mvebu_a3700_utmi_phy_power_off() function tries to modify the USB2_PHY_CTRL register by using the IO address of the PHY IP block along with the readl/writel IO accessors. However, the register exist in the USB miscellaneous register space, and as such it must be accessed via regmap like it is done in the mvebu_a3700_utmi_phy_power_on() function. Change the code to use regmap_update_bits() for mod=C3=ADfying the register to fix this. Fixes: cc8b7a0ae866 ("phy: add A3700 UTMI PHY driver") Signed-off-by: Gabor Juhos Reviewed-by: Miquel Raynal --- drivers/phy/marvell/phy-mvebu-a3700-utmi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/phy/marvell/phy-mvebu-a3700-utmi.c b/drivers/phy/marve= ll/phy-mvebu-a3700-utmi.c index 04f4fb4bed7024c933190bbd9353615d54ac172c..f882bc57649c77343c3cb9c5111= db82812993c3e 100644 --- a/drivers/phy/marvell/phy-mvebu-a3700-utmi.c +++ b/drivers/phy/marvell/phy-mvebu-a3700-utmi.c @@ -168,9 +168,8 @@ static int mvebu_a3700_utmi_phy_power_off(struct phy *p= hy) u32 reg; =20 /* Disable PHY pull-up and enable USB2 suspend */ - reg =3D readl(utmi->regs + USB2_PHY_CTRL(usb32)); - reg &=3D ~(RB_USB2PHY_PU | RB_USB2PHY_SUSPM(usb32)); - writel(reg, utmi->regs + USB2_PHY_CTRL(usb32)); + regmap_update_bits(utmi->usb_misc, USB2_PHY_CTRL(usb32), + RB_USB2PHY_PU | RB_USB2PHY_SUSPM(usb32), 0); =20 /* Power down OTG module */ if (usb32) { --- base-commit: 81af9e40e2e4e1aa95f09fb34811760be6742c58 change-id: 20260321-a3700-utmi-fix-usb2_phy_ctrl-access-759ad1d7c935 Best regards, --=20 Gabor Juhos