From nobody Sat Apr 4 03:27:37 2026 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0C6137BE8F for ; Fri, 20 Mar 2026 22:24:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774045474; cv=none; b=p3KoVcPZsn9ZAsmWR/2ql0uj1XAHphevEjcCiy69x6f6lcmAXAz+KAynTbatatz2/IFRCMHKwWIloXPLL+k1vzYvygnylaEEFIolCz3nj0Uc1uRgBtysJRyizoiUHbGuEk9FBCsf1+MqZtwLTAIppSSuTbDOtpsXjCeOKlG1uf4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774045474; c=relaxed/simple; bh=DcqeRaeNTz2cvEC9STCbQYR4Z81ZFbiadjKzMth+Dvs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=amy2QxLgYGiRsgx8tCPU5bDGq34YaHWY5/dY9vvyyVpeWXZLgMBgvdRNbr75begsd7u9SnAxHlelHDfio/ZvYsfZZd3tx5oK0Sac/z9ZwJ1SVnvBwst6d5hwz9WrFdin6uFsPXxbjhRoI8yq/H/+MhOPZnrvYOqETjhRaP5nNAQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XxX3XFvv; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XxX3XFvv" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-439b97a8a8cso1143516f8f.1 for ; Fri, 20 Mar 2026 15:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774045471; x=1774650271; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qd4q+zZz8MsM0QKHv87+OJfyCSSecvFPAS7HdQl0+z8=; b=XxX3XFvvXCsWFyVDRhQz8aGT3E2Y92bvk7lnS9g1pERTrA8F7+b9KQm8TWw1Gx2qGQ 1+MJdpSrN1qBOzwX3SbOxAUUHfraAxSOv03Oqo01LV0WLi32AmMQZgBWxJMsHq+7XYoB +IvtWutSoBlYUfy31rfUEZwnHWd0SD5U2Gk+oeIQszNnmTAVwhq1uCEUUFItETS9230g y+yP7pNRh00qfdpyp22HiiwrKU0MFdAB0FwjXs5I4zHgHhaj+b4rF/D53rGH9j9xKIfq aanzkXa6RqeqBtsst3JdWD3czp9OnNq0SI4KszHgd7bVky47d3Ly8mS1cXNUW8C74HF3 xs5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774045471; x=1774650271; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qd4q+zZz8MsM0QKHv87+OJfyCSSecvFPAS7HdQl0+z8=; b=HYuGPUWkymspcEN4AJjIsoChT6oabDwljMv+GV9beqLTE9hxk1niuHC20/joYaa7qi c72L/SNDIWEIp1xoGZlMAZNQbVBrpoVXbn859pQ43bEQbB+Shy/Hw0MdaqTipYMEXE6D j+PF+cXmrUFdKThxXInwWgYD9tI7ANng7ZgGfnEHz/X925T8B5qeoVnFNMlVVFNltKZX RzH64MTGtoEYxslQ6PihklX9MemM7fdRGKdJrCvt2a9Qy3ItZ+uhksyF32j9s1dHpGdl sdAAST1iAqoB8b5OuW+3ErP2wnihfjO2zupwkgVtcasYEClRMSvskv36Ou83eKpMDWWs 1D3g== X-Forwarded-Encrypted: i=1; AJvYcCU+941d9Sr6890q+2kNJjgM3NQmxg4cS2kXEaiKseV7Q/j8uc+SFHCUSnsNuQZ3txzcy64F7CdNuaWqeGY=@vger.kernel.org X-Gm-Message-State: AOJu0YyPZBW8rVeULgWi4NCU2si81HOVVJHkCW7SioVyOaUJ4uYYfMU9 UeNnjR0LyBizDLhvz6yGxSUhIK34yoPb41OFvN4IaufU3UI/8DUeJ+3A X-Gm-Gg: ATEYQzyvLmuNPUhszvWVWREIPhBtMPacaM/guF/J43cyCbuCCquIPhEK0cxHnPusiq7 RouSzNExtFUwY9Eqv7jFxfb7ZWCj7bWuYUVKqwHSb03UxCF1G9L25YHMnS7Z6Do/BHZ5qU8NFKf urx515AMaABAsxXIcGi3Eri/fp/ZMN1I2ILog7rSC0Gsy8hF6vrF+D+jEa6adALZoMQPgb/WeSd rYPDeoEFJ4QRCPXkbtYGzhCb3Tmh3d3lfgdJ7WINesK/FoIWeImKEszjHRM7XHYOZVWXlMYAwVq 7x2qjdROt3k6OKF/OlPCsRemxyaAM0hBVCK8AFP264T5JCTIlPHX6h/HR8IhPJhL7wtoURG27RS pSvIrpACrsPN0SkBZVLQSZ1dlyV2bpw47NZETRrDHZTtzL79hA27Vk/J7Xfid690OysHXPS9whF wrSxGIt+UY+4lnn2ORj85YIoTB4+/qbWPioxM7kH2dY8gnN2fl+IYY3gA3bw== X-Received: by 2002:a05:6000:2c0e:b0:439:b744:c5fe with SMTP id ffacd0b85a97d-43b6427d272mr7665769f8f.52.1774045471238; Fri, 20 Mar 2026 15:24:31 -0700 (PDT) Received: from localhost.localdomain ([2001:8a0:6c9b:a000:bc11:6b0a:79ed:3d9f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b644ae016sm9290237f8f.4.2026.03.20.15.24.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 15:24:30 -0700 (PDT) From: Gabriel Rondon To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org Cc: andriy.shevchenko@intel.com, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] staging: iio: ad5933: use sysfs_emit() in show functions Date: Fri, 20 Mar 2026 22:24:23 +0000 Message-Id: <20260320222424.53294-3-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260320222424.53294-1-grondon@gmail.com> References: <20260319225719.73587-1-grondon@gmail.com> <20260320222424.53294-1-grondon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace sprintf() with sysfs_emit() in all sysfs attribute show functions. sysfs_emit() is the preferred API for sysfs callbacks as it is aware of the PAGE_SIZE buffer limit. Also remove the unnecessary (int) cast in ad5933_show_frequency() and use the correct format specifier %llu for the unsigned long long freqreg variable. Signed-off-by: Gabriel Rondon --- .../staging/iio/impedance-analyzer/ad5933.c | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/stag= ing/iio/impedance-analyzer/ad5933.c index 85a422329..e5a4f8d7a 100644 --- a/drivers/staging/iio/impedance-analyzer/ad5933.c +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c @@ -285,7 +285,7 @@ static ssize_t ad5933_show_frequency(struct device *dev, freqreg =3D (u64)freqreg * (u64)(st->mclk_hz / 4); do_div(freqreg, BIT(27)); =20 - return sprintf(buf, "%d\n", (int)freqreg); + return sysfs_emit(buf, "%llu\n", freqreg); } =20 static ssize_t ad5933_store_frequency(struct device *dev, @@ -338,27 +338,27 @@ static ssize_t ad5933_show(struct device *dev, mutex_lock(&st->lock); switch ((u32)this_attr->address) { case AD5933_OUT_RANGE: - len =3D sprintf(buf, "%u\n", - st->range_avail[(st->ctrl_hb >> 1) & 0x3]); + len =3D sysfs_emit(buf, "%u\n", + st->range_avail[(st->ctrl_hb >> 1) & 0x3]); break; case AD5933_OUT_RANGE_AVAIL: - len =3D sprintf(buf, "%u %u %u %u\n", st->range_avail[0], - st->range_avail[3], st->range_avail[2], - st->range_avail[1]); + len =3D sysfs_emit(buf, "%u %u %u %u\n", st->range_avail[0], + st->range_avail[3], st->range_avail[2], + st->range_avail[1]); break; case AD5933_OUT_SETTLING_CYCLES: - len =3D sprintf(buf, "%d\n", st->settling_cycles); + len =3D sysfs_emit(buf, "%d\n", st->settling_cycles); break; case AD5933_IN_PGA_GAIN: - len =3D sprintf(buf, "%s\n", - (st->ctrl_hb & AD5933_CTRL_PGA_GAIN_1) ? - "1" : "0.2"); + len =3D sysfs_emit(buf, "%s\n", + (st->ctrl_hb & AD5933_CTRL_PGA_GAIN_1) ? + "1" : "0.2"); break; case AD5933_IN_PGA_GAIN_AVAIL: - len =3D sprintf(buf, "1 0.2\n"); + len =3D sysfs_emit(buf, "1 0.2\n"); break; case AD5933_FREQ_POINTS: - len =3D sprintf(buf, "%d\n", st->freq_points); + len =3D sysfs_emit(buf, "%d\n", st->freq_points); break; default: ret =3D -EINVAL; --=20 2.33.0