From nobody Sat Apr 4 01:47:24 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EE6D36920E for ; Fri, 20 Mar 2026 22:24:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774045472; cv=none; b=ZqiAmvs/E4lfmDazqeaqDRTKIjqq1/rIEfb4ZOcx/celaryKd+JP+6JpeEP2TSnH1gcPSVCIUGM+Ti2pzxG63eii6MxuPdmfhpqLDTvLF4wlAH9sjyCuGGPTEzg5ux6oiHl059tpslPVaKAajYn9FdDBi3dES0RRSto/SQZLkvY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774045472; c=relaxed/simple; bh=A5fdWSepkSgmkvMJpmG5ZlnAONFldDTK+KtfLvuP/z0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dLds/HexlthEKk6bJwF9TCuZhKORpE3s0YStln1IbIk26Cm8QqL5VGXJRvFqnVeHKasDF/c7N7oCSvkzq6KjTifZ3+LOYxGCW5/NUXUWVnt6J1a5KcrQAsu9PCI7QgTEAk39/d3I+bbmlDE7iGBqJXuJYy478pInHWYuE8cewCI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EbHbFKK6; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EbHbFKK6" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48540d21f7dso12317835e9.0 for ; Fri, 20 Mar 2026 15:24:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774045470; x=1774650270; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QLzLy2hDM9Kbvx/sb4ZAms8XilnjagJUDNjtCCjNGlk=; b=EbHbFKK6hs3F1bZSbocdY4HT2p2x4cGtxUqaXaaSfxzBiOO3iTRF4EWLz07lbz1I5d iXf26Rgru28cYN6dNMjYsNsZRHpn2Ed8zpIFzTmJpvgOeGCTB1WiaF3T6HrX7Hr7gLty wUIgOnrLNtjrQFaZQ+TKuLb0WneztJRP4QaCmFwlFtvl7Ojl2f7GAmvPp3qw2bpvkpnT UpXhgOaiYrmibmMTL00Rd+hVodrwFwYVsdU1EI8esyrY4hGS23AMFcRbWMSJXEcrCRDA QVNvSAEOCjtx5f9TQkH1T+23KqH9aekg70Pt/srx5jKYrVXz/R4DjQXxp/v+TPxJepy2 utWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774045470; x=1774650270; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QLzLy2hDM9Kbvx/sb4ZAms8XilnjagJUDNjtCCjNGlk=; b=nBuFubvZ9IWFjJxXlV38zE8qQx2QvV2iwS9xBNVUaK/gSU+qYoVPnzuVGciCJsIVcM 1YOb8QZ83xtbQzDtuDEeSd4p/a+Th8Yd+6ZIK16qjPDFb7MqKR5HTv0tz4tpf1LkVli1 nLXhf8tnaRH9yRx/0dO5DKdkrh3oUYdBAnad9f4rLUByTCIUP2HM8llQndA4bnlBJbHD +6uFsMCXUEvlVoWEA1R2MKO1iaO3XEYSYofPiwBWoarwLY7r9LDd0wyblUdB3CyBX+jS A2Qb4MHcq9JzQbcZJCe+MkQDAmjd8R21YioTyS8xVOm35wFgi2dWdnYTCBfRe9G3pRfG L7QA== X-Forwarded-Encrypted: i=1; AJvYcCUGTW/Jw0YpM8ngBzG5O+iaXCoNUMv2BWPa+5CZ2Y/hRvxuSO/S+EWYznK2+ocdes1nmSx4BI533/BMoYw=@vger.kernel.org X-Gm-Message-State: AOJu0YwqDilFUcfbfehd5LOxb1VhTBeH2ppUIk+yjezr9G8NyC2880OG xCbxxk7UAVN9kavEAwY2NNJpXyeTAEkYwjQe1BZuCe555XsmuHuwwb2N X-Gm-Gg: ATEYQzyXqwnrKicBI2NuO8kSxq37CIlTWVB1tQzLXpSY3n/4+QzL1EntY89iUdsA177 N0qLcLwxjmA7dCIIlHd5NFH7Mck5got7BKk/q6WVgwt0caBQ5KfGskVFMIsXrKQskAu8UoIkwe+ RT0VLkH5pzRNwS8NDCPl5BE31BF7nazo00UpsT5oVvjnuwBjYuCwKkTt5MaN29/L7s9N5ohNF6r 2/UJEGwACfgScQY4PYmaCvNad/S3u8d/60x0L/6rL16Wb+8nVyT72l2ObjG9xjl4EHuNiKri99z osblM0KSjDWLiQQLH1Wr8FBRm1wMzzyJ9h/VvDakZew2i9iHn/F79Vj4j7s04uJGdDU/ulSAKpa e+nEn0hs/PCiArd47zWrQ9aX8nxHQCLFw/gMNEMOb2KhDdxgo2siXlTvA0Yp9T+ymZCGfInLJt0 pe3g9VFvskLiajoSR346/R4+JBzc4dJzTu4/veWxnoTPAcIv2So7ZyNst8+A== X-Received: by 2002:a05:600c:17d8:b0:483:703e:4ad9 with SMTP id 5b1f17b1804b1-486ff0291d7mr40807615e9.19.1774045469730; Fri, 20 Mar 2026 15:24:29 -0700 (PDT) Received: from localhost.localdomain ([2001:8a0:6c9b:a000:bc11:6b0a:79ed:3d9f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b644ae016sm9290237f8f.4.2026.03.20.15.24.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 15:24:29 -0700 (PDT) From: Gabriel Rondon To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org Cc: andriy.shevchenko@intel.com, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] staging: iio: ad7816: use sysfs_emit() in show functions Date: Fri, 20 Mar 2026 22:24:22 +0000 Message-Id: <20260320222424.53294-2-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260320222424.53294-1-grondon@gmail.com> References: <20260319225719.73587-1-grondon@gmail.com> <20260320222424.53294-1-grondon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace sprintf() with sysfs_emit() in all sysfs attribute show functions. sysfs_emit() is the preferred API for sysfs callbacks as it is aware of the PAGE_SIZE buffer limit. No functional change. Signed-off-by: Gabriel Rondon --- drivers/staging/iio/adc/ad7816.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index 172acf135..0e32a2295 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -124,8 +124,8 @@ static ssize_t ad7816_show_mode(struct device *dev, struct ad7816_chip_info *chip =3D iio_priv(indio_dev); =20 if (chip->mode) - return sprintf(buf, "power-save\n"); - return sprintf(buf, "full\n"); + return sysfs_emit(buf, "power-save\n"); + return sysfs_emit(buf, "full\n"); } =20 static ssize_t ad7816_store_mode(struct device *dev, @@ -156,7 +156,7 @@ static ssize_t ad7816_show_available_modes(struct devic= e *dev, struct device_attribute *attr, char *buf) { - return sprintf(buf, "full\npower-save\n"); + return sysfs_emit(buf, "full\npower-save\n"); } =20 static IIO_DEVICE_ATTR(available_modes, 0444, ad7816_show_available_modes, @@ -169,7 +169,7 @@ static ssize_t ad7816_show_channel(struct device *dev, struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); =20 - return sprintf(buf, "%d\n", chip->channel_id); + return sysfs_emit(buf, "%d\n", chip->channel_id); } =20 static ssize_t ad7816_store_channel(struct device *dev, @@ -231,9 +231,9 @@ static ssize_t ad7816_show_value(struct device *dev, data &=3D AD7816_TEMP_FLOAT_MASK; if (value < 0) data =3D BIT(AD7816_TEMP_FLOAT_OFFSET) - data; - return sprintf(buf, "%d.%.2d\n", value, data * 25); + return sysfs_emit(buf, "%d.%.2d\n", value, data * 25); } - return sprintf(buf, "%u\n", data); + return sysfs_emit(buf, "%u\n", data); } =20 static IIO_DEVICE_ATTR(value, 0444, ad7816_show_value, NULL, 0); @@ -281,9 +281,9 @@ static ssize_t ad7816_show_oti(struct device *dev, value =3D AD7816_BOUND_VALUE_MIN + (chip->oti_data[chip->channel_id] - AD7816_BOUND_VALUE_BASE); - return sprintf(buf, "%d\n", value); + return sysfs_emit(buf, "%d\n", value); } - return sprintf(buf, "%u\n", chip->oti_data[chip->channel_id]); + return sysfs_emit(buf, "%u\n", chip->oti_data[chip->channel_id]); } =20 static inline ssize_t ad7816_set_oti(struct device *dev, --=20 2.33.0 From nobody Sat Apr 4 01:47:24 2026 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0C6137BE8F for ; Fri, 20 Mar 2026 22:24:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774045474; cv=none; b=p3KoVcPZsn9ZAsmWR/2ql0uj1XAHphevEjcCiy69x6f6lcmAXAz+KAynTbatatz2/IFRCMHKwWIloXPLL+k1vzYvygnylaEEFIolCz3nj0Uc1uRgBtysJRyizoiUHbGuEk9FBCsf1+MqZtwLTAIppSSuTbDOtpsXjCeOKlG1uf4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774045474; c=relaxed/simple; bh=DcqeRaeNTz2cvEC9STCbQYR4Z81ZFbiadjKzMth+Dvs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=amy2QxLgYGiRsgx8tCPU5bDGq34YaHWY5/dY9vvyyVpeWXZLgMBgvdRNbr75begsd7u9SnAxHlelHDfio/ZvYsfZZd3tx5oK0Sac/z9ZwJ1SVnvBwst6d5hwz9WrFdin6uFsPXxbjhRoI8yq/H/+MhOPZnrvYOqETjhRaP5nNAQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XxX3XFvv; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XxX3XFvv" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-439b97a8a8cso1143516f8f.1 for ; Fri, 20 Mar 2026 15:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774045471; x=1774650271; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qd4q+zZz8MsM0QKHv87+OJfyCSSecvFPAS7HdQl0+z8=; b=XxX3XFvvXCsWFyVDRhQz8aGT3E2Y92bvk7lnS9g1pERTrA8F7+b9KQm8TWw1Gx2qGQ 1+MJdpSrN1qBOzwX3SbOxAUUHfraAxSOv03Oqo01LV0WLi32AmMQZgBWxJMsHq+7XYoB +IvtWutSoBlYUfy31rfUEZwnHWd0SD5U2Gk+oeIQszNnmTAVwhq1uCEUUFItETS9230g y+yP7pNRh00qfdpyp22HiiwrKU0MFdAB0FwjXs5I4zHgHhaj+b4rF/D53rGH9j9xKIfq aanzkXa6RqeqBtsst3JdWD3czp9OnNq0SI4KszHgd7bVky47d3Ly8mS1cXNUW8C74HF3 xs5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774045471; x=1774650271; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qd4q+zZz8MsM0QKHv87+OJfyCSSecvFPAS7HdQl0+z8=; b=HYuGPUWkymspcEN4AJjIsoChT6oabDwljMv+GV9beqLTE9hxk1niuHC20/joYaa7qi c72L/SNDIWEIp1xoGZlMAZNQbVBrpoVXbn859pQ43bEQbB+Shy/Hw0MdaqTipYMEXE6D j+PF+cXmrUFdKThxXInwWgYD9tI7ANng7ZgGfnEHz/X925T8B5qeoVnFNMlVVFNltKZX RzH64MTGtoEYxslQ6PihklX9MemM7fdRGKdJrCvt2a9Qy3ItZ+uhksyF32j9s1dHpGdl sdAAST1iAqoB8b5OuW+3ErP2wnihfjO2zupwkgVtcasYEClRMSvskv36Ou83eKpMDWWs 1D3g== X-Forwarded-Encrypted: i=1; AJvYcCU+941d9Sr6890q+2kNJjgM3NQmxg4cS2kXEaiKseV7Q/j8uc+SFHCUSnsNuQZ3txzcy64F7CdNuaWqeGY=@vger.kernel.org X-Gm-Message-State: AOJu0YyPZBW8rVeULgWi4NCU2si81HOVVJHkCW7SioVyOaUJ4uYYfMU9 UeNnjR0LyBizDLhvz6yGxSUhIK34yoPb41OFvN4IaufU3UI/8DUeJ+3A X-Gm-Gg: ATEYQzyvLmuNPUhszvWVWREIPhBtMPacaM/guF/J43cyCbuCCquIPhEK0cxHnPusiq7 RouSzNExtFUwY9Eqv7jFxfb7ZWCj7bWuYUVKqwHSb03UxCF1G9L25YHMnS7Z6Do/BHZ5qU8NFKf urx515AMaABAsxXIcGi3Eri/fp/ZMN1I2ILog7rSC0Gsy8hF6vrF+D+jEa6adALZoMQPgb/WeSd rYPDeoEFJ4QRCPXkbtYGzhCb3Tmh3d3lfgdJ7WINesK/FoIWeImKEszjHRM7XHYOZVWXlMYAwVq 7x2qjdROt3k6OKF/OlPCsRemxyaAM0hBVCK8AFP264T5JCTIlPHX6h/HR8IhPJhL7wtoURG27RS pSvIrpACrsPN0SkBZVLQSZ1dlyV2bpw47NZETRrDHZTtzL79hA27Vk/J7Xfid690OysHXPS9whF wrSxGIt+UY+4lnn2ORj85YIoTB4+/qbWPioxM7kH2dY8gnN2fl+IYY3gA3bw== X-Received: by 2002:a05:6000:2c0e:b0:439:b744:c5fe with SMTP id ffacd0b85a97d-43b6427d272mr7665769f8f.52.1774045471238; Fri, 20 Mar 2026 15:24:31 -0700 (PDT) Received: from localhost.localdomain ([2001:8a0:6c9b:a000:bc11:6b0a:79ed:3d9f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b644ae016sm9290237f8f.4.2026.03.20.15.24.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 15:24:30 -0700 (PDT) From: Gabriel Rondon To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org Cc: andriy.shevchenko@intel.com, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] staging: iio: ad5933: use sysfs_emit() in show functions Date: Fri, 20 Mar 2026 22:24:23 +0000 Message-Id: <20260320222424.53294-3-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260320222424.53294-1-grondon@gmail.com> References: <20260319225719.73587-1-grondon@gmail.com> <20260320222424.53294-1-grondon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace sprintf() with sysfs_emit() in all sysfs attribute show functions. sysfs_emit() is the preferred API for sysfs callbacks as it is aware of the PAGE_SIZE buffer limit. Also remove the unnecessary (int) cast in ad5933_show_frequency() and use the correct format specifier %llu for the unsigned long long freqreg variable. Signed-off-by: Gabriel Rondon --- .../staging/iio/impedance-analyzer/ad5933.c | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/stag= ing/iio/impedance-analyzer/ad5933.c index 85a422329..e5a4f8d7a 100644 --- a/drivers/staging/iio/impedance-analyzer/ad5933.c +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c @@ -285,7 +285,7 @@ static ssize_t ad5933_show_frequency(struct device *dev, freqreg =3D (u64)freqreg * (u64)(st->mclk_hz / 4); do_div(freqreg, BIT(27)); =20 - return sprintf(buf, "%d\n", (int)freqreg); + return sysfs_emit(buf, "%llu\n", freqreg); } =20 static ssize_t ad5933_store_frequency(struct device *dev, @@ -338,27 +338,27 @@ static ssize_t ad5933_show(struct device *dev, mutex_lock(&st->lock); switch ((u32)this_attr->address) { case AD5933_OUT_RANGE: - len =3D sprintf(buf, "%u\n", - st->range_avail[(st->ctrl_hb >> 1) & 0x3]); + len =3D sysfs_emit(buf, "%u\n", + st->range_avail[(st->ctrl_hb >> 1) & 0x3]); break; case AD5933_OUT_RANGE_AVAIL: - len =3D sprintf(buf, "%u %u %u %u\n", st->range_avail[0], - st->range_avail[3], st->range_avail[2], - st->range_avail[1]); + len =3D sysfs_emit(buf, "%u %u %u %u\n", st->range_avail[0], + st->range_avail[3], st->range_avail[2], + st->range_avail[1]); break; case AD5933_OUT_SETTLING_CYCLES: - len =3D sprintf(buf, "%d\n", st->settling_cycles); + len =3D sysfs_emit(buf, "%d\n", st->settling_cycles); break; case AD5933_IN_PGA_GAIN: - len =3D sprintf(buf, "%s\n", - (st->ctrl_hb & AD5933_CTRL_PGA_GAIN_1) ? - "1" : "0.2"); + len =3D sysfs_emit(buf, "%s\n", + (st->ctrl_hb & AD5933_CTRL_PGA_GAIN_1) ? + "1" : "0.2"); break; case AD5933_IN_PGA_GAIN_AVAIL: - len =3D sprintf(buf, "1 0.2\n"); + len =3D sysfs_emit(buf, "1 0.2\n"); break; case AD5933_FREQ_POINTS: - len =3D sprintf(buf, "%d\n", st->freq_points); + len =3D sysfs_emit(buf, "%d\n", st->freq_points); break; default: ret =3D -EINVAL; --=20 2.33.0 From nobody Sat Apr 4 01:47:24 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DE943806DE for ; Fri, 20 Mar 2026 22:24:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774045476; cv=none; b=mIS/xZ84IuKTnrilUQkxkNfnhcMh/e/DxZ+haz8ssGfn3ZxrI8qfJdrV2OUNSinVGbFZsj9TvqxQhgVQIDxa0EtF/kjKKQhnaS+fKUpS4psOb+2N5SvuSs2sP5/j1DKhO2BK3X3aDVNLPmL+LWmcMS/S5j4Zz2Mh4PJTCgUClTM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774045476; c=relaxed/simple; bh=24s4xN6YFjoYXIk8uTUy5ywo7jxmwS+0fXPQrONB34k=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CqbQChsblnvWShZQjgIuKjLBAZsJDPMNgaVyFMeFWujDnn/Jz28u+PVPpzBgcyStfDA4uFe6bVU4OrGKXzyiSUITXFzuHgj0NQE9u0mqxPwZTBT5Dh5lclFXOXEJhED8R8WhZJspbvwVDGoIjjg6p5mWV5DR6kDUu4yJaHcwDh4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pv4HZlku; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pv4HZlku" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-486b9675d36so18202495e9.0 for ; Fri, 20 Mar 2026 15:24:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774045473; x=1774650273; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=besVw0Q61aUOkSVGtpMPG9G/0SuwwqrtJ6yLz21HoDQ=; b=Pv4HZlkuZAqIfT7F7q4jLO7WFVpiFwAMptuvNHtlDE7+WNZsd8Dt5IzHbqSiSbJ2QS CNy1Ck+QbbP/MXzPtA/7DuxMa+AhgTMl3DeKNKokHaHseWhP0klAOYnQtB/1SfzIJrT/ 3WaAV9qUL/AV6vWvvXFdcOVfcyBx6Wl7vGFVRtL/j46Aaw3Wgf5LziUeZXBbnYtw3IbL jEij2n5cuw+TUa20xF+OrLYQ5gxOVp9HYY94xsg9Wqi/mXPElcCO7hLcBUb1/Y+UC3LF CyqtVHv2rJ0L0VJYRPNfxmaeqvrDvzimobVdJGuyjI7nmZYSCCo0ZsriLCntLWD/AFes Jz2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774045473; x=1774650273; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=besVw0Q61aUOkSVGtpMPG9G/0SuwwqrtJ6yLz21HoDQ=; b=W/Y5wKLnFvPcrWjnJfT0zL3vleChqUnnf2GS1ZM7yrmO3VEuvI5+u+ZflbCixYy4ur zICw6KJkepyQjDbuRHUWnnNImquwdBsjMxzSDpl3/d/pfajFeJcV5jpLBnRHEh/7EgNf d0Ix/PSQIVPDcZ4DWwc9P7B12X9id2diD0bCrAFCpkMYiADxkB8ujefWE/dMb17j21Zg xkDWRH6bY5xDi7g2p0+uMg/8X5Tkt5fSrJLE6F+Qfk47Hp7zqR1jnn/V7jqBFGeKyNji q+LIiUthguDYK3FC6Yi5h7n5cS6OPsovT1XPubVjqsgujBon4H+VIdfEcCx70Ppd2TR9 PjKA== X-Forwarded-Encrypted: i=1; AJvYcCXKhdQ3Berikb/obejEge/mBtvNVkJqXEQP9x8+GmwjJFGl2iAiFMXPWGAkvFo/iTzlYiJK+GeTJp/+L8E=@vger.kernel.org X-Gm-Message-State: AOJu0YyqgNFHYaP+KJzmkWq9phzEuUFnS6fo+DYC0YhVvYOj5lB/ap0R wXL8j9xgiA46nCjpvr9YPhryXpvvN4zx40u9v8J5x2w7F+OK59Y4lNI3 X-Gm-Gg: ATEYQzwXpkkVANKTPA018N5QGk4w/yfODH1A0YBYZnktDpwz5HbunMYYcekMY8HAbVU AFC91rBNgATIWn1XAhB9cCs9YCqFKMXsfL+gQZ9ML9wZJ/uCzhyoAOQjuTt4ZV/g8b7cnQcZ+EB YfnV1GD60avywvtce5ttLIa/b5KNojPyauJ2ls00j9tkv/vgXAEKhzY+n6zNLSwI3wQSWEyHoTH MvnnHl8lgsZuA+yq9N8iBqCU8k2RW+15AqYJJqo8Mtrjk9W0goJQXZR4RHLEZaGIBRDpSUbnZdP 9KNOq/XULhOupDCLpmxwyhFZHGQ4E+t0OnzHhsk5VI/r+pWgdX7FXT8MTXDbAOI9azBTKGm/8cK Mx0OO9jRWPWzZ4z+b0SnyeviKkFNMwxxR20+9IpslDvVvUDHqTMjw3LKhGaJtiFvLmGvfE66+qz ePobbtNGoVb4dpdkmj+mQMOgBQ5xHZF51V313bhW61xep47AgsqvfTWiF5PA== X-Received: by 2002:a05:600c:4e8e:b0:483:c35d:3659 with SMTP id 5b1f17b1804b1-486fee04a48mr64997975e9.18.1774045472933; Fri, 20 Mar 2026 15:24:32 -0700 (PDT) Received: from localhost.localdomain ([2001:8a0:6c9b:a000:bc11:6b0a:79ed:3d9f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b644ae016sm9290237f8f.4.2026.03.20.15.24.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 15:24:32 -0700 (PDT) From: Gabriel Rondon To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org Cc: andriy.shevchenko@intel.com, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] staging: iio: ad9834: use sysfs_emit() and simplify show functions Date: Fri, 20 Mar 2026 22:24:24 +0000 Message-Id: <20260320222424.53294-4-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260320222424.53294-1-grondon@gmail.com> References: <20260319225719.73587-1-grondon@gmail.com> <20260320222424.53294-1-grondon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace sprintf() with sysfs_emit() in sysfs attribute show functions. sysfs_emit() is the preferred API for sysfs callbacks as it is aware of the PAGE_SIZE buffer limit. Also simplify the wavetype_available show functions by removing the intermediate string variable and returning directly from each branch. Signed-off-by: Gabriel Rondon --- drivers/staging/iio/frequency/ad9834.c | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/f= requency/ad9834.c index d339d5e8e..bdb2580e2 100644 --- a/drivers/staging/iio/frequency/ad9834.c +++ b/drivers/staging/iio/frequency/ad9834.c @@ -281,16 +281,12 @@ ssize_t ad9834_show_out0_wavetype_available(struct de= vice *dev, { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad9834_state *st =3D iio_priv(indio_dev); - char *str; =20 if (st->devid =3D=3D ID_AD9833 || st->devid =3D=3D ID_AD9837) - str =3D "sine triangle square"; - else if (st->control & AD9834_OPBITEN) - str =3D "sine"; - else - str =3D "sine triangle"; - - return sprintf(buf, "%s\n", str); + return sysfs_emit(buf, "sine triangle square\n"); + if (st->control & AD9834_OPBITEN) + return sysfs_emit(buf, "sine\n"); + return sysfs_emit(buf, "sine triangle\n"); } =20 static IIO_DEVICE_ATTR(out_altvoltage0_out0_wavetype_available, 0444, @@ -303,14 +299,10 @@ ssize_t ad9834_show_out1_wavetype_available(struct de= vice *dev, { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad9834_state *st =3D iio_priv(indio_dev); - char *str; =20 if (st->control & AD9834_MODE) - str =3D ""; - else - str =3D "square"; - - return sprintf(buf, "%s\n", str); + return sysfs_emit(buf, "\n"); + return sysfs_emit(buf, "square\n"); } =20 static IIO_DEVICE_ATTR(out_altvoltage0_out1_wavetype_available, 0444, --=20 2.33.0