From nobody Sat Apr 4 04:33:35 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E53023B6BE9 for ; Fri, 20 Mar 2026 20:14:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774037660; cv=none; b=tNuwC8Ybasxu2wZ0lgB5RPLMZa/TEMr5ZkqQSh8vBW9aAtTOpl7SMyOfRs/ofW1Cvdb/exZRxdiBrpe7gKjXZ+lF/aTg1DfhERfchR56gGiQV52H4pQuGgPcObjVaketxgbORON6vmFl73GQNxQiyXGGXE0rF9v4wOo6ZupwIBw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774037660; c=relaxed/simple; bh=RMoWLRANM8/2/oMiqcxTksuxeQgvNQvDb9zxMCPcigY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tLNCs3ieTIp1pVT3x7a0AMFgpNGqopV4VhCowk5Gg48vL20JcrSfhYjeDpo2yJmIqOfT9qmALZf0hU69+dNgcboCrrpyMvxpr2AaBW2ESMD8nrkbyUHA4cGiyicokmWMDD5iAEaoiSO1UyFaBJfsdnZKhcNlqaqJ+YZH6kU2jqk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=A5s6rj1o; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=H0tREukZ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="A5s6rj1o"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="H0tREukZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774037658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=JPuumjF1Q/CxeVJhcu6LhrvdlVq1DqJdhZ9BrK6DHGc=; b=A5s6rj1oO85DKhQXxCbGvG1SK6bR/9SKRnHhLwjXtlOUB4Pgoe7bhW9MOnXhLL689FFg6e 7y9/aoTHDvyzzW6Wr0re4UN7Emduj2i0znta6XKkNRhm1haW5DhGOoz9G9phPZdAaO0q5y V7vvREepENnJSfw2QeA1vhpa5WU49AQ= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-212-iKlrFEHAPTmwkC7tanbdGg-1; Fri, 20 Mar 2026 16:14:17 -0400 X-MC-Unique: iKlrFEHAPTmwkC7tanbdGg-1 X-Mimecast-MFC-AGG-ID: iKlrFEHAPTmwkC7tanbdGg_1774037656 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-79878791ec6so47692187b3.3 for ; Fri, 20 Mar 2026 13:14:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774037656; x=1774642456; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=JPuumjF1Q/CxeVJhcu6LhrvdlVq1DqJdhZ9BrK6DHGc=; b=H0tREukZAdHPYC+rdZQk6rJ9agWyIv6bnNUM1rEzxU6bZ7XbnNi7iq/CHdGFM4ndcQ /CzHqJNzIPpSgZ6GbrWMxh/RVPeTF+i4IfDh4q9+dtHCu37u9oV3weUltbRgj08x6umx zGTL/YOIGPP74fV0K0J7qubaqBPDwoX++73dd3R8YDIPHrpxkNaJ1h6g2KGOXhe/zJJs ZpjkazXomRhKuB2eMKR+p9V2OFFBTNlkSbC0r7jj2JwK7TYO4pN3mW467IRKQs+l5rAK m2JGDdJACWkqh2VA+FUweEn/lHSeQp3Fa6w/GRDvZNx9yLK7P4lUWUL1/1AhdbSyySsK Fkdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774037656; x=1774642456; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JPuumjF1Q/CxeVJhcu6LhrvdlVq1DqJdhZ9BrK6DHGc=; b=SXFyEdymWBKU45VUjmk4o0hBVODNy7sFBrLyJS6eMYWfAlvE3/85CX0muQbbjulHO7 Aj54NxW+rMtG9bmLkWtbUaXl5EhSYyGm6+u8/6fsi1J2F+BknpXXHD1/DE2W9IEGUGN+ ehu/7k1ePyelARUXwmRFpylHN041IWwr1VfkgDnEGZpLoNw/j0n6JH5h8VaNmfn3mRXR Z0GYk9mrP7UGFZAW7qShDxtCjvRRo4rNwQXrUqSDfRcq5LMqfXe/QtY/fXLmCLAmdc2W aEtLDA9POBTfYPpxu5Z0mtL2fEsmmlqtw4+/oPMZZXkjioUtIWvBamjEQlHrlKbWFZqA SO+g== X-Forwarded-Encrypted: i=1; AJvYcCVm5uMSRFh8sZ+zbNcDw1BN045lvJN1+NN6ih82FOx+RKDJpKLKcg9tiTOcBAg9uo5zP/iz5C1BNLWVAB8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxk8RdNUKVwld13j+flUjzt3Tap901ijvV+EpzKKPBHp0oNXnnY TyiZ+/Cs6oQKBvTfGIYQ38Xj+VtU3DMvLsTRt735872zhjbL+FkrNQCpacl7AczC5MQKFm8SZkF 5prnV0tbYslG1LZbU5d8gVP9mLRcnf8MBfUhnjUbguaW7ZjotPKnyTB+IG0iAb0QWMq/fi4pnEm MK X-Gm-Gg: ATEYQzwWv6CtOU01NJFS5U3LJhLbXSzLizVN29uS5QGUzrGNhogyCb/pVwt9yasqVTH 7Ot4+DOcwoxGRZcl+Wj9svZ3Mj281qJt4WYO6klgT/3ys7vCt3bXP736VXpu/dP99W9BmEDKibZ zxg2Lt+N4ROydD4Js0M9yRCE/xGoTrew9mi9LELvqb1hYHRR79JNfdbLQUVvEPi+O/ClGwOlKQf XyX9PVbW4P0StRh1sm8SyNkwXGvFkNhq0lzOVmaqprwQqwQ6onQWEQx/pwNsCS9O5d6nQt/YlFi 0CoZP3bJ1cjS9MMKOXMAxqJINiWvFcY9tKu3ob9C1mwiWkfc0A7CHNtHg3l31KDz9u8kbvcJ9w2 omoBwC+2Pz1tKDsSUG3St41DMrTJ3 X-Received: by 2002:a05:690c:a04d:b0:79a:649e:265d with SMTP id 00721157ae682-79a90be905dmr33607887b3.49.1774037656088; Fri, 20 Mar 2026 13:14:16 -0700 (PDT) X-Received: by 2002:a05:690c:a04d:b0:79a:649e:265d with SMTP id 00721157ae682-79a90be905dmr33607617b3.49.1774037655640; Fri, 20 Mar 2026 13:14:15 -0700 (PDT) Received: from thiccpad.redhat.com ([179.99.166.70]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79a903f4190sm21415977b3.15.2026.03.20.13.14.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 13:14:15 -0700 (PDT) From: Pablo Hugen To: live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: jpoimboe@kernel.org, jikos@kernel.org, mbenes@suse.cz, pmladek@suse.com, joe.lawrence@redhat.com, shuah@kernel.org, Pablo Alessandro Santos Hugen Subject: [PATCH] selftests/livepatch: add test for module function patching Date: Fri, 20 Mar 2026 17:11:17 -0300 Message-ID: <20260320201135.1203992-1-phugen@redhat.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Pablo Alessandro Santos Hugen Add a target module and livepatch pair that verify module function patching via a proc entry. Two test cases cover both the klp_enable_patch path (target loaded before livepatch) and the klp_module_coming path (livepatch loaded before target). Signed-off-by: Pablo Alessandro Santos Hugen Acked-by: Joe Lawrence Acked-by: Miroslav Benes --- .../selftests/livepatch/test-livepatch.sh | 100 ++++++++++++++++++ .../selftests/livepatch/test_modules/Makefile | 2 + .../test_modules/test_klp_mod_patch.c | 53 ++++++++++ .../test_modules/test_klp_mod_target.c | 39 +++++++ 4 files changed, 194 insertions(+) create mode 100644 tools/testing/selftests/livepatch/test_modules/test_klp= _mod_patch.c create mode 100644 tools/testing/selftests/livepatch/test_modules/test_klp= _mod_target.c diff --git a/tools/testing/selftests/livepatch/test-livepatch.sh b/tools/te= sting/selftests/livepatch/test-livepatch.sh index 6673023d2b66..c44c5341a2f1 100755 --- a/tools/testing/selftests/livepatch/test-livepatch.sh +++ b/tools/testing/selftests/livepatch/test-livepatch.sh @@ -8,6 +8,8 @@ MOD_LIVEPATCH1=3Dtest_klp_livepatch MOD_LIVEPATCH2=3Dtest_klp_syscall MOD_LIVEPATCH3=3Dtest_klp_callbacks_demo MOD_REPLACE=3Dtest_klp_atomic_replace +MOD_TARGET=3Dtest_klp_mod_target +MOD_TARGET_PATCH=3Dtest_klp_mod_patch =20 setup_config =20 @@ -196,4 +198,102 @@ livepatch: '$MOD_REPLACE': unpatching complete % rmmod $MOD_REPLACE" =20 =20 +# - load a target module that provides /proc/test_klp_mod_target with +# original output +# - load a livepatch that patches the target module's show function +# - verify the proc entry returns livepatched output +# - disable and unload the livepatch +# - verify the proc entry returns original output again +# - unload the target module + +start_test "module function patching" + +load_mod $MOD_TARGET + +if [[ "$(cat /proc/$MOD_TARGET)" !=3D "$MOD_TARGET: original output" ]] ; = then + echo -e "FAIL\n\n" + die "livepatch kselftest(s) failed" +fi + +load_lp $MOD_TARGET_PATCH + +if [[ "$(cat /proc/$MOD_TARGET)" !=3D "$MOD_TARGET_PATCH: this has been li= ve patched" ]] ; then + echo -e "FAIL\n\n" + die "livepatch kselftest(s) failed" +fi + +disable_lp $MOD_TARGET_PATCH +unload_lp $MOD_TARGET_PATCH + +if [[ "$(cat /proc/$MOD_TARGET)" !=3D "$MOD_TARGET: original output" ]] ; = then + echo -e "FAIL\n\n" + die "livepatch kselftest(s) failed" +fi + +unload_mod $MOD_TARGET + +check_result "% insmod test_modules/$MOD_TARGET.ko +$MOD_TARGET: test_klp_mod_target_init +% insmod test_modules/$MOD_TARGET_PATCH.ko +livepatch: enabling patch '$MOD_TARGET_PATCH' +livepatch: '$MOD_TARGET_PATCH': initializing patching transition +livepatch: '$MOD_TARGET_PATCH': starting patching transition +livepatch: '$MOD_TARGET_PATCH': completing patching transition +livepatch: '$MOD_TARGET_PATCH': patching complete +% echo 0 > $SYSFS_KLP_DIR/$MOD_TARGET_PATCH/enabled +livepatch: '$MOD_TARGET_PATCH': initializing unpatching transition +livepatch: '$MOD_TARGET_PATCH': starting unpatching transition +livepatch: '$MOD_TARGET_PATCH': completing unpatching transition +livepatch: '$MOD_TARGET_PATCH': unpatching complete +% rmmod $MOD_TARGET_PATCH +% rmmod $MOD_TARGET +$MOD_TARGET: test_klp_mod_target_exit" + + +# - load a livepatch that targets a not-yet-loaded module +# - load the target module: klp_module_coming patches it immediately +# - verify the proc entry returns livepatched output +# - disable and unload the livepatch +# - verify the proc entry returns original output again +# - unload the target module + +start_test "module function patching (livepatch first)" + +load_lp $MOD_TARGET_PATCH +load_mod $MOD_TARGET + +if [[ "$(cat /proc/$MOD_TARGET)" !=3D "$MOD_TARGET_PATCH: this has been li= ve patched" ]] ; then + echo -e "FAIL\n\n" + die "livepatch kselftest(s) failed" +fi + +disable_lp $MOD_TARGET_PATCH +unload_lp $MOD_TARGET_PATCH + +if [[ "$(cat /proc/$MOD_TARGET)" !=3D "$MOD_TARGET: original output" ]] ; = then + echo -e "FAIL\n\n" + die "livepatch kselftest(s) failed" +fi + +unload_mod $MOD_TARGET + +check_result "% insmod test_modules/$MOD_TARGET_PATCH.ko +livepatch: enabling patch '$MOD_TARGET_PATCH' +livepatch: '$MOD_TARGET_PATCH': initializing patching transition +livepatch: '$MOD_TARGET_PATCH': starting patching transition +livepatch: '$MOD_TARGET_PATCH': completing patching transition +livepatch: '$MOD_TARGET_PATCH': patching complete +% insmod test_modules/$MOD_TARGET.ko +livepatch: applying patch '$MOD_TARGET_PATCH' to loading module '$MOD_TARG= ET' +$MOD_TARGET: test_klp_mod_target_init +% echo 0 > $SYSFS_KLP_DIR/$MOD_TARGET_PATCH/enabled +livepatch: '$MOD_TARGET_PATCH': initializing unpatching transition +livepatch: '$MOD_TARGET_PATCH': starting unpatching transition +livepatch: '$MOD_TARGET_PATCH': completing unpatching transition +livepatch: '$MOD_TARGET_PATCH': unpatching complete +% rmmod $MOD_TARGET_PATCH +% rmmod $MOD_TARGET +$MOD_TARGET: test_klp_mod_target_exit" + + exit 0 diff --git a/tools/testing/selftests/livepatch/test_modules/Makefile b/tool= s/testing/selftests/livepatch/test_modules/Makefile index 939230e571f5..a13d398585dc 100644 --- a/tools/testing/selftests/livepatch/test_modules/Makefile +++ b/tools/testing/selftests/livepatch/test_modules/Makefile @@ -8,6 +8,8 @@ obj-m +=3D test_klp_atomic_replace.o \ test_klp_callbacks_mod.o \ test_klp_kprobe.o \ test_klp_livepatch.o \ + test_klp_mod_patch.o \ + test_klp_mod_target.o \ test_klp_shadow_vars.o \ test_klp_state.o \ test_klp_state2.o \ diff --git a/tools/testing/selftests/livepatch/test_modules/test_klp_mod_pa= tch.c b/tools/testing/selftests/livepatch/test_modules/test_klp_mod_patch.c new file mode 100644 index 000000000000..6725b4720365 --- /dev/null +++ b/tools/testing/selftests/livepatch/test_modules/test_klp_mod_patch.c @@ -0,0 +1,53 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (C) 2026 Pablo Hugen + +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + +#include +#include +#include +#include + +static int livepatch_mod_target_show(struct seq_file *m, void *v) +{ + seq_printf(m, "%s: %s\n", THIS_MODULE->name, + "this has been live patched"); + return 0; +} + +static struct klp_func funcs[] =3D { + { + .old_name =3D "test_klp_mod_target_show", + .new_func =3D livepatch_mod_target_show, + }, + {}, +}; + +static struct klp_object objs[] =3D { + { + .name =3D "test_klp_mod_target", + .funcs =3D funcs, + }, + {}, +}; + +static struct klp_patch patch =3D { + .mod =3D THIS_MODULE, + .objs =3D objs, +}; + +static int test_klp_mod_patch_init(void) +{ + return klp_enable_patch(&patch); +} + +static void test_klp_mod_patch_exit(void) +{ +} + +module_init(test_klp_mod_patch_init); +module_exit(test_klp_mod_patch_exit); +MODULE_LICENSE("GPL"); +MODULE_INFO(livepatch, "Y"); +MODULE_AUTHOR("Pablo Hugen "); +MODULE_DESCRIPTION("Livepatch test: patch for module-provided function"); diff --git a/tools/testing/selftests/livepatch/test_modules/test_klp_mod_ta= rget.c b/tools/testing/selftests/livepatch/test_modules/test_klp_mod_target= .c new file mode 100644 index 000000000000..9643984d2402 --- /dev/null +++ b/tools/testing/selftests/livepatch/test_modules/test_klp_mod_target.c @@ -0,0 +1,39 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (C) 2026 Pablo Hugen + +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + +#include +#include +#include +#include + +static struct proc_dir_entry *pde; + +static noinline int test_klp_mod_target_show(struct seq_file *m, void *v) +{ + seq_printf(m, "%s: %s\n", THIS_MODULE->name, "original output"); + return 0; +} + +static int test_klp_mod_target_init(void) +{ + pr_info("%s\n", __func__); + pde =3D proc_create_single("test_klp_mod_target", 0, NULL, + test_klp_mod_target_show); + if (!pde) + return -ENOMEM; + return 0; +} + +static void test_klp_mod_target_exit(void) +{ + pr_info("%s\n", __func__); + proc_remove(pde); +} + +module_init(test_klp_mod_target_init); +module_exit(test_klp_mod_target_exit); +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Pablo Hugen "); +MODULE_DESCRIPTION("Livepatch test: target module with proc entry"); --=20 2.53.0