From nobody Mon Apr 6 09:10:04 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABD1034676F for ; Fri, 20 Mar 2026 19:15:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774034131; cv=none; b=qKtj1ueE6xVsioD9re63WYwQcMx7YWmxEjeEIqOdntuFoPixL5zb5LeEmSYkZaAzs/2cGLYz9j+URoqxaOo/Dhzcvd1KH8Gebd2rvf0E6P0rnXaA1C8PHSByT38n3Bzybi1EZ8EvwM+o18UmyulPUuqdJQ82q/QqRqEmbBnSbB4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774034131; c=relaxed/simple; bh=K4AbDxiPtFtHSpGdGDtx7OdA8I3+c3fZMd8RDCScu78=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=q+udOPuQ0rHqJ6tjV4I8xix7h2eJ504kl/oyEvtSZVtW6Ors5yQqbCVVzR37MFXkzEP9/KG+0jZ4jDM8UphH7XngkcRXHu01v/q2mLb1qLcBZxGrWOScOJ7EmBpNk2OVLYLNh270BN1tXGDbD54IttskpHK6GKIjGy8SH0hXTfc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XCqfV0+g; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XCqfV0+g" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2adff872068so4625485ad.1 for ; Fri, 20 Mar 2026 12:15:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774034129; x=1774638929; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=hLR2ZkG6bg0iShqg1gNOyekotcqpmX708u+9fcbgzN8=; b=XCqfV0+gVKtpqLWbnYlNWnkLzJSUrGA266wZOPYzyyTzK+AxK7xkiyJNMh4fgAf1Fi BYGnjcfry8wVUrqtFoVjiOnYIDh/w3plwqz/pkyPqqSDGfUxl6ed7wA8a87dNjBSn2yO lOI88lNY1lmO2klOg5YIcQBcDDvKU57HegHUqHWKBKEqXv9zUTMNkJRjYKN8zrc8j6Ze SU+EDSkTNYlGJ1x4TiUij2BKq/p0AWEFH14AmbWIr5/dltOgrcdhVecL5rRNDlnuTMNw VIQ8V/qS6IpT9VDHTSCsY+KQBeITyPdTzygY/VsbG/XdUW6Vb5cMDIQMJI9KfD5xub0d wLbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774034129; x=1774638929; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hLR2ZkG6bg0iShqg1gNOyekotcqpmX708u+9fcbgzN8=; b=LtdwR35Lzh3fhr2aV5SSLP+321oN2YCSavWQomn6lCEcztiqfcPk7YEDEZbH7FImJA n6FI2Y+1Ti2CtmAdhc5WieJbPoiql+E0CwazQQA4uA0fIMXW6p+QMsk1++p2JRnEiCAU kLwVnnIEVVfWquVqAd4VKMyIhLaxh4lr+LxleOp/pM8v9JoH0mkrgeTH1UNM34uHJ0B+ 4kBGykdawaTNLp1VTRvZ3wrmtzHDhcRjZ0SApJULGVQBIEAR/ECKwSp2mc5qjA0giH08 6w7+rlh26TF8k/sV5yplog9Ze45ImTNHAEw711zaUCzl+LFKq+wLsGOa6fT5q048/aHA f+oA== X-Forwarded-Encrypted: i=1; AJvYcCU5UXHXcw3bPj9F1jqHkCqHdlKyLdTJomdqagafTxf6nslft91LQG9tkMy1xFiotAZfeN7HOXpgJ7OEIC8=@vger.kernel.org X-Gm-Message-State: AOJu0YwdHKYppl0vgE+XWjI0XSrur6AU7FgZcJaDy1ijNCymtVOdfv5Y N/H52vdFrB9/8p8/W790/jmzqDQ9tchUi/7srBG37+beb7rNGYQUF73B X-Gm-Gg: ATEYQzySGlZ+zLRm09t2eSL3Wcm31Oq7Fu5Mq+QyZvn+O9rdqieoR8ge+chbWL2SXq4 KM9JPZDYt2CJQZnqrPXGI753Cll+AN/xCvPl1WPq/1QIheqOVFd41qlHRBnkOspm6JM7mpdp0kQ 4jr/fXutl7hEwyD+4kHqgc8nmRXaBfNIaLYz3rcPCXXnDRv3peReocU2hbHCtKqHhL9fP2qW0R5 /bi3Jbe5QDTA1Q0eJcPmLnCkUYFfwSeq/sAkq28Dn9NVDKqvAbLLvlcu5llp2nTMnmwetHn0RCZ 3zEwk4llPiBC5MOJ4L1hP2cP8QceI/t0zD8I59cl5qufeYyxoJC06/t11BSbHK7vwhYf6XOYgV3 Vv8En4gY3+Q61eZHysYnO8Koq3koN1NhOjQiEtwTTtUwJQQM7PbkVJHKCtoo80gefIklMxLPnNK mqeoZ0tn4sXRrN3JRHb8qK959Qsp4ehixtUUmQDtM= X-Received: by 2002:a17:903:38cf:b0:2b0:6961:150a with SMTP id d9443c01a7336-2b0827d7e20mr37600295ad.38.1774034128858; Fri, 20 Mar 2026 12:15:28 -0700 (PDT) Received: from LIB-LAP-0152.lan ([2409:40f2:2080:22bd:b0c0:3626:1867:c290]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0836b97fesm28973025ad.84.2026.03.20.12.15.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 12:15:28 -0700 (PDT) From: "Chethan.C" X-Google-Original-From: "Chethan.C" To: Mauro Carvalho Chehab , Greg Kroah-Hartman , "Chethan.C" , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2] staging: media: av7110: fix coding style Date: Sat, 21 Mar 2026 00:45:02 +0530 Message-Id: <20260320191507.511560-1-mail.chethan.c@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fixed Indentation issues reported by checkpatch.pl. Renamed enum av7110_rec_play_state from camel case to upper case underscore style to comply kernel style guidelines. Signed-off-by: Chethan.C --- v2: - fixed indentation issues reported by checkpatch.pl - Rename av7110_rec_play_state to follow kernel naming style --- drivers/staging/media/av7110/av7110_av.c | 109 ++++++++++++++++++----- drivers/staging/media/av7110/av7110_hw.h | 16 ++-- 2 files changed, 94 insertions(+), 31 deletions(-) diff --git a/drivers/staging/media/av7110/av7110_av.c b/drivers/staging/med= ia/av7110/av7110_av.c index 2993ac43c49c..a7d76348318d 100644 --- a/drivers/staging/media/av7110/av7110_av.c +++ b/drivers/staging/media/av7110/av7110_av.c @@ -111,7 +111,7 @@ int av7110_av_start_record(struct av7110 *av7110, int a= v, =20 if (av7110->playing || (av7110->rec_mode & av)) return -EBUSY; - av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, __Stop, 0); + av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, AV7110_REC_PLAY_STOP, 0); dvbdmx->recording =3D 1; av7110->rec_mode |=3D av; =20 @@ -121,7 +121,11 @@ int av7110_av_start_record(struct av7110 *av7110, int = av, dvbdmx->pesfilter[0]->pid, dvb_filter_pes2ts_cb, (void *)dvbdmx->pesfilter[0]); - ret =3D av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, __Record, 2, AudioPES, 0= ); + ret =3D av7110_fw_cmd(av7110, + COMTYPE_REC_PLAY, + AV7110_REC_PLAY_RECORD, + 2, + AudioPES, 0); break; =20 case RP_VIDEO: @@ -129,7 +133,12 @@ int av7110_av_start_record(struct av7110 *av7110, int = av, dvbdmx->pesfilter[1]->pid, dvb_filter_pes2ts_cb, (void *)dvbdmx->pesfilter[1]); - ret =3D av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, __Record, 2, VideoPES, 0= ); + ret =3D av7110_fw_cmd(av7110, + COMTYPE_REC_PLAY, + AV7110_REC_PLAY_RECORD, + 2, + VideoPES, + 0); break; =20 case RP_AV: @@ -141,7 +150,12 @@ int av7110_av_start_record(struct av7110 *av7110, int = av, dvbdmx->pesfilter[1]->pid, dvb_filter_pes2ts_cb, (void *)dvbdmx->pesfilter[1]); - ret =3D av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, __Record, 2, AV_PES, 0); + ret =3D av7110_fw_cmd(av7110, + COMTYPE_REC_PLAY, + AV7110_REC_PLAY_RECORD, + 2, + AV_PES, + 0); break; } return ret; @@ -158,7 +172,7 @@ int av7110_av_start_play(struct av7110 *av7110, int av) if (av7110->playing & av) return -EBUSY; =20 - av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, __Stop, 0); + av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, AV7110_REC_PLAY_STOP, 0); =20 if (av7110->playing =3D=3D RP_NONE) { av7110_ipack_reset(&av7110->ipack[0]); @@ -168,15 +182,30 @@ int av7110_av_start_play(struct av7110 *av7110, int a= v) av7110->playing |=3D av; switch (av7110->playing) { case RP_AUDIO: - ret =3D av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, __Play, 2, AudioPES, 0); + ret =3D av7110_fw_cmd(av7110, + COMTYPE_REC_PLAY, + AV7110_REC_PLAY_PLAY, + 2, + AudioPES, + 0); break; case RP_VIDEO: - ret =3D av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, __Play, 2, VideoPES, 0); + ret =3D av7110_fw_cmd(av7110, + COMTYPE_REC_PLAY, + AV7110_REC_PLAY_PLAY, + 2, + VideoPES, + 0); av7110->sinfo =3D 0; break; case RP_AV: av7110->sinfo =3D 0; - ret =3D av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, __Play, 2, AV_PES, 0); + ret =3D av7110_fw_cmd(av7110, + COMTYPE_REC_PLAY, + AV7110_REC_PLAY_PLAY, + 2, + AV_PES, + 0); break; } return ret; @@ -190,15 +219,25 @@ int av7110_av_stop(struct av7110 *av7110, int av) =20 if (!(av7110->playing & av) && !(av7110->rec_mode & av)) return 0; - av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, __Stop, 0); + av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, AV7110_REC_PLAY_STOP, 0); if (av7110->playing) { av7110->playing &=3D ~av; switch (av7110->playing) { case RP_AUDIO: - ret =3D av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, __Play, 2, AudioPES, 0); + ret =3D av7110_fw_cmd(av7110, + COMTYPE_REC_PLAY, + AV7110_REC_PLAY_PLAY, + 2, + AudioPES, + 0); break; case RP_VIDEO: - ret =3D av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, __Play, 2, VideoPES, 0); + ret =3D av7110_fw_cmd(av7110, + COMTYPE_REC_PLAY, + AV7110_REC_PLAY_PLAY, + 2, + VideoPES, + 0); break; case RP_NONE: ret =3D av7110_set_vidmode(av7110, av7110->vidmode); @@ -208,10 +247,20 @@ int av7110_av_stop(struct av7110 *av7110, int av) av7110->rec_mode &=3D ~av; switch (av7110->rec_mode) { case RP_AUDIO: - ret =3D av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, __Record, 2, AudioPES, = 0); + ret =3D av7110_fw_cmd(av7110, + COMTYPE_REC_PLAY, + AV7110_REC_PLAY_RECORD, + 2, + AudioPES, + 0); break; case RP_VIDEO: - ret =3D av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, __Record, 2, VideoPES, = 0); + ret =3D av7110_fw_cmd(av7110, + COMTYPE_REC_PLAY, + AV7110_REC_PLAY_RECORD, + 2, + VideoPES, + 0); break; case RP_NONE: break; @@ -551,7 +600,7 @@ static ssize_t dvb_aplay(struct av7110 *av7110, const c= har __user *buf, if (nonblock) return count - todo; if (wait_event_interruptible(av7110->aout.queue, - (dvb_ringbuffer_free(&av7110->aout) >=3D 20 * 1024))) + (dvb_ringbuffer_free(&av7110->aout) >=3D 20 * 1024))) return count - todo; } n =3D todo; @@ -1168,7 +1217,10 @@ static int dvb_video_ioctl(struct file *file, } if (av7110->videostate.stream_source =3D=3D VIDEO_SOURCE_MEMORY) { if (av7110->playing =3D=3D RP_AV) { - ret =3D av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, __Stop, 0); + ret =3D av7110_fw_cmd(av7110, + COMTYPE_REC_PLAY, + AV7110_REC_PLAY_STOP, + 0); if (ret) break; av7110->playing &=3D ~RP_VIDEO; @@ -1184,7 +1236,10 @@ static int dvb_video_ioctl(struct file *file, case VIDEO_FREEZE: av7110->videostate.play_state =3D VIDEO_FREEZED; if (av7110->playing & RP_VIDEO) - ret =3D av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, __Pause, 0); + ret =3D av7110_fw_cmd(av7110, + COMTYPE_REC_PLAY, + AV7110_REC_PLAY_PAUSE, + 0); else ret =3D vidcom(av7110, AV_VIDEO_CMD_FREEZE, 1); if (!ret) @@ -1193,7 +1248,10 @@ static int dvb_video_ioctl(struct file *file, =20 case VIDEO_CONTINUE: if (av7110->playing & RP_VIDEO) - ret =3D av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, __Continue, 0); + ret =3D av7110_fw_cmd(av7110, + COMTYPE_REC_PLAY, + AV7110_REC_PLAY_CONTINUE, + 0); if (!ret) ret =3D vidcom(av7110, AV_VIDEO_CMD_PLAY, 0); if (!ret) { @@ -1291,7 +1349,7 @@ static int dvb_video_ioctl(struct file *file, //note: arg is ignored by firmware if (av7110->playing & RP_VIDEO) ret =3D av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, - __Scan_I, 2, AV_PES, 0); + AV7110_REC_PLAY_SCAN_I, 2, AV_PES, 0); else ret =3D vidcom(av7110, AV_VIDEO_CMD_FFWD, arg); if (!ret) { @@ -1303,7 +1361,12 @@ static int dvb_video_ioctl(struct file *file, case VIDEO_SLOWMOTION: if (av7110->playing & RP_VIDEO) { if (av7110->trickmode !=3D TRICK_SLOW) - ret =3D av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, __Slow, 2, 0, 0); + ret =3D av7110_fw_cmd(av7110, + COMTYPE_REC_PLAY, + AV7110_REC_PLAY_SLOW, + 2, + 0, + 0); if (!ret) ret =3D vidcom(av7110, AV_VIDEO_CMD_SLOW, arg); } else { @@ -1329,15 +1392,15 @@ static int dvb_video_ioctl(struct file *file, av7110_ipack_reset(&av7110->ipack[1]); if (av7110->playing =3D=3D RP_AV) { ret =3D av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, - __Play, 2, AV_PES, 0); + AV7110_REC_PLAY_PLAY, 2, AV_PES, 0); if (ret) break; if (av7110->trickmode =3D=3D TRICK_FAST) ret =3D av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, - __Scan_I, 2, AV_PES, 0); + AV7110_REC_PLAY_SCAN_I, 2, AV_PES, 0); if (av7110->trickmode =3D=3D TRICK_SLOW) { ret =3D av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, - __Slow, 2, 0, 0); + AV7110_REC_PLAY_SLOW, 2, 0, 0); if (!ret) ret =3D vidcom(av7110, AV_VIDEO_CMD_SLOW, arg); } @@ -1483,7 +1546,7 @@ static int dvb_audio_ioctl(struct file *file, av7110_ipack_reset(&av7110->ipack[0]); if (av7110->playing =3D=3D RP_AV) ret =3D av7110_fw_cmd(av7110, COMTYPE_REC_PLAY, - __Play, 2, AV_PES, 0); + AV7110_REC_PLAY_PLAY, 2, AV_PES, 0); break; =20 case AUDIO_SET_ID: diff --git a/drivers/staging/media/av7110/av7110_hw.h b/drivers/staging/med= ia/av7110/av7110_hw.h index d4579f411c56..1b17f1f2ea42 100644 --- a/drivers/staging/media/av7110/av7110_hw.h +++ b/drivers/staging/media/av7110/av7110_hw.h @@ -168,14 +168,14 @@ enum av7110_encoder_command { }; =20 enum av7110_rec_play_state { - __Record, - __Stop, - __Play, - __Pause, - __Slow, - __FF_IP, - __Scan_I, - __Continue + AV7110_REC_PLAY_RECORD, + AV7110_REC_PLAY_STOP, + AV7110_REC_PLAY_PLAY, + AV7110_REC_PLAY_PAUSE, + AV7110_REC_PLAY_SLOW, + AV7110_REC_PLAY_FF_IP, + AV7110_REC_PLAY_SCAN_I, + AV7110_REC_PLAY_CONTINUE }; =20 enum av7110_fw_cmd_misc { --=20 2.25.1