From nobody Sat Apr 4 03:18:41 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 807F63E0C54 for ; Fri, 20 Mar 2026 18:10:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774030248; cv=none; b=S8gTrK3XkJmJZ8u6RnhZOiJ8VPafLfhxpQh2+tY+s/UWuFR/sDaz51lyaAQpdujMHsb4SS51yVnUvWiY4ruZp0mqtxixsx7gcTlWUqeYW+/EWVaG3vSzpztOYaGphUajP8Vla6DwWcdWaLfuoJdV5DSY8ysVNbGJaTZ7TZOk1t0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774030248; c=relaxed/simple; bh=su0qCKHnq3PtTnb31b3a9kZUX/DqBj3yiDnEaH4YW+w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fiOsa3V0qPV9kO6AE6eliHeefiJ5d6OpkoARzGHIRzq+XPtuhF32zz4vLrvDj5NcpITHa104TGaUGrUW7fMn++aymRM0aoF0wwzPuE1ni8hmpNhrvvHDWzepKKwDzc2MIwaGg/7z17uVoKc27R86yzlTjgMBOVfbE84IKD2ujhE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CkDWpgXf; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CkDWpgXf" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-359f35dfef6so507127a91.2 for ; Fri, 20 Mar 2026 11:10:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774030245; x=1774635045; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=md5Ntsc0rRpCFPPT7+6W0Dr1q7JQYEVArLNrJ+0AKc8=; b=CkDWpgXfofYCcZUwyDcaJ5h7BJ9F9rPzEeN2VE2QiBsbQ+pkvNkvfPD+e6yHK+Pbyd ikwCe8KDI+cNEuEsEFrWwbS6pYsD16FkK00C+scdNXAJ0gIz65SNFVi+4bLRaEKxZQRq yBiRVagUQBdbvz0dtwBUITeRUeN1BASy66P9FTt/CJ+PHR2i8RIge8lElSJPOOPDR+ku M3kWanabV2SZdJOVBJyK8AWj/V59jGxPQ8DlakMIn1/IzMZ9vGt3iLKEFrfXTYdTq3Kh LCGg+X+d9tbDY/8JDHgsp7IjE80aS3x5jvRWyhP6R39B+ljYI8b5JfKfYAJlF/GewnVQ Kx1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774030245; x=1774635045; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=md5Ntsc0rRpCFPPT7+6W0Dr1q7JQYEVArLNrJ+0AKc8=; b=dqycE5TVzJrLN+fsEwbn5kmFw9HSSTk+gfWkmQOWf9D/K0bjkJ8wUbUsW17lXlsrmK ER5Xvy45n5Y4GOatufE4yI9OqeLDTRZDAGM9Hp3MAGQ6lVFR0zxUIW40mDBweV9lG9uT 9VrN6tljjN9immrVh85Ir3IZZnHmMGz94inaapAa8Nhqt3Sr0yibELP4X4uexSD+Vdao LON+kJELTjWUvjLwHy/eDzphbXdihzzGYIk5N5Uqpg3GMqY7w9HxpAUt2UqMIazMZNKs Y/zRHpeLSijni/FFuSEBbQ7jq4iB64LDnGPhQoFltSabCD4ZGJIm0uY0njNT6Jl9uEtC Zfyg== X-Forwarded-Encrypted: i=1; AJvYcCUEDLSLjoau7ggIbuasT7D6+ksQecmGZ69U/cpZYzzjN22FPTiIhVTUpBHK50GyQo1+YkTNO09uUxY8LM0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxt26e1tVG28jjXiHMAPnVjUpBfSQTqW/JqQ8oGAHooHiyJ6tY6 Iw6cIJJsVMVzSyR6hLF0I8DXijU9H0OvR9UuCdqlHFJ7FoIj2rPTRyMZ X-Gm-Gg: ATEYQzzRERAXqCl/AtkdMUzl6hOwuo5QrRyxbSrTD3H1dQp0/tgJZqLw2cIiBX6ZeFz LuecJmdI2FO9VKpD+84acIDC7VdLhoLMnmGzQz+ECxyt8WaHwa8V41v1kLzNZExm9EC3KztjFW+ ovrJ/QJDgbRAjrOrUMiwBuEMfKyfqq/3OdbO0zHhWPNuBKxpAnd4ImhDw8OxWaMM4KLE8Hmkbpu vRpPvYo9MVFgxNgmw1fwsy7HnVEtzAPCom1q9DDZXH53bOF2yiLyL11BjPtT5S8/wuPJr1uF626 2tRCPvDcydpswO9wt7plrVF8nBBzBQ3d5KyhIU7nDWVa44XZantlAuEvMO1VOrGo6YzsaZ483UB bTrDRK3sY6s8ezCuOv+YXuI/SoPZfCSZqrLFaolOKt1iIFsTULdRdqOi+NjS/Vo+k0x012VIWZo LyFNe8Jc7CdlzssUAG12rAcypfSKy6GXIdU4swzoVH1rEIXmuAkpWuX05fhE2TmhpMRVvuy78= X-Received: by 2002:a17:90b:3f8e:b0:35b:ccb2:9fad with SMTP id 98e67ed59e1d1-35bd2d1d572mr2544272a91.24.1774030244701; Fri, 20 Mar 2026 11:10:44 -0700 (PDT) Received: from sean-All-Series.. (1-160-226-215.dynamic-ip.hinet.net. [1.160.226.215]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd368837bsm959352a91.11.2026.03.20.11.10.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 11:10:44 -0700 (PDT) From: Sean Chang To: Andrew Lunn , Chuck Lever , David Laight , Anna Schumaker , Andy Shevchenko Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v4 1/5] sunrpc: Fix dprintk type mismatch using do-while(0) Date: Sat, 21 Mar 2026 02:09:51 +0800 Message-Id: <20260320180955.150696-2-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260320180955.150696-1-seanwascoding@gmail.com> References: <20260320180955.150696-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Following David Laight's suggestion, simplify the macro definitions by remo= ving the unnecessary 'fmt' argument and using no_printk(VA_ARGS) directly. To resolve a Sparse warning (void vs int mismatch) when dfprintk is used in conditional statements, wrap the non-debug definition in a do-while(0) bloc= k. This ensures the macro always evaluates to a void expression. Suggested-by: David Laight Signed-off-by: Sean Chang --- include/linux/sunrpc/debug.h | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/include/linux/sunrpc/debug.h b/include/linux/sunrpc/debug.h index ab61bed2f7af..f6f2a106eeaf 100644 --- a/include/linux/sunrpc/debug.h +++ b/include/linux/sunrpc/debug.h @@ -38,8 +38,6 @@ extern unsigned int nlm_debug; do { \ ifdebug(fac) \ __sunrpc_printk(fmt, ##__VA_ARGS__); \ - else \ - no_printk(fmt, ##__VA_ARGS__); \ } while (0) =20 # define dfprintk_rcu(fac, fmt, ...) \ @@ -48,15 +46,13 @@ do { \ rcu_read_lock(); \ __sunrpc_printk(fmt, ##__VA_ARGS__); \ rcu_read_unlock(); \ - } else { \ - no_printk(fmt, ##__VA_ARGS__); \ } \ } while (0) =20 #else # define ifdebug(fac) if (0) -# define dfprintk(fac, fmt, ...) no_printk(fmt, ##__VA_ARGS__) -# define dfprintk_rcu(fac, fmt, ...) no_printk(fmt, ##__VA_ARGS__) +# define dfprintk(fac, ...) no_printk(__VA_ARGS__) +# define dfprintk_rcu(fac, ...) no_printk(__VA_ARGS__) #endif =20 /* --=20 2.34.1 From nobody Sat Apr 4 03:18:41 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A340D3E3DBD for ; Fri, 20 Mar 2026 18:10:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774030252; cv=none; b=kTt7aXsqX5OFh69x3Eg9+bvjuDVaeJVwvp7rR0luS+G4CHzevxWpSMy7/VncmQ3c74fDMc2iTEd3MO5ApjpyQpVW/5gSkN95py5ZEE1JZWzDz706zztxVV3ucI1M21apHiwSR9uABqQ7asWdTeevNEKh5hkDr027+ehsCMH5C4M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774030252; c=relaxed/simple; bh=CZYrSzJxOTHz3y2+Yn1YrwZjKF3A8fsmk9txEkZG5Eg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=o+xyLZhQYQMLE7pJR7HcYr1hkcGL9bixESyDdTx+QJHkXhZxMJMzyAwUlvsu25S5d+879FU8cABGIXcxT/Q01yS0dR0o2eiyFLRucJAQAdnv9/K+uNZDo/yFJxTClQQW5nJ7O4ycTUqye8Vz3SFG8O8vcRY28jwfZKQq81r0/T4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ni3iMJzu; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ni3iMJzu" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-35a09e0dd63so1095459a91.3 for ; Fri, 20 Mar 2026 11:10:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774030247; x=1774635047; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=capsefnRJybIkJWvu7BICDZ5yODeSG4sK/v0sJ/qwmE=; b=Ni3iMJzuv0zm9JIPpIqMAullCODUQPmcGAII9eD/pBg2BXI9he9MfyDLut/faWLMSh iO9w2tQHrORgyVCVkMvtulxwAJR29BAox7alDfH4vxpdyu+wv5tx5jFBHnTLRwy3jJK/ Fw/lKwkWd6kQj4kyxaiINcsQ+L4cZXWw3BWIR4dilJVsQX3AdQd0WbINLU3MGALY6VIH DgdUxhfntXlvvNWI107p3qQklMogB4h2VEc45yIigU3oMnIus/IaFhhbLUVwrs//4FnS HFbxfpeyaRjgXJsVXjyPbZL00GlsOXjFfyxfMNUmf6aLbMIP+3O7aY+D+FU7k5tM3i3f lQwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774030247; x=1774635047; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=capsefnRJybIkJWvu7BICDZ5yODeSG4sK/v0sJ/qwmE=; b=s8hRhuJOeKAwPJgKTfXp8vnJiTk0kryA7a3LWWEuytUyBtoVa8svYq6omaAvW0kefw cfT1DCTPwkJOnWwk3saDn3z94lIo292Q7yOrf+gBTI6Lo5kBxSSdn1uv5XVluWY+hcRE JcQ2grV+OS72FfCHKewD8qb+vfT8sNfg8IcDaLhFaB/0ogQ80QkEXSNUm0r5fE4V6cAT SDY33vBf/KIAEV67/cfwV1elnROh7ZTcBnvSZF5Zt8xtB0uaK/emP2fZq508m1ENrAXu 49EUVFQ+Aoq65lhdxlbypqhZHeiwGktOCiYce/sNb/KeiqZvxz9FUB7VI+sAih+dxON8 ovrg== X-Forwarded-Encrypted: i=1; AJvYcCX9j4mcZPJWEOZAB5L544RF7FT2m0PgIWoom5V2D5Jw3we5nDcHusE9SHRkAxMvK0qUWCX4xPYAIu3W8pw=@vger.kernel.org X-Gm-Message-State: AOJu0YxIgBWAuaa12Ddb/tKFtJ2jl2Owv2hydbjUZcqNj5CILDFgMthd mz6pYxPSFLpnCXKZthyXPY5bhGYgVDUrGfEqAEUxOIb9ATbiBvM6U+UB X-Gm-Gg: ATEYQzy1x3RPnz0gLiIFEFoRmBbu5SrEl2DTnO8R1ho2NceVXMQuoOA3B08FX0t2K7V 4kXshZLdA1IJ6RjfUMW5vO71mRX/vsxVdh0e9eUmp4WbF5gw9judRVScCwjREgy5XHEmSpH7X2C aIVxohLHwpXxKza2Ou3MszUIkbbuv6BDhaA0DvrUJwhg45XbVh1P39MSJpsBjkqSqVN/MaKiuB9 e9Qk/6FCqGVpBFfQX3kMZUX5HAVnUYXyI9/CGawnr4SSRChkREtiNrQFpr/C68/nbzhN7G0O/oX ysIj8AXe8DC9/DgGkFq+e/iCQzGr0BbNivmt5Tp1X0dhCgPC5om0dNcNH7yO2nZmtBo/xNGcOnI LLAkuwGeDUtklhwAosuyC3tYL+ooS7xMBzbqgOuJkieGSV21AwfGAliglFkMrKFsdNXIH1+tQSS sZwmw7tDd2X6QnThVJ07shJ9ZlAhFqJCNKyOwgn6RZcLjDtBqFUl/9RxGYu7sYCJ9u6+hcaog= X-Received: by 2002:a17:90b:3e45:b0:35b:a1b6:5bf5 with SMTP id 98e67ed59e1d1-35bd2d79c38mr3132080a91.31.1774030246724; Fri, 20 Mar 2026 11:10:46 -0700 (PDT) Received: from sean-All-Series.. (1-160-226-215.dynamic-ip.hinet.net. [1.160.226.215]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd368837bsm959352a91.11.2026.03.20.11.10.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 11:10:46 -0700 (PDT) From: Sean Chang To: Andrew Lunn , Chuck Lever , David Laight , Anna Schumaker , Andy Shevchenko Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v4 2/5] nfsd/lockd: Remove redundant debug checks Date: Sat, 21 Mar 2026 02:09:52 +0800 Message-Id: <20260320180955.150696-3-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260320180955.150696-1-seanwascoding@gmail.com> References: <20260320180955.150696-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unnecessary IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards and #ifdefs in nfsfh.c and svclock.c. Verification with .lst files under -O2 confirms that the compiler successfully performs "dead code elimination". Even when variables (like char buf[] in nfsfh.c) or static helper functions (like nlmdbg_cookie2a() in svclock.c) are declared without #ifdef, they are completely optimized out (no stack allocation, no symbol references in the final executable) as they are only referenced within no_printk(). Suggested-by: Andrew Lunn Signed-off-by: Sean Chang --- fs/lockd/svclock.c | 7 ------- fs/nfsd/nfsfh.c | 8 +++----- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/fs/lockd/svclock.c b/fs/lockd/svclock.c index ee23f5802af1..9b978a087b3c 100644 --- a/fs/lockd/svclock.c +++ b/fs/lockd/svclock.c @@ -47,7 +47,6 @@ static const struct rpc_call_ops nlmsvc_grant_ops; static LIST_HEAD(nlm_blocked); static DEFINE_SPINLOCK(nlm_blocked_lock); =20 -#if IS_ENABLED(CONFIG_SUNRPC_DEBUG) static const char *nlmdbg_cookie2a(const struct nlm_cookie *cookie) { /* @@ -74,12 +73,6 @@ static const char *nlmdbg_cookie2a(const struct nlm_cook= ie *cookie) =20 return buf; } -#else -static inline const char *nlmdbg_cookie2a(const struct nlm_cookie *cookie) -{ - return "???"; -} -#endif =20 /* * Insert a blocked lock into the global list diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c index 68b629fbaaeb..91514326d1b4 100644 --- a/fs/nfsd/nfsfh.c +++ b/fs/nfsd/nfsfh.c @@ -105,12 +105,10 @@ static __be32 nfsd_setuser_and_check_port(struct svc_= rqst *rqstp, { /* Check if the request originated from a secure port. */ if (rqstp && !nfsd_originating_port_ok(rqstp, cred, exp)) { - if (IS_ENABLED(CONFIG_SUNRPC_DEBUG)) { - char buf[RPC_MAX_ADDRBUFLEN]; + char buf[RPC_MAX_ADDRBUFLEN]; =20 - dprintk("nfsd: request from insecure port %s!\n", - svc_print_addr(rqstp, buf, sizeof(buf))); - } + dprintk("nfsd: request from insecure port %s!\n", + svc_print_addr(rqstp, buf, sizeof(buf))); return nfserr_perm; } =20 --=20 2.34.1 From nobody Sat Apr 4 03:18:41 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2382E3E557B for ; Fri, 20 Mar 2026 18:10:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774030253; cv=none; b=UcQV7mFg2Sr8dY89vdGOTi8YoR2QUyUCetNpRj0GP7bmRhLYaK3lJVHqDkhwmtj05hoQxR8p259XgLu/CjLRKgk5JiyxqjFalACyP/+x72AE7nHc5rRDgUEdDnD6F+Yxa6YTAGtNuk0u9GtNy8bMpDNwCVIADeKrW8k5ZMQ+LdE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774030253; c=relaxed/simple; bh=Bj04iTXB7MhKSrOnlUvWs1/LZRy/U40aj1lrebnr4kE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WmVBzd6yxB5GetB9tRH01tpaAzbvzsgtTo7Xe3P+wTSMVnBTOzc9RbOJjR6y7tVzNSRGkfVDVJsW75RFzs7jPjIz/wejA1CSH+w7PW/JSowASorMJIst2OFqFzzjbFHmCfuKFTlLy4pPZxiE3AkJoUGkuAdhlyOX0RCoTvgcwlQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G+U8BTzn; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G+U8BTzn" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-35bb863824fso1175677a91.1 for ; Fri, 20 Mar 2026 11:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774030249; x=1774635049; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TOf9LcnO5IRemgfOLwtBwbNVtgVrreL+MONpjgDCJOc=; b=G+U8BTznQj2zP7rwDb2gB9WqQIms2m7rgquampiYFjtqLH3W5k+3dIZOj/7NAFixB3 mEeemIzxNHekLWvUShp+d43c9WaeJ9LxqkNvJ9F+HNNcRuivU5FuOsycKxcOw7nqWvNn 9ZPnysO0LZVXLHs9mJfShvuy/2d7SsOqN7TyDykgJ2Kl5PtwXN6IHdiQM0irHqtn0wKV DkIMZG+/u55QESIEKw6pcaWGhRDLov9ja5fA9anE7kpRfEJIaATFQdIhgabSlvBYZ6ji LIcoZ1KYNY8w6g+eWs93StY7UOaP6z/R/h3/7XCclD949fQLplfQz5Jge/3ei8WzNcb0 /0Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774030249; x=1774635049; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TOf9LcnO5IRemgfOLwtBwbNVtgVrreL+MONpjgDCJOc=; b=rJdj3En6nYPwatYIFcL7pjlqugBjbr5jjZPIZ23M346KpD33EV6MZTRJOWQAL1yliI 8iQH3lumu0kvo0oaXNQXBWTKFNbLkUlXLBR68Tnr+dN5h/QpgDTei5isCDkEsH1GFpiS LdZCce9wzxXRvp5MUwdNEHY89Nrp1N/5lNAlhFw9lShyRLs1f16VAj3oD5XwoTkjjFjh iCS7VvBp+HxqrA4F86XPCMkJzDeYH2ZnQKrTalnnWGsPVZlZ67ZqhCJQFLflh42ozZxF veMWYfwjpd73AD1oR1WtgA9/501ciHa3a3JNFRD8WuDndXcuU3Sf53lAgRIbNbkFjAg9 g1Ow== X-Forwarded-Encrypted: i=1; AJvYcCUtqKSDyBaDNtyO1pxBO2HVhh3aoEf+JL3foXQfCdSb09CTKxRB+lKfl867fdhFT+6RFWgQnzSEsF6QiIU=@vger.kernel.org X-Gm-Message-State: AOJu0YxHFZigU8jiFUP3MmzZCyE8kZQPtV5/5yfwKpNFwT+xDnd03tpw lPH/se/neSZDeb2bgyaoNmIRTr7G2kjPm7NLeB24ddGc68rGw918Y7wk X-Gm-Gg: ATEYQzzOO5mB02SJMeaszL2yOIuob1hxRXde1jLJFxVpGPFa3GoS1jf2d2Ewqf24OiJ hjMIs3bP0l7SJSLpT2RQ9PkBnwlkwxoM6rzolFxI+W7ns2fY2vOnA9YobaJ/e4Gtv3avaR3BFWd F/ZMUJL+NMJNPSdVsTtMEKIAXsMi9/XvNbJgjH+nePdr/7jz8ioSgC3vd6MhF/hRdlhG2wrPApJ QCD1pAfVASafAgCPBEDCdsRcHPUBHNYxSx2VvGT6FwhDyuFVJLWiXgd95mYGtlVMOJPUBn4FlXz 8X8r1JXGsQrQTUgx9/bVzeC9HnVPL7g395DHrrqH5Dpyp62A/Z0UgwP8Sh/F66RmgJSKwN9U+Le 1dbK+IHocSSIwzr1RYisCbsTcn+TeSGqShjkmhxXTnUHeoVWUlW+71SCW/yVp5GT7CKAQXL3gwM 7pQ4Ne5sNEW6OhzN1KRh/b9AUmshYHBcVVw2WYWq2RYo7yGe4So2S+V3T8IQdf7uGj1BJtyZs= X-Received: by 2002:a17:90b:3f88:b0:35b:a44f:b8a with SMTP id 98e67ed59e1d1-35bd2ba3293mr3032450a91.6.1774030249148; Fri, 20 Mar 2026 11:10:49 -0700 (PDT) Received: from sean-All-Series.. (1-160-226-215.dynamic-ip.hinet.net. [1.160.226.215]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd368837bsm959352a91.11.2026.03.20.11.10.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 11:10:48 -0700 (PDT) From: Sean Chang To: Andrew Lunn , Chuck Lever , David Laight , Anna Schumaker , Andy Shevchenko Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v4 3/5] svcrdma: remove redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards Date: Sat, 21 Mar 2026 02:09:53 +0800 Message-Id: <20260320180955.150696-4-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260320180955.150696-1-seanwascoding@gmail.com> References: <20260320180955.150696-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards in svc_rdma_accept(). Since dprintk() already evaluates to a no-op (via no_printk) when debugging is disabled, these explicit guards are unnecessary. Verification with .lst files under -O2 confirms that the compiler successfully performs "dead code elimination". Even when variables (like 'sap' in this case) are declared outside of #ifdef, they are completely optimized out (no stack allocation, no symbol references in the final executable) as they are only referenced within dprintk(). Signed-off-by: Sean Chang --- net/sunrpc/xprtrdma/svc_rdma_transport.c | 25 +++++++++++------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma= /svc_rdma_transport.c index f2d72181a6fe..0759444bda50 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c @@ -413,6 +413,7 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt= *xprt) struct rpcrdma_connect_private pmsg; struct ib_qp_init_attr qp_attr; struct ib_device *dev; + struct sockaddr *sap; int ret =3D 0; =20 listen_rdma =3D container_of(xprt, struct svcxprt_rdma, sc_xprt); @@ -559,20 +560,16 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xp= rt *xprt) goto errout; } =20 - if (IS_ENABLED(CONFIG_SUNRPC_DEBUG)) { - struct sockaddr *sap; - - dprintk("svcrdma: new connection accepted on device %s:\n", dev->name); - sap =3D (struct sockaddr *)&newxprt->sc_cm_id->route.addr.src_addr; - dprintk(" local address : %pIS:%u\n", sap, rpc_get_port(sap)); - sap =3D (struct sockaddr *)&newxprt->sc_cm_id->route.addr.dst_addr; - dprintk(" remote address : %pIS:%u\n", sap, rpc_get_port(sap)); - dprintk(" max_sge : %d\n", newxprt->sc_max_send_sges); - dprintk(" sq_depth : %d\n", newxprt->sc_sq_depth); - dprintk(" rdma_rw_ctxs : %d\n", ctxts); - dprintk(" max_requests : %d\n", newxprt->sc_max_requests); - dprintk(" ord : %d\n", conn_param.initiator_depth); - } + dprintk("svcrdma: new connection accepted on device %s:\n", dev->name); + sap =3D (struct sockaddr *)&newxprt->sc_cm_id->route.addr.src_addr; + dprintk(" local address : %pIS:%u\n", sap, rpc_get_port(sap)); + sap =3D (struct sockaddr *)&newxprt->sc_cm_id->route.addr.dst_addr; + dprintk(" remote address : %pIS:%u\n", sap, rpc_get_port(sap)); + dprintk(" max_sge : %d\n", newxprt->sc_max_send_sges); + dprintk(" sq_depth : %d\n", newxprt->sc_sq_depth); + dprintk(" rdma_rw_ctxs : %d\n", ctxts); + dprintk(" max_requests : %d\n", newxprt->sc_max_requests); + dprintk(" ord : %d\n", conn_param.initiator_depth); =20 return &newxprt->sc_xprt; =20 --=20 2.34.1 From nobody Sat Apr 4 03:18:41 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A055F3E5EF6 for ; Fri, 20 Mar 2026 18:10:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774030256; cv=none; b=MQq1Beu8cQGkY0CdU/0zLMnmEyDaV4AbIjJtKuhxqjbI7sXMFdnPzhGCYmsEN9jTt/l6mZrwynrt76Y2RKv7+C8Nl/OL0xfAOPCQ7ObtE91EAyu22BqQMvzN/5Nvr9Q8wLXzWA7PCirk4Wh0t7KgqT+UcVXclFyS8HAgveLw1jc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774030256; c=relaxed/simple; bh=sZ044YpPu4R5dXrNGbenZJqvSeauBzwp0RnljpfXqow=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fQHQe4+CLuNp/uZZXgPwlYaqxQN4e+SvwUx8Nzrf+R8iVWufWVmdal60YxeHnKev4waBXFO5sqfSQ4hpcCVeRpeNwzF1TYJx/pK6MjUXVOuNlq9ljzF7Mf/3LXugyRfky2XDhawLwoN/h75GuRv3aLSC/1LKW2BdNGi48IHhuoQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FclW1RY1; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FclW1RY1" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-359fea895b5so1551239a91.0 for ; Fri, 20 Mar 2026 11:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774030253; x=1774635053; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ISn/U3wnVX56vQY00IkkHQXLUWsuK0LhCSEUHY06MyE=; b=FclW1RY1IzKS2ohmjktg7a8TUhDqAQ3MwXtYQEzHo+PRzCm2NMXAI7Y93jT/IefNNp xXyRhb4+H0nW5fLbpxzM7YJ5W/7sCRaE7cZT/lvII+tdAvgAA9OauYGWUfFK7lWKvhd7 L0qCNnLPk7co8nyMS7pyRAiu7F2pC4RsUflsAF+L1DrFSMu3HcCbODwlnB06R+McNjM1 G4B//ZUPZKSrIvHIjj3PgyHaMSZ5UfaTDkR2hjdhWHtVHDjDunZ126urTbJKD6CJkKI9 YqbhOrr43jpRlbx0ici5iu+kVyDkA+sKXqV4LPYP+f50Sb8qN+Su5qIhn7vef41UETvc n9LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774030253; x=1774635053; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ISn/U3wnVX56vQY00IkkHQXLUWsuK0LhCSEUHY06MyE=; b=A1IKFTNKgS0y3xzbC6zJvBtb8UKGvruoy5obObhqUy/inMTJO2OUm+jC2ITkN8z2uV YhOPn9yuOHjWpIMKqGhWOneRH3oCn22vnEJwMcA2clu6EnSfvU/x/2e+rK84OztAkOMo xj1qRft5T5tCghj6X9L7CcliANyAzQYTwdb18ZkhBtJjm+TzIwzoqVJjJDVM8U3ldT++ StPvIaeH0oo4dvLykn3ih0GT5jxQAkoiCIbIMNOCtkaQUPEl51/sC/Iu4c2sNBdk6GhQ Fe+1JZKp+aJl8Ea9VNguypf84TlK11Z7ULa0edDaoM1Ai82CZBspeH33k2O4FsRxb6tc JDPQ== X-Forwarded-Encrypted: i=1; AJvYcCUowL+PAiS8SoNnJi39NzDYTISGukrgC55nB1ro4kUVOtqgYstsZf5O3GrCddvcUuUCXoc+kgg2Wyto+JI=@vger.kernel.org X-Gm-Message-State: AOJu0Yxq0FIqURtP/Oh+88Ancu/Wy+HwBuktd1otjX8OhdLn0UHS0iAR MDRDvURH0WTlVCHSZjM6GaUMEQhkLi4R8djFPeNb0ykaEumIkdgXmtpW X-Gm-Gg: ATEYQzxdTvjWkwKA13C3o2ZI8aQn9q1BPUZ3eRvH9HQ7z5osD4pZluPO15qXLxv0k2z O2mAAgms0hoN308FsQI6YmOoSLS7LbcjWyvcNoKVtTKxvNTlGZzwfd+ZNEZHli0FVO7546RbftL ZNoPG+uwRrjTVdtqBhQVk0w14vGyj4RPkJ3JvADdT1OI4LAq9OrZFZ9QY3n3ypC1shfx9CHv6l5 +cD/k1VswbUfbuaYJhPk+qAsGS77jzcHTHl17W4m3jWIWopXE8sAKpG+kHrXuFBJEhT49PIpWMP xclyzNNNFcdRfNYpidBTOw4TOoj/L0yvKkjQ4tX+vBPPkGSuQHlhvj1GM2TaM1sO879rB3vmSRh S6Sp6Zfsj3At8iVffx0UTA/MRiYepD4nkj9hpjr6Es9QDdjNjeOTkBhPZPRCT0MILbSRtgtCzU2 yceAa9UYJcvVBOh+EZDgx9EmQyIMvyvtaxOXIkkLdbqUsa7dPW2qDCx6oQ13QRm+Hqz45fH6I= X-Received: by 2002:a17:90b:2d8d:b0:359:fd9a:c506 with SMTP id 98e67ed59e1d1-35bd2d31502mr3244103a91.29.1774030252740; Fri, 20 Mar 2026 11:10:52 -0700 (PDT) Received: from sean-All-Series.. (1-160-226-215.dynamic-ip.hinet.net. [1.160.226.215]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd368837bsm959352a91.11.2026.03.20.11.10.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 11:10:51 -0700 (PDT) From: Sean Chang To: Andrew Lunn , Chuck Lever , David Laight , Anna Schumaker , Andy Shevchenko Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang , kernel test robot Subject: [PATCH v4 4/5] nfs: refactor nfs_errorf macros and remove unused ones Date: Sat, 21 Mar 2026 02:09:54 +0800 Message-Id: <20260320180955.150696-5-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260320180955.150696-1-seanwascoding@gmail.com> References: <20260320180955.150696-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" refactor nfs_errorf() and nfs_ferrorf() to the standard do-while(0) pattern for safer macro expansion and kernel style compliance. additionally, remove nfs_warnf() and nfs_fwarnf() as git grep confirms they have no callers in the current tree. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202603110038.P6d14oxa-lkp@int= el.com/ Reviewed-by: Andy Shevchenko Tested-by: Andy Shevchenko Signed-off-by: Sean Chang --- fs/nfs/internal.h | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h index 63e09dfc27a8..59ab43542390 100644 --- a/fs/nfs/internal.h +++ b/fs/nfs/internal.h @@ -161,13 +161,19 @@ enum nfs_lock_status { NFS_LOCK_NOLOCK =3D 2, }; =20 -#define nfs_errorf(fc, fmt, ...) ((fc)->log.log ? \ - errorf(fc, fmt, ## __VA_ARGS__) : \ - ({ dprintk(fmt "\n", ## __VA_ARGS__); })) - -#define nfs_ferrorf(fc, fac, fmt, ...) ((fc)->log.log ? \ - errorf(fc, fmt, ## __VA_ARGS__) : \ - ({ dfprintk(fac, fmt "\n", ## __VA_ARGS__); })) +#define nfs_errorf(fc, fmt, ...) do { \ + if ((fc)->log.log) \ + errorf(fc, fmt, ## __VA_ARGS__); \ + else \ + dprintk(fmt "\n", ## __VA_ARGS__); \ +} while (0) + +#define nfs_ferrorf(fc, fac, fmt, ...) do { \ + if ((fc)->log.log) \ + errorf(fc, fmt, ## __VA_ARGS__); \ + else \ + dfprintk(fac, fmt "\n", ## __VA_ARGS__); \ +} while (0) =20 #define nfs_invalf(fc, fmt, ...) ((fc)->log.log ? \ invalf(fc, fmt, ## __VA_ARGS__) : \ @@ -177,14 +183,6 @@ enum nfs_lock_status { invalf(fc, fmt, ## __VA_ARGS__) : \ ({ dfprintk(fac, fmt "\n", ## __VA_ARGS__); -EINVAL; })) =20 -#define nfs_warnf(fc, fmt, ...) ((fc)->log.log ? \ - warnf(fc, fmt, ## __VA_ARGS__) : \ - ({ dprintk(fmt "\n", ## __VA_ARGS__); })) - -#define nfs_fwarnf(fc, fac, fmt, ...) ((fc)->log.log ? \ - warnf(fc, fmt, ## __VA_ARGS__) : \ - ({ dfprintk(fac, fmt "\n", ## __VA_ARGS__); })) - static inline struct nfs_fs_context *nfs_fc2context(const struct fs_contex= t *fc) { return fc->fs_private; --=20 2.34.1 From nobody Sat Apr 4 03:18:41 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A85D63E1234 for ; Fri, 20 Mar 2026 18:10:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774030259; cv=none; b=IuaWu7s7ZWONpczMMT9RfRCMS8cglufJbYiw63XOtfJxN6lKJVE1NJCYtXtfef+fTuyIK4voAamWZ9/O8sWbacsz7dJly0ewATBG0zlNICsBQBj8YFFs378tiHRPufV6aQw2+9Hp13oUS0onaVOW5MaKqLqx+VxYrxvT1tNuJOk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774030259; c=relaxed/simple; bh=26UQrZbU/JLBJCqLwaX88rDbciQrWYFpkBrK87bA5aM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=TP3ElqBMHPgz9jIr5iXCOhDZSbNjjwd+DF/RCrfugzOcEk2ImS8dgWRJZevDwFTsS6Jy/doSL0pXcnXpCibElssh5tbrtuJvYGq3s3/c9Twby+0TM80o0Gnbz/GbshE08UPJaTct6kDiPD+EIXYC/Jvav2D7PiJDPJllnuY0ltY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ukjksohu; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ukjksohu" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-354a18c48b5so1698710a91.1 for ; Fri, 20 Mar 2026 11:10:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774030255; x=1774635055; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Rs59ZYsmevHDwekpgOW1Jo5Q8vTfXRm0+cDIBjhCcOE=; b=UkjksohuJRYV5krQr4lw6YbTM+VwHFPMavoxqbeht8miFHq0+Lv9iyzkDcQUh8s0+r Mw+Rws3X3e66QkhywIn62m3bxVEcWB41nbn92CwOMy5NLFL2p7aRUrbX8Rqi+NZRMq1r RVPpmii67atOMA0F1ctiuFl0vH0ImsdOwevJPvm8K0TqYWounQjCR2GEYl2B/8sMxylX Tnww8bxFJ7EnWzwMnjcfyVledFObeHpY7WOD2eu6bNV03sw+nAulD9KxJzzUiso4OikN Btj7rq1b3KhetrGEx/F8cva4uAUg5cLPYkUM5KlNohMhR5r/TAnsZE6PVHNscX6lkMFm ERBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774030255; x=1774635055; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Rs59ZYsmevHDwekpgOW1Jo5Q8vTfXRm0+cDIBjhCcOE=; b=oGlp40EG4nhe+6Rx5dcYrFtbLE8IulyUxEGoHD0ITAtc8VeBp0Csx6qdHeCbCwgk9C ShTwsPfpMXwF6wKZy2aMmdU+AR9DrW7ukZ1IwzjFjDUUhOg8nDoejTP2cy/E/tpDecNl iioA3hHoNa4l07r1xeJ96L6bhcoIIUYM8DFJxxGKlxTRzGbkuDYE2iHt4pjaVKU8xA2m bz7rll7UuF2nG54lQr6BU23+fZmwqCDRY4gR2I4DKFy5lavHs4cNGzMcu0F+lsEjcEwl 9F7TWrboFEay92n25bnnzg8tZkkvBcSnltb/kc8yM5dUQaSHMFfrNig9ALIyuNt/DKpO Twyg== X-Forwarded-Encrypted: i=1; AJvYcCXsRwpLYRLhfMDgD2ECqzQnvgLNRAMSTsOFM8Gi5HU43DM0ZSahSToCKFpp05d424lB+64YrhUS3xZ6/S8=@vger.kernel.org X-Gm-Message-State: AOJu0YyYZ9hswtoWG2hRYyuEfOU5Z4zmLDV5LNIp/B8eJEMFMWmS1UMo JvnfM/EmYYaq6n9IlpxvSZVgf6gfpRsklYIwR6IGir4ypoLLyAZuF9ml X-Gm-Gg: ATEYQzxcKfEdUq3dXOygIXeVS5csK74d81KuztPCO/eoLE89035pgTvh3n0SH0shcKu LN+WqwU3yv65I0bKX38iSMkzwFp+ZnlfUaxoIKbioWKZcOpRUl0ubC+IoqCtLgpx+A1bif2IHHb LphfXEVoNm+jlcS02uV30kP7evzzqtAyzYLQqPO5i82mZMFMU4jzKcBzgSgxo5kuL17FG2YpbWS PX7/G/bqgv4LJB5/tZMvmpja4Fg6KCGqiKXhiAcKKhrntFyO0MZ839xnDaZqSyJ2IhFpnFu7IAg I15SVmUHJAVKGSJuHAhaa9edQNaUkpH8U3bSoclqqyNJJmX0KoFVd79YDW9KfjqnTV7EtE8k1GJ f88QCYF0iidS07C+M3L6lXOHK6p2bgP8gpg/A1Y87CaSYHL2R4cpsgSeou7eyh/PlJf3z7zEUzD KtVC/YHpckqSELpDZyNzIP6icjnQvUweUNW4aPBrwYETJ9kaysQ/SVEWKyHce0SIw+o+MJGO4= X-Received: by 2002:a17:90a:d605:b0:359:406c:49f3 with SMTP id 98e67ed59e1d1-35bd2d1f873mr3078727a91.27.1774030255511; Fri, 20 Mar 2026 11:10:55 -0700 (PDT) Received: from sean-All-Series.. (1-160-226-215.dynamic-ip.hinet.net. [1.160.226.215]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd368837bsm959352a91.11.2026.03.20.11.10.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 11:10:55 -0700 (PDT) From: Sean Chang To: Andrew Lunn , Chuck Lever , David Laight , Anna Schumaker , Andy Shevchenko Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v4 5/5] nfsd: remove obsolete __maybe_unused from variables Date: Sat, 21 Mar 2026 02:09:55 +0800 Message-Id: <20260320180955.150696-6-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260320180955.150696-1-seanwascoding@gmail.com> References: <20260320180955.150696-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Now that dprintk() has been refactored to use no_printk(), variables used only for debugging are properly referenced by the compiler even when CONFIG_SUNRPC_DEBUG is disabled. Therefore, the __maybe_unused attributes added in commit ebae102897e7 ("nfsd: Mark variable __maybe_unused to avoid W=3D1 build break") are no longer necessary. This patch removes them to clean up the code. Suggested-by: Andy Shevchenko Signed-off-by: Sean Chang --- fs/nfsd/export.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c index 8fdbba7cad96..8116e5bcbe00 100644 --- a/fs/nfsd/export.c +++ b/fs/nfsd/export.c @@ -1025,7 +1025,7 @@ exp_rootfh(struct net *net, struct auth_domain *clp, = char *name, { struct svc_export *exp; struct path path; - struct inode *inode __maybe_unused; + struct inode *inode; struct svc_fh fh; int err; struct nfsd_net *nn =3D net_generic(net, nfsd_net_id); --=20 2.34.1