From nobody Mon Apr 6 10:45:12 2026 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A67FC3D1714 for ; Fri, 20 Mar 2026 16:42:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774024926; cv=none; b=uCK+rI6SFQGuuA8UxcblFtsk3ZU6bo0LQISHXwsx26reZpiSIRrww3CexLokVEi8zfa8EVdklncsBhWYRYdNivuSONEqtB37CiWW+iiarPEl83+qe5MBWlemSck3Sm8QouVUKoiIz0NYo5W5lWQJLlYwPeZEoBdgkCY93iEK1KI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774024926; c=relaxed/simple; bh=xEu9LJD1BjNp1PBcg8TnYk1Oxe/SU41CU/O72DexVVs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LElBB8MuLySjG+bNm7HjM1VPQ3q+ZCI0kESacgnYq/HM7ZefyRzLcizjmJ1nqxL6ewEk6Bv01mzYiznTKYH4nrgYHsP9uOuA1Zm/0DfHJpvKrADT8h8ZlFMF1caRmT99eqlPoNyibA0Ex1m6pC4HqhRqivSnCgKFmscLrDZ65RY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fRhEeGTK; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fRhEeGTK" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-43b44c0bcdbso2030648f8f.1 for ; Fri, 20 Mar 2026 09:42:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774024923; x=1774629723; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4rtUTy7c+JMXpO6EpoYVOPqOA1jyBKbjjOPg7/yERVQ=; b=fRhEeGTKwtzjnITwVYksKLR4BMQ5W0ZEDAkYne14hVlrnaBAcJZyk92KYLfpU4sMBX 4Pnd0NQl/p6AiI4ZH5SGRjaBHPPxph0q6FtWoVmS7zonHBm2E5FcbzC1+lQZTectlgqc 9uRhjVXp5N/UlXKBxoFeiH6rUBNyHUkZZ1lfQD3T+u1DEgxR5fT+VK2CCT9KnDj5PxjU GcyjwjTdPDVvIWIU25rLyZYUPGIL3ghzAPFbKc/YSYssGJKJo8bCH2ynhVeR+YkTXeL8 JpGaQt1lsuWV9Rc3OyOEwwlQpAyNa/z5sGqmnBXjTJQeiUrlw0ZsskVrHh+U4PeGoqAy Ll1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774024923; x=1774629723; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4rtUTy7c+JMXpO6EpoYVOPqOA1jyBKbjjOPg7/yERVQ=; b=TPdlj/90U0W3WvxRqPqsOH3FjUtxWJewgH2+8Fzf/SEmq4G9m6yZAuPddsNkg/FS7f 6sX7W7GkVgALbUyU3BkZKJT3Gkk9s+ozY7N18vpeHQb4kY6asGHbK0Kkgw5HOGI0rs1L NTwltO5O+h3VTsY67iu4FStvgoZuOfX3/TUbx0iuULdRdYQ9sO1466yZRQ0gx7PgLj6o U09QMskm4Q9M/O7zdEFGcRFwSU6B92jw/NgwbaZ2gTuonL4KawWE+HIRi1VTOC/VCUuf kmuUtFHS1WNjxUlCDqRf9ssVB6h2b9e8SGHiiIKeBuKbb24DXaKhs9RVraRt4zt4Xsbu Jkfg== X-Forwarded-Encrypted: i=1; AJvYcCV28+MOWZdfbuU71vD++KBWRihashEvVdLgLPyxG27jzDaJwi3QI+0eYXuAODX2b8oqka62Aakcj+McbgQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxzGb8eMLO0gl+J8GuHVe+L5KfIbBlxZSPXP4GBhhN/WsvVmla9 ldG5o8R1hXJC91oRj8+k5z1vU3vXzfwLGBSIE0Wny/+dwVANyJenG0fi X-Gm-Gg: ATEYQzw3NAipGPiaWcYED7ZSTTmQ1AG7ZXytE9K2pQhoQSelq3qaAhLUljAAY0+PCV6 kDm96pei8YGjEoYy3qJLCzwIAs1EUSRBdBB8pGYE/Ni/Dk4pGsHPjAfbv9C3/JDlbKaHzATTY7t eOZXl6MgDzxlI0/d87Tim3jR2D2yYbCCkC+eEV8ntKOW2xYpGWQR6iL8XbXYk1nLS4Y7bIgUaen VybZRl/ICnWQcQiSV9qdPVH99xo2Q0QYfEr268qSY47SyA7EZ3hR2cXTqDCEwimeNwLbJ4Q/oyz gYJB2DVyMVfuENwYZxIHsQAUkLih5kyT7RkbrM1BN4Nh6t/LOPwq92GDGAIxXZIXmM4ZDwRCqIL HOolvziQkwFV0vaPF+Zr1DtjeWPRHA9xOufsRwtK3SQvAZvyTAZqABgYJ/mlf4qGeTV8Zy9EV6V IZOFkA+qu01R+YZ3TZgt/96Y4XbbK33QU= X-Received: by 2002:a05:6000:310d:b0:43b:3b80:6776 with SMTP id ffacd0b85a97d-43b64262ebbmr6599087f8f.30.1774024922785; Fri, 20 Mar 2026 09:42:02 -0700 (PDT) Received: from biju.lan ([2a00:23c4:a758:8a01:5b93:d2b1:bc5c:9231]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b64703650sm7016575f8f.20.2026.03.20.09.42.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 09:42:02 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Boris Brezillon , Rob Herring , Steven Price , =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Biju Das , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , Biju Das , linux-renesas-soc@vger.kernel.org Subject: [PATCH v2 2/4] drm/panfrost: Drop redundant optional clock checks in runtime PM Date: Fri, 20 Mar 2026 16:41:48 +0000 Message-ID: <20260320164158.487406-3-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260320164158.487406-1-biju.das.jz@bp.renesas.com> References: <20260320164158.487406-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Biju Das The clk_enable() and clk_disable() APIs already handle NULL clock pointers gracefully =E2=80=94 clk_enable() returns 0 and clk_disable() returns immed= iately when passed a NULL or optional clock. The explicit if (pfdev->bus_clock) guards around these calls in the runtime suspend/resume paths are therefore unnecessary. Remove them to simplify the code. Reviewed-by: Steven Price Signed-off-by: Biju Das Reviewed-by: Adri=C3=A1n Larumbe --- v1->v2: * Collected tag --- drivers/gpu/drm/panfrost/panfrost_device.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/p= anfrost/panfrost_device.c index dedc13e56631..01e702a0b2f0 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -429,11 +429,9 @@ static int panfrost_device_runtime_resume(struct devic= e *dev) if (ret) goto err_clk; =20 - if (pfdev->bus_clock) { - ret =3D clk_enable(pfdev->bus_clock); - if (ret) - goto err_bus_clk; - } + ret =3D clk_enable(pfdev->bus_clock); + if (ret) + goto err_bus_clk; } =20 panfrost_device_reset(pfdev, true); @@ -464,9 +462,7 @@ static int panfrost_device_runtime_suspend(struct devic= e *dev) panfrost_gpu_power_off(pfdev); =20 if (pfdev->comp->pm_features & BIT(GPU_PM_RT)) { - if (pfdev->bus_clock) - clk_disable(pfdev->bus_clock); - + clk_disable(pfdev->bus_clock); clk_disable(pfdev->clock); reset_control_assert(pfdev->rstc); } --=20 2.43.0