From nobody Mon Apr 6 09:13:44 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EEF23C9425 for ; Fri, 20 Mar 2026 14:49:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774018174; cv=none; b=OGP+XEmE9+gTNrWOU0DPghs+0/klscW7TVUG/idgL2TfbgDvvpPkHNHtOIQRzBb0A0eK37xw1WTe1gQiSQfVVO4EuRkZq6EWjirXWyAb6cA6CXfqF7HsRJUGP+VMmhwQoBTUcqpJCJT7FbpuLHmxb+JyZpDRWuxYcWGxFtlniIE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774018174; c=relaxed/simple; bh=uSbPbbEF96iO4/jDf1d3kH2TPon+s7DHfw5HFTuRwdk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Faia4UuQUwH12cUTvqQdVrge2pgfCEJ+QdHoR+ZxWJM1lbTP/6dC5by93ai/0L6RfOVxA2ni5rfFLLUh/vUsaG1y/6zCT/Q/V/dPayk78heRZ21/0hIATWqyi8s9Y7NBoNdzbCKQsHBFESgcZ9HnAU9NbvJr8eTybUh8Cc5cawU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=H0mudFIR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=C6LhaE6P; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="H0mudFIR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="C6LhaE6P" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62KElucp989742 for ; Fri, 20 Mar 2026 14:49:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=/jKQw8dGxLC 6/wkqCmrBcQV0wz2LZBd3Fby8QVjVQNY=; b=H0mudFIR1/xHDAwKWwh7u3rW4UV 0YoL2HXoCdZfXn3FcRnoYI9SiA52cx+zOE8LZfemtOw8MIsAmmaCbajCBT+UgLVb hBOfjxD+fS6ypsuDT5hlkO3CsTspZBKdfgMiZwx5j+BbfKwnZ04QndJR/ZHgYgnL nJdu7EeqVUOL6fROJWgJcNH8PvaDpjgr+ZpaxIkdsPRb8iJHlZx4x3qp+rbaFO1N McnwM6KtJoxpfg8x7SjvvU1rrEWsqQsi33wxvg9FNi5FF58fQGsyAetdkR0nr8M6 DBjLiVU2s6I8Jfp2hDCpvQkjNaPyHL3CpltKY7Cna9fmFpYJrsKkD/EzTAw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d0k0vbpvs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 20 Mar 2026 14:49:32 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-5093a985e21so129943231cf.3 for ; Fri, 20 Mar 2026 07:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774018172; x=1774622972; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/jKQw8dGxLC6/wkqCmrBcQV0wz2LZBd3Fby8QVjVQNY=; b=C6LhaE6Ps8jL1tckqKCjDmeMdUjVJAWHXlFVAcPnh/aVEJCmZu4JXG/PIJ4YACuAja eOW1vJ/eYeKYbuncY9BKnxZu3s+mEzPW0XG3CflvcPalT40THHLa/pnZhV3XX/GYIRyB J7rVHXVBswVcEchTlb1cl5+/8Vx0vdIlovSVRiEE39O2gI8cxxZvdItvyfCCZijju4Di Wjq25ie3fG45curUGmVvg5OFAfsUQ2pP0EhbO66By2HvpIsXBqQk6PyixzAvjjH6LQN5 rsgB3l8LR36mxY3X3Cy/Hth09M6GnbHN6OjJ+S972Z2FXWu1+MXpKBf7aLifaJ7qzWRT u8MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774018172; x=1774622972; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/jKQw8dGxLC6/wkqCmrBcQV0wz2LZBd3Fby8QVjVQNY=; b=Q4y/TVA2dYwXYDfFpJKFZlsHaTTKE52A0x1w9gVP6/OTrFtfBzup8+cW1lfMNnjcGR MRkad2voJRRp3OJKsQtmhR0WB6tO5EdomWq7Jecmd23E0yQQ0cMjX8wFG//B9PVuN9l4 BPTRobCoFVizG3XBVeIQWDKbOfCsoeVWS1NvC5lSXizWZGlww0TSkWZRSXipR2/OdKhW raJythh3KcuqYYzwpynQgY2PKdL72SOKTy3cKtkJBpB9JEB1dd5iNU6n3Ta3pVMfn2Dj yT/8T77CwAcZ0z/HsTME4aW7OSa+WgCz0VYd/cEoQrZtDxQjmRTtPKHXozlXF+t8SxQM YOGw== X-Forwarded-Encrypted: i=1; AJvYcCVuF/Kewq4Jv97pCX7QDoF3Ax2mrrZxL9v7151Fa2MttifKpLqTUdZQryvEnGZTjfYJEQ/VvKRcFLNoVtY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzyl1S2DA16rvSGQz7GlxItnQb0ZZislUF3P/RYWTEzqIHZlphY IeoEsW5AWIga7+EChJBfT4S/eRqzwf+qi8gt34GyU3MqLlBqcgEwLY3QIm4b8j4SuEwCkmNtGC0 a+MmvHvDxW+r+VpSEQy0LLyVxCC6ZtwfZjcIPCDWk+XSBSy11O/ZOPDo7goquIsqb5ME= X-Gm-Gg: ATEYQzwhSyk6GjOQt2KHeAS0BSzSsp5tlBVGJtDgQ+UJ6FEPuZoyW4++zR3Z4SKTDNz DNF5RK7v1+LmMDJy/GuJXRtvEEVwvdAkNZ/t4qEJn6cN3ofHmca+XJvqbCHIbhJMIzfDRd30ZpD JxFZePAyGpUb0IT/QvNWRty83jA6LmYspgVpHPdwfuzyqEE5uExbYFwDFL4AxcAadXHusAd2mGq 3gOaPc0DGjhKT9//tOhighFEHrlC0g3yNYT/naSdJc7i+hD7ZE8p0EIy1aQpZd1vqrg6dQk8J3J Yu720cOHsAPJBV5BgpCheJZG2tomHqIkAKLVLkW7ddaZOtTaD84MuHBtdJpbzINdm450lYXsYIJ 8bE/5RPZJ6D61ergfSIwnhqJrMzgwzeNUawoU2DUMO642ncItdsH8JEw= X-Received: by 2002:ac8:588a:0:b0:509:609:b2e5 with SMTP id d75a77b69052e-50b37453b95mr48199221cf.24.1774018171715; Fri, 20 Mar 2026 07:49:31 -0700 (PDT) X-Received: by 2002:ac8:588a:0:b0:509:609:b2e5 with SMTP id d75a77b69052e-50b37453b95mr48198571cf.24.1774018171219; Fri, 20 Mar 2026 07:49:31 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486ff109b95sm47906825e9.1.2026.03.20.07.49.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 07:49:29 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org, val@packett.cool, mailingradian@gmail.com, Srinivas Kandagatla , Stable@vger.kernel.org Subject: [PATCH v6 05/13] ASoC: qcom: q6apm-dai: reset queue ptr on trigger stop Date: Fri, 20 Mar 2026 14:49:10 +0000 Message-ID: <20260320144918.1685838-6-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260320144918.1685838-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260320144918.1685838-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: NJ_cIwA2Sjc5BEUbe_JY2InJDrAAigrG X-Authority-Analysis: v=2.4 cv=EcjFgfmC c=1 sm=1 tr=0 ts=69bd5e7c cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=w9bA4Yi6UXS1dLCTJJEA:9 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: NJ_cIwA2Sjc5BEUbe_JY2InJDrAAigrG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIwMDExOCBTYWx0ZWRfX+y2S/0jRH/sr jWoLq20ETA0f1dKTnfXPOWy4dD5K8P28xQNYknsOOBKP+3dbJRkWDazQu4mRD3WpPgtaXuElBu5 QTX9jZ0Anwj6dKFaqK5hA5gnQGP1xJw+z3xI4GPUo1VVpA4RCVtCbtbLy3k2NXRvtAsRd4WX3QF BpZUIEB8R8u2T5cjSmth9DTvHZxr2flkYEUgf1iZ4FFSewRctoXrUmxfV5CupaXkAsNEszpKcPC 9ZQ8cMMgEVZyCQyQbNKNPWoQEiOyBBP5LWTb2w4+PSruxftUbYYr5LLCtwl4i18NSdLD4JpgP8+ euKERN8x1a9od/v7E/uqDGcY5x9T7mFMIjoRSKQg3mRGlIdRSuSOSBeI+mEsjMdL+dzPKXB1cJx hJhXvdztdik/Q8ZCQG56wkjDSkfSzYlzmZfyq5jLlEHx2ShaoQ1SHJ9fpaBESE/afoMbyJEA1Op l01Lsy6m2RGDRGqF3nA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-20_02,2026-03-19_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 suspectscore=0 impostorscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603200118 Content-Type: text/plain; charset="utf-8" Reset queue pointer on SNDRV_PCM_TRIGGER_STOP event to be inline with resetting appl_ptr. Without this we will end up with a queue_ptr out of sync and driver could try to send data that is not ready yet. Fix this by resetting the queue_ptr. Fixes: 3d4a4411aa8bb ("ASoC: q6apm-dai: schedule all available frames to av= oid dsp under-runs") Cc: Stable@vger.kernel.org Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6apm-dai.c | 1 + sound/soc/qcom/qdsp6/q6apm.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/sound/soc/qcom/qdsp6/q6apm-dai.c b/sound/soc/qcom/qdsp6/q6apm-= dai.c index 306e928e7b49..292be457764f 100644 --- a/sound/soc/qcom/qdsp6/q6apm-dai.c +++ b/sound/soc/qcom/qdsp6/q6apm-dai.c @@ -317,6 +317,7 @@ static int q6apm_dai_trigger(struct snd_soc_component *= component, case SNDRV_PCM_TRIGGER_STOP: /* TODO support be handled via SoftPause Module */ prtd->state =3D Q6APM_STREAM_STOPPED; + prtd->queue_ptr =3D 0; break; case SNDRV_PCM_TRIGGER_SUSPEND: case SNDRV_PCM_TRIGGER_PAUSE_PUSH: diff --git a/sound/soc/qcom/qdsp6/q6apm.c b/sound/soc/qcom/qdsp6/q6apm.c index 1fbcbbf3123d..9d4cbe29cf94 100644 --- a/sound/soc/qcom/qdsp6/q6apm.c +++ b/sound/soc/qcom/qdsp6/q6apm.c @@ -215,6 +215,8 @@ int q6apm_map_memory_regions(struct q6apm_graph *graph,= unsigned int dir, phys_a =20 mutex_lock(&graph->lock); =20 + data->dsp_buf =3D 0; + if (data->buf) { mutex_unlock(&graph->lock); return 0; --=20 2.47.3