From nobody Mon Apr 6 09:13:46 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 212C33C73EB for ; Fri, 20 Mar 2026 14:49:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774018172; cv=none; b=HkSLOUb2b1ageDBWipzaeMNbV6QJxvV9cfYvYBkAQOLnNAA7fJf9qF34cg8U7PJz3veCCPXRiDn2EjV/8BQC9XFkmc/NG0qssMEMIZNGf5c2RATMiQVweFtRB4DYOlkakzRdF5+Bd6sZFMH8p+kGTwOtsXhBOhOjAhBu44h9UUk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774018172; c=relaxed/simple; bh=Nn5W6j2KgfG3MXrQpHQ1hcxXhxv/yUbhKAiv5Knj23A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jra5vYP5eidpV6PyDxfkDTY2b70VcR+PBiFKYiIKAit4Jnc/2MWW/5Tr/lNSrXXzp/nbR26Fd2izLF5yhNQVamByfxJC2i+VdcBF2/mVTcJ11O5Q6x/mtMZyVMvt9wfoemq/eKG3o8qUMxf2KsPBdwWiBuJ3KCNIFuEDclKSQCI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BZQ7rV5/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EoXw7R2G; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BZQ7rV5/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EoXw7R2G" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62KEYaA43557556 for ; Fri, 20 Mar 2026 14:49:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=it+OAEpYU8v 0MR39X1WR6T1UKdIHL61i+TcaqL8baj4=; b=BZQ7rV5/GyyNa8ccYSgIrTTB2fD QkljqL7NXHQUJMRG7q+BNPaL8+raXhjI87j1bwAocGjCvoj+Z8GYTn1MWdUla4LE v077WSzk/FN5yQ8MqEz9GBvhD5DaYL4FCkPHMklwtfIK20+4eeyX+4U7lh2/6PuM aidycHxqCrJD00u0iDqrKdgZ0BKr74bAprHqxHybF1VbR47pp1wXGaVURrKalSI7 pj/n3Bx4qgNxpCRz0HbhB/NSIF7rn30AEgfyb8cOuwja3z6tbs7eoEvfE6jqr8Nt T2BpU0CegVRCKSrtXelsU3xgCdSsg+5INQUwM5CBH8Y6cj/PUhD8yOqkRVg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d0r1gtfne-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 20 Mar 2026 14:49:30 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50b3a341f3dso46782061cf.0 for ; Fri, 20 Mar 2026 07:49:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774018170; x=1774622970; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=it+OAEpYU8v0MR39X1WR6T1UKdIHL61i+TcaqL8baj4=; b=EoXw7R2G3nUQ93kVGDEQbjcXcFIsQkozOB6ZVD9p4PqE08iqqMYOvN+dLtnnaR4MsE hclDv/KEA5UVMVRlTd1K7eYomI7VS7PhYAOTyJK9ADKJR+k6P5OThJRpr7dJqrLKqrXc AvnovdLm8tPBRnuVQyCve+VyDXlzS49D4DR1pLgYSo/EzDkRj8hWf5OMvc3R4ISUOlfw 1BY1Z5t9wVf/rII1aTs1PUOSDA5gAvnUhCVa4vT8pjVk1gXZn+IczoLrsvx1M/CxLwrG LeZinTfXWLczo5lwrmDMvIqoEqJ8THzjkEdvN4Xa2C/PrN5rgU34fsm35dzEsteU7Ejp 7ljg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774018170; x=1774622970; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=it+OAEpYU8v0MR39X1WR6T1UKdIHL61i+TcaqL8baj4=; b=B/lFNygWWjIBC6FsfrwnXw+zbHdMFcWkaGfbCR3pj9Pr7TlaGObjoKzhlZuugXrz7N IfYAeE9IMIuSlj+9rbcUZ02zEaYjiM4JHfcfG9s26Fr3Si7iPf9inyYDskF2eNCw/FQk ISpBW60r37ff9dRt50Xk5GRTkaiFnZkOaQ+rXOF+dN2642/QH227GYqJHmKQuTqXDoii NMEdOcUGCVqOolNFDSp3NWRhxej2SecKXT9v5kDsPfNIRY58ENTnRjCpdEoqQ9ZczCQ7 wqFAMYHyEWleqHev1LU96ZxJ788x9nR0dqdMrtTsLNB390dDGJYVPngla0cmaJ6igMzJ CjZA== X-Forwarded-Encrypted: i=1; AJvYcCUcf/Y5aUhWkWkx1MoaFVyVtBdZ0W5Wk85ix/3xZsHLCa0Uz7ukPEb++S8nodQmOd1gb7DCSd3bb6CkHBQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxjLU6MxmIyLO3AkTeJZxHh3ADkP+BnOSGPnFRKztZtdXmrAgVz U0qhNnZM1ciTk3PMalik3RGeiHjPld09Dq/Ai2X3ZXzvaHPTIakIY3fITITSUaxik1EtnwX50Mh LQKA4Vr1YjTHK+Tz+fVnT7827VE+deS+ByttqgaJoQEKTr3FdJaca7mpmIZhXglTdzMg= X-Gm-Gg: ATEYQzyIixBISiBNwJfY3aOwUp9J+ijzSZMJZs1bnw7bc1a/i1rx/+7ozFjPGPak43H LH7AwS+kgTAJFAtBlny9fJe72VHfcKQKec0nZfMOcnzxKjgwGHt+r0Jmpd7aLyQw6eo5W7DS52E F2ZN4k7vJJMLMAoi1Sn4xsBr1rcDPizulCNTPTQKQCXc9dVERCHF6yzdEZNQpOC0/tIxeSmSBIS tqyhsCR2Uwba8HBsQSiP4UjERNlTOe0stz83jcotzMSgOsar0xfKZXZeksz35uQTfD9IqRhXq2z VzfpWVww4BburE4Krq+2EqQ3Bd2gn0KaU/IR5Ym+BSMUP9GGUQodQ3ZnJ5ebzlR57+PC6YUweZb OEM9xIN/Oy5YCcgRi5Z3z3AZo+Bu7krahsXyJwVWNsKJDiq++DphwttY= X-Received: by 2002:a05:622a:11c6:b0:509:4342:9966 with SMTP id d75a77b69052e-50b2461b2a5mr104983761cf.16.1774018169633; Fri, 20 Mar 2026 07:49:29 -0700 (PDT) X-Received: by 2002:a05:622a:11c6:b0:509:4342:9966 with SMTP id d75a77b69052e-50b2461b2a5mr104983171cf.16.1774018169094; Fri, 20 Mar 2026 07:49:29 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486ff109b95sm47906825e9.1.2026.03.20.07.49.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 07:49:27 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org, val@packett.cool, mailingradian@gmail.com, Srinivas Kandagatla , Stable@vger.kernel.org Subject: [PATCH v6 04/13] ASoC: qcom: q6apm-lpass-dai: Fix multiple graph opens Date: Fri, 20 Mar 2026 14:49:09 +0000 Message-ID: <20260320144918.1685838-5-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260320144918.1685838-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260320144918.1685838-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIwMDExOCBTYWx0ZWRfXwFiHNlQ6pw59 yc4c9G7kFJ5TlOryqxnRaiN4eOIvlqX0/4WlbH5JtbPPZm5cBooCPTYXDJ/a5ozH/6lBKy8iBro bNHTjW6zPnZoJkylFOY7i8yhrp+ra+os34aKB6L4fzhJbnNstzdn2IDV1zxLwCw3J7GErJa1EqB 8IA0V7OzANZ3tfSz0nCsWsBwmXij6N77nG8+Ak6/wZJtNdKgpuz4NrMLIsiYZHAMNBdHPIwlxK4 pc52PbU0IH0z92NZfzGs9M/pAcLCuom6RwJ9zE66jsrCfjgYSNqHPXYag/4P+hhvzR6V/IhQqhF 8j2xSqkxFV14qX3DkQ4Dd6Fe/zzKeNH8AFol/j+8HkVp1X5VfPrRPsSxOVriPP4d/51oDMwlKd0 yhVeHhbkCRTZlMuaokEkiqNEn5nUQx72clQMUVFdIxvUZe/v4wvOKALrsuMmcQ0Hk8wLT+2dtNQ IvG1v7S1D7CMhkLy8kA== X-Proofpoint-GUID: LD1O0dL1B1tdDr3cm3uKCv7RSUXBqcs5 X-Proofpoint-ORIG-GUID: LD1O0dL1B1tdDr3cm3uKCv7RSUXBqcs5 X-Authority-Analysis: v=2.4 cv=Y/D1cxeN c=1 sm=1 tr=0 ts=69bd5e7a cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=M_mAHeyD2EURj3i0m2kA:9 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-20_02,2026-03-19_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 phishscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603200118 Content-Type: text/plain; charset="utf-8" As prepare can be called mulitple times, this can result in multiple graph opens for playback path. This will result in a memory leaks, fix this by adding a check before opening. Fixes: be1fae62cf25 ("ASoC: q6apm-lpass-dai: close graph on prepare errors") Cc: Stable@vger.kernel.org Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c b/sound/soc/qcom/qdsp6= /q6apm-lpass-dais.c index 5be37eeea329..ba64117b8cfe 100644 --- a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c +++ b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c @@ -181,7 +181,7 @@ static int q6apm_lpass_dai_prepare(struct snd_pcm_subst= ream *substream, struct s * It is recommend to load DSP with source graph first and then sink * graph, so sequence for playback and capture will be different */ - if (substream->stream =3D=3D SNDRV_PCM_STREAM_PLAYBACK) { + if (substream->stream =3D=3D SNDRV_PCM_STREAM_PLAYBACK && dai_data->graph= [dai->id] =3D=3D NULL) { graph =3D q6apm_graph_open(dai->dev, NULL, dai->dev, graph_id); if (IS_ERR(graph)) { dev_err(dai->dev, "Failed to open graph (%d)\n", graph_id); --=20 2.47.3