From nobody Mon Apr 6 09:13:13 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 340DC3C660E for ; Fri, 20 Mar 2026 14:49:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774018170; cv=none; b=Z46fO3sQRgESaW/PF7krrHZ1sr/erz5lKYiSpDAbGXps+fsfgmOhcRGwUMud8lD5/8qdTr4cdj0cczvPdhn/mMp7DkbH4elnLZjbA++kDnB/nO530qo9hM8Pr8Kbs8OAZG+9GEl+E7D1sMc3dBEFfpQHU7eVeLGFV0uqTZFGyBI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774018170; c=relaxed/simple; bh=6jShP5otc7Z/xglFZY5mqaUqDhEckaI1JOm+jwe6kcI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qNJim3qhbPaU1OToo8EZU5bkgnZlMm3tWMXT1vb/OpttuXjZHeexFEJftVaaM+yefaUepGk7mvAlpjwimrT6iXm4CNjTzJxS2WVR3h/zAF+TGFWh4cNXTSqpqQEhp61rQRYxl7hyg1sL3yE+d+jBPqL+ROiU7R+jGpvObOKm9dI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UKugyLLF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hT9QZYQV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UKugyLLF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hT9QZYQV" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62KEC05H3557777 for ; Fri, 20 Mar 2026 14:49:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=xKWL+GAYqNp +tTujHQMkzR7HCGoYVVs3sPVjIKR0hiY=; b=UKugyLLFffJgxwyOQephHKfj6xm KIiZroCPWFahqNu4B2fA4ORCuZcHOvzzbnjqBIvCtdCpZ38sYtR6UZ54oQLG2bCa CXRJGR+9mZXR9MOaf2KdCfAZOyhVIOQciOxa8jcoRi+QQis3R/S3kvlcgglsH9Dw mpRKs8V9su4VTXQL70DgmCwvylbEdzzv83Hh5opuHEXnVB+6vQlhgNrG4FNg6MXt Suui3JXHtpeo757+04hlRwiWxDOhBBjyKQuWzIXhBPfoFoES4BewF1fr8kXjJs48 9n4Rg7oPicfJRlS3TC647055epdYxFM2ZzQoh83I2VgP4ZrejJooujAMyUw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d0r1gtfnd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 20 Mar 2026 14:49:28 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50b274f94f8so129802641cf.1 for ; Fri, 20 Mar 2026 07:49:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774018168; x=1774622968; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xKWL+GAYqNp+tTujHQMkzR7HCGoYVVs3sPVjIKR0hiY=; b=hT9QZYQVEKKkmHX+bF4C/4NRdfstqE2Lx2U+29VtOnJ9Pkyl93hFZzelLhpagRugZN 6nGIaKugNTWmMiY2YSgQhGCFoJaxejvk6M5KZQm3WoXUK5OZcH1jDkss972bD4qs5ymE 1PL2DwzFk3ctXmE4ubDS3m2krIsNbXkA5fnzWN4AhEs3NNR/bwKNF9hT0NJAJDego5Ki mN1NVV7eiyTkf/OEvCt8c9iIXSfwFznSaEoq66HBthszRqcwmoct9OuMzxV87gNcjfJZ J4YnS5Bkyn8jREUdGNCY/zEHX06MBPXWaW9asjOb5gUXakXls6EQtCurBX0yytmCbe3T 7BjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774018168; x=1774622968; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xKWL+GAYqNp+tTujHQMkzR7HCGoYVVs3sPVjIKR0hiY=; b=lfLlpWBWIwNCkBsW8TuKhoRi6G03G5+xyj7aW+2TukMq/ymZ6FLh1txT2ms7VdYA6x ynyUphgtGFuRiaSkskdswDF0lkhULMkmvwVX8SgyTGw/IHZKRZ+s6+BbnbPxviRBPtoL rjrfvLoCzz/Zsiy1qfLstFSLLLjfY29wJsvJvygm2xZkURgOKU/s4jVcw4Z3TiMoRxAA biSqHuRwCCw24jP9hT8YikcxSFgl4rw9ZVIcvhqX3xVGYIXloy0WnrhGEocOiGduNmrD RJO7XySDZgKf7fovBj0wTaTu21n9/4CZ1d6t1EUuolOCpw+yFK+cPZBrX5zF8nfg3pUM OmwQ== X-Forwarded-Encrypted: i=1; AJvYcCW8FVHrSim+IpQJm77IDhHAUNkBUgzRPt+gdrjGkNRXTlC+IyOP4oKhb1i6BLXnlhkfiz8CGL68rg/CzJc=@vger.kernel.org X-Gm-Message-State: AOJu0YxjfkR6fpqjgU86ZN/ZyxMv1chIoTbhbBsiGgY4stNZPUshbBu2 C46jFEBTz93WtnPmxtS4xUTEuVn3fFLXosNc7yXNLm0vyvYS3CdH5E+II0vL/zxjoeY4QhtyRIv y4J5PzlPGyrFe6Mji/LeMv+YDt/4rS3XlxF1Ct+575QVf1d6gP7Lz7tEQb/IcHwJg+cc= X-Gm-Gg: ATEYQzz6MnsGlfuPo3P5j8xQSUrCXYBUQdPFJ7vsCi6k5vqImR9Nv0DZ95PLYoA+nsa e4GHPXfHgmUNr2X+DgCXcLQSo8vNLawXzlKwsqOhvcxSXKBGQCVStlozaWObinkFcSNa/QoBUNS OeT5rHfdbA3zhsKTquVddbhw12ZNG0BBUxxO71QmIeQ+JxCAxCJ2uxbCprsWuO+WrV5AGP8eofQ /C1GaYEj9wM+dCkQFXVSSTr8x+IDye9Xvh7eblGP8p17mYmCzP10cu8yP/swWwBBmjEd5/u3iwq Ds6ZHR48cT1S8OtbCF/YYTIn5J3T9iJx3ZKrjnrpmwRTo+AlV2ntAdQZXXx5FaWl2sDfriTg+Zh GeooKJZBPCkZgl6AI3mSkm9tCynGteFbQqGa5hL1SaJbaroQzTW4FQ1g= X-Received: by 2002:a05:622a:146:b0:501:51d4:df30 with SMTP id d75a77b69052e-50b245b43e7mr103801641cf.8.1774018167480; Fri, 20 Mar 2026 07:49:27 -0700 (PDT) X-Received: by 2002:a05:622a:146:b0:501:51d4:df30 with SMTP id d75a77b69052e-50b245b43e7mr103801031cf.8.1774018166894; Fri, 20 Mar 2026 07:49:26 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486ff109b95sm47906825e9.1.2026.03.20.07.49.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 07:49:26 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org, val@packett.cool, mailingradian@gmail.com, Srinivas Kandagatla Subject: [PATCH v6 03/13] ASoC: qcom: qdsp6: topology: check widget type before accessing data Date: Fri, 20 Mar 2026 14:49:08 +0000 Message-ID: <20260320144918.1685838-4-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260320144918.1685838-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260320144918.1685838-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIwMDExOCBTYWx0ZWRfX8NtoYFTJe3Qx E0OTU5yOGDzw3j+DzMTNWKBH6GifeNEs+AufA+y1vjdTfZo4dxyhNglJPLxXE+PlPH6lw3AoaiP FJnDb8g47WhD/EjmrHp7PEC74Qly/MKO5HjEXdaqKqYPboTcOSykXLccyK7s1JhCQ43RoPSD2w+ V/OWEHi+qFbN7oeKyDNpfA8a+AHXGkYfQ4C0k0Jc/ptYtslUlHmBNWkIDw/eDCkc4oCUUoeVKEx czQEI1MLHZiCIHN5I/Jq8RP/4P8/qdpKpfUSzkNpUN7FYbzfXH0QB/aS8ExhR78RMYMmfswFTpX /xlDoZVPXplr5Q1ALAKVm7/hKZHM2tAeKpEn5us2sbkyBbUYeR+ZYRdi6iOVIT4yqe9uCFpPBvm Osy23eflAQgquRUFW/9jaOMpmPcwAyy7k6Urf45mQ4r4IU+9zVV5uo2r7+QEgA7gLKMPQ/4sx6K NJ44KnuagVmoGxqgJzQ== X-Proofpoint-GUID: ebCqgrBUIfiN08cMXrCE3lpnkWpwxnkX X-Proofpoint-ORIG-GUID: ebCqgrBUIfiN08cMXrCE3lpnkWpwxnkX X-Authority-Analysis: v=2.4 cv=Y/D1cxeN c=1 sm=1 tr=0 ts=69bd5e78 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=5HTw2GpdgXbBP0wXRk4A:9 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-20_02,2026-03-19_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 phishscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603200118 Content-Type: text/plain; charset="utf-8" Check widget type before accessing the private data, as this could a virtual widget which is no associated with a dsp graph, container and module. Accessing witout check could lead to incorrect memory access. Fixes: 36ad9bf1d93d ("ASoC: qdsp6: audioreach: add topology support") Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/topology.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc/qcom/qdsp6/topology.c b/sound/soc/qcom/qdsp6/topolog= y.c index e732fac9b8ca..1f69fba6de26 100644 --- a/sound/soc/qcom/qdsp6/topology.c +++ b/sound/soc/qcom/qdsp6/topology.c @@ -952,9 +952,6 @@ static int audioreach_widget_unload(struct snd_soc_comp= onent *scomp, struct audioreach_container *cont; struct audioreach_module *mod; =20 - mod =3D dobj->private; - cont =3D mod->container; - if (w->id =3D=3D snd_soc_dapm_mixer) { /* virtual widget */ struct snd_ar_control *scontrol =3D dobj->private; @@ -963,6 +960,11 @@ static int audioreach_widget_unload(struct snd_soc_com= ponent *scomp, kfree(scontrol); return 0; } + mod =3D dobj->private; + if (!mod) + return 0; + + cont =3D mod->container; =20 mutex_lock(&apm->lock); idr_remove(&apm->modules_idr, mod->instance_id); --=20 2.47.3