From nobody Mon Apr 6 09:13:16 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 230BE3A0B11 for ; Fri, 20 Mar 2026 14:49:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774018168; cv=none; b=IXDYpMh3Cz9RAlgHHeH3J1ZqYPSxDF1dEtbdrp1J+A5uIFQYns5h+AX243lkWHMKwYU8VBlXtanrjdbKSnZHdZ3f64dWB07CvI9xVXNn1KRlZPKiuqJo1aBxA+HRQm6iIByk/Fx2fKAJgFSMao7pXvaJjVcwJD8VFGOT4pOMNvM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774018168; c=relaxed/simple; bh=ioMmjxhpKgEGbU9Q5ZhuNjYP6+vM1Ed4pEa/HmaRSl8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YebZ6S882EJbZE4R9fegBsgifWpkwQGJ+YKNM9iyBdoFk5EWQQcTV6Muvv1kdNYD9K9Q/0bzvQg3Q3TFP6s7rSXG7Oa3rOCm7rUHWY/GBHBIa0w0nJ/qJs6whTVJ9ocHCC+i4/uCCFjVxxhDmRSz7edAga3zi29gV4F03MyLEr4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=o3PZlQwQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TcUDIYWP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="o3PZlQwQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TcUDIYWP" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62K2XjX7331583 for ; Fri, 20 Mar 2026 14:49:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=NKjWGmdRv65 20W4OaNXC1TctOioozKWeG4nDgD3XJX8=; b=o3PZlQwQO9IaP04i4zJIwMNcNc1 edwARPEPwIoKRydap85PblMumF6blqYfYpjc2BLZP/WHvVC3XXg5qaXHdXdyytcP G8ki5J5AFmJqp0iYdgJzhP1y3zgDV06Myv0oQT/qhc0xTg7t5TMtfj/CxCCoKZOb gvAM4Ycxo3cdKOey1k68+kh1gfOP9FQAmC2QEM56eD0NKwXIfzOFUqIxGouWiuQm ziwXzKRcxIkYji86xrF56zrW5+OpSqrKC4Tkn1l/6ZR+ElgSVzijguUw2w4Y00Tt Kz+iyP1L/PEwH77EnMX98pTd8JXBWVnWm7CTRc0pX1UXiQNF8YncdE0bCoA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d0k083pb1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 20 Mar 2026 14:49:25 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5093b92f327so120854101cf.1 for ; Fri, 20 Mar 2026 07:49:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774018164; x=1774622964; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NKjWGmdRv6520W4OaNXC1TctOioozKWeG4nDgD3XJX8=; b=TcUDIYWP1Oj7idnqgzS4WwRD71KSfpwI2ZoWpaPBCM5sGB2hQQwwhNKv9pDH+IFKgR TRgJZI7rbDocm6qHNFtADyH2Ua2QqRofK+flekxOmA04u9nbe4LmzJwaW/FGwXL/W3fa 5PiPmXEaW6Dd6dYCtH8VAJODu2X9YaJTy38qn+PQb4GeZYRGJFEjVhvKhGh3ffd6jtCR SxbL/+3mKHT/o31LPIzWM/Mkq2j+NBGxgb3j/qMXk0O7Kl38lUQxrY3VX4qyPzErl/vp vP0zANIWlxOnN9W4HDctuXzO/GicR6TGZFE1rI/MKk/qdFkmSrMn4u1JqiNI311T/9fB dZdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774018164; x=1774622964; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NKjWGmdRv6520W4OaNXC1TctOioozKWeG4nDgD3XJX8=; b=N63I4AWthqcbyDjVIsjs6pBe98zYXvWhAX8RUsOro/OLFQijs0j8w/p1In3Zv8dXty wUVP8ciYZnloq5OjBdV9szj0gekuJ0nm/UbzPsKan/+klzPJguLZwPZ8MwEJFQAaMV1v 4hizCf3UC7mJrPFSL9PN8X1QLcPbbTdTNKQiTkJgCSTd4wLDyF6ebGukRxbUhb5qx5sZ hLn0/UQZzxSlo7gysimT9roC4DOpsZg12+AEoSicjHC7P1M6tUyJnGCzq5MxmfMuzAu2 0yCfiicI5hI/y/TfMO07uDBe9a5LDXMG0wnVOSRJjlATs6ZGms6FR5cX1u1eo6RD9o/y Ml+g== X-Forwarded-Encrypted: i=1; AJvYcCUoVz2NG0ppYk7MQdjFM8vV6W1zwXqJ0KD8DpqOhbAbVT8C+tWZhBx4eJBGWzjADO9lvfIQBWPWOPE4r1A=@vger.kernel.org X-Gm-Message-State: AOJu0YyBcHzPCfV67BRxKC6ezMUz1DUcZvQcpJcpZLIqAqVEiA1TsDRB IaR3gbA64goC2FZJy3PElxbfEKZ7vbOBRt1GJzbjznLd394XqwVblppvt9BP9r0+/w5bK8nJu+q 3r3J1qg0+VfTDVsfFS8Udv0RKQkaga7meUOy2dFQpDnuLEmjnr62F9MkgkQOUMAG6TXc= X-Gm-Gg: ATEYQzxut3o2fXSa5SZBxheT+CfBwpAaNPJX2c+Ck2UQGBTFlY7Yhaju0ff2CDAxC3m SxhUNBgxqLH+eNK5DojLVtUAoqHejZtw99qfAYa4RGrDBQ4mRFYoX5flR+JbfxT2HYa5GgqRDVB 5PeHLKnztKHnnho2RrSZW6P1wOPYE3dv7m8aObf8OlEM2lQmnmnvyowfSlBRCvxO5JL8VBrY/wc 5vu0Ki5wDovqC/TjN+yzpaWLKYJnb5I0o9SQzvxsspuBpkKLMZFTYxd6zRqCOn5Oo4B/ZxezuQr 3m/BNjX+osMB5BdaSa1QVU474AN296d7/HcQ5dIeQBLtUQe7ml8TEyajGORP3Y53aUVPY5YwhsS YX9CGIevdGEnSG5Mqge9Pi6foOaK2uGTqvk3P1p/iKTOxouB4+r0+Hrg= X-Received: by 2002:a05:622a:1b8c:b0:50b:4001:ae12 with SMTP id d75a77b69052e-50b4001b068mr19927641cf.46.1774018164482; Fri, 20 Mar 2026 07:49:24 -0700 (PDT) X-Received: by 2002:a05:622a:1b8c:b0:50b:4001:ae12 with SMTP id d75a77b69052e-50b4001b068mr19927011cf.46.1774018163780; Fri, 20 Mar 2026 07:49:23 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486ff109b95sm47906825e9.1.2026.03.20.07.49.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 07:49:23 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org, val@packett.cool, mailingradian@gmail.com, Srinivas Kandagatla Subject: [PATCH v6 01/13] ASoC: qcom: q6apm: move component registration to unmanaged version Date: Fri, 20 Mar 2026 14:49:06 +0000 Message-ID: <20260320144918.1685838-2-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260320144918.1685838-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260320144918.1685838-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=MYhhep/f c=1 sm=1 tr=0 ts=69bd5e75 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=ZjLH_7kMUelE1Q3ziugA:9 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: Hxf277Rv470gq82BsXndNmB-_2sEHi7n X-Proofpoint-GUID: Hxf277Rv470gq82BsXndNmB-_2sEHi7n X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIwMDExOCBTYWx0ZWRfX/NjjfdwG6Ygn o//suxBNp1rN116Pw0EI+AKOC9tbPNqioI7/eAIf9724GVZtuuv7AaJRelZC4jrkPEmmwxrFwW5 uNhRJX9D68P8bcbFkUyWalSaZQfiPk3xlK/iyE2fNsGgeQXWG9+ME5Dgw+4inh+e9Nkyo2dLQjX SNufzSgIiZ6XC6BusE2K1j/1Xwda4RjK8NvQNH4dX6+UEjYB/3ERBcU5s9yLFQAMSvvAZmHQhPh v7Nr6kyeCLD5BdZ7C0oC6GJcYlEgKU7/f7RKktLzJezN78P0zPdXgIYk3rrey9/9jrJ47AAGO2/ cgOejVz2ZoR8+JBP0hcGOF6Y3u6ENnRlqCxFiiYQW5AB/5DzN6Rj+rAl8DxfHzPl1C/HRk++BbH ek+JEz7spT1n5u7RQ7tMZsphRUlIBdMa9UHEALWUUk8rAmFHXdqQbfB5sAw481DAAQeK6yrdo/H pKaf6rRxJt9SyckJdiw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-20_02,2026-03-19_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 impostorscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603200118 Content-Type: text/plain; charset="utf-8" q6apm component registers dais dynamically from ASoC toplology, which are allocated using device managed version apis. Allocating both component and dynamic dais using managed version could lead to incorrect free ordering, dai will be freed while component still holding references to it. Fix this issue by moving component to unmanged version so that the dai pointers are only freeded after the component is removed. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D BUG: KASAN: slab-use-after-free in snd_soc_del_component_unlocked+0x3d4/0x4= 00 [snd_soc_core] Read of size 8 at addr ffff00084493a6e8 by task kworker/u48:0/3426 Tainted: [W]=3DWARN Hardware name: LENOVO 21N2ZC5PUS/21N2ZC5PUS, BIOS N42ET57W (1.31 ) 08/08/20= 24 Workqueue: pdr_notifier_wq pdr_notifier_work [pdr_interface] Call trace: show_stack+0x28/0x7c (C) dump_stack_lvl+0x60/0x80 print_report+0x160/0x4b4 kasan_report+0xac/0xfc __asan_report_load8_noabort+0x20/0x34 snd_soc_del_component_unlocked+0x3d4/0x400 [snd_soc_core] snd_soc_unregister_component_by_driver+0x50/0x88 [snd_soc_core] devm_component_release+0x30/0x5c [snd_soc_core] devres_release_all+0x13c/0x210 device_unbind_cleanup+0x20/0x190 device_release_driver_internal+0x350/0x468 device_release_driver+0x18/0x30 bus_remove_device+0x1a0/0x35c device_del+0x314/0x7f0 device_unregister+0x20/0xbc apr_remove_device+0x5c/0x7c [apr] device_for_each_child+0xd8/0x160 apr_pd_status+0x7c/0xa8 [apr] pdr_notifier_work+0x114/0x240 [pdr_interface] process_one_work+0x500/0xb70 worker_thread+0x630/0xfb0 kthread+0x370/0x6c0 ret_from_fork+0x10/0x20 Allocated by task 77: kasan_save_stack+0x40/0x68 kasan_save_track+0x20/0x40 kasan_save_alloc_info+0x44/0x58 __kasan_kmalloc+0xbc/0xdc __kmalloc_node_track_caller_noprof+0x1f4/0x620 devm_kmalloc+0x7c/0x1c8 snd_soc_register_dai+0x50/0x4f0 [snd_soc_core] soc_tplg_pcm_elems_load+0x55c/0x1eb8 [snd_soc_core] snd_soc_tplg_component_load+0x4f8/0xb60 [snd_soc_core] audioreach_tplg_init+0x124/0x1fc [snd_q6apm] q6apm_audio_probe+0x10/0x1c [snd_q6apm] snd_soc_component_probe+0x5c/0x118 [snd_soc_core] soc_probe_component+0x44c/0xaf0 [snd_soc_core] snd_soc_bind_card+0xad0/0x2370 [snd_soc_core] snd_soc_register_card+0x3b0/0x4c0 [snd_soc_core] devm_snd_soc_register_card+0x50/0xc8 [snd_soc_core] x1e80100_platform_probe+0x208/0x368 [snd_soc_x1e80100] platform_probe+0xc0/0x188 really_probe+0x188/0x804 __driver_probe_device+0x158/0x358 driver_probe_device+0x60/0x190 __device_attach_driver+0x16c/0x2a8 bus_for_each_drv+0x100/0x194 __device_attach+0x174/0x380 device_initial_probe+0x14/0x20 bus_probe_device+0x124/0x154 deferred_probe_work_func+0x140/0x220 process_one_work+0x500/0xb70 worker_thread+0x630/0xfb0 kthread+0x370/0x6c0 ret_from_fork+0x10/0x20 Freed by task 3426: kasan_save_stack+0x40/0x68 kasan_save_track+0x20/0x40 __kasan_save_free_info+0x4c/0x80 __kasan_slab_free+0x78/0xa0 kfree+0x100/0x4a4 devres_release_all+0x144/0x210 device_unbind_cleanup+0x20/0x190 device_release_driver_internal+0x350/0x468 device_release_driver+0x18/0x30 bus_remove_device+0x1a0/0x35c device_del+0x314/0x7f0 device_unregister+0x20/0xbc apr_remove_device+0x5c/0x7c [apr] device_for_each_child+0xd8/0x160 apr_pd_status+0x7c/0xa8 [apr] pdr_notifier_work+0x114/0x240 [pdr_interface] process_one_work+0x500/0xb70 worker_thread+0x630/0xfb0 kthread+0x370/0x6c0 ret_from_fork+0x10/0x20 Fixes: 5477518b8a0e ("ASoC: qdsp6: audioreach: add q6apm support") Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6apm.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/q6apm.c b/sound/soc/qcom/qdsp6/q6apm.c index 970b08c89bb3..fece0e3def23 100644 --- a/sound/soc/qcom/qdsp6/q6apm.c +++ b/sound/soc/qcom/qdsp6/q6apm.c @@ -747,7 +747,7 @@ static int apm_probe(gpr_device_t *gdev) =20 q6apm_get_apm_state(apm); =20 - ret =3D devm_snd_soc_register_component(dev, &q6apm_audio_component, NULL= , 0); + ret =3D snd_soc_register_component(dev, &q6apm_audio_component, NULL, 0); if (ret < 0) { dev_err(dev, "failed to register q6apm: %d\n", ret); return ret; @@ -756,6 +756,11 @@ static int apm_probe(gpr_device_t *gdev) return of_platform_populate(dev->of_node, NULL, NULL, dev); } =20 +static void apm_remove(gpr_device_t *gdev) +{ + snd_soc_unregister_component(&gdev->dev); +} + struct audioreach_module *q6apm_find_module_by_mid(struct q6apm_graph *gra= ph, uint32_t mid) { struct audioreach_graph_info *info =3D graph->info; @@ -820,6 +825,7 @@ MODULE_DEVICE_TABLE(of, apm_device_id); =20 static gpr_driver_t apm_driver =3D { .probe =3D apm_probe, + .remove =3D apm_remove, .gpr_callback =3D apm_callback, .driver =3D { .name =3D "qcom-apm", --=20 2.47.3