From nobody Mon Apr 6 10:43:35 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71FDE3C5559 for ; Fri, 20 Mar 2026 14:41:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774017719; cv=none; b=q7UYixf0NZsphuSFFnaD2T7ViqHJmfARDmCk+6pgMPUYivPATCM7oCce5NiZ9oe58IK93KSKKfZXu4b6KkaFbdJWr2chVyd3LYhdl5BiBFZZfzsYp8fxH4gS3eRWt5HTDjM1jTHephbaw/5RvlFxVI/DsugT2/iI9aYKKelALDw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774017719; c=relaxed/simple; bh=godTSr6bdicrLv4RTlBef/WCwR5oxIRNe7AE0gxUCjM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qWHj3gqfvgdcxoRzAsS0Nqq1JsXwWr2LFPhe0/7dq1YdFZFJhNFY2yCRSdybOa7iB+o4S8+1KHDqsdpCVk+WY/qzq7SEDpGMWkTx2aNNXJXvGaCbhyu9gwPkvYj/uqFMQDHV900XNC874vW6lV2+F8VEfuOUEbbwFp7FB25sL/A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=lsTw072U; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="lsTw072U" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2b04b4974abso19246995ad.1 for ; Fri, 20 Mar 2026 07:41:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1774017718; x=1774622518; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cQm62Y6+YSHQLskIUl4TXD+Tc/f2ddlM4l+yzD6p7gA=; b=lsTw072UVGrFIlFgMVdG4e3ip4GrbPp5vFAkqQ2nRwwVvb11lq99p1GpQMiVHbzC1m E2qv+JLtkwuaFiVME+b8pStULkSwKRJMjPDXf51gvz7LNrtXs9/VamnBdonapjWwkSFe ROtzPqkc3qI7u2txkBaFt0P5lNEKxKHS30J6njPkPI7tSYAaknctNa5TUcvK+/an85s4 75OLDMr69yQ/mGYay3To1mgqZgGGFOPYCceoe4FD5MqnBP3UYcxnC3Mhw3x/DIMoFcGA ZCpUgRvZZb8YUeRIBUPZxmKpV3lKNJNsuu+epIFa8xihPWBG+/eM5p+yHcAI24Bk7Zll 6y+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774017718; x=1774622518; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cQm62Y6+YSHQLskIUl4TXD+Tc/f2ddlM4l+yzD6p7gA=; b=kBIQ19/Fqbu9kmIejM8l2CKOEaH52mZsNtp+Ro5M4Vwco6FEPviZnjNMZcogrDIbZE eogsmacCGr45PekRFSbMvNSiLECiBaMVzNBbhVS9bMq9sv4XWiscAvAAqF70YxgxLoaT 6gC/jdZikJ+h6KaeUyQL78/jS6oowu2QPGfgr74VYqBM4UjTTGGkRDbBf+fjaD1w5Kof Y+Tyu3YXcd1PEY9kZ5q2caJKcrpwVaxmN9rGNGJzTUSHVQNn82AHlagVYGRy0LMJUile UCQ/IPfDCf3I6C5r3KbUI7Nsc0nX6SUoDklxWWx2KIEFkJwaWx2EkpnZxkC+FZUplz47 qXog== X-Forwarded-Encrypted: i=1; AJvYcCWm9JXyWMy3UvMPYYdvYId+a1Zpr6NefyJEF1b3LlFKVMxhgoycHDCIGQrD59pH/uJoAC2lzaXqvcodaZY=@vger.kernel.org X-Gm-Message-State: AOJu0YyUtoQetJd4FRNMQGZrhR3jpZ62k0sRmvupXjLv9UlOLPvlnxc+ sEYtWl5l9PQP8sVHbZT5ZNqDtuWUfpaWjXOAmtbeUlHb0yM5mllVJ+4wM5h60W9JVxo= X-Gm-Gg: ATEYQzwFszXoJkel+d7rCDLnrRE4kaXeY44fylZ2+6JkwXjTJU2fngLQCBIWL8LMfDR KtuXYLJIhsIQRq4cNOBhM0taMuoL3kr7sWz08JmJFI0ZAQwBgl2muR925dfB5pfeH+TJeCeJnB6 E4wr4dU6bhQzKFKY4QklOuUllOoPePKaqDcgRv+gVRanVDKvV+bLkSBZT1hiERteL/fqgc5uom3 PsRGXKgBmjxVRY+I4Q8xxx6FCulU+0okLGPe8IP/lpHQu1wQB+dm6m0gCGnpghNjGG1+yakTDHr OUpybuFpUkDPt4bQ3BsLUkC/PLAixggt9CTWUr/Qnknj5mc6OYvJfCV1GuYVbSObU9WISLQ55ku Ga2MX67vSzs+EqXSOg8IpcakLnbv6Bt7PjwRyG8bGtZKd7JmCcDxKR/mg4A35CD6pHfJ6PdKChH u0pghk X-Received: by 2002:a17:903:2f87:b0:2b0:7ca0:3fe4 with SMTP id d9443c01a7336-2b0827dd702mr30026435ad.43.1774017717849; Fri, 20 Mar 2026 07:41:57 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:73::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b083656df5sm34525935ad.44.2026.03.20.07.41.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 07:41:57 -0700 (PDT) From: Joe Damato To: netdev@vger.kernel.org, Michael Chan , Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: horms@kernel.org, linux-kernel@vger.kernel.org, leon@kernel.org, Joe Damato Subject: [net-next v4 04/12] net: bnxt: Add a helper for tx_bd_ext Date: Fri, 20 Mar 2026 07:41:25 -0700 Message-ID: <20260320144141.260246-5-joe@dama.to> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260320144141.260246-1-joe@dama.to> References: <20260320144141.260246-1-joe@dama.to> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Factor out some code to setup tx_bd_exts into a helper function. This helper will be used by SW USO implementation in the following commits. Suggested-by: Jakub Kicinski Reviewed-by: Pavan Chebbi Signed-off-by: Joe Damato --- v4: - Added Pavan's Reviewed-by tag. No functional changes. drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 ++------- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 18 ++++++++++++++++++ 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethern= et/broadcom/bnxt/bnxt.c index c9206977fd54..d12e4fcd5063 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -663,10 +663,9 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb= , struct net_device *dev) txbd->tx_bd_opaque =3D SET_TX_OPAQUE(bp, txr, prod, 2 + last_frag); =20 prod =3D NEXT_TX(prod); - txbd1 =3D (struct tx_bd_ext *) - &txr->tx_desc_ring[TX_RING(bp, prod)][TX_IDX(prod)]; + txbd1 =3D bnxt_init_ext_bd(bp, txr, prod, lflags, vlan_tag_flags, + cfa_action); =20 - txbd1->tx_bd_hsize_lflags =3D lflags; if (skb_is_gso(skb)) { bool udp_gso =3D !!(skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4); u32 hdr_len; @@ -693,7 +692,6 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb,= struct net_device *dev) } else if (skb->ip_summed =3D=3D CHECKSUM_PARTIAL) { txbd1->tx_bd_hsize_lflags |=3D cpu_to_le32(TX_BD_FLAGS_TCP_UDP_CHKSUM); - txbd1->tx_bd_mss =3D 0; } =20 length >>=3D 9; @@ -706,9 +704,6 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb,= struct net_device *dev) flags |=3D bnxt_lhint_arr[length]; txbd->tx_bd_len_flags_type =3D cpu_to_le32(flags); =20 - txbd1->tx_bd_cfa_meta =3D cpu_to_le32(vlan_tag_flags); - txbd1->tx_bd_cfa_action =3D - cpu_to_le32(cfa_action << TX_BD_CFA_ACTION_SHIFT); txbd0 =3D txbd; for (i =3D 0; i < last_frag; i++) { frag =3D &skb_shinfo(skb)->frags[i]; diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethern= et/broadcom/bnxt/bnxt.h index 8147f31967b5..a822bbb71146 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h @@ -2834,6 +2834,24 @@ static inline u32 bnxt_tx_avail(struct bnxt *bp, return bp->tx_ring_size - (used & bp->tx_ring_mask); } =20 +static inline struct tx_bd_ext * +bnxt_init_ext_bd(struct bnxt *bp, struct bnxt_tx_ring_info *txr, + u16 prod, __le32 lflags, u32 vlan_tag_flags, + u32 cfa_action) +{ + struct tx_bd_ext *txbd1; + + txbd1 =3D (struct tx_bd_ext *) + &txr->tx_desc_ring[TX_RING(bp, prod)][TX_IDX(prod)]; + txbd1->tx_bd_hsize_lflags =3D lflags; + txbd1->tx_bd_mss =3D 0; + txbd1->tx_bd_cfa_meta =3D cpu_to_le32(vlan_tag_flags); + txbd1->tx_bd_cfa_action =3D + cpu_to_le32(cfa_action << TX_BD_CFA_ACTION_SHIFT); + + return txbd1; +} + static inline void bnxt_writeq(struct bnxt *bp, u64 val, volatile void __iomem *addr) { --=20 2.52.0