From nobody Mon Apr 6 09:12:34 2026 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6F123CCFD9 for ; Fri, 20 Mar 2026 14:42:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774017733; cv=none; b=h4l5phB633W3j0e5gsJ3TDhVA8c/Lt3Qu0Z/jDvwqCgsYd7ZlYWwIbxVK1c/M3YGsRZouyMoyWrPN+zkwUfrXeF8/yjhVBY9OhL79PJroJ+pr22H0AZn1EEv0wrz3Jm4hmUWBJgLM/rAdzRWcSmH+iuTxAH7+nu3KGGzVXauQbQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774017733; c=relaxed/simple; bh=tk6yIcgDNmYbIICltKD6OaLCHNSA9DvyfvCudVZWJRs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cijE13u1/1WW8s1OFmzT6NUb1SjSC0H9ZIbtFA3wAK6hJE9BRvnn0we/RIzoqMs8mwTVO9gok8oi0TeqMoNKmbtbUc/3bc4i8nvgJMsJ5qpsckmxDPsiGBAyMo+J1huvVX2NywWRn72uWNLnKlKRw7J6ChTkmX5jskGHj2PTM68= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=bh2smwQ/; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="bh2smwQ/" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-c6dd5b01e14so769179a12.0 for ; Fri, 20 Mar 2026 07:42:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1774017731; x=1774622531; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rGXsa+qFOM0/tzQzSS33c8kc0mVqkh8Ml/C2OypIk08=; b=bh2smwQ/tGrl5yHrGGZbNYyHFi67UFFscGfjrDg2+A2uFyECYF+WZii3j1O0DTOhdW 0Pi4cD/FB7UmMHC+HkaFwRn93e9dp8T0eJSrN+NvVyiuthkqbVGLtCpCajeqdmLXMxDc J6jIeVQGMyQWNYBuUBiOLYljGkp3h1RRKYHl4HZuEM/EaIPhdg9RoJDLKHaNzByGWhIf 8Ks/5s9J2SGTrnje8ptb+1TuQBCXRMpBzgbhNgkjNA2X/CiOomZqopvMnuQ5OcBerLQx 9khbclzZ1czhwulgPnMuHmF5XrcN6Am6+E463OlqTZUnjUeATi/jSnYY2L7Wj5JGHRz+ ZyDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774017731; x=1774622531; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rGXsa+qFOM0/tzQzSS33c8kc0mVqkh8Ml/C2OypIk08=; b=EbpviJe7tkUEV/YcBJFVlbzFuVm78AQ5cUTRZOVXd747JsfYp74wikqjgfZ0h1DKo5 AHJt72iIZiO4uuVXdr363WSHelUez0H1Fex1mSmbZAR8EmXWYGltjlZfyHCRSYDPStXE yXu/kLSIn2hHFCP/5tmL5jGfewlknXoSoqBFBmdOwGKxWo16ITYs3IfAHLPCAeyIR1EW VTGS0XDwt9zal2eWFJnhbNxune9Uw442q9rPKwqe4jUz6I2WJ5clzlpa5jzE7uPRyZjT ftTuVHVQXtXBpxU1pDTFH3cIi+kylUoiWHI0OsAOqUDMIRUb1yaaop1bGDdhKnx0pFBC nDbw== X-Forwarded-Encrypted: i=1; AJvYcCWvqgIOZAX8JAfm+NWcp+m2j/MFP4wX6oLscCeyCHvvjR7u7cKML3kiQHGEdl9JhLqCzgXIAEcDXpcD6DU=@vger.kernel.org X-Gm-Message-State: AOJu0YxedCXGcLTtxXKx96DaWL5//6F6QwgxyryAtX1WC84SD7msbALx kf0v+I1seiMYHIl1mYZQNerZjBSriicCPadc/rGUTV0id7ZNjS4m/GrkmN52LfzWujc= X-Gm-Gg: ATEYQzxEz/lkb5Z7Sy47o+ONWH6XoVCQ2C/JUWenPkZ8myz2pUbrZWhCB2qEQ1zRuud X8+pDGWm1zIvZ7Loipio9oquWhEzLoL3kj08t2ahbQZkZNynH9rPmnY+ETafdoYNgLFf7dlhSlZ H4UZFj2siaLCQbtFDae3HJHOYHu+NIYzE3rC0e2mj3L65jRPZqyS7EfnEKp8eRbg6yuSuizndXb u9YuIC8A4p4bxDb6dKDHC0cPnHLAJav+YlEWT2FIz3g+YRWXNmwNj0yPe9KU3MyeA4QiCM+4tdm fEOeQI0O8DDqcnowx86pU7pB2nc7neGkrhQ7Rg5LvH6vA7DCTdnggglAllgmRoE5utR5s9pCWiz +Kv+tzBNkDfuTC2rgxb8LG2BYfGgyCDe2cY74INnA877dmmW8mBdZk8Gm45C7msvXWppBQKhKGh 2gL/nIQag+HzeQ0p8= X-Received: by 2002:a05:6a20:3948:b0:398:9fc9:e07c with SMTP id adf61e73a8af0-39bcea31be3mr2935202637.24.1774017731199; Fri, 20 Mar 2026 07:42:11 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:72::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b041059a5sm2844280b3a.53.2026.03.20.07.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 07:42:10 -0700 (PDT) From: Joe Damato To: netdev@vger.kernel.org, Jakub Kicinski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni Cc: horms@kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, linux-kernel@vger.kernel.org, leon@kernel.org, Joe Damato Subject: [net-next v4 11/12] net: netdevsim: Add support for SW USO Date: Fri, 20 Mar 2026 07:41:32 -0700 Message-ID: <20260320144141.260246-12-joe@dama.to> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260320144141.260246-1-joe@dama.to> References: <20260320144141.260246-1-joe@dama.to> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add support for UDP Segmentation Offloading in software (SW USO). This is helpful for testing when real hardware is not available. A test which uses this codepath will be added in a following commit. Suggested-by: Jakub Kicinski Signed-off-by: Joe Damato Reviewed-by: Pavan Chebbi --- v4: - Added parentheses around the gso_type check for clarity. No functional change. rfcv2: - new in rfcv2 drivers/net/netdevsim/netdev.c | 100 ++++++++++++++++++++++++++++++++- 1 file changed, 99 insertions(+), 1 deletion(-) diff --git a/drivers/net/netdevsim/netdev.c b/drivers/net/netdevsim/netdev.c index 5ec028a00c62..f7dd7692a5d9 100644 --- a/drivers/net/netdevsim/netdev.c +++ b/drivers/net/netdevsim/netdev.c @@ -30,6 +30,7 @@ #include #include #include +#include =20 #include "netdevsim.h" =20 @@ -117,6 +118,98 @@ static int nsim_forward_skb(struct net_device *tx_dev, return nsim_napi_rx(tx_dev, rx_dev, rq, skb); } =20 +static netdev_tx_t nsim_uso_segment_xmit(struct net_device *dev, + struct sk_buff *skb) +{ + unsigned int hdr_len, mss, total_payload, num_segs; + struct netdevsim *ns =3D netdev_priv(dev); + struct net_device *peer_dev; + unsigned int total_len =3D 0; + struct netdevsim *peer_ns; + struct nsim_rq *rq; + struct tso_t tso; + int i, rxq; + + hdr_len =3D tso_start(skb, &tso); + mss =3D skb_shinfo(skb)->gso_size; + total_payload =3D skb->len - hdr_len; + num_segs =3D DIV_ROUND_UP(total_payload, mss); + + udp_hdr(skb)->check =3D 0; + if (!tso.ipv6) + ip_hdr(skb)->check =3D 0; + + rcu_read_lock(); + peer_ns =3D rcu_dereference(ns->peer); + if (!peer_ns) + goto out_drop_free; + + peer_dev =3D peer_ns->netdev; + rxq =3D skb_get_queue_mapping(skb); + if (rxq >=3D peer_dev->num_rx_queues) + rxq =3D rxq % peer_dev->num_rx_queues; + rq =3D peer_ns->rq[rxq]; + + for (i =3D 0; i < num_segs; i++) { + unsigned int seg_payload =3D min_t(unsigned int, mss, + total_payload); + bool last =3D (i =3D=3D num_segs - 1); + unsigned int seg_remaining; + struct sk_buff *seg; + + seg =3D alloc_skb(hdr_len + seg_payload, GFP_ATOMIC); + if (!seg) + break; + + seg->dev =3D dev; + + tso_build_hdr(skb, skb_put(seg, hdr_len), &tso, + seg_payload, last); + + if (!tso.ipv6) { + unsigned int nh_off =3D skb_network_offset(skb); + struct iphdr *iph; + + iph =3D (struct iphdr *)(seg->data + nh_off); + iph->check =3D ip_fast_csum(iph, iph->ihl); + } + + seg_remaining =3D seg_payload; + while (seg_remaining > 0) { + unsigned int chunk =3D min_t(unsigned int, tso.size, + seg_remaining); + + memcpy(skb_put(seg, chunk), tso.data, chunk); + tso_build_data(skb, &tso, chunk); + seg_remaining -=3D chunk; + } + + total_payload -=3D seg_payload; + + seg->ip_summed =3D CHECKSUM_UNNECESSARY; + + if (nsim_forward_skb(dev, peer_dev, seg, rq, NULL) =3D=3D NET_RX_DROP) + continue; + + total_len +=3D hdr_len + seg_payload; + } + + if (!hrtimer_active(&rq->napi_timer)) + hrtimer_start(&rq->napi_timer, us_to_ktime(5), + HRTIMER_MODE_REL); + + rcu_read_unlock(); + dev_kfree_skb(skb); + dev_dstats_tx_add(dev, total_len); + return NETDEV_TX_OK; + +out_drop_free: + dev_kfree_skb(skb); + rcu_read_unlock(); + dev_dstats_tx_dropped(dev); + return NETDEV_TX_OK; +} + static netdev_tx_t nsim_start_xmit(struct sk_buff *skb, struct net_device = *dev) { struct netdevsim *ns =3D netdev_priv(dev); @@ -129,6 +222,10 @@ static netdev_tx_t nsim_start_xmit(struct sk_buff *skb= , struct net_device *dev) int rxq; int dr; =20 + if (skb_is_gso(skb) && + (skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4)) + return nsim_uso_segment_xmit(dev, skb); + rcu_read_lock(); if (!nsim_ipsec_tx(ns, skb)) goto out_drop_any; @@ -986,7 +1083,8 @@ static void nsim_setup(struct net_device *dev) NETIF_F_HW_CSUM | NETIF_F_LRO | NETIF_F_TSO | - NETIF_F_LOOPBACK; + NETIF_F_LOOPBACK | + NETIF_F_GSO_UDP_L4; dev->pcpu_stat_type =3D NETDEV_PCPU_STAT_DSTATS; dev->max_mtu =3D ETH_MAX_MTU; dev->xdp_features =3D NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_HW_OFFLOAD; --=20 2.52.0