From nobody Fri Apr 3 08:20:44 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CF393A75B5 for ; Fri, 20 Mar 2026 11:28:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774006130; cv=none; b=sd6VjqHzUfq8luv5kLkGIzd0b1sgiqw0WQUg5DTenGwS1CwNWxxRQhMg4sWW366nct6YkAyzufIHbFsG4VqOc04dsu3hbBvxGBZ65YqLweVWQZa0aMXvG256XFoUjDm4ErKAi4sYvKZqoJb1P6yDB8cswZqVIe3mCBQcvU1WVCw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774006130; c=relaxed/simple; bh=GD9E2/SQwtIIE1eJkpGHpxa3R5g8LJo5xRqW215y1pQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pTWNMqvEMGTtmKq6sdLb5eePQGB77gjoshA7+mLQYesvCEa5Ggq7kfpOH+C94OUDIxG2nrM3gobQPUEGqHKo3nLPncPGoixBj8pHBLSnrEL4HSyGsCGqVZt1PC/QORhOXe1crGrNT/0+Tb7yAP2gcq6d+KoU0RYGVyJGOlVLxRM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=SkFXGbql; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="SkFXGbql" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-486b96760easo20837805e9.2 for ; Fri, 20 Mar 2026 04:28:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1774006128; x=1774610928; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nZSF6Phsi5Ep6XqjzxpapK7aNLJkF/Hb03hbbBTs8F4=; b=SkFXGbql1tHWC0FQoTE5nLfAzdcerDWpmihpAW3yl3f7vb5v8AD+AYjbyCK6p6pVHE FYyHiRPruswVsJ8bcnWKIQ6bPoEi1qeSytHvw+6+pxIVEXR3Lr04b5xm0W1Sc6sAxxJ7 ZjVk7bRRVmQfuSEnUca1dsFdNfCO1Fx5prX9mo+Wdo/fFiNkqomspFPB9ajZvoqGHGEq GUQSk6BCI7HEPbG0bnpwlzvEYugZJu0rXkGJWO+7Fcl3sxnlzLboOdFsq+e6oNXEhtU/ Lg3CLnWrCGwlqyBXm2BrOYoI+fcfKpOYw98AwJFb3MYlvBgQVcjYM796xiFdd41ibMTX BcUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774006128; x=1774610928; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nZSF6Phsi5Ep6XqjzxpapK7aNLJkF/Hb03hbbBTs8F4=; b=VaozWC02p4GVeTM46TxWpVFyV7180OGm7rjxUf/HsIAoAfmj6sFIwZcPx5+lf9C0uQ 17gKIt/VxgKI9aUTRsJz4JxF3sF4hAOBWZTqc+0GdITPmSYjyCbPbOI+ouJuJDPMdZRq kUqLsdpr++8j5FLJ78UgSefpJGzTLhuPIxeI21HyL9xvO4F3Rp8U87L6thIR+82cz08W +Dp2fXskanQo2KaZGticBw9A04JTXy4hHgT9GmlIGYsTWb7CF7OMmjF34b4E7qlvuYFw CrBEgE3xyNvxMczzFASXdLgKTI1LeXA35sOGF39qQj8y3C99MLKhr+2+VzGmVOCvfCFi BEvw== X-Forwarded-Encrypted: i=1; AJvYcCU7fMW2uNj0XOEWekJbsDT0JjSnyqzvmcMw2GRzdACeKQqOt8Weg1dWVVBgEZgfQYGKbxljaCkv933krxI=@vger.kernel.org X-Gm-Message-State: AOJu0YygCNw1yWNwbQTj7IQKY/RqGj7g+RXloa/t7c5pIGSpweEoiUNf gKlQURZWmuAH9RzdMXYWsfWi6g6KuyrYr3CEjJ2kUl1QYKWMDZCIhhk2lGE/9Bw75Yw= X-Gm-Gg: ATEYQzy2iOshFay/st4RUGIPw6FTrZauxt/DBZENPVmyDf3w5js7/r71OZGPfi7QJ1/ TxgtOAgHeJjuWpKbx1x8Wp0BdjuJKFMFzuOycRFUpQeNyCgFObJ58tMIr4hwNP3GUMZgsGiKRJq jU3//4ikTD+XOyHJtMShPKwBcZ0dNAg8n3sQwc7ULfj9vhgQ4b7TNd1FNJI2HOf1LPR+Z7FFaud NH4fS1bK1SSV/MemwNh+3Lgst3AaEouT5fBNrpjjfQm/bMjaIGjxZ9r2DZvAY71am6qmNTBEt/w yqfdo1thtoSHqmUm/9OwQsC3qi3caNidjWNjsUYsAbqcH7AFVNNE6IP+lGU6shAK4N0EkW6g9lD XniJCd8KV46W8cvo+/8a6smNMzlQYcjlEfkHMaj4MmoB1s4jDYkwbF35Hcu9/ZLZxp5G3gtXZcD 9KFvO06LXSR3lI/wq1kNUn90KN5Zi2A9FzqqZeI2tSqjEz4mgN84BG X-Received: by 2002:a05:600c:c493:b0:485:4388:3492 with SMTP id 5b1f17b1804b1-486fedbd0b0mr40251935e9.11.1774006127646; Fri, 20 Mar 2026 04:28:47 -0700 (PDT) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.216]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe836784sm49869935e9.13.2026.03.20.04.28.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 04:28:46 -0700 (PDT) From: Claudiu X-Google-Original-From: Claudiu To: vkoul@kernel.org, Frank.Li@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, p.zabel@pengutronix.de, geert+renesas@glider.be, fabrizio.castro.jz@renesas.com, john.madieu.xa@bp.renesas.com, kuninori.morimoto.gx@renesas.com, tommaso.merciai.xr@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Claudiu Beznea Subject: [PATCH v2 3/7] dmaengine: sh: rz-dmac: Drop the update of channel->chctrl with CHCTRL_SETEN Date: Fri, 20 Mar 2026 13:28:34 +0200 Message-ID: <20260320112838.2200198-4-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260320112838.2200198-1-claudiu.beznea.uj@bp.renesas.com> References: <20260320112838.2200198-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea The CHCTRL_SETEN bit is explicitly set in rz_dmac_enable_hw(). Updating struct rz_dmac_chan::chctrl with this bit in rz_dmac_prepare_desc_for_memcpy() and rz_dmac_prepare_descs_for_slave_sg() is unnecessary in the current code base. Moreover, it conflicts with the configuration sequence that will be used for cyclic DMA channels during suspend to RAM. Cyclic DMA support will be introduced in subsequent commits. This is a preparatory commit for cyclic DMA suspend to RAM support. Signed-off-by: Claudiu Beznea --- Changes in v2: - fixed typos in patch title and patch description drivers/dma/sh/rz-dmac.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index 32349d214f68..58446726afb5 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -368,7 +368,7 @@ static void rz_dmac_prepare_desc_for_memcpy(struct rz_d= mac_chan *channel) rz_dmac_set_dma_req_no(dmac, channel->index, dmac->info->default_dma_req_= no); =20 channel->chcfg =3D chcfg; - channel->chctrl =3D CHCTRL_STG | CHCTRL_SETEN; + channel->chctrl =3D CHCTRL_STG; } =20 static void rz_dmac_prepare_descs_for_slave_sg(struct rz_dmac_chan *channe= l) @@ -417,8 +417,6 @@ static void rz_dmac_prepare_descs_for_slave_sg(struct r= z_dmac_chan *channel) channel->lmdesc.tail =3D lmdesc; =20 rz_dmac_set_dma_req_no(dmac, channel->index, channel->mid_rid); - - channel->chctrl =3D CHCTRL_SETEN; } =20 static int rz_dmac_xfer_desc(struct rz_dmac_chan *chan) --=20 2.43.0