From nobody Mon Apr 6 10:44:15 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B671738238B for ; Fri, 20 Mar 2026 10:49:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774003799; cv=none; b=NEY/Svli8BWPsN1UtsfK78F+l5w1khP6dGkDW7WwwdOXfD8oSJhA397/T3eiy3tvHq1jQyYjhDWS5xQIloIh3CJdNPuNDzyogUBRHUOpP5aIk34/Uzl0c5sEsyq8BD/zpzZQdeL8W4HvcJ1GlADKHQjOG0RWv2aZ38y3/YZUOVo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774003799; c=relaxed/simple; bh=PqdtBxyERndEosPDHbmI+GUBTlW7xb/TJgdAmt5315U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TuY7jjAUea0u1PGHlgA7gwQfZl+/jCahHR/E10QHsRZ5iT3yKI8H5X1PSIqnV3HgfvYiY5ywbeumN2DkE5uMEbJmTz2e5c/988Qo6x38EHpFSIiBJCE5d6P945GkE9oJ/dZRY+qFOlOiua/Y9bfzbEkYUMdwHbIVuXjIJ+rQx7E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i5bgaBFX; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i5bgaBFX" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-439b9b1900bso378717f8f.1 for ; Fri, 20 Mar 2026 03:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774003795; x=1774608595; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZKbe+TyX+B1VS7SJjwxdTR+wYHiyWXqHq9Z2tzEU/jk=; b=i5bgaBFXMp2eOUgrOECULRD2bDP5PqXyy5SD+BvHjCIq+XRPiz/htJHvzAO15gqslF 77RHptLZedmsFCgiNdzx1QZ8y/+5cRWs+K2uP+cC30p0vq/hP/fqWYkaK/troFfKhGvQ nw2fEWu8LSG545vHqMycnfF3QhJkn9Gw5IFIDMEGLLH3H/95CnV1EGm4AdIL/OV743vh b+uYWvu71rNT2TK1xVTXw/sxrSykd2usPlVEsVdvAxeO3wlwLh9se4Qj0EUALS6iK+BM K+NwtzutluRfH/649VgEbj46GY+FrZS8NGBfoLpcxQgK+vP1Wdb1RkFimhytAufkXIp9 KRRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774003795; x=1774608595; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZKbe+TyX+B1VS7SJjwxdTR+wYHiyWXqHq9Z2tzEU/jk=; b=cL124be0BsxChMuL3r7EfKaZEo53AUJ7d2Z/FStmJYMBWXUcEDieDAOozLE2+mnDFl 2Lctuxrajm2yy/G3sUh39fq8NNU10S9T28DTVtL0e2WMItlqYyAoJ9X44EJe7xZjvZVZ Ejg3rKuI+e0SpJ3ycb203KVe6IhqRbIklp7k72aQX5bCqNpmHyLlmjfCXXalA1waFPaT 57ZKjhQypPgBMYKUoDimORiKepFI71ZlJpawx8q5/onZWDRu7zAOtoxt20eJqTHhGeBx cEyBnYbb/xoxLrrlubBkLPHUcxE4gz/fL7GekZoACFGFAQMngt4g4uFp3X8BzTq5WsXI RaUA== X-Forwarded-Encrypted: i=1; AJvYcCU5nv76q5FJ1xItkUIf4MAAfeat8e6cqcHBInSYjnRgS6KF5n5eneZ5lYUf27ta1zofCswMU9YyGup4mOY=@vger.kernel.org X-Gm-Message-State: AOJu0YwW3sYHxs7OTk7LTJ3JzuKe2CQyLTkngW5JkmCz+RzqIxmo2lHu Wq3Sqoe8DtYIMPTU5WzmyQHrkgY4dy0YXB4kuAZbYL+uaNcvw0oA4VfI X-Gm-Gg: ATEYQzyHrC3bGC2vinmY0/KE0AS5i2YMUegttpU82tXQ5YzAMK0lyjDIlenOwLMRa/M goUlx4bu8Q4J+ZSKyZCOaHPLFQ7hKLdeckltvQuHTSQFVIZWcyIKBhUR9LwVpQlmMHOui8GSZaS H4Y1RmqKzGV7heAiHMknVp5+phHjmcApLfgBvRv8vZfs+WwxURsUTgih3l3RSfWwhIKpRvZvO0Q R5wQD5XkUmVuHgGJ5LsAwGVSFxoZnMZ167mJAI24zfni8xnni23qMorB5qPSjYgJg2DFE+qc38z 2HehPgZdyEqaInPGrd1flRwLOPlA+Qez4SWgQPqnXemHs7OP065FhlMEuzfX4jBA1KdW7e62I8s NUJucP251eiMCF8ESUhrtaZKnwY54dr1EjS5SVGHn8UcTxTNUyPX1qYEwTYu4eT7Zyi3MAIoEAc nCZrSKp4T/7I//QFiVaOCyCoNVTfKiG5g= X-Received: by 2002:a5d:588f:0:b0:439:b3a3:7239 with SMTP id ffacd0b85a97d-43b6423fb3dmr4617157f8f.5.1774003794609; Fri, 20 Mar 2026 03:49:54 -0700 (PDT) Received: from biju.lan ([2a00:23c4:a758:8a01:5b93:d2b1:bc5c:9231]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b644ae619sm6203062f8f.5.2026.03.20.03.49.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 03:49:54 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Biju Das , linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar Mahadev Lad , Biju Das Subject: [PATCH v7 04/10] clk: renesas: rzg2l-cpg: Add rzg2l_mod_clock_init_mstop_helper() Date: Fri, 20 Mar 2026 10:49:38 +0000 Message-ID: <20260320104950.42220-5-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260320104950.42220-1-biju.das.jz@bp.renesas.com> References: <20260320104950.42220-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das Refactor the mstop initialisation logic in rzg2l_mod_clock_init_mstop() into a dedicated helper function rzg2l_mod_clock_init_mstop_helper(). This decouples the logic for setting module stop state on disabled clocks from the iteration loop, allowing it to be reused during resume to re-enable critical clocks. No functional change. Reviewed-by: Geert Uytterhoeven Signed-off-by: Biju Das --- v6->v7: * Collected tag v6: * New patch --- drivers/clk/renesas/rzg2l-cpg.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/clk/renesas/rzg2l-cpg.c b/drivers/clk/renesas/rzg2l-cp= g.c index f9e4af7f49d0..b68b0312f0e3 100644 --- a/drivers/clk/renesas/rzg2l-cpg.c +++ b/drivers/clk/renesas/rzg2l-cpg.c @@ -1586,6 +1586,20 @@ static struct mstop *rzg2l_mod_clock_get_mstop(struc= t rzg2l_cpg_priv *priv, u32 return NULL; } =20 +static void rzg2l_mod_clock_init_mstop_helper(struct rzg2l_cpg_priv *priv, + struct mod_clock *clk) +{ + /* + * Out of reset all modules are enabled. Set module state + * in case associated clocks are disabled at probe. Otherwise + * module is in invalid HW state. + */ + scoped_guard(spinlock_irqsave, &priv->rmw_lock) { + if (!rzg2l_mod_clock_is_enabled(&clk->hw)) + rzg2l_mod_clock_module_set_state(clk, true); + } +} + static void rzg2l_mod_clock_init_mstop(struct rzg2l_cpg_priv *priv) { struct mod_clock *clk; @@ -1595,15 +1609,7 @@ static void rzg2l_mod_clock_init_mstop(struct rzg2l_= cpg_priv *priv) if (!clk->mstop) continue; =20 - /* - * Out of reset all modules are enabled. Set module state - * in case associated clocks are disabled at probe. Otherwise - * module is in invalid HW state. - */ - scoped_guard(spinlock_irqsave, &priv->rmw_lock) { - if (!rzg2l_mod_clock_is_enabled(&clk->hw)) - rzg2l_mod_clock_module_set_state(clk, true); - } + rzg2l_mod_clock_init_mstop_helper(priv, clk); } } =20 --=20 2.43.0