From nobody Sat Apr 4 07:48:54 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ACA636EA88 for ; Fri, 20 Mar 2026 09:48:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774000119; cv=none; b=MXourSTCLuthy4vZe2Uy4A7PlkjGYf9/nMrIKU9G/SqwSHrM2EzPNVdZJhT33t9g/dvpk6PfMuykmAUsnByR3XxFsp5afXMVYgCqw2FXTLGcp7W2l9mVvIfLJ2CYek4InV81fT5TDQA0O4sh5/2ylMSj1rnhUrv+7GVQ3mHf9rU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774000119; c=relaxed/simple; bh=rR4613r473/GpReOQF2c0gi0wcNrtyOYb4RtpDOv59Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kPo/3yPhBm2/2j5P5S4+MEwJY3VxLXxXMxcDOOvz4wEDiysBmKxUGISlEzLxXLVPHYwGy7FGrVcsovv/BQYqJSK0OzBwl5K+ZVC7KU+9yTXGM+GqQFm+t4VfRunqxJHG1WKZyIoy23IiSA9xtAF8pgqHtMZwxkDF6xHXZvIzJrU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SgfXFlFM; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SgfXFlFM" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4852c9b4158so13117255e9.0 for ; Fri, 20 Mar 2026 02:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774000117; x=1774604917; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UkCbhWRAULtVVKzFWTVsQsIFodMYtCVdUKkMxRtDx4o=; b=SgfXFlFM3REO9PDsdd9Kc9FfC6g0jU99UOZNYti3MODl2Rnr1jnvTq+mWJgu3v2JcY f8U9nv3+VfbzeE89GgjZ06aPUUIaHxTIGGTUz9jtpSe3Tm2jsr7bcwvsTJOv6LOAo9Rt dpnP2SgWjneFXOx7BEH/JJ3PeoDWIm4ylgyjfTQjwcl/v/FduLarhWkSrkKYo77a0lDQ i2OT05cspr06rU6cRumlW1RXLdCb3Jzmdbk7QECuwEZWcsRldbXWP0Nqx1Q7sAv/12aD K5oGNT1jVqP/+7MqYveCDrZ6Phc+mzMlGof7xkn5f1TwhkFj1qVDppZIrKZ8nhdLQT1w qGdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774000117; x=1774604917; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UkCbhWRAULtVVKzFWTVsQsIFodMYtCVdUKkMxRtDx4o=; b=J5LIrcY8bbUqEzOeweWzhKnsqeun7kWTawsodHJFDETioFy5INY5QvRorUVfKzrkFl cN8PY9MhK75PvcECghJAxjmNyA5Pqn16ySskt4U1sl/HoMKxeMNBh/G7Kj2LrzstL2QS 2xgH8Vf5MUKr5EmHgGCRkKg4kFdXrlfDjmRryH+I26Dct6a3bS6w4hVbYtJ6YR9wDBHq B9M4e+itZ1LsXsJmTWKGDQoPnycW84D+EE6HvAWI9xIer47wzU8fW0OdBvmmuYibOzRS +tM9zpH0zLDqaf1P1u358yDE408SSdLD2UzWip7k87DIdQiUfv7+lk5CYr4le0BPpxjG ETCw== X-Forwarded-Encrypted: i=1; AJvYcCX7tBFgM+nlXbKvFyWsMi3A787Nr4AyrTQcKoqJdEaYP5g5JhZh5etqCUROhE+JOxCFOqJ3K31hkX74GDM=@vger.kernel.org X-Gm-Message-State: AOJu0YyAmCAt8e+EZbnLIdrqN/pfRQa6WPZ8IacwR20CxvxLZ+2CSskg W9dAXRFHQY0Ri5b914wAKMT+0Tr81cExwFHcrbN4N0EMaDZaCHGw3ZvC X-Gm-Gg: ATEYQzzwZ+Qx0n8Ozntjwo9y3NFOt+XWy3gplYUnQOn7iWaQhdHTTBn1U5mLiHEnCMa nTpkKLPxNYUjfaXAhBKf5n0j9WTV2hwCRNtDIwYmsseEYQKZfOGEvnDJHbgnOgxwAxzq04S7mfp eAWQAyMzH5hb0q5+tylOei8iGjc2SX3yjuGiOncc5tGyBWAl04/cH1LkT8UgpITNFvu9zU7p8xO kfg1zufqMxhBLyq1Va5TbnImPpI6ojMX36kTyLrMy+Kp8dJPacQQjKyOCwJ6o5zcXNwWU6i03Sb DoMjIKcT9QEh4NdXhxxQst/Y1QBZtS6F/dggP4x8iIDs0Os3Lku9jx/CVnyjAQtAjkOKgu4vWjl BTEEDLwzHqCl/wWI4oB0AcRJyimlJe4EnDr56YppaAJrs9J5Qay4sMvs0YCSG0l/yY30TPLr+7X Os5IGpAH1r/+rT5sCsTPo3mmo= X-Received: by 2002:a05:600d:8401:b0:485:35a4:939f with SMTP id 5b1f17b1804b1-486fee297bcmr26183805e9.28.1774000116583; Fri, 20 Mar 2026 02:48:36 -0700 (PDT) Received: from potato ([31.176.170.248]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486ff118bb4sm19344325e9.2.2026.03.20.02.48.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 02:48:36 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH v2] staging: rtl8723bs: change error handling to use standard errno Date: Fri, 20 Mar 2026 10:48:24 +0100 Message-ID: <20260320094824.66349-1-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260320072951.54045-1-omer.e.idrissi@gmail.com> References: <20260320072951.54045-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace non-standard return values with descriptive linux kernel error codes in probe path. Also replace the variable name 'status' with 'ret' to be more consistent with other kernel code. Changes since v1: -- Replace -ENOMEM with -ENODEV for sdio_dvobj_init fail path Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 30 +++++++++++++------- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index d664e254912c..4c16c514ca39 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -345,38 +345,46 @@ static int rtw_drv_init( struct sdio_func *func, const struct sdio_device_id *id) { - int status =3D _FAIL; + int ret; struct adapter *if1 =3D NULL; struct dvobj_priv *dvobj; =20 dvobj =3D sdio_dvobj_init(func); - if (!dvobj) + if (!dvobj) { + ret =3D -ENODEV; goto exit; + } =20 if1 =3D rtw_sdio_if1_init(dvobj, id); - if (!if1) + if (!if1) { + ret =3D -ENOMEM; goto free_dvobj; + } =20 /* dev_alloc_name && register_netdev */ - status =3D rtw_drv_register_netdev(if1); - if (status !=3D _SUCCESS) + ret =3D rtw_drv_register_netdev(if1); + if (ret) { + ret =3D -EIO; goto free_if1; + } =20 - status =3D sdio_alloc_irq(dvobj); - if (status !=3D _SUCCESS) + ret =3D sdio_alloc_irq(dvobj); + if (ret) { + ret =3D -EIO; goto free_if1; + } =20 - status =3D _SUCCESS; + ret =3D _SUCCESS; =20 free_if1: - if (status !=3D _SUCCESS && if1) + if (ret !=3D _SUCCESS && if1) rtw_sdio_if1_deinit(if1); =20 free_dvobj: - if (status !=3D _SUCCESS) + if (ret !=3D _SUCCESS) sdio_dvobj_deinit(func); exit: - return status =3D=3D _SUCCESS ? 0 : -ENODEV; + return ret; } =20 static void rtw_dev_remove(struct sdio_func *func) --=20 2.51.0