From nobody Mon Apr 6 09:25:57 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4103835F161 for ; Fri, 20 Mar 2026 07:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773991813; cv=none; b=MbXF2w7F5VyLhF62ASWox4B1xjKFIO77QY+U+4CJqFCBIlkeNw4+5fGryV4gk06foUy/iBnD2hMj0UsE58fZ6zw5zVGhWt7w/ja8wRkEOuUKZ7m/q3KOhnBX8sjuJVaOp9M2OEYrgZ+xBggxD8ee6M3wDyKFYDJXFlJcOgBTuQs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773991813; c=relaxed/simple; bh=2s+3JUKVwXs//qhUZDX+kepxYgNIL2IFkq8qjI+6j0Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cU94shyXPHAnSej8kU92hnEjKpe7SJx5bEGVdBjCu0g6INr8uWoZyKirXJaTHQRPyNUzqBWUGI+wiA1jbECsZLPweWJT4kc8QTl8o2Dcy0CyZ64utYH+G/p+slTxdxPbYEJ45xx09C9/HI8cjudJh6zkStgxTEacZd4R/01vKHY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZvTBuSUJ; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZvTBuSUJ" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-486fd3a577eso2232275e9.1 for ; Fri, 20 Mar 2026 00:30:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773991810; x=1774596610; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=W45HpX5niuHro12lOKLPgOnlXJW5x1S152G0+z7gMOg=; b=ZvTBuSUJAVO3oGTUYpE5uvKALvcN3BfnCx33zJZBFgKYhMuaTvTQLdqjuthuxNcKmy h9rlW1WquChQHQBlHWLGv+Q9PN2wSqCiinnsJ8W6/0PQd67FSVR4Y/mxQe1a3TsVAgpK Xe6qxizCClXBvECxbfEfifV9JHHQ2cKU++QqtM2YsdEiiHGpG/oqmrMTumFn4LXLAZ6O WO7TM4/r/8m5aZom2e8gy4AC9DVCC1dLiZW/gFzLADiXs/jTwouu9/cqxDPAbSww/CTP /aMPkG0IJ2DweU4vc8rOR4IjtvHD5vQo9j6CIiKN3NCmjiNeoHivj3W23MUQOCenX6JG CwRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773991810; x=1774596610; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=W45HpX5niuHro12lOKLPgOnlXJW5x1S152G0+z7gMOg=; b=U3xKc9Z8nQxBl6wGzf41bIsnJ9rxQaD3xIOsJ9aXIF4S1VSjEZ1Db/1NMxbas6GBJV ZHIllA3pgXqy27NMVePAgQ/944zPHuM2dIhzcR0r6LkNK/ZxpXgKCMsXbYFsUNeSil2V +KQEGcLr83LBJ/Q5D6tlOdM1uGH9ovFG3Ndhn++ndOE3Um0Z13kIYTLdH5L71XaOAGiu dPbPL9VzCoQJs2wMpD5ekg+khs6gkDzbf3FoTgYiaH50UxiTYmgkvBLp9r5u7oqzEZ31 llwHJsOmtsuztbGgX94qBG3wiScoKTy6jm2OmsEkX+GbRIG0k9xdPyGIxYs20QWjIbEk xSvg== X-Forwarded-Encrypted: i=1; AJvYcCXN4AnoY0RBvMhxyoNeFNDvcrz0301nSMaSpW4WB1vobTFLoibW/oFnbuCAtym0Y14/S/mDVV1AblZmydc=@vger.kernel.org X-Gm-Message-State: AOJu0YxPE8LVG4g3G/y8EYQ6yODLp/ILG+M56iIlK597sZ1QBF9M6Y2b ZuXTujkrpPPojjT/w1NksgyJW3TabFcebmPUi5baicyH4zE9T7m3XNyX X-Gm-Gg: ATEYQzxc53hpQ2Kz7GWRmQZXgQa7OEsvtqxsQeZgOd2oUww3ZRlZyjVENwodXFY6Kvf CQCE8LtgtRZbly3UMWAVw6Bw5WkYO6HhUliZiVjpOT1mJl9BQEXEFRSwG3Z5iqfHdgY+OYHDu10 c0DRUrTHMCBi9c+0/lqB/i+UHhrrTpI3uUJpTZ2EkTKp/ea3rp0d3HbIzXdK29iQL7+rnLRHdep DEXrHW0/oXDzuBo7N9jUeQM9156BOO/VSRPqz88MzD+8pKJpUOWfpcFJ+JTRZd/DEVxcnM2CpZO GdKyYVmwkcLolmJNY1fuyC458zvQ8sQPGvQhgA41z1qBLrOyWlNml0KkHM1dALvb/+2Qy1vzGk7 U+gujUVdlYlSKjOViPX6GsJ3fAvXf3Qw0NNg+Fgcu0gxoOKl1HOtejc5EHaTVYLLQzY+K0HYfjL cJ5nuxNCEj02UCOx42TUqh1Hp4UTNFy6SZ+A== X-Received: by 2002:a05:600c:c167:b0:486:fc94:d8f2 with SMTP id 5b1f17b1804b1-486fedbc066mr28798995e9.14.1773991810423; Fri, 20 Mar 2026 00:30:10 -0700 (PDT) Received: from potato ([31.176.170.248]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe89e2b5sm11875105e9.13.2026.03.20.00.30.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 00:30:10 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH] [PATCH] staging: rtl8723bs: change error handling to use standard errno Date: Fri, 20 Mar 2026 08:29:50 +0100 Message-ID: <20260320072951.54045-1-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace non-standard return values with descriptive linux kernel error codes in probe path. Also replace the variable name 'status' with 'ret' to be more consistent with other kernel code Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 30 +++++++++++++------- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index d664e254912c..ff0ebcb59c68 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -345,38 +345,46 @@ static int rtw_drv_init( struct sdio_func *func, const struct sdio_device_id *id) { - int status =3D _FAIL; + int ret; struct adapter *if1 =3D NULL; struct dvobj_priv *dvobj; =20 dvobj =3D sdio_dvobj_init(func); - if (!dvobj) + if (!dvobj) { + ret =3D -ENOMEM; goto exit; + } =20 if1 =3D rtw_sdio_if1_init(dvobj, id); - if (!if1) + if (!if1) { + ret =3D -ENOMEM; goto free_dvobj; + } =20 /* dev_alloc_name && register_netdev */ - status =3D rtw_drv_register_netdev(if1); - if (status !=3D _SUCCESS) + ret =3D rtw_drv_register_netdev(if1); + if (ret) { + ret =3D -EIO; goto free_if1; + } =20 - status =3D sdio_alloc_irq(dvobj); - if (status !=3D _SUCCESS) + ret =3D sdio_alloc_irq(dvobj); + if (ret) { + ret =3D -EIO; goto free_if1; + } =20 - status =3D _SUCCESS; + ret =3D _SUCCESS; =20 free_if1: - if (status !=3D _SUCCESS && if1) + if (ret !=3D _SUCCESS && if1) rtw_sdio_if1_deinit(if1); =20 free_dvobj: - if (status !=3D _SUCCESS) + if (ret !=3D _SUCCESS) sdio_dvobj_deinit(func); exit: - return status =3D=3D _SUCCESS ? 0 : -ENODEV; + return ret; } =20 static void rtw_dev_remove(struct sdio_func *func) --=20 2.51.0