From nobody Mon Apr 6 09:08:48 2026 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BE142472A6 for ; Fri, 20 Mar 2026 07:19:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773991145; cv=none; b=pXs+V0oqB04UcxHdtLH5XJ2F4WIJXaGiS8Vyx8XTY5rv76T16Asw8OCZ6h8GhQ3AvEmt3Urwb84p6pShOchBQ2XXHjnho9nTQjecLKeXaM4tTwo3UQbnpH11N/R4da7J8F4+5GMztJZ1lvKhbaQj6NbWgYEZod3z18+QBDnDCaE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773991145; c=relaxed/simple; bh=oHi3xT9LrOP0HbQ0Iy7BrowcVeMjdIQxJxdnmbUYn1U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=TnuD+Vh5CI9jgXT74im3+ymBsOYrEY9VqN59iTP4GS4350SbxBdn05k6MDfaWkYUqdIlELblT6HtaIpzvOrXgpFBmCeI/PhM1NsX8wivMgNWY4Un3BH0/zA4bcJ3GHbJX1LRxJ4d1IsKnOP5hh/R+oA8q43o40jx2c3hOnokOzA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fuYCoRrk; arc=none smtp.client-ip=209.85.128.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fuYCoRrk" Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-48557c8ad47so13439555e9.0 for ; Fri, 20 Mar 2026 00:19:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773991142; x=1774595942; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mkpT7FRro2B0nIIi8uBJzPYh9VjK5QgSvYEjTmCKl0Y=; b=fuYCoRrkAqT13XwauKv959ovlHA9G8mB/xhDNpNhCLPI6rRsi5oYj/1pGiAN4MSd9i ePq03DKM67olsFJjhazOjDpR4Vp10Si8WwdxbAQ0LYv6u8j+97nBbKpuVDD6ZDA6sMqZ /doJcYwDp3cGh2aBUJj6wI3nIsbN8FQbyJMpFByoWzdV89OBmvqsKBLtSGlBbUFLI7ma sCXOJJ0MkoA+EorzF7AT7EgMvjvGi7kMkeZO9cfqWJCJ9IsAkO3eEl2BV4nH4lMwd8WV sKU/bXq//jvzC0n6cqww9hGaD6fvDj3fUlb6e5S+Ze6z1AYPKhaYy/K/hOk9Ub2USNef M3rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773991142; x=1774595942; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mkpT7FRro2B0nIIi8uBJzPYh9VjK5QgSvYEjTmCKl0Y=; b=q9Tc241Rmc0CgNTG/fbEuemp8DCOymkBQbZHirCnkIVTwDGK4czHhbY0JlTYjEybJY tzJdSF2bjL/A9kjo4hTC+iaqaOnTPEtcEs5J8oaSLpFwdgrWUiscenCwWyPObZEdfCW+ o1rGA6hUZtLSE8DpxfePmXtP9hW3Z6nTxFUiTxLASTMdI6WlCaOt2PcEDA35MvCwC+bb Llt5YdpXh5KPfS+SBQd+HKe3w9oHUafgh4+B50y365ITXKG+mBZ1MN5k8NjEV7A7VFvX bAhKqD5u0Fp4LPHQM87nftxLRLqYY1ZEu0cOe+1ZwmIxXDWEvaFEjXucvovz9BjjiWeI g/ZQ== X-Forwarded-Encrypted: i=1; AJvYcCX2zaPb1TDdFIT4558ro2qx1iwcV6uPWDlpYYM0IonPw8YqW+eLRQQkUIRjXJJTaBmbK4of1I9xxrl/yrA=@vger.kernel.org X-Gm-Message-State: AOJu0YwBA1YLQPPwhpjVEBJgZzVN4+KuNkFMu8pe3bx9Ip5cDIHFpfsx B7R8CssuAdOlddEFumnf6DNudO2b/ntELED1U5RhlZ9EALXzjSJJPVCo X-Gm-Gg: ATEYQzyqN/clsPbJmU8Vi9bVTzMGEAfm14una8N9xJFe63jeBwrBwQe1CoH3vOKWGIh 4OLJXlyB0XzQEsRZI0Ujz//oT1eRLXV9o1Uqhi0AIsET8xMKR607x+7YACoLOjKPUs5Ef8Kaz/5 gdsIj02pOXN2qB70D1H8g370eMwzCoyS3oJspooY2f26LodwT9xDmhNn41eHs5FTCxOnUOA3PgS MbD1f4OJ343NJLSu+fYLQHtaMJqr7C+PrnABCfjHycYVaTzqRPO6hDAmMyMz7htxRH2puP1bU7q X4qzq1f0KzK3aiP215XyvpunjBRNB61iu1QHP2LDO9vuCOL72LGyJG/PYFmg45sb2/jBzruycE1 ixLrvtiRNp5+u8+K0xg4D07JicypKayDNGJ8GhRwfZmdmyijB2Z4sz7ohDmKLPn8fUr8qodj2JM stauOYVptkUNPtD+qKrc3dPcfMeoQ= X-Received: by 2002:a05:600c:a4a:b0:485:4eaf:eb14 with SMTP id 5b1f17b1804b1-486fee0fbf6mr25951625e9.21.1773991141982; Fri, 20 Mar 2026 00:19:01 -0700 (PDT) Received: from bera-arch ([176.216.244.236]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe6d91fbsm41070205e9.3.2026.03.20.00.19.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 00:19:01 -0700 (PDT) From: =?UTF-8?q?Bera=20Y=C3=BCzl=C3=BC?= To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, andriy.shevchenko@linux.intel.com, ethantidmore06@gmail.com, hansg@kernel.org, Yeking@Red54.com, rayfraytech@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, =?UTF-8?q?Bera=20Y=C3=BCzl=C3=BC?= Subject: [PATCH] staging: rtl8723bs: remove copy function Date: Fri, 20 Mar 2026 10:18:31 +0300 Message-ID: <20260320071830.28713-2-b9788213@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable GetU1ByteIntegerFromStringInDecimal() is a copy of kstrtou8(). Remove its usages to kstrtou8() and check the return value. Signed-off-by: Bera Y=C3=BCzl=C3=BC Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/hal/hal_com.c | 19 ------------------- .../staging/rtl8723bs/hal/hal_com_phycfg.c | 14 ++++++++++---- drivers/staging/rtl8723bs/include/hal_com.h | 2 -- 3 files changed, 10 insertions(+), 25 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index 50370b14ce7c..4f4a430c9f87 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -751,25 +751,6 @@ void SetHalODMVar( } } =20 - -bool GetU1ByteIntegerFromStringInDecimal(char *Str, u8 *pInt) -{ - u16 i =3D 0; - *pInt =3D 0; - - while (Str[i] !=3D '\0') { - if (Str[i] >=3D '0' && Str[i] <=3D '9') { - *pInt *=3D 10; - *pInt +=3D (Str[i] - '0'); - } else - return false; - - ++i; - } - - return true; -} - void rtw_hal_check_rxfifo_full(struct adapter *adapter) { /* switch counter to RX fifo */ diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/stagi= ng/rtl8723bs/hal/hal_com_phycfg.c index bdd595a99b98..447b72954804 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c @@ -816,11 +816,17 @@ void PHY_SetTxPowerLimit( ) { struct hal_com_data *pHalData =3D GET_HAL_DATA(Adapter); - u8 regulation =3D 0, bandwidth =3D 0, rateSection =3D 0, channel; - s8 powerLimit =3D 0, prevPowerLimit, channelIndex; + u8 regulation =3D 0, bandwidth =3D 0, rateSection =3D 0, channel, powerLi= mit; + s8 prevPowerLimit, channelIndex; + int ret; =20 - GetU1ByteIntegerFromStringInDecimal((s8 *)Channel, &channel); - GetU1ByteIntegerFromStringInDecimal((s8 *)PowerLimit, &powerLimit); + ret =3D kstrtou8((const char *)Channel, 10, &channel); + if (ret) + return; + + ret =3D kstrtou8((const char *)PowerLimit, 10, &powerLimit); + if (ret) + return; =20 powerLimit =3D powerLimit > MAX_POWER_INDEX ? MAX_POWER_INDEX : powerLimi= t; =20 diff --git a/drivers/staging/rtl8723bs/include/hal_com.h b/drivers/staging/= rtl8723bs/include/hal_com.h index 483f0390addc..7c67fee148fa 100644 --- a/drivers/staging/rtl8723bs/include/hal_com.h +++ b/drivers/staging/rtl8723bs/include/hal_com.h @@ -141,8 +141,6 @@ void rtw_hal_check_rxfifo_full(struct adapter *adapter); u8 GetHalDefVar(struct adapter *adapter, enum hal_def_variable variable, void *value); =20 -bool GetU1ByteIntegerFromStringInDecimal(char *str, u8 *in); - #define HWSET_MAX_SIZE 512 =20 void rtw_bb_rf_gain_offset(struct adapter *padapter); --=20 2.53.0