From nobody Mon Apr 6 09:13:45 2026 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7AAE322B74 for ; Fri, 20 Mar 2026 06:49:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773989363; cv=none; b=kDkNXpUwBmG6TuTg+SEpnWzLHksKvK8rf7VLpflSZZlLDStBRZUeI487GJ5jtD2+/ErKr746iR75S5ZrKItROIumTwyBUuiWwLe/luO+/G2Bivv/UF1qmGsSwJwcqS6bRQmQb0+4uaIJfWklAoJjULOz31g/B2rSDP+EAnt1ohA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773989363; c=relaxed/simple; bh=3K4b4813pw2F/OddIRzlH5bDVOqG6rJEOYy+6OhnOoY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=e/xdmkxk9xGPivXkSu/xHmyFz/X57Bns+Ag3TsqaiDyAn2LqZad4qtAOCGDG3Jzsmela514NUGm7P18c8F/55kGzYVyvc4eCAP8dMBWliYM4Gbi25wQTgqOkrr02hOQI4mCSIPnXVs8pSJldVchG6DlUOWmI62JQp3Mq0+gczxM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost (unknown [124.16.138.129]) by APP-01 (Coremail) with SMTP id qwCowADnjWnp7bxpJtGUCg--.24083S2; Fri, 20 Mar 2026 14:49:13 +0800 (CST) From: Chen Ni To: vkoul@kernel.org Cc: neil.armstrong@linaro.org, luyulin@eswincomputing.com, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Chen Ni Subject: [PATCH] phy: eswin: Fix incorrect error check for devm_ioremap() Date: Fri, 20 Mar 2026 14:45:15 +0800 Message-Id: <20260320064515.412360-1-nichen@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowADnjWnp7bxpJtGUCg--.24083S2 X-Coremail-Antispam: 1UD129KBjvdXoW7XF4ruFWrXF17GF13GF1xXwb_yoWDtrb_Cw 1rZrn3JrWDCF4q9r1jywsxZFWjyF90gr9rWws2y3sxA34UGr4akFyIvrnxW39ruw4rGryD C34DZFy3ury7WjkaLaAFLSUrUUUUbb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbs8FF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s 0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkF7I0En4kS14v26r12 6r1DMxkIecxEwVAFwVW8AwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8Jw C20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAF wI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjx v20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2 jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43 ZEXa7VUUJUUUUUUUU== X-CM-SenderInfo: xqlfxv3q6l2u1dvotugofq/ Content-Type: text/plain; charset="utf-8" Check devm_ioremap() return value for NULL instead of ERR_PTR and return -ENOMEM on failure. devm_ioremap() never returns ERR_PTR, using IS_ERR() skips the error path and may cause a NULL pointer dereference. Fixes: 67ee9ccaa34a ("phy: eswin: Create eswin directory and add EIC7700 SA= TA PHY driver") Signed-off-by: Chen Ni --- drivers/phy/eswin/phy-eic7700-sata.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/eswin/phy-eic7700-sata.c b/drivers/phy/eswin/phy-e= ic7700-sata.c index c33653d48daa..76774b9e391b 100644 --- a/drivers/phy/eswin/phy-eic7700-sata.c +++ b/drivers/phy/eswin/phy-eic7700-sata.c @@ -216,8 +216,8 @@ static int eic7700_sata_phy_probe(struct platform_devic= e *pdev) return -ENOENT; =20 regs =3D devm_ioremap(dev, res->start, resource_size(res)); - if (IS_ERR(regs)) - return PTR_ERR(regs); + if (!regs) + return -ENOMEM; =20 sata_phy->regmap =3D devm_regmap_init_mmio (dev, regs, &eic7700_sata_phy_regmap_config); --=20 2.25.1