From nobody Thu Apr 2 20:28:06 2026 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EA89283FD4 for ; Fri, 20 Mar 2026 06:09:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773986977; cv=none; b=FTh/yfQ8tBw6YfH0VFL0cZJ3Ads7dYiO0ba84d9YN448fmz3L88MUq9nCEgJjMnHH9YRUWj5KFemScIgz4Yf7clZ8N0VxC8PMJrk0ZVU92g/Qjd/WlVC/vt18UW7fc08iP0gRt61vatFwa6vgEq4Gh/Zss08vjDUQIh4aPE51ZI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773986977; c=relaxed/simple; bh=7gZTYvCYms6JLg4kbg3LMUFIljecloyM93oJfeULTjg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lEXpCByUBf1tc443d8DlJ2ih6tWBOGxRpFf/o25x8bh/g9YPnZVmvYGm7Z05I4Llcq+nIvjXsl9FOxg+Ztu3w8DQ3ftUihr1zx80O3LdBqFNsrChI0p5YbJlwZJOMFWKz5bgrxCfAY1H+bFSY6DCs8Z5X+L6GiG2xaiVyXGSs6Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=mv9+d/VP; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="mv9+d/VP" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1773986974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YQcMr+CuWLq8RG6gUzwSk4dQyB0LcYdk73WHFDu273k=; b=mv9+d/VPBKfDjFilfhE2bHGIwTlmVmGbkIgFN/Cko7k8Xl3bn65yphgTHn2wmKf6ei+teN 3+nTV5Ry2i6xsSofmOLxzxGnYtDEfFSVV/w8UMpsU9VE7/oWJREOakoQDplur9X2xsMC4+ uxjSuJEsE2HXyTYvaLCTYclU/B3wZyo= From: sunliming@linux.dev To: song@kernel.org, yukuai@fnnas.com, akpm@linux-foundation.org Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, sunliming Subject: [PATCH RESEND v3 1/3] lib/raid6: Divide the raid6 algorithm selection process into two parts Date: Fri, 20 Mar 2026 14:07:48 +0800 Message-Id: <20260320060750.31334-2-sunliming@linux.dev> In-Reply-To: <20260320060750.31334-1-sunliming@linux.dev> References: <20260320060750.31334-1-sunliming@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: sunliming Divide the RAID6 algorithm selection process into two parts: fast selection and benchmark selection. To prepare for the asynchronous processing of the benchmark phase. Signed-off-by: sunliming --- lib/raid6/algos.c | 76 +++++++++++++++++++++++++++++++++-------------- 1 file changed, 54 insertions(+), 22 deletions(-) diff --git a/lib/raid6/algos.c b/lib/raid6/algos.c index 799e0e5eac26..c21e3ad99d97 100644 --- a/lib/raid6/algos.c +++ b/lib/raid6/algos.c @@ -152,8 +152,32 @@ static inline const struct raid6_recov_calls *raid6_ch= oose_recov(void) return best; } =20 -static inline const struct raid6_calls *raid6_choose_gen( - void *(*const dptrs)[RAID6_TEST_DISKS], const int disks) +/* Quick selection: select the highest priority valid algorithm. */ +static inline int raid6_choose_gen_fast(void) +{ + int ret =3D 0; + const struct raid6_calls *const *algo; + const struct raid6_calls *best =3D NULL; + + for (best =3D NULL, algo =3D raid6_algos; *algo; algo++) + if (!best || (*algo)->priority > best->priority) + if (!(*algo)->valid || (*algo)->valid()) + best =3D *algo; + + if (best) { + raid6_call =3D *best; + pr_info("raid6: skipped pq benchmark and selected %s\n", + best->name); + } else { + pr_err("raid6: No valid algorithm found even for fast selection!\n"); + ret =3D -EINVAL; + } + + return ret; +} + +static inline const struct raid6_calls *raid6_gen_benchmark( + void *(*const dptrs)[RAID6_TEST_DISKS], const int disks) { unsigned long perf, bestgenperf, j0, j1; int start =3D (disks>>1)-1, stop =3D disks-3; /* work on the second half = of the disks */ @@ -165,11 +189,6 @@ static inline const struct raid6_calls *raid6_choose_g= en( if ((*algo)->valid && !(*algo)->valid()) continue; =20 - if (!IS_ENABLED(CONFIG_RAID6_PQ_BENCHMARK)) { - best =3D *algo; - break; - } - perf =3D 0; =20 preempt_disable(); @@ -200,12 +219,6 @@ static inline const struct raid6_calls *raid6_choose_g= en( =20 raid6_call =3D *best; =20 - if (!IS_ENABLED(CONFIG_RAID6_PQ_BENCHMARK)) { - pr_info("raid6: skipped pq benchmark and selected %s\n", - best->name); - goto out; - } - pr_info("raid6: using algorithm %s gen() %ld MB/s\n", best->name, (bestgenperf * HZ * (disks - 2)) >> @@ -239,15 +252,13 @@ static inline const struct raid6_calls *raid6_choose_= gen( /* Try to pick the best algorithm */ /* This code uses the gfmul table as convenient data set to abuse */ =20 -int __init raid6_select_algo(void) +static int raid6_choose_gen_benmark(void) { const int disks =3D RAID6_TEST_DISKS; - const struct raid6_calls *gen_best; - const struct raid6_recov_calls *rec_best; char *disk_ptr, *p; void *dptrs[RAID6_TEST_DISKS]; - int i, cycle; + int i, cycle, ret =3D 0; =20 /* prepare the buffer and fill it circularly with gfmul table */ disk_ptr =3D (char *)__get_free_pages(GFP_KERNEL, RAID6_TEST_DISKS_ORDER); @@ -269,15 +280,36 @@ int __init raid6_select_algo(void) if ((disks - 2) * PAGE_SIZE % 65536) memcpy(p, raid6_gfmul, (disks - 2) * PAGE_SIZE % 65536); =20 - /* select raid gen_syndrome function */ - gen_best =3D raid6_choose_gen(&dptrs, disks); + gen_best =3D raid6_gen_benchmark(&dptrs, disks); + if (!gen_best) + ret =3D -EINVAL; + + free_pages((unsigned long)disk_ptr, RAID6_TEST_DISKS_ORDER); + + return ret; +} + +int __init raid6_select_algo(void) +{ + int ret =3D 0; + const struct raid6_recov_calls *rec_best =3D NULL; + + /* select raid gen_syndrome functions */ + if (!IS_ENABLED(CONFIG_RAID6_PQ_BENCHMARK)) + ret =3D raid6_choose_gen_fast(); + else + ret =3D raid6_choose_gen_benmark(); + + if (ret < 0) + goto out; =20 /* select raid recover functions */ rec_best =3D raid6_choose_recov(); + if (!rec_best) + ret =3D -EINVAL; =20 - free_pages((unsigned long)disk_ptr, RAID6_TEST_DISKS_ORDER); - - return gen_best && rec_best ? 0 : -EINVAL; +out: + return ret; } =20 static void raid6_exit(void) --=20 2.25.1 From nobody Thu Apr 2 20:28:06 2026 Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AF0526A0DD for ; Fri, 20 Mar 2026 06:10:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773987005; cv=none; b=KnIqGUvJI/D4AocPamg4ENCC4J5QqkZsdxtCHPYQNqpkPbR7HYATj7DHR7+C0NZwZ5itQQv87xHfsHJkWZduUWgohl+uoeb8CG72NzCWa27k/m6J6BDPmj7yf95GxJMuvqvjw059lDNu5TY1dwjxnUQVU6SrZDZw5ApHBB8jJ0M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773987005; c=relaxed/simple; bh=tRjI5SXiH5BCcAaQLg7tSNGUURQ24BdhEkmdLr7ZCZA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HBRuSMbzIENzhA96YTOYJ/lVdgwo9vJJo/R8/2Gp3Xv1e59l5EXucc2XR59ytKkljJBqSFYGcnaHxOfJ9/Ct2yPX9Q5ZsEIJja2aB4VINesyRu8Eo5MoyW2Q/toyxBprOWl8peH6Lt+WV6VZApKAgkZUfp4sJnmPhWrsta26yR0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=dI70HJUF; arc=none smtp.client-ip=95.215.58.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="dI70HJUF" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1773987002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FMLAU+TNwvgizddZfji1MH8+7sBrNmHxaW+imWLM8p4=; b=dI70HJUF+aKE/yOvRmZEP/VWL9g8EpaUK9tMVFQyuk3GoDrApdyQv0My/VoY3PBISH5Km8 dib4HBmlLKFwtOtj0WVWzDBJnJg17Q6BpBAYlUYtYTzHJlRIjbnlsfRFyKLIYIsACej0rK 04pBnTDCyxGOm+wiRe713vW0GmYgV0s= From: sunliming@linux.dev To: song@kernel.org, yukuai@fnnas.com, akpm@linux-foundation.org Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, sunliming Subject: [PATCH RESEND v3 2/3] lib/raid6: Optimizing the raid6_select_algo time through asynchronous processing Date: Fri, 20 Mar 2026 14:07:49 +0800 Message-Id: <20260320060750.31334-3-sunliming@linux.dev> In-Reply-To: <20260320060750.31334-1-sunliming@linux.dev> References: <20260320060750.31334-1-sunliming@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: sunliming Optimizing the raid6_select_algo time. In raid6_select_algo(), an raid6 gen algorithm is first selected quickly through synchronous processing, while the time-consuming process of selecting the optimal algorithm via benchmark= ing is handled asynchronously. This approach speeds up the overall startup time and ultimately ensures the selection of an optimal algorithm. Signed-off-by: sunliming --- lib/raid6/algos.c | 30 ++++++++++++++++++++---------- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/lib/raid6/algos.c b/lib/raid6/algos.c index c21e3ad99d97..b8b5515ac7a6 100644 --- a/lib/raid6/algos.c +++ b/lib/raid6/algos.c @@ -12,6 +12,7 @@ */ =20 #include +#include #ifndef __KERNEL__ #include #include @@ -166,7 +167,7 @@ static inline int raid6_choose_gen_fast(void) =20 if (best) { raid6_call =3D *best; - pr_info("raid6: skipped pq benchmark and selected %s\n", + pr_info("raid6: raid6: fast selected %s, async benchmark pending\n", best->name); } else { pr_err("raid6: No valid algorithm found even for fast selection!\n"); @@ -213,7 +214,7 @@ static inline const struct raid6_calls *raid6_gen_bench= mark( } =20 if (!best) { - pr_err("raid6: Yikes! No algorithm found!\n"); + pr_warn("raid6: async benchmark failed to find any algorithm\n"); goto out; } =20 @@ -289,24 +290,33 @@ static int raid6_choose_gen_benmark(void) return ret; } =20 +static struct work_struct raid6_benchmark_work; + +static void benchmark_work_func(struct work_struct *work) +{ + raid6_choose_gen_benmark(); +} + int __init raid6_select_algo(void) { int ret =3D 0; const struct raid6_recov_calls *rec_best =3D NULL; =20 - /* select raid gen_syndrome functions */ - if (!IS_ENABLED(CONFIG_RAID6_PQ_BENCHMARK)) - ret =3D raid6_choose_gen_fast(); - else - ret =3D raid6_choose_gen_benmark(); - + /* phase 1: synchronous fast selection generation algorithm */ + ret =3D raid6_choose_gen_fast(); if (ret < 0) goto out; =20 /* select raid recover functions */ rec_best =3D raid6_choose_recov(); - if (!rec_best) + if (!rec_best) { ret =3D -EINVAL; + goto out; + } + + /* phase 2: asynchronous performance benchmarking */ + INIT_WORK(&raid6_benchmark_work, benchmark_work_func); + schedule_work(&raid6_benchmark_work); =20 out: return ret; @@ -314,7 +324,7 @@ int __init raid6_select_algo(void) =20 static void raid6_exit(void) { - do { } while (0); + cancel_work_sync(&raid6_benchmark_work); } =20 subsys_initcall(raid6_select_algo); --=20 2.25.1 From nobody Thu Apr 2 20:28:06 2026 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9F8A27CCE0 for ; Fri, 20 Mar 2026 06:10:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773987057; cv=none; b=RksWgR4c3HoCs8ysJvRlNwgccxvgvN4mMXEtvETlmexSVmGmMOId8ZfqVAY4AC6zx3xECxteKnVmmNrI6dAjC3ywjhm6eJNDuQvQ0mXSsiRJoNCzi+IdFx8uWzMON4HGwFVOunlUvFAM6+sx5z11PexnZe8qsMV4eorV4kE84D0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773987057; c=relaxed/simple; bh=n7LgFgkZ88IJ/hMH3zs0Om6GScBtmFY7Jf38aF0UOq4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Cs+FFmoAXD9W/PjOX47f/FmTgzkXU5ID0mBn3GhnpLe5+xz+m3agQZNPXHHPGv4q9JuFot3VTSY2weNUYOLJicCmCIhA2NRB6IXQhianIAG8S8nc86H5xsgY1kTlEDWB30JRLbCmuCCdQoFaAPLDvi9gyZA3OQSsM5wOzQ2OvCk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=iTcs2gZW; arc=none smtp.client-ip=91.218.175.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="iTcs2gZW" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1773987053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fXo6H32cr3HG8t0LoC8JWMAyx4PWbzKReGAxpF5HxXc=; b=iTcs2gZWGg30DQ19g+aMeIVa15tlGyUlF6O0UtEHkz+rSn3KbmO9xj6wm9QQ6TrboNWBQB DOCcq0yTAVJOVTwOTlBvttNmuh/3pwJdzZXjBa6EV0RHmvHXRfQuJ9p82qzr9vyk+KBDxy J5ksEDfUC5SJNHuvyijrDZt4m5pEgOA= From: sunliming@linux.dev To: song@kernel.org, yukuai@fnnas.com, akpm@linux-foundation.org Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, sunliming Subject: [PATCH RESEND v3 3/3] lib/raid6: Delete the RAID6_PQ_BENCHMARK config Date: Fri, 20 Mar 2026 14:07:50 +0800 Message-Id: <20260320060750.31334-4-sunliming@linux.dev> In-Reply-To: <20260320060750.31334-1-sunliming@linux.dev> References: <20260320060750.31334-1-sunliming@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: sunliming Now RAID6 PQ functions is automatically choosed and the RAID6_PQ_BENCHMARK is not needed. Signed-off-by: sunliming --- include/linux/raid/pq.h | 3 --- lib/Kconfig | 8 -------- 2 files changed, 11 deletions(-) diff --git a/include/linux/raid/pq.h b/include/linux/raid/pq.h index 2467b3be15c9..6378ec4ae4ba 100644 --- a/include/linux/raid/pq.h +++ b/include/linux/raid/pq.h @@ -67,9 +67,6 @@ extern const char raid6_empty_zero_page[PAGE_SIZE]; #define MODULE_DESCRIPTION(desc) #define subsys_initcall(x) #define module_exit(x) - -#define IS_ENABLED(x) (x) -#define CONFIG_RAID6_PQ_BENCHMARK 1 #endif /* __KERNEL__ */ =20 /* Routine choices */ diff --git a/lib/Kconfig b/lib/Kconfig index 2923924bea78..841a0245a2c4 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -11,14 +11,6 @@ menu "Library routines" config RAID6_PQ tristate =20 -config RAID6_PQ_BENCHMARK - bool "Automatically choose fastest RAID6 PQ functions" - depends on RAID6_PQ - default y - help - Benchmark all available RAID6 PQ functions on init and choose the - fastest one. - config LINEAR_RANGES tristate =20 --=20 2.25.1