From nobody Mon Apr 6 09:09:52 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB2DA2D5C71; Fri, 20 Mar 2026 04:03:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773979434; cv=none; b=pFk/z82FOWJ4UvHXtoLzn6XUFDGAtbLlBiNTy5KkmWR8FOlo8QVq+XTrBn7HnJgd7SpB1K+/vsv/NiUoH+E8DM1dTGtlZ6GxHo9OF0jzqiwuYY9YQU1DFg95elgB5Un/nd/npUDSgb5fU9AWpY6W7zOoJPqUdD9ljr9qTB2tTkU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773979434; c=relaxed/simple; bh=92xLNYFXxkf133MqVUP+9mIohxfqEpXhSTZuPRD+mjg=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EU0osjskLnZreWyXJENmCENmYOvHU8oorez4YKjsDfFbrQ92ZJvK+Oj2++0+o1KRwvTSiWx8cSywhopLszf07KLl3hm3SfK4A3XYq0mF9ghgsiF8e4o3XS4L9OVa5UYYBijvLilZdIRSRba21es7c6Jj3AZ+7mJFchXphiy4/PY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=QXsAvh6U; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="QXsAvh6U" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773979433; x=1805515433; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=92xLNYFXxkf133MqVUP+9mIohxfqEpXhSTZuPRD+mjg=; b=QXsAvh6U9IJtP2WAavRVJ3mycbRNcJL7ffRZu1vzIpzpPgD/fOdLoAiK ze0eV2zYvz9jucXKMf2t+Z6SqQ4vo2OHiMHJ1qbnyvmt8qB2aOPCK1Zn9 o9rY3+qJmPCGy97TEG6XFiS6NdvzbPaioun3hJj7QCrH95URKSde5eYIy oS3PUESv1ejjuGqLaaZF0StEl5RzcRlD4+UlJYLxzLVUF/CG020bAo1Fi kUb4Zc8o5H3IxnRckMqOiIPfXS4UYM1ui0EgLhM5R5rZH5fKfqcAzdknA zOe35BH/T1kM1NTs+4tLnAUkt8IswcWYr0M1d12ByPZmBep7DLVjuEdPR g==; X-CSE-ConnectionGUID: H7YafZ6lRQ2GgD55sTj45g== X-CSE-MsgGUID: PV/QDRTHSVCZfcM6+HYTmQ== X-IronPort-AV: E=McAfee;i="6800,10657,11734"; a="85688493" X-IronPort-AV: E=Sophos;i="6.23,130,1770624000"; d="scan'208";a="85688493" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2026 21:03:51 -0700 X-CSE-ConnectionGUID: KFEIx0K4Qm+89YjcB5Cw8g== X-CSE-MsgGUID: CUxuvRD0Ty2IcTrS+HNrpQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,130,1770624000"; d="scan'208";a="227885198" Received: from ly-workstation.sh.intel.com ([10.239.182.64]) by fmviesa005.fm.intel.com with ESMTP; 19 Mar 2026 21:03:49 -0700 From: Yi Lai To: yi1.lai@intel.com, Alex Williamson , David Matlack , Shuah Khan , Baolu Lu , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] vfio: selftests: Fix iommufd compat mode __iommu_unmap() crash Date: Fri, 20 Mar 2026 12:03:21 +0800 Message-ID: <20260320040322.487429-2-yi1.lai@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260320040322.487429-1-yi1.lai@intel.com> References: <20260320040322.487429-1-yi1.lai@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When running vfio_dma_mapping_mmio_test in MODE_IOMMUFD_COMPAT* mode, the test crashes with "Test terminated unexpectedly by signal 11". The crash happens because: 1. __iommu_map() fails as expected for MMIO mappings in iommufd. Consequently, the region.link remains uninitialized. 2. The test proceeds to call __iommu_unmap(). 3. In iommufd compat mode, the kernel returns 0 for unmapping a non-existent range. 4. __iommu_unmap() calls list_del_init(®ion->link), dereferencing the uninitialized pointer. Fix this by explicitly initializing region.link using INIT_LIST_HEAD. Signed-off-by: Yi Lai --- tools/testing/selftests/vfio/vfio_dma_mapping_mmio_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/vfio/vfio_dma_mapping_mmio_test.c b/to= ols/testing/selftests/vfio/vfio_dma_mapping_mmio_test.c index 957a89ce7b3a..4f7ecdca0215 100644 --- a/tools/testing/selftests/vfio/vfio_dma_mapping_mmio_test.c +++ b/tools/testing/selftests/vfio/vfio_dma_mapping_mmio_test.c @@ -88,6 +88,7 @@ static void do_mmio_map_test(struct iommu *iommu, .vaddr =3D vaddr, .size =3D size, .iova =3D iova_allocator_alloc(iova_allocator, size), + .link =3D LIST_HEAD_INIT(region.link), }; =20 /* --=20 2.43.0 From nobody Mon Apr 6 09:09:52 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5E1A1C84A0; Fri, 20 Mar 2026 04:04:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773979444; cv=none; b=LpB2WNubPE6dhGExsYAuSX8vyQcmYRRZyJmV/z+8o6AGd30oBT7P2itO1OFxK12OR4AQ0UrI9XylZ80C/w4VrM9WuCpgPtSzcbSSiEax4eEQ7ocYCz+dzYammI495+K9wKZAiNKhEDnUJmeiDtRaIh70baZOtCJHu4Z655+WkOU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773979444; c=relaxed/simple; bh=v4TVmYNjh8hgyB2oT0oMALAa/nPVWHCpkQkwTtRx8MM=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C8x90ICSbFu5nn9v8w3xAYAkP0vo45ky1STg7pXb5vTZ7Z35JYc6lNELQoWT2epEdgSrS6dj1sp2RQJhSPLZrbTKAX8eA/OelBq+4WTGtZtdsd8AmhGTmIGQ2h2UulvUH5Ln1A6l+3DqDW8JmYmdhWMQeASGFpgaaJbg7MF/Z/s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=hgSJ+I+R; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="hgSJ+I+R" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773979443; x=1805515443; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=v4TVmYNjh8hgyB2oT0oMALAa/nPVWHCpkQkwTtRx8MM=; b=hgSJ+I+RZ1lf/RQpE5d/Wy5Aw0vYuLBjBxmXMlNjtoKt12RwQkNTg6m1 oZAgpsFe0dDKRjV4y2NLHzysqeP3KHxtpdUNWq1fcooUt8b83QqikqasT MBu0rrSFitLrbRDps/87I4+9yguWnyfMBkdjc3rN9mGgnvbki1xtV686A aDskTQFFYSRrWHNC5iKjVcdYPAeuB/5nRTa43VobBMQLS3VUDTDFINjUz 1c6BiXbsMGjEMQgF+2buAd10CYeBLFbMoN6kE/hJF+NOrvtUEIFe+PnoK CipjOFCyDNZZ5GBXtyU69dhxm2vlqdB73KqhsDIWPFvKg2bKpxnTVIMNb w==; X-CSE-ConnectionGUID: lOJ3TLwgTMafj3bZkQjQqQ== X-CSE-MsgGUID: pJ0xIAkyReeyJyDd+gOOKw== X-IronPort-AV: E=McAfee;i="6800,10657,11734"; a="85688513" X-IronPort-AV: E=Sophos;i="6.23,130,1770624000"; d="scan'208";a="85688513" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2026 21:04:02 -0700 X-CSE-ConnectionGUID: S/3gUPFRQaC96aL6d+iarw== X-CSE-MsgGUID: zVlsBHFCT/6HiKj3ED45/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,130,1770624000"; d="scan'208";a="227885221" Received: from ly-workstation.sh.intel.com ([10.239.182.64]) by fmviesa005.fm.intel.com with ESMTP; 19 Mar 2026 21:03:55 -0700 From: Yi Lai To: yi1.lai@intel.com, Alex Williamson , David Matlack , Shuah Khan , Baolu Lu , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] vfio: selftests: Align __iommu_unmap() check with iommufd compat mode Date: Fri, 20 Mar 2026 12:03:22 +0800 Message-ID: <20260320040322.487429-3-yi1.lai@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260320040322.487429-1-yi1.lai@intel.com> References: <20260320040322.487429-1-yi1.lai@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When __iommu_map() fails (as expected for MMIO in iommufd modes), the test proceeds to call __iommu_unmap() for cleanup. The behavior of unmapping a non-existent range differs between iommufd native and compat modes: - Native iommufd returns -ENOENT (failure). - Compat iommufd returns 0 (success), mimicking legacy VFIO behavior. The previous code asserted that __iommu_unmap() always fails, which caused test failures in compat mode. Fix this by checking the return value based on the iommufd mode. Signed-off-by: Yi Lai --- .../testing/selftests/vfio/vfio_dma_mapping_mmio_test.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/vfio/vfio_dma_mapping_mmio_test.c b/to= ols/testing/selftests/vfio/vfio_dma_mapping_mmio_test.c index 4f7ecdca0215..e6a2b2ff91f0 100644 --- a/tools/testing/selftests/vfio/vfio_dma_mapping_mmio_test.c +++ b/tools/testing/selftests/vfio/vfio_dma_mapping_mmio_test.c @@ -101,7 +101,14 @@ static void do_mmio_map_test(struct iommu *iommu, iommu_unmap(iommu, ®ion); } else { VFIO_ASSERT_NE(__iommu_map(iommu, ®ion), 0); - VFIO_ASSERT_NE(__iommu_unmap(iommu, ®ion, NULL), 0); + /* + * Native IOMMUFD returns -ENOENT and Compat IOMMUFD returns 0 + * for unmapping a non-existent range. + */ + if (!strcmp(iommu->mode->name, MODE_IOMMUFD)) + VFIO_ASSERT_NE(__iommu_unmap(iommu, ®ion, NULL), 0); + else + VFIO_ASSERT_EQ(__iommu_unmap(iommu, ®ion, NULL), 0); } } =20 --=20 2.43.0