From nobody Mon Apr 6 10:44:14 2026 Received: from mail-dl1-f51.google.com (mail-dl1-f51.google.com [74.125.82.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E0C12DF138 for ; Fri, 20 Mar 2026 01:25:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773969914; cv=none; b=N5xcbbQrcD5up+HhG54d3amVFDKWn0ltF0vZJaZ5lI8xa+e7KU9/+f+07Y9DBXyvYjlfuly5QppJhwntXbMb+J/5aUdQZsloeGW3OvgWZmX3K5HXambM3i60SUBf1n6eSb/KNeSsogiyhX8gqevcmP/DZdMuQ4lRh5X6j1rETu0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773969914; c=relaxed/simple; bh=tlKgbNIWgXjZ/slb5MPH0/mHqdsJA6vJ0LluTcLD1PQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=L6wtWU5Kjk9EQYBcJnGeYKqN2L6KJVu/AIlZjSmS4oRwfAaipivsiPuEJZf58JUXjBdXqimEywtNTj9EWJ8qwcodZTJtRZVqioXwdmAo2oLOK8p/wLtBy6nSVqdlSsoyrqS6dPt6+sMEp+QCMGuBGHXj5+zy2HhkoA7zx+oT2ak= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fomichev.me; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=74.125.82.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fomichev.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-dl1-f51.google.com with SMTP id a92af1059eb24-12732e6a123so2874785c88.1 for ; Thu, 19 Mar 2026 18:25:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773969910; x=1774574710; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IJxOxbLkNxTNWsN6hAmdg1mKxCY8QyUuCBIp5EpuSIA=; b=pGs50RYCkwtwSSP2BVrhm9EQTdJ9U7wXvnEkP4J2t61ekjA/SIfxYrxEeGZ4w1AaXa JP97ObPrZeAXbVLf1Z/aAQmLQ87K3KP/DUMzNiWeXnX1oJDjl0zEma88ggSsPpwLri30 3Df/XDIQJTTFRTE+uca1dfBy3dakFuCc2LKZcBtUv+bfnAw5fugpiWUNuffHOMRUH2S/ kdHJHXQwcbK0K+RVyJ+2TN/bmeA2MAZbF0nCGL09ldWLvOjWmxbUeUKumqOJ8UGjNcST DHdD3TZ4Pjjx5uz3nuk4U+olMdN/apAcD11yQl0ebRnDRxFXC6G/7/j82N23M7OVHf7H 5Dzw== X-Forwarded-Encrypted: i=1; AJvYcCWK8VWZTZakVizmqvKBOmILUYafXGjacCew9IVFfginy7WXgfMy3E8TGUwXt9VJZePKF0BCzdfjM1vCjKI=@vger.kernel.org X-Gm-Message-State: AOJu0YyCX+fHwQZrBGd1GpgbY7T2IwA1xqgMRryLQ44M0RR26/HhIOeH yphBPHMmoxKnYOiGVw0ea6lIi4abL340MoSdr1P5aOEPF2TfY00L65M= X-Gm-Gg: ATEYQzxQAJ9Ff20Kn3JoA8zf08KjZ1zEclKEMCeP841632AzqEukSS1gVX98NZWAQp2 x/AA5spDiwT5kZnvv8A1Ltvdbtyj0hPKmJ0V97LicTCygLPU/cgXS1+vRNK85z9TC9I/hrw8vWi eQxJ5k+VzJAY3ZiPt4BaRpqAXCs2T3z+XD32OYNO+jtZUO3BJr7yt9qF8cARNowVqqE+/Z5ywAc v+HlqYual38ecN6DEkvnCz2vMqrxvlsP5yCQDPfIR//a1YGXhWnnCYiTz/+nOFpOaA2R6FcPjiY 4bd3KqWHyO1Drmpof80rkcLDR1lPAYfHt/SG8N00COWoWcRRdy4SOaNQ8OerPeTqx5HrRljnrFO pDfLenXvJ+Scb6iss3wzWBcJVSvKBdRdw1Uj+vCrr0qI2UnX4eq7tNwNNHjsxHsJTVISTzwrOaP HSviWRrGrQv+MpvU6wpYePA1DcNKLW7XCR6kTePQWxjWYFs87M/cfBUsvTOjiThIK3JjFqXUnhD 80uUC7aMeOXxqoIgA== X-Received: by 2002:a05:7022:fa1:b0:123:2d38:929a with SMTP id a92af1059eb24-12a726f86c3mr611130c88.38.1773969909296; Thu, 19 Mar 2026 18:25:09 -0700 (PDT) Received: from localhost (c-76-102-12-149.hsd1.ca.comcast.net. [76.102.12.149]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b17a7c1sm1191627eec.7.2026.03.19.18.25.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 18:25:08 -0700 (PDT) From: Stanislav Fomichev To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org, andrew+netdev@lunn.ch, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com, alexanderduyck@fb.com, kernel-team@meta.com, johannes@sipsolutions.net, sd@queasysnail.net, jianbol@nvidia.com, dtatulea@nvidia.com, sdf@fomichev.me, mohsin.bashr@gmail.com, jacob.e.keller@intel.com, willemb@google.com, skhawaja@google.com, bestswngs@gmail.com, aleksandr.loktionov@intel.com, kees@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kselftest@vger.kernel.org, leon@kernel.org Subject: [PATCH net-next v3 05/13] fbnic: convert to ndo_set_rx_mode_async Date: Thu, 19 Mar 2026 18:24:53 -0700 Message-ID: <20260320012501.2033548-6-sdf@fomichev.me> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260320012501.2033548-1-sdf@fomichev.me> References: <20260320012501.2033548-1-sdf@fomichev.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert fbnic from ndo_set_rx_mode to ndo_set_rx_mode_async. The driver's __fbnic_set_rx_mode() now takes explicit uc/mc list parameters and uses __hw_addr_sync_dev() on the snapshots instead of __dev_uc_sync/__dev_mc_sync on the netdev directly. Update callers in fbnic_up, fbnic_fw_config_after_crash, fbnic_bmc_rpc_check and fbnic_set_mac to pass the real address lists calling __fbnic_set_rx_mode outside the async work path. Cc: Alexander Duyck Cc: kernel-team@meta.com Reviewed-by: Aleksandr Loktionov Signed-off-by: Stanislav Fomichev --- .../net/ethernet/meta/fbnic/fbnic_netdev.c | 20 ++++++++++++------- .../net/ethernet/meta/fbnic/fbnic_netdev.h | 4 +++- drivers/net/ethernet/meta/fbnic/fbnic_pci.c | 4 ++-- drivers/net/ethernet/meta/fbnic/fbnic_rpc.c | 2 +- 4 files changed, 19 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c b/drivers/net/e= thernet/meta/fbnic/fbnic_netdev.c index b4b396ca9bce..c406a3b56b37 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c @@ -183,7 +183,9 @@ static int fbnic_mc_unsync(struct net_device *netdev, c= onst unsigned char *addr) return ret; } =20 -void __fbnic_set_rx_mode(struct fbnic_dev *fbd) +void __fbnic_set_rx_mode(struct fbnic_dev *fbd, + struct netdev_hw_addr_list *uc, + struct netdev_hw_addr_list *mc) { bool uc_promisc =3D false, mc_promisc =3D false; struct net_device *netdev =3D fbd->netdev; @@ -213,10 +215,10 @@ void __fbnic_set_rx_mode(struct fbnic_dev *fbd) } =20 /* Synchronize unicast and multicast address lists */ - err =3D __dev_uc_sync(netdev, fbnic_uc_sync, fbnic_uc_unsync); + err =3D __hw_addr_sync_dev(uc, netdev, fbnic_uc_sync, fbnic_uc_unsync); if (err =3D=3D -ENOSPC) uc_promisc =3D true; - err =3D __dev_mc_sync(netdev, fbnic_mc_sync, fbnic_mc_unsync); + err =3D __hw_addr_sync_dev(mc, netdev, fbnic_mc_sync, fbnic_mc_unsync); if (err =3D=3D -ENOSPC) mc_promisc =3D true; =20 @@ -238,18 +240,21 @@ void __fbnic_set_rx_mode(struct fbnic_dev *fbd) fbnic_write_tce_tcam(fbd); } =20 -static void fbnic_set_rx_mode(struct net_device *netdev) +static void fbnic_set_rx_mode(struct net_device *netdev, + struct netdev_hw_addr_list *uc, + struct netdev_hw_addr_list *mc) { struct fbnic_net *fbn =3D netdev_priv(netdev); struct fbnic_dev *fbd =3D fbn->fbd; =20 /* No need to update the hardware if we are not running */ if (netif_running(netdev)) - __fbnic_set_rx_mode(fbd); + __fbnic_set_rx_mode(fbd, uc, mc); } =20 static int fbnic_set_mac(struct net_device *netdev, void *p) { + struct fbnic_net *fbn =3D netdev_priv(netdev); struct sockaddr *addr =3D p; =20 if (!is_valid_ether_addr(addr->sa_data)) @@ -257,7 +262,8 @@ static int fbnic_set_mac(struct net_device *netdev, voi= d *p) =20 eth_hw_addr_set(netdev, addr->sa_data); =20 - fbnic_set_rx_mode(netdev); + if (netif_running(netdev)) + __fbnic_set_rx_mode(fbn->fbd, &netdev->uc, &netdev->mc); =20 return 0; } @@ -551,7 +557,7 @@ static const struct net_device_ops fbnic_netdev_ops =3D= { .ndo_features_check =3D fbnic_features_check, .ndo_set_mac_address =3D fbnic_set_mac, .ndo_change_mtu =3D fbnic_change_mtu, - .ndo_set_rx_mode =3D fbnic_set_rx_mode, + .ndo_set_rx_mode_async =3D fbnic_set_rx_mode, .ndo_get_stats64 =3D fbnic_get_stats64, .ndo_bpf =3D fbnic_bpf, .ndo_hwtstamp_get =3D fbnic_hwtstamp_get, diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.h b/drivers/net/e= thernet/meta/fbnic/fbnic_netdev.h index 9129a658f8fa..eded20b0e9e4 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.h +++ b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.h @@ -97,7 +97,9 @@ void fbnic_time_init(struct fbnic_net *fbn); int fbnic_time_start(struct fbnic_net *fbn); void fbnic_time_stop(struct fbnic_net *fbn); =20 -void __fbnic_set_rx_mode(struct fbnic_dev *fbd); +void __fbnic_set_rx_mode(struct fbnic_dev *fbd, + struct netdev_hw_addr_list *uc, + struct netdev_hw_addr_list *mc); void fbnic_clear_rx_mode(struct fbnic_dev *fbd); =20 void fbnic_phylink_get_pauseparam(struct net_device *netdev, diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_pci.c b/drivers/net/ethe= rnet/meta/fbnic/fbnic_pci.c index e3aebbe3656d..6b139cf54256 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_pci.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_pci.c @@ -135,7 +135,7 @@ void fbnic_up(struct fbnic_net *fbn) =20 fbnic_rss_reinit_hw(fbn->fbd, fbn); =20 - __fbnic_set_rx_mode(fbn->fbd); + __fbnic_set_rx_mode(fbn->fbd, &fbn->netdev->uc, &fbn->netdev->mc); =20 /* Enable Tx/Rx processing */ fbnic_napi_enable(fbn); @@ -180,7 +180,7 @@ static int fbnic_fw_config_after_crash(struct fbnic_dev= *fbd) } =20 fbnic_rpc_reset_valid_entries(fbd); - __fbnic_set_rx_mode(fbd); + __fbnic_set_rx_mode(fbd, &fbd->netdev->uc, &fbd->netdev->mc); =20 return 0; } diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_rpc.c b/drivers/net/ethe= rnet/meta/fbnic/fbnic_rpc.c index 42a186db43ea..fe95b6f69646 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_rpc.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_rpc.c @@ -244,7 +244,7 @@ void fbnic_bmc_rpc_check(struct fbnic_dev *fbd) =20 if (fbd->fw_cap.need_bmc_tcam_reinit) { fbnic_bmc_rpc_init(fbd); - __fbnic_set_rx_mode(fbd); + __fbnic_set_rx_mode(fbd, &fbd->netdev->uc, &fbd->netdev->mc); fbd->fw_cap.need_bmc_tcam_reinit =3D false; } =20 --=20 2.53.0