From nobody Mon Apr 6 10:44:14 2026 Received: from mail-dl1-f50.google.com (mail-dl1-f50.google.com [74.125.82.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AB132C3255 for ; Fri, 20 Mar 2026 01:25:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773969921; cv=none; b=rOFuVrS7uYOY/JPfKZCesCiJ4ZNv1/H0hmKGa1LBs5Sc8+TW4ba1BGI3wcxQv26izhYe+ce9NW5V8J8qYw9ERWt3jQ3E/5A89Zu6sMhO1wHd4cLPAc+HnU+DOLtH16+ffbPa+IQ1Cs2tpam2egNb2+g0KmzFM65bgbK9Ocvacto= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773969921; c=relaxed/simple; bh=VK90M3+EGSzjVfsemFKOmNIILll+ZAdpTFJtqe6Y2Mo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xu33Xj9xTvy/nD32dVfSNDwrDM1jnKeJmYNvikgldCbbW8paBDxf5MbhBTb7FTZq7wiUQKHU1UMXEwJtHoyOYY5D6K/CJebIVGFsZHfmlT50RGzSk8IYwzrOxT+Zl8ihfWu8tS/P0DHEIQSx03VuDuAddy5gswEJlpLm+EddQQ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fomichev.me; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=74.125.82.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fomichev.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-dl1-f50.google.com with SMTP id a92af1059eb24-128b9b7e3edso2688606c88.0 for ; Thu, 19 Mar 2026 18:25:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773969918; x=1774574718; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LWBQoO52uK1jdWWUCzjHOfQ7E5wdgkDdRoNSlPpZPUc=; b=IVSZdm9F+gqSNN3R18LDPRBJWYM3GJa2mrlgAyML5HKJpWouRytwb88XMDwnjJil2Q DDIaq5cEtuI+wIaNh0RpWsKIEna1wIiS+z3s31+8pkbxdBBQfPlvJEaXur40GvlhoSjx Hd/7y2iiyX7h0jFuhiU2+ECC7MEvcaIh/F3ZUbfpEcItSV0pE1LmABenobpInwRawBxY ZM6jRZA0izk8eabjEKDUwMnkd6PHsA4c23Cqx9xGCcAIA7qvXtWCI8nSGlceHbtSkbWD jDhHhpJbo0WOb0gz5cKIlHKDAJAvR1CY+hXQzEsg6FrtClL+bRHy3OJNARtJl89ISiIc SV0A== X-Forwarded-Encrypted: i=1; AJvYcCXZoilfbaYMAha31oLs9lRkyjLnJt3Ltj6kGUn1qQOAX0z1DR3EUlBt03o+JUbUc0KZgokvTQW9kScEHeY=@vger.kernel.org X-Gm-Message-State: AOJu0YzZIzbkqyb6x3JpDFwhgGIJYPrznyg7vAnTI2pm6SoBFmYqoeB9 1opCiMk1zNROAJjKNmD23uccBj9WGXZJExb/zfKpmD3qE8m7wTpS1fc= X-Gm-Gg: ATEYQzwgWRSSZMH6wuJHXX9zTM4+QKFQJUSHLt+Cm21BKzSxkOOavNzgGPyHD3lSZtO jBFV7QwNOk/3HZ2ikdTJbAG1NpwFIJz4cSntfUMdd1Qkpe+EMnEchKsPk1ppHxjrab0hJZUl3l9 L56M9H72c/gowOUoZQ0GrTIjZf6hs7448SVV04pQ2AduLj5Eiw6iEgDocolO7h8r6HoXBVgMc54 w2DtCD6+hzRmNw0va4XJmDxFir24h1lYhN5yauvblYPWMU3V2kw3gm7N4CpsgCDYXwoJkeUhl4y aoxXCR9Bl4h6kQI/+ZAxIm7jJi16P/TT/lbfw+WQeUrHkDYU+3XUwLHQV+7xWr3HBp8UvKneOVs wUZOcjnbH3gStvcDixmoRDRoIQ/J8W7UgRGFyoCMBpzpQ+loI4BWgqviSAPUSm3yrts1jJnK53V gRrhVIG/q1Ouncuhx1meTP+O+QPLuBzijc2H7bjed0dAhZNIqZS74nskwPoDRfgGObIGHFzQsjk owr6vr7V19oyMh9dg== X-Received: by 2002:a05:7022:e08:b0:128:d737:d7a6 with SMTP id a92af1059eb24-12a7266cdddmr651698c88.3.1773969917836; Thu, 19 Mar 2026 18:25:17 -0700 (PDT) Received: from localhost (c-76-102-12-149.hsd1.ca.comcast.net. [76.102.12.149]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12a734bbbc5sm747251c88.11.2026.03.19.18.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 18:25:17 -0700 (PDT) From: Stanislav Fomichev To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org, andrew+netdev@lunn.ch, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com, alexanderduyck@fb.com, kernel-team@meta.com, johannes@sipsolutions.net, sd@queasysnail.net, jianbol@nvidia.com, dtatulea@nvidia.com, sdf@fomichev.me, mohsin.bashr@gmail.com, jacob.e.keller@intel.com, willemb@google.com, skhawaja@google.com, bestswngs@gmail.com, aleksandr.loktionov@intel.com, kees@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kselftest@vger.kernel.org, leon@kernel.org Subject: [PATCH net-next v3 12/13] net: warn ops-locked drivers still using ndo_set_rx_mode Date: Thu, 19 Mar 2026 18:25:00 -0700 Message-ID: <20260320012501.2033548-13-sdf@fomichev.me> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260320012501.2033548-1-sdf@fomichev.me> References: <20260320012501.2033548-1-sdf@fomichev.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Now that all in-tree ops-locked drivers have been converted to ndo_set_rx_mode_async, add a warning in register_netdevice to catch any remaining or newly added drivers that use ndo_set_rx_mode with ops locking. This ensures future driver authors are guided toward the async path. Also route ops-locked devices through dev_rx_mode_work even if they lack rx_mode NDOs, to ensure netdev_ops_assert_locked() does not fire on the legacy path where only RTNL is held. Signed-off-by: Stanislav Fomichev Reviewed-by: Aleksandr Loktionov --- net/core/dev.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index fc5c9b14faa0..f38ab254708b 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -9779,7 +9779,8 @@ void __dev_set_rx_mode(struct net_device *dev) if (!netif_up_and_present(dev)) return; =20 - if (ops->ndo_set_rx_mode_async || ops->ndo_change_rx_flags) { + if (ops->ndo_set_rx_mode_async || ops->ndo_change_rx_flags || + netdev_need_ops_lock(dev)) { queue_work(rx_mode_wq, &dev->rx_mode_work); return; } @@ -11471,6 +11472,11 @@ int register_netdevice(struct net_device *dev) goto err_uninit; } =20 + if (netdev_need_ops_lock(dev) && + dev->netdev_ops->ndo_set_rx_mode && + !dev->netdev_ops->ndo_set_rx_mode_async) + netdev_WARN(dev, "ops-locked drivers should use ndo_set_rx_mode_async\n"= ); + ret =3D netdev_do_alloc_pcpu_stats(dev); if (ret) goto err_uninit; --=20 2.53.0