From nobody Mon Apr 6 09:09:33 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B1692517AC for ; Fri, 20 Mar 2026 00:53:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773968038; cv=none; b=NXJZtP5udQqESIsdsnIYw0xgZsw64tt3o7JeVxYqGB+3LkhnraQYmgZfpC9Z/GQ+hwt8YLP4uROsrQDeb0S4/9WKS/mO9wULydmILxw/lz3OGcZWUEeG4FjY/M1l+1AHxZGEEng5e4ZTvlEUVrrFMq5bMXLl88gRoiGbNr7QCRg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773968038; c=relaxed/simple; bh=RPdS4yZ4aMDBpjdVYOmpeBtEsGxqKGyrHqi3ViirQf8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZnS2wTMAF9ygHk9XufMvi2vrJt+RvLMeUhvX/qEIuXyjXYCLEDKV37y35XGR3YrcRaxdcwh/lliSNqE4yoL5rZuxS+V26Cp5KfY6ptCEnbvOZo/3yq0I2bN4bxE1ix2UEHiMzkAe9hTq3dJYLm5/4gnyZmqSa4fUc5oOotvAd0U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MltemJ5g; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MltemJ5g" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-829a27414a3so83821b3a.3 for ; Thu, 19 Mar 2026 17:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773968037; x=1774572837; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dAZdaOpK8Tpotf92jIjh2hYipqpzhjyOHEd27w2pfAc=; b=MltemJ5gbKKHa0HoB43cnvFFPdGv/1GdmSki69ImFdn3JHvqkH3D54TekvpniIAtZD 8UWa2MKVk3xwErCmNQgReb7uKR9z8h5DIiE0o8sedgoZ3bibU8k9uB4DkDroVglcYvqp qO4JjSEfTi21NmJA0po7+OEH8RDidtD79tLQuM3M3VhJiUXhHLNQI2fmZW8Y2E0e54VK U0G0jvQwqGzNu/pfPHW77HOQfqhZBe2CnTUEwP4DW1qaJJZ8G2Yj3YNar6GAkNHnLbCo o5/m79LiA2M5sZX+QZ7sXIxoBHXulrhqkXviz5dBZD+TKGGDRqbr1V329xbZyNJOix/Q JqMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773968037; x=1774572837; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dAZdaOpK8Tpotf92jIjh2hYipqpzhjyOHEd27w2pfAc=; b=T8uq8kpp/KcNFwzztcycM/PCejRQPYYURUK/jpu/YuyIVCDvVWCXzpcT2SbrnoVdJC vXbP+ewbDdpan2YpeMyyop5F+gmOcDjnnCraFoHQodTKjL0RRZPwZ/IGgrhwWxM0pdrU ve86I7cdMzURkpxnfYx4waBSIpakT/sawLSOKr15UMIDi2h9KpZeRBxXQ6Fu7LcwglSZ GWE9jU2dlPEz7AneSjfuKx2czpHfyxGnz4fSfzHlKCshNx331A8p3F82E77gshlgnhQ/ EgvQ5WIBQ9p9wz4eI3OBOoYgHAiz3l177hghYxce+EIK4BlsrDJqPbhi8jwRu66yTR87 95Ew== X-Forwarded-Encrypted: i=1; AJvYcCXuQv1QJyAV4yY6fa38nTTfOa81/eFVTisAqACjhAr5+VnSF0P7RwEkric8Hw3JE8etRh8x9OCFHFVVHOU=@vger.kernel.org X-Gm-Message-State: AOJu0YwJR+iwMSXMdLCmZJb1tAHu0qgJ5MYvSPzpU7PmmwiciMEOs9it xSTGfh9jNtSAIFNB8DeNznImyApL+tzFQELxFTn+iicdzSlz6QAQOu9y X-Gm-Gg: ATEYQzw5sAPsXApessALbhFI3Kil87xHv0b7dAY8Cmem4G3w3eRkEhKXRQFdfBahoii tftlJj3dzfkGG34HHIkx/zVbgzHwGZUurSV8psFfw0Kd6anXC6UJam9IK46ZSq2iegTOaIGbCYK NZLXftX7lLJNR4p6eKn35Do74LuMStBdI2DovCHbzf3HavrVZmJIs5rnhc8MpgjxDKn9bzfCdED hCAVqKLJ3P7LDq8cG/hv7yVOAWhUduAXP8aHJ6P+4qvuyPmZ6zjz6zy5dD4xlv3uvxPV+4MGpAp 5e22Ia8TQ7ChADZcEKLuiT5Wp6r5nonZMTCU+1iXS8YcC6ttZ1grUFx539oM7eQO2g9HmUTQWC3 +e1bFjsP7HBgTuzEYeshWwjDKVORYSu2xOYl8AIMfzUakbqLrUuA9mRoSi9EYCFiPHYqbwKXggI vxlSuIIvKfxjRbLrrjwctyWJM2+HGBjdqty2Ub6LWqDO/Wu7UhslqeKfc= X-Received: by 2002:a05:6a20:7d9e:b0:39b:bee4:2954 with SMTP id adf61e73a8af0-39bcec29e21mr1068513637.63.1773968036651; Thu, 19 Mar 2026 17:53:56 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d::8bd]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c74665ca1f8sm435525a12.20.2026.03.19.17.53.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 17:53:56 -0700 (PDT) From: Rosen Penev To: linux-gpio@vger.kernel.org Cc: Hoan Tran , Linus Walleij , Bartosz Golaszewski , Kees Cook , "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org (open list), linux-hardening@vger.kernel.org (open list:KERNEL HARDENING (not covered by other areas):Keyword:\b__counted_by(_le|_be)?\b) Subject: [PATCH] gpio: dwapb: reduce allocation to single kzalloc Date: Thu, 19 Mar 2026 17:53:38 -0700 Message-ID: <20260320005338.30355-1-rosenp@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Instead of kzalloc + kcalloc, Combine the two using a flexible array member. Allows using __counted_by for extra runtime analysis. Move counting variable to right after allocation as required by __counted_by. Signed-off-by: Rosen Penev Reviewed-by: Linus Walleij --- drivers/gpio/gpio-dwapb.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c index 4986c465c9a8..15cebc8b5d66 100644 --- a/drivers/gpio/gpio-dwapb.c +++ b/drivers/gpio/gpio-dwapb.c @@ -75,8 +75,8 @@ struct dwapb_port_property { }; =20 struct dwapb_platform_data { - struct dwapb_port_property *properties; unsigned int nports; + struct dwapb_port_property properties[] __counted_by(nports); }; =20 /* Store GPIO context across system-wide suspend/resume transitions */ @@ -114,11 +114,11 @@ static inline struct dwapb_gpio *to_dwapb_gpio(struct= gpio_chip *gc) struct dwapb_gpio { struct device *dev; void __iomem *regs; - struct dwapb_gpio_port *ports; unsigned int nr_ports; unsigned int flags; struct reset_control *rst; struct clk_bulk_data clks[DWAPB_NR_CLOCKS]; + struct dwapb_gpio_port ports[] __counted_by(nr_ports); }; =20 static inline u32 gpio_reg_v2_convert(unsigned int offset) @@ -585,14 +585,10 @@ static struct dwapb_platform_data *dwapb_gpio_get_pda= ta(struct device *dev) if (nports =3D=3D 0) return ERR_PTR(-ENODEV); =20 - pdata =3D devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); + pdata =3D devm_kzalloc(dev, struct_size(pdata, properties, nports), GFP_K= ERNEL); if (!pdata) return ERR_PTR(-ENOMEM); =20 - pdata->properties =3D devm_kcalloc(dev, nports, sizeof(*pp), GFP_KERNEL); - if (!pdata->properties) - return ERR_PTR(-ENOMEM); - pdata->nports =3D nports; =20 i =3D 0; @@ -714,22 +710,17 @@ static int dwapb_gpio_probe(struct platform_device *p= dev) if (IS_ERR(pdata)) return PTR_ERR(pdata); =20 - gpio =3D devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL); + gpio =3D devm_kzalloc(&pdev->dev, struct_size(gpio, ports, pdata->nports)= , GFP_KERNEL); if (!gpio) return -ENOMEM; =20 - gpio->dev =3D &pdev->dev; gpio->nr_ports =3D pdata->nports; + gpio->dev =3D &pdev->dev; =20 err =3D dwapb_get_reset(gpio); if (err) return err; =20 - gpio->ports =3D devm_kcalloc(&pdev->dev, gpio->nr_ports, - sizeof(*gpio->ports), GFP_KERNEL); - if (!gpio->ports) - return -ENOMEM; - gpio->regs =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(gpio->regs)) return PTR_ERR(gpio->regs); --=20 2.53.0