From nobody Mon Apr 6 09:09:32 2026 Received: from mail-yx1-f51.google.com (mail-yx1-f51.google.com [74.125.224.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9194564 for ; Fri, 20 Mar 2026 00:20:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773966004; cv=none; b=LBDqiqZqTLviCPgy03A9aNqERlYbmstjehOFDywiK3zbdPXTy2zlSlvqhyHR/SQ5L7FvVqaV7PnKelNXX82VDPfzhxMd78sumJvTliNXKL9/aZ71rbWo60pNCWAUmuBF85KoYh+bUcJxylC1VAY/zn/0BxolKZUNgt6/QICYiaw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773966004; c=relaxed/simple; bh=gLQNx9glXF6hqM2kMDc3j1Sg/zalWdjszUK7zPegkZc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=c+5qjIbE6ZVcInZEvBiWpODMFrR1MJOdhlAw5KlmZ7XxuQGb0/AIEeqYx84QWYdVWAb0uYwXRcMyyUhq5J+WcetAyTWa4gbuIQ0dRdzYmlpt1dXIuskr/HfJE2Ka6NwtIruNMdOFJ3gdmrNcWyrDB9aXBBr8GZb26pt5EPrs6t8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gu2njmvg; arc=none smtp.client-ip=74.125.224.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gu2njmvg" Received: by mail-yx1-f51.google.com with SMTP id 956f58d0204a3-64c9707fc11so76397d50.2 for ; Thu, 19 Mar 2026 17:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773966002; x=1774570802; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MzlIIY7b66i4fIFyZ2+UWe+HudSTmQ+Ey/SWxXk4aRw=; b=gu2njmvgEsAawV6zbSZQTBlFW9Tn6B+EoIuPg+GFRNWx2lXiMTugyFJ98WLueKRYOq U1t3uhqrov/9fC7J/dKJBuDulMppWLDfJSBfruli01pk4MlsMCEh3BLAjhRvSY9ebMQp 1aAv17P1CuQV9ScWyVc7vC++djFBmzoR9Vn7nSvIpDtQYchbgOAMnsTVbx1nNkkJ45Km rviGOxnj9kR6nn4y8DK+l2kpgP81hiQRINugvGqOH3+r9wfuxhyTT6of+94m6ajmZ47s 4fSwiAN8pjda7X9NW2zR4zRKJVo0hY+pN+UbPPYRnr9nhgEEdYpabGbauLeLPuAbQiqq K5Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773966002; x=1774570802; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MzlIIY7b66i4fIFyZ2+UWe+HudSTmQ+Ey/SWxXk4aRw=; b=TKKBdZG3+hT5Nk81fntCYe3Lz03lr3pm3tbo47VcTh8MupVMTC/YnYxAERe3Dazjlc aHxchLBnxgyY56U9YviFyoKxOpyC9KRoFw+CFoGEmDdbv3pMz9KIQeEwwLUtNSBltlDy d3CvfS2CV6PqJZrjny701pITp1DlXgSy/ScfVV0IAvrYYENRngkZ/THB9LrsBktkmiie tLyE8fWWEHhnn9FK08syviu9BJOEsuGkRqOTuyOecuKrxYK5rTA8gRmH3zVwisUZg+bT k0ZaLgbHroQlRa/SP/XAtw+IZJrH1hq562zDm1+dwnEg7ot5tWROjwi5vC55OjnzEBiB 7+Jg== X-Forwarded-Encrypted: i=1; AJvYcCWdrrDFxx6tJiq2XuSre29SNzTpPwr6TUgH16cYqX189hUGeksiJrVbLip/QNK3aryE8VBs0skDJS+n5dc=@vger.kernel.org X-Gm-Message-State: AOJu0YwHtZE+6XKDeMb/Z90/rgZSXRUNMPETWxPvXt74C4Sp9jxNUxdi GPIZqhhDwYcmJWCwBGkfCo8/HN2Swwxz4YoGF79FhMXTcc65h0rmYHZx X-Gm-Gg: ATEYQzydl8W6SP6ppKFNxpk/dq3oBgxnevueHO6e2DLYdEDbjrAqjUhNCBIrUXtM2XZ h71j1q595vCEq5TPzmCqv6QZwqQhMOqQTRr/Y7mOfuj8xpl3icaDkp92iwrShMxAb8PlDr9e0Nv R9zZCDXKAR/r80IhgibbgNakyvE/UQlKDebdPb4iuVZBP1q74Xt1tdudRu/Jj9z+5zgpVE6DZuX WXVReEGyQDdLyvK9f3746cC4gkoBlxFgGXSDwo4zp4JrzCmAw5bV34eJ+JYPweWx7LPg+FIPFOY j3X2pWZf2vqGfFIQ0oRbrdlfNbt3YH4nQrZzhBHTyKoPqSjoFypSZofsRq/p5Z5vdxnWsk/W1cd JJWKaGgUrqtxpBC1JTNN+lqjIP4KPy/qwuSlQ1CMykTPnKz9keGR+z2LioLtrSXrRNhxDevQUXt svQzGjOhtHG/bYtQ4DZxax45Zie3GxAD4xK6deKUlqdIEOCC5qaER3wZA= X-Received: by 2002:a05:690c:e3c6:b0:79a:65af:7f4d with SMTP id 00721157ae682-79a90aaea1dmr13698267b3.1.1773966002555; Thu, 19 Mar 2026 17:20:02 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d::8bd]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79a903a294fsm6866627b3.8.2026.03.19.17.20.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 17:20:01 -0700 (PDT) From: Rosen Penev To: linux-media@vger.kernel.org Cc: Laurent Pinchart , Mauro Carvalho Chehab , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dong Aisheng , Jacopo Mondi , Guoniu Zhou , Stefan Riedmueller , imx@lists.linux.dev (open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2] media: nxp: imx8-isi: remove kzalloc_objs Date: Thu, 19 Mar 2026 17:19:43 -0700 Message-ID: <20260320001943.19443-1-rosenp@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use a flexible array member to combine allocations. It looks like pipes never gets freed anywhere. Meaning this effectively fixes a memory leak. Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver") Signed-off-by: Rosen Penev --- v2: add fixes tag, fix typo, and move pdata assignment to original place. drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 10 ++++------ drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h | 3 ++- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.c index 16392420903a..8d8ee1b3076b 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -459,24 +459,22 @@ static const struct dev_pm_ops mxc_isi_pm_ops =3D { static int mxc_isi_probe(struct platform_device *pdev) { + const struct mxc_isi_plat_data *pdata; struct device *dev =3D &pdev->dev; struct mxc_isi_dev *isi; unsigned int dma_size; unsigned int i; int ret =3D 0; - isi =3D devm_kzalloc(dev, sizeof(*isi), GFP_KERNEL); + pdata =3D of_device_get_match_data(dev); + isi =3D devm_kzalloc(dev, struct_size(isi, pipes, pdata->num_channels), G= FP_KERNEL); if (!isi) return -ENOMEM; isi->dev =3D dev; platform_set_drvdata(pdev, isi); - isi->pdata =3D of_device_get_match_data(dev); - - isi->pipes =3D kzalloc_objs(isi->pipes[0], isi->pdata->num_channels); - if (!isi->pipes) - return -ENOMEM; + isi->pdata =3D pdata; isi->num_clks =3D devm_clk_bulk_get_all(dev, &isi->clks); if (isi->num_clks < 0) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.h index 3cbd35305af0..99532efa4e41 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h @@ -286,7 +286,6 @@ struct mxc_isi_dev { struct regmap *gasket; struct mxc_isi_crossbar crossbar; - struct mxc_isi_pipe *pipes; struct mxc_isi_m2m m2m; struct media_device media_dev; @@ -294,6 +293,8 @@ struct mxc_isi_dev { struct v4l2_async_notifier notifier; struct dentry *debugfs_root; + + struct mxc_isi_pipe pipes[]; }; extern const struct mxc_gasket_ops mxc_imx8_gasket_ops; -- 2.53.0