From nobody Mon Apr 6 09:09:44 2026 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9175D249EB for ; Fri, 20 Mar 2026 00:09:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773965398; cv=none; b=lvgbZZLWouMVH0C+OqsCoGZ88yBsAAq9+CBnHvg8hoaYtcLPo+0IPgd6WNuRLiS3oTr+wH6Op8ysNlJM0xmZokrDFMphj58MEmmo+PK40om2Cb56GEsjS6M0y9dSGqxU863NxAbpX+RtFnTmMoH0HrVMuXQ3esJU6ZO6zw32MKg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773965398; c=relaxed/simple; bh=+075GOoyLbd5S34H1HUCr/nG7KpOcOATM4+CPgFOnJs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hpj1w6HZmsC8igBp06tr+Mlc1M/0iguCYdWbGLQoEvFJcXH0GO0zbL99mVTiYXD3c5/CMRpth0NiYN2fOVTEudSo9WrU5c842K8fBzHRziWAPhCr4mWwR99s6hEv6uGUbDjgTVt3YdOnsPdmkz8vNJqfs+BlU8rYALAILRxhNxA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hFTxmVXn; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hFTxmVXn" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-2ba895adfeaso1745066eec.0 for ; Thu, 19 Mar 2026 17:09:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773965396; x=1774570196; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yX+MCrL59z+GAPTCkuU/G/y2YHYVEKPhhbS8nU432oc=; b=hFTxmVXn0dDfoYV3hMU4aLW084yRWr1F33oAfITIKfKqgAq4lvvuQT4yIYAqAV0zGM 7btESoIZgVGzkQh2iF4Li6eTBNrBxZlPkaC0SZgZQp1J4gAx34j6NsvGTjcjmP7um0Qm WttdjaQE8RWzY0NjymZ9ul0XFgt6JaDYlFXF12xUNdNTk7g0GaI03lLnbAmMQrOQL6ld Wtk2g+kwtCUuXiwPHEnhAp3J/VfgJ20iBYUFqBzo+GEiqJtp0ubjVNTeXR8YWGV34UUx 4B4v6Ywt3YQQqnwUIEc7Eexj/W5G07OaSLQLBV/YrV+ABkYNOOGOdTPhTQD3uunkhEjn RCsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773965396; x=1774570196; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yX+MCrL59z+GAPTCkuU/G/y2YHYVEKPhhbS8nU432oc=; b=Eoy6uQLmuoP56N4DfIVEeAThs1vjYxuHRJdjEyVqiUYFfipi2ZL2R4El+cXspKnZZh Rkjx7jcgeimWjNMKEBepJ2eKU6MtX9JcQuEqiLxzm0p4f5NgZfgC7p1g2bMYEfcredFn F5XSVak9T/bqrSDz4d4RxI2RQHvpWzfa1Z3YQ1om7XZD4JMEj/l/XgkwSbgn9PZAbOIP p6YTk6eqJMtLgesRZADBaC7rNcRfb35k10ECQJLiR7em5x2V8X0NdwamOKSVuLNbuNS9 3hhpmZ3XzM1eDviXf9jEm+AjbWOwFYzKsyGw/uwTr77bikz4mSFm7Rk04n+f9jnFeRvt Sb7A== X-Gm-Message-State: AOJu0YxAVD6Cjlof58Pm4A098+5EHz/Xa2WrqeeoEH+2rv3UHJKYjU4w RvgbQkUmIJNKlprqO76caEaADSDS/tPvc74iVuaC4cDs5jv/8bea0xLbMu2BkoizkNg= X-Gm-Gg: ATEYQzwgYb4x8MGuyUCeek422yoEJqX1ZJ9AvEkkfK9X0jzUAUrOl/kHOyTxfnyMGXb pHhfBt0sSJUaX4NZcirt5yGBlKjZWGF/Dhky2WClDBXgZzHTFEiFwBUXW1q/VqQmXc09iPq7sOn Eyd0L28XCnsOxfvjJfpGLq0AA6fa6jwh1qP5TCRtnWDFTQfDzsHMp5LWDu/5JRJQWT25VvOYh69 eiJr6gEPr6M+r7zpa5XhIeBgZ3449duiVzLaUwVrrQ/agmHrE4Fd+QFgdeLFdjGf15NIyZlZOVv vO8AqFEf82w8dg5g/BIwfBVG6Wg2i9NGdngHR74rb9JEFCO3ssJ2pScjXyTrETs+axS0uebdE+9 q/uL8x+EA+lifpj17PrY98ZIdu1aQpd/BvFjSfZ2RNPofLyIhGnMHIIK+bPhn4Z44+w6G1ZTJeR vWMA2Ljdn9mAjfuHCcZawsDA== X-Received: by 2002:a05:7300:50e:b0:2c0:ffe7:318d with SMTP id 5a478bee46e88-2c1097d7856mr553269eec.30.1773965396453; Thu, 19 Mar 2026 17:09:56 -0700 (PDT) Received: from TC-LAPTOP.lan ([209.76.64.37]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b3253d0sm927960eec.29.2026.03.19.17.09.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 17:09:55 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: linux-media@vger.kernel.org, platform-driver-x86@vger.kernel.org, lee@kernel.org, djrscally@gmail.com, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, Thierry Chatard Subject: [PATCH 1/5] platform/x86: intel_lpss: add resource conflict quirk for Dell Latitude 5285 Date: Thu, 19 Mar 2026 17:09:29 -0700 Message-ID: <20260320000937.9177-2-tchatard@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260320000937.9177-1-tchatard@gmail.com> References: <20260320000937.9177-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Dell Latitude 5285 2-in-1 has a BIOS bug where the ACPI GEXP device and the I2C4 controller (INT3446) both claim the same MMIO region via the shared SB04 variable. This causes intel_lpss_acpi to fail binding to I2C4 with -EBUSY, preventing the front camera (OV5670) sensor from being registered. Add a DMI quirk that selects IGNORE_RESOURCE_CONFLICTS for INT3446 on this machine, matching the existing pattern used by other LPSS quirks. Signed-off-by: Thierry Chatard --- drivers/mfd/intel-lpss-acpi.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/drivers/mfd/intel-lpss-acpi.c b/drivers/mfd/intel-lpss-acpi.c index 63406026d..7d0964848 100644 --- a/drivers/mfd/intel-lpss-acpi.c +++ b/drivers/mfd/intel-lpss-acpi.c @@ -13,6 +13,8 @@ #include #include #include +#include +#include #include #include #include @@ -52,6 +54,15 @@ static const struct intel_lpss_platform_info spt_i2c_inf= o =3D { .swnode =3D &spt_i2c_node, }; =20 +/* Same as spt_i2c_info but with QUIRK_IGNORE_RESOURCE_CONFLICTS for Dell = 5285 + * where ACPI GEXP device conflicts with I2C4 (INT3446) MMIO resources. + */ +static const struct intel_lpss_platform_info spt_i2c_info_ignore_conflicts= =3D { + .clk_rate =3D 120000000, + .swnode =3D &spt_i2c_node, + .quirks =3D QUIRK_IGNORE_RESOURCE_CONFLICTS, +}; + static const struct property_entry uart_properties[] =3D { PROPERTY_ENTRY_U32("reg-io-width", 4), PROPERTY_ENTRY_U32("reg-shift", 2), @@ -172,6 +183,16 @@ static const struct acpi_device_id intel_lpss_acpi_ids= [] =3D { }; MODULE_DEVICE_TABLE(acpi, intel_lpss_acpi_ids); =20 +static const struct dmi_system_id dell5285_lpss_dmi[] =3D { + { + .matches =3D { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude 5285"), + }, + }, + { } +}; + static int intel_lpss_acpi_probe(struct platform_device *pdev) { const struct intel_lpss_platform_info *data; @@ -182,6 +203,17 @@ static int intel_lpss_acpi_probe(struct platform_devic= e *pdev) if (!data) return -ENODEV; =20 + /* Apply IGNORE_RESOURCE_CONFLICTS for I2C4 on Dell Latitude 5285. + * The ACPI GEXP device conflicts with I2C4 (INT3446) MMIO resources + * due to a BIOS bug where both use the same SB04 variable. + */ + if (data =3D=3D &spt_i2c_info && + acpi_dev_hid_uid_match(ACPI_COMPANION(&pdev->dev), "INT3446", NULL) && + dmi_check_system(dell5285_lpss_dmi)) { + dev_info(&pdev->dev, "Dell 5285: applying IGNORE_RESOURCE_CONFLICTS for = I2C4\n"); + data =3D &spt_i2c_info_ignore_conflicts; + } + info =3D devm_kmemdup(&pdev->dev, data, sizeof(*info), GFP_KERNEL); if (!info) return -ENOMEM; --=20 2.51.0 From nobody Mon Apr 6 09:09:44 2026 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E131026AE5 for ; Fri, 20 Mar 2026 00:10:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773965402; cv=none; b=kjDhINmHrwx0nrp4mbLqE1kdaTC1yhPLculDTfwSqFuJXPci5PM8fMj1gUMuH9tU2KhFsDTo+kVljW7a3A2lgWtHwfeVCcCZ8q9cXWMxJOnrRoxCZj72u7EhqzTrMC3bnPfWCGRAmT3oD+vz3rdbSSAsxT/DJxgAnelu+BupBjE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773965402; c=relaxed/simple; bh=KUWcIgCt9D5pwCWxyvBt4VgHH/prw2tSLJf/1FS/jME=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SnN+gRBhSLPAVMtTIBcznDxqx4OU+0IhdA/FP4Zgui8ZBhjffuETzuXHa1bNDR7uOEsGQISQtyIDY1hyfDP9GiVtU2iu4ckUtrZkaok/RVkhW3YFoNR284F+NjgTTED6WEEyRoLWRp8KsQmSRKXdT+0T6470AbxLdsKqlDDfowk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AdLeZiZS; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AdLeZiZS" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-2c0d36f3888so180763eec.0 for ; Thu, 19 Mar 2026 17:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773965400; x=1774570200; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=brRc9bgMF+/5nq2Bp8IT7dW2X+rA31PaurtC7LG/XIg=; b=AdLeZiZS+dzld85PL9ETYPFZm/1qzfmsvT06/1ZcRGrUtudPfCQncRMiz90q2+EPMT 7BhSzVVNlfI8VlUKHCHOX1QOYBCBL3UBGEwAsBzHr7gNN7m/7VTIAFWyhvSXE0NXZNli S1cibJqZ8ZTESquosP44yW4BN/tRh+9bFtlcz/0wMnnEvwiJz/OvyGxoOEYTBehrKTGj jxPQ0lxMffQKOtnGkKghqKzEZO0uzsA7GxCGgqFoIJqmdpjjYLzT8vQcZkGrfCbrOqOa 72rFBHfKCPPsHGpbosYU/rdbxg/9677IMwJCS7yNvRS6Ea+VfCBvZRJLaJkznMzgPCe+ y2kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773965400; x=1774570200; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=brRc9bgMF+/5nq2Bp8IT7dW2X+rA31PaurtC7LG/XIg=; b=GQ/HxcuhlYW1zvwY1n2/rRR6mFijGmONz0hDZ48EX1SgZcUNqlQtDosotKCBZcF5i0 t6IA8Qaxdf8oD0ZYJ8bjookU8qjkEbQpF6iq4zYO+JWR93dtDenGrCrdKJHI6t3pOVBG H/4PccIwY++f+CbRsJY7k/cbp+j3jmevmwqRmwlrVRVZn8BTb5D7tHprQFipSkZA4k00 XwNgwbHtK7ZAid3fcDqBrLi1wHcwUcq++hzk16usREFSdgXF84vfUnDTRbAPweyxarRU 1Tm4KDJ2ohusmEKCegG1xqO4OE7XCZRO10JvRupCW19/4RbSG20Bl94Legj01g59I3Dz FLUA== X-Gm-Message-State: AOJu0YzSCR+VQq/vhpPIIN2dAuJS39UDADi+Pp1hetwujolEE/mpXesU BYrUHCP9tLkD5xeEEiprhRh1FISIM3VmWCIdEMeBIEtp87wBVrGoZSSmV4b3eIASnFA= X-Gm-Gg: ATEYQzysT6GBsqvDm3yXS2ppelgInAXURxu8TXriDUnOI/HlaOxbEw8++yIEDCRADUJ /Gz4ugCF4nGB1ywLVnA2oOz8dPWESQSb5CD5d7WYdrU1c7B5dfCxJRYSXV9ZRts68QGRDwVhwxH su99U9LN9NMb4fTMpMz6L6FMrPlrWjMcQRIcJ3jrVdTgMX5Q8EY5MqoLHjiZQ53UYOYUAsSVN/J 0MJ2PoTMT4FVvSCgAaTpx1xp7bqVoof2drA4YaQAgSEc/DLCjugN6WKF7kAccRpBtXl1Dg3+3qi LiNywsRo9Q/fQPnrD2JsEJ5S3b+68b/gDLyd8hViQ2C83akZnjsvrXfCfAvmb8e/GoQCdocGxKa FZ6WoqjZ4WYrXRHFEtjBEVP3ga2lHcBwHkNCSrJNeKBZeN7YZbJxT4AuH/xdAvW9hRcq0GoaOLj lUisNDrwuo97YlH8ufRz/CiQ== X-Received: by 2002:a05:693c:2c0f:b0:2ba:64c6:2cd7 with SMTP id 5a478bee46e88-2c10980abdbmr668243eec.32.1773965399642; Thu, 19 Mar 2026 17:09:59 -0700 (PDT) Received: from TC-LAPTOP.lan ([209.76.64.37]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b3253d0sm927960eec.29.2026.03.19.17.09.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 17:09:59 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: linux-media@vger.kernel.org, platform-driver-x86@vger.kernel.org, lee@kernel.org, djrscally@gmail.com, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, Thierry Chatard Subject: [PATCH 2/5] platform/x86: int3472: tps68470: fix GNVS clock fields for Dell Latitude 5285 Date: Thu, 19 Mar 2026 17:09:30 -0700 Message-ID: <20260320000937.9177-3-tchatard@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260320000937.9177-1-tchatard@gmail.com> References: <20260320000937.9177-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The Dell Latitude 5285 BIOS leaves the GNVS fields C0TP, L0CL, and L1CL at zero at boot. The TPS68470 clock driver reads L0CL and L1CL to select the output frequency; with both fields zero the clock outputs are disabled, and neither camera sensor can communicate over I2C. Additionally, when C0TP=3D0 the ACPI _DEP method on INT3479 returns PCI0 as its dependency instead of CLP0 (the INT3472 device), causing ipu_bridge to never create the i2c-INT3479:00 client for the front camera. Add a DMI-gated fixup that runs at TPS68470 probe time and writes 0x02 (19.2 MHz) into C0TP, L0CL, and L1CL. The GNVS physical address is discovered at run time by scanning the raw AML of the DSDT (and any SSDTs) for the GNVS SystemMemory OperationRegion definition (opcode sequence 0x5B 0x80 "GNVS" 0x00). The parsed address is then mapped with acpi_os_map_memory(), which is safe because ACPI NVS memory is reserved by the firmware and already mapped by the OS. No hard-coded physical addresses are used. Field byte offsets within the GNVS region (verified against DSDT disassembly on this platform, region size 0x0725 bytes): C0TP: 0x43A L0CL: 0x4F7 L1CL: 0x549 Signed-off-by: Thierry Chatard --- drivers/platform/x86/intel/int3472/tps68470.c | 179 ++++++++++++++++++ 1 file changed, 179 insertions(+) diff --git a/drivers/platform/x86/intel/int3472/tps68470.c b/drivers/platfo= rm/x86/intel/int3472/tps68470.c index a496075c0..5ffcb45c3 100644 --- a/drivers/platform/x86/intel/int3472/tps68470.c +++ b/drivers/platform/x86/intel/int3472/tps68470.c @@ -2,8 +2,10 @@ /* Author: Dan Scally */ =20 #include +#include #include #include +#include #include #include #include @@ -140,6 +142,181 @@ skl_int3472_fill_clk_pdata(struct device *dev, struct= tps68470_clk_platform_data return n_consumers; } =20 +/* Dell Latitude 5285 GNVS fix + * + * The BIOS leaves GNVS fields C0TP, L0CL and L1CL at zero after POST. + * With C0TP=3D0 the ACPI _DEP on INT3479 resolves to PCI0 instead of CLP0 + * (INT3472), so ipu_bridge never creates i2c-INT3479:00 (OV5670 front cam= ). + * With L0CL=3DL1CL=3D0 the TPS68470 clock driver disables all clock outpu= ts, + * making both sensors unreachable over I2C. + * + * Fix: at TPS68470 probe time, locate the GNVS SystemMemory OperationRegi= on + * by scanning the DSDT/SSDTs for its AML definition, map the region, and + * write 0x02 (19.2 MHz) into C0TP, L0CL and L1CL. + * + * Field byte offsets (verified from DSDT disassembly, GNVS size 0x0725): + * C0TP: 0x43A L0CL: 0x4F7 L1CL: 0x549 + */ +#define DELL5285_C0TP_OFF 0x43A +#define DELL5285_L0CL_OFF 0x4F7 +#define DELL5285_L1CL_OFF 0x549 +/* Minimum GNVS region size: last field (L1CL) is 1 byte at 0x549 */ +#define DELL5285_GNVS_MIN_SIZE (DELL5285_L1CL_OFF + 1) + +/* AML integer opcodes (ACPI 6.4, =C2=A720.2.3) */ +#define AML_ZERO_OP 0x00 +#define AML_ONE_OP 0x01 +#define AML_BYTE_PREFIX 0x0A +#define AML_WORD_PREFIX 0x0B +#define AML_DWORD_PREFIX 0x0C +#define AML_QWORD_PREFIX 0x0E + +/** + * aml_parse_int - Parse one AML integer at @p, store value in @val. + * Returns number of bytes consumed, or 0 on failure. + */ +static int aml_parse_int(const u8 *p, const u8 *end, u64 *val) +{ + if (p >=3D end) + return 0; + switch (*p) { + case AML_ZERO_OP: *val =3D 0; return 1; + case AML_ONE_OP: *val =3D 1; return 1; + case AML_BYTE_PREFIX: + if (p + 2 > end) return 0; + *val =3D p[1]; return 2; + case AML_WORD_PREFIX: + if (p + 3 > end) return 0; + *val =3D get_unaligned_le16(p + 1); return 3; + case AML_DWORD_PREFIX: + if (p + 5 > end) return 0; + *val =3D get_unaligned_le32(p + 1); return 5; + case AML_QWORD_PREFIX: + if (p + 9 > end) return 0; + *val =3D get_unaligned_le64(p + 1); return 9; + } + return 0; +} + +/** + * dell5285_gnvs_from_table - Scan one ACPI table for the GNVS OperationRe= gion. + * + * Searches the AML body of @tbl for the byte sequence: + * ExtOp(0x5B) OpRegionOp(0x80) NameSeg("GNVS") RegionSpace(SystemMemory= =3D0x00) + * followed by two AML integers (region address and length). + * + * Returns true and fills @addr / @size if found and plausible. + */ +static bool dell5285_gnvs_from_table(const struct acpi_table_header *tbl, + phys_addr_t *addr, u32 *size) +{ + /* AML: ExtOp OpRegionOp NameSeg("GNVS") SystemMemory */ + static const u8 sig[] =3D { 0x5B, 0x80, 'G', 'N', 'V', 'S', 0x00 }; + const u8 *aml =3D (const u8 *)tbl + sizeof(*tbl); + const u8 *end =3D (const u8 *)tbl + tbl->length; + const u8 *p; + + for (p =3D aml; p + sizeof(sig) < end; p++) { + u64 region_addr, region_size; + int consumed; + + if (memcmp(p, sig, sizeof(sig)) !=3D 0) + continue; + + p +=3D sizeof(sig); + consumed =3D aml_parse_int(p, end, ®ion_addr); + if (!consumed || !region_addr) + continue; + + p +=3D consumed; + consumed =3D aml_parse_int(p, end, ®ion_size); + if (!consumed || region_size < DELL5285_GNVS_MIN_SIZE) + continue; + + *addr =3D (phys_addr_t)region_addr; + *size =3D (u32)region_size; + return true; + } + return false; +} + +/** + * dell5285_gnvs_find - Locate the GNVS OperationRegion address by scanning + * DSDT and SSDTs. + */ +static bool dell5285_gnvs_find(phys_addr_t *addr, u32 *size) +{ + struct acpi_table_header *tbl; + u32 i; + + /* DSDT */ + if (ACPI_SUCCESS(acpi_get_table(ACPI_SIG_DSDT, 1, &tbl))) { + bool found =3D dell5285_gnvs_from_table(tbl, addr, size); + + acpi_put_table(tbl); + if (found) + return true; + } + + /* SSDTs (instance numbers start at 1, stop at first failure) */ + for (i =3D 1; i <=3D 32; i++) { + bool found; + + if (ACPI_FAILURE(acpi_get_table(ACPI_SIG_SSDT, i, &tbl))) + break; + found =3D dell5285_gnvs_from_table(tbl, addr, size); + acpi_put_table(tbl); + if (found) + return true; + } + + return false; +} + +static const struct dmi_system_id dell5285_gnvs_dmi[] =3D { + { + .matches =3D { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude 5285"), + }, + }, + { } +}; + +static void dell5285_gnvs_fix(void) +{ + phys_addr_t gnvs_addr; + u32 gnvs_size; + void *gnvs; + + if (!dmi_check_system(dell5285_gnvs_dmi)) + return; + + if (!dell5285_gnvs_find(&gnvs_addr, &gnvs_size)) { + pr_err("int3472-tps68470: Dell 5285: GNVS OperationRegion not found in D= SDT/SSDTs\n"); + return; + } + + gnvs =3D acpi_os_map_memory(gnvs_addr, gnvs_size); + if (!gnvs) { + pr_err("int3472-tps68470: Dell 5285: failed to map GNVS at %pa\n", + &gnvs_addr); + return; + } + + pr_info("int3472-tps68470: Dell 5285 GNVS fix at %pa: C0TP=3D0x%02x L0CL= =3D0x%02x L1CL=3D0x%02x -> 0x02\n", + &gnvs_addr, + *(u8 *)(gnvs + DELL5285_C0TP_OFF), + *(u8 *)(gnvs + DELL5285_L0CL_OFF), + *(u8 *)(gnvs + DELL5285_L1CL_OFF)); + + *(u8 *)(gnvs + DELL5285_C0TP_OFF) =3D 0x02; + *(u8 *)(gnvs + DELL5285_L0CL_OFF) =3D 0x02; + *(u8 *)(gnvs + DELL5285_L1CL_OFF) =3D 0x02; + + acpi_os_unmap_memory(gnvs, gnvs_size); +} + static int skl_int3472_tps68470_probe(struct i2c_client *client) { struct acpi_device *adev =3D ACPI_COMPANION(&client->dev); @@ -155,6 +332,8 @@ static int skl_int3472_tps68470_probe(struct i2c_client= *client) if (!adev) return -ENODEV; =20 + dell5285_gnvs_fix(); + n_consumers =3D skl_int3472_fill_clk_pdata(&client->dev, &clk_pdata); if (n_consumers < 0) return n_consumers; --=20 2.51.0 From nobody Mon Apr 6 09:09:44 2026 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F6154315F for ; Fri, 20 Mar 2026 00:10:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773965404; cv=none; b=Mbk8FsCaneTFUh/RIkMSUexaTtfnim9g7D70dfr2V7nP0btm5QAi5RapdXCF/ZD9WkM5P/YWqLzHB/ZFouQk3MeJEL1BKx4Fx2Sy0YRkr9UcCs49N2dCRFX/5EgqIUXVU8qtkILOwg44l8aXVyeAiVBvVOGLKR972td2JqeKlRI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773965404; c=relaxed/simple; bh=0Gwtc1Aw3N0kKl6UBYxX38wZYxqXLGfLSaCSDBMFI/c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T+uLZ07U0ShdrmeYTrnw71i9iM6q/awvKlSvhleJbgDhozgDvpUrcPCZ6Eth0jBJLVV/8zBUpsTtG1gz5MjVdqdghYSeLeRWqjOlzKEbcbsKqW5Ya7S71+OMCSFYrxJeSqvuLoUuy3n1/F8I1qYUl7rPaqOl/2flulo2leRiKOE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AcY7hPIT; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AcY7hPIT" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-2b4520f6b32so2307048eec.0 for ; Thu, 19 Mar 2026 17:10:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773965402; x=1774570202; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4wfzgvzVMeg4WQczJDrBbctjHV7qEIQWsbnU0+vLey0=; b=AcY7hPIT6oHCWrGBq1eZ2qxY5H0f3XAMYvkj2nenJ9sAhQvOAQBXn0fLCNZqrHw+hR K1t/BpvoqJdlsUApZqd5Q/QGXkz+yayWbbUOKKYZ+ThOWDaDwJBbFUYdJzLKTJEvSkh2 nNrGwSu34oWdv98q7GSJuU3R/chp347q9rpTm6SaEGkzkMQSQsJ73sLwH2QPJTvMuZ1N SAmsrrd+afnQ8L/sHtJeaFjg3UHq8o+sswLBn3x8xi8qPK8iv5IM+6YhLC/hA59bHdQs MIr/ayBlGHyF1YZtqYZT0jrBrif+gokuZYXb6wrhsfRJmMOFcC7KCqNVCvzoER4mnYDa vDgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773965402; x=1774570202; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4wfzgvzVMeg4WQczJDrBbctjHV7qEIQWsbnU0+vLey0=; b=PnNEPBweShmK0ZsXgrILgsihFWqUERAqfHfuEvUtB2OWd0tFFkAlJDjf4UJQNSS+B+ KddP4+0tzD80/5HVNULT32zvlxsrWTPXJjrxulFz3Kf09xzYnEUkQAam9YFJwrxnTqnd S8MVXfrB5WRRUzxTu4rksVPwmX+8UxiV65+9sKcYra07/KQbd5ogNBV5r7A0vrpiHxf4 D1UIesH9xFPSmjq6/njEqlHqF3yAtVAMnrT2GCz39/DO734J11izZw56HPMJGbr8aty0 K4QU5K8VeZUzBUfFTyhy1p3WJNaTHBfVNaCq7x+cWUgxM6cSxBOU4nK26SI2u5SAfroO n6IA== X-Gm-Message-State: AOJu0Yyea3+jQujHkk5sNaypAHEWxx/jac0BNVsDf029THUKlxu5dJj7 1uaZNHL0LTNKRzePEDyzUy+ITWclxZVoilM++NNE3K3cJZv0u9x/GyZN2TZe9ggzfis= X-Gm-Gg: ATEYQzwJ02ioAZa5GlG6Gf6ViLx0/zAyiUUP0MAemBvUraswCrUtf/BFTtIQgrjohMK SVI7BAeSCUlEQ/v/bCZrowaQ8TmOBMldXmE88vB5ERz65qfaTuqlnTxiRSUPji1fDJtFwgFSSlo I9CgQhQvKeR9tVyFq/hHsRnpNfDukc4jrQcro4DP/OmESfM1o6jd2CZtk7hOQsDOF9GiffjCozr RA1M2DvFzWMNuBcTRh4wd9xmbEVmdsOV6BiV30nOC3OfkYKWO8tAxJ41Tjc/2V+9eUvz5PsJi7o xOwUXBJAhNptsEJ7OfY+iac0O0q/vMpXc6H3LxhQ73nHb6TkSGQUHjaFtYyZrrxrCApQNeWafo3 iL1vj5JnuCpjfxXazdyFLQNmjxqWZrciOfEKq7imKnM9v59GvsvN51VZWngMxPPGx+ETV9ISj/c oHZu8CrHZh55JgzcfOId3xKA== X-Received: by 2002:a05:7300:7fa2:b0:2c0:c482:7ed with SMTP id 5a478bee46e88-2c109567b49mr625937eec.7.1773965402272; Thu, 19 Mar 2026 17:10:02 -0700 (PDT) Received: from TC-LAPTOP.lan ([209.76.64.37]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b3253d0sm927960eec.29.2026.03.19.17.10.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 17:10:01 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: linux-media@vger.kernel.org, platform-driver-x86@vger.kernel.org, lee@kernel.org, djrscally@gmail.com, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, Thierry Chatard Subject: [PATCH 3/5] platform/x86: int3472: tps68470: add board data for Dell Latitude 5285 Date: Thu, 19 Mar 2026 17:09:31 -0700 Message-ID: <20260320000937.9177-4-tchatard@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260320000937.9177-1-tchatard@gmail.com> References: <20260320000937.9177-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Dell Latitude 5285 2-in-1 has two cameras connected through a TPS68470 PMIC/clock/GPIO hub: Front: OV5670 (ACPI INT3479) on I2C4 Back: OV8858 (ACPI INT3477) on I2C2, daisy-chained behind TPS68470 S_I2C port (controlled by reg 0x43 S_I2C_CTL) GPIO mapping (TPS68470): INT3479 (OV5670): GPIO3 =3D reset (active-low), GPIO4 =3D powerdown (acti= ve-low) INT3477 (OV8858): GPIO9 =3D s_resetn (active-low), GPIO7 =3D s_enable (ac= tive-low) GPIO9 and GPIO7 are the TPS68470 secondary-port GPIOs (SGPO reg 0x22 bits 2 and 0), not regular GPDO outputs. Regulator mapping: CORE -> dvdd / INT3477 ANA -> avdd / INT3477 VIO -> dovdd / INT3477 VSIO -> avdd / INT3479 and vsio / INT3477 (always_on: keeps S_I2C_CTL non-zero from boot so OV8858 is reachable on I2C2 at any time) AUX1 -> dvdd / INT3479 AUX2 -> dovdd / INT3479 Marking VSIO always_on ensures the TPS68470 S_I2C passthrough is active from the moment the PMIC driver probes, eliminating a timing dependency between TPS68470 and ov8858 probe ordering. Signed-off-by: Thierry Chatard --- .../x86/intel/int3472/tps68470_board_data.c | 163 ++++++++++++++++++ 1 file changed, 163 insertions(+) diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/dri= vers/platform/x86/intel/int3472/tps68470_board_data.c index 71357a036..a5b469dcb 100644 --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c @@ -287,6 +287,162 @@ static const struct int3472_tps68470_board_data dell_= 7212_tps68470_board_data =3D }, }; =20 +/* Settings for Dell Latitude 5285 2-in-1 */ + +static struct regulator_consumer_supply dell_5285_int3477_ana_consumer_sup= plies[] =3D { + REGULATOR_SUPPLY("avdd", "i2c-INT3477:00"), +}; + +static struct regulator_consumer_supply dell_5285_int3477_core_consumer_su= pplies[] =3D { + REGULATOR_SUPPLY("dvdd", "i2c-INT3477:00"), +}; + +static struct regulator_consumer_supply dell_5285_int3477_vio_consumer_sup= plies[] =3D { + REGULATOR_SUPPLY("dovdd", "i2c-INT3477:00"), +}; + +static struct regulator_consumer_supply dell_5285_int3479_vsio_consumer_su= pplies[] =3D { + REGULATOR_SUPPLY("avdd", "i2c-INT3479:00"), + /* S_I2C_CTL: must be enabled for OV8858 I2C daisy-chain access */ + REGULATOR_SUPPLY("vsio", "i2c-INT3477:00"), +}; + +static struct regulator_consumer_supply dell_5285_int3479_aux1_consumer_su= pplies[] =3D { + REGULATOR_SUPPLY("dvdd", "i2c-INT3479:00"), +}; + +static struct regulator_consumer_supply dell_5285_int3479_aux2_consumer_su= pplies[] =3D { + REGULATOR_SUPPLY("dovdd", "i2c-INT3479:00"), +}; + +static const struct regulator_init_data dell_5285_tps68470_core_reg_init_d= ata =3D { + .constraints =3D { + .min_uV =3D 1200000, + .max_uV =3D 1200000, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3477_core_consumer_sup= plies), + .consumer_supplies =3D dell_5285_int3477_core_consumer_supplies, +}; + +static const struct regulator_init_data dell_5285_tps68470_ana_reg_init_da= ta =3D { + .constraints =3D { + .min_uV =3D 2815200, + .max_uV =3D 2815200, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3477_ana_consumer_supp= lies), + .consumer_supplies =3D dell_5285_int3477_ana_consumer_supplies, +}; + +static const struct regulator_init_data dell_5285_tps68470_vcm_reg_init_da= ta =3D { + .constraints =3D { + .min_uV =3D 2815200, + .max_uV =3D 2815200, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D 0, + .consumer_supplies =3D NULL, +}; + +static const struct regulator_init_data dell_5285_tps68470_vio_reg_init_da= ta =3D { + .constraints =3D { + .min_uV =3D 1800600, + .max_uV =3D 1800600, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3477_vio_consumer_supp= lies), + .consumer_supplies =3D dell_5285_int3477_vio_consumer_supplies, +}; + +static const struct regulator_init_data dell_5285_tps68470_vsio_reg_init_d= ata =3D { + .constraints =3D { + .min_uV =3D 1800600, + .max_uV =3D 1800600, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + /* + * Keep S_I2C_CTL enabled from boot so OV8858 I2C daisy-chain + * is accessible before ov8858 driver probes. + */ + .always_on =3D 1, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3479_vsio_consumer_sup= plies), + .consumer_supplies =3D dell_5285_int3479_vsio_consumer_supplies, +}; + +static const struct regulator_init_data dell_5285_tps68470_aux1_reg_init_d= ata =3D { + .constraints =3D { + .min_uV =3D 1213200, + .max_uV =3D 1213200, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3479_aux1_consumer_sup= plies), + .consumer_supplies =3D dell_5285_int3479_aux1_consumer_supplies, +}; + +static const struct regulator_init_data dell_5285_tps68470_aux2_reg_init_d= ata =3D { + .constraints =3D { + .min_uV =3D 1800600, + .max_uV =3D 1800600, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3479_aux2_consumer_sup= plies), + .consumer_supplies =3D dell_5285_int3479_aux2_consumer_supplies, +}; + +static const struct tps68470_regulator_platform_data dell_5285_tps68470_pd= ata =3D { + .reg_init_data =3D { + [TPS68470_CORE] =3D &dell_5285_tps68470_core_reg_init_data, + [TPS68470_ANA] =3D &dell_5285_tps68470_ana_reg_init_data, + [TPS68470_VCM] =3D &dell_5285_tps68470_vcm_reg_init_data, + [TPS68470_VIO] =3D &dell_5285_tps68470_vio_reg_init_data, + [TPS68470_VSIO] =3D &dell_5285_tps68470_vsio_reg_init_data, + [TPS68470_AUX1] =3D &dell_5285_tps68470_aux1_reg_init_data, + [TPS68470_AUX2] =3D &dell_5285_tps68470_aux2_reg_init_data, + }, +}; + +static struct gpiod_lookup_table dell_5285_int3477_gpios =3D { + .dev_id =3D "i2c-INT3477:00", + .table =3D { + /* + * TPS68470 GPIO9 =3D s_resetn (secondary camera reset, active-low) + * TPS68470 GPIO7 =3D s_enable (secondary camera enable/powerdown) + * These logic outputs are specifically designed for secondary + * camera control on the TPS68470. Matches Surface Go pattern. + */ + GPIO_LOOKUP("tps68470-gpio", 9, "reset", GPIO_ACTIVE_LOW), + GPIO_LOOKUP("tps68470-gpio", 7, "powerdown", GPIO_ACTIVE_LOW), + { } + } +}; + +static struct gpiod_lookup_table dell_5285_int3479_gpios =3D { + .dev_id =3D "i2c-INT3479:00", + .table =3D { + GPIO_LOOKUP("tps68470-gpio", 3, "reset", GPIO_ACTIVE_LOW), + GPIO_LOOKUP("tps68470-gpio", 4, "powerdown", GPIO_ACTIVE_LOW), + { } + } +}; + +static const struct int3472_tps68470_board_data dell_5285_tps68470_board_d= ata =3D { + .dev_name =3D "i2c-INT3472:05", + .tps68470_regulator_pdata =3D &dell_5285_tps68470_pdata, + .n_gpiod_lookups =3D 2, + .tps68470_gpio_lookup_tables =3D { + &dell_5285_int3477_gpios, + &dell_5285_int3479_gpios, + }, +}; + static const struct dmi_system_id int3472_tps68470_board_data_table[] =3D { { .matches =3D { @@ -316,6 +472,13 @@ static const struct dmi_system_id int3472_tps68470_boa= rd_data_table[] =3D { }, .driver_data =3D (void *)&dell_7212_tps68470_board_data, }, + { + .matches =3D { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude 5285"), + }, + .driver_data =3D (void *)&dell_5285_tps68470_board_data, + }, { } }; =20 --=20 2.51.0 From nobody Mon Apr 6 09:09:44 2026 Received: from mail-dl1-f45.google.com (mail-dl1-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CF1327442 for ; Fri, 20 Mar 2026 00:10:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773965406; cv=none; b=c+YCWOC/8qIoUJsjDjxnPgYafLfh0+/UzHW6J3zXbhKAhvtWAHPC30+ESz7l+TVkZx9ESMbAsZ+0OGudJTrHsktZaw1dkk2DF5ODkMtztybw6SX4I4YgUG5AqN0L8yz/Iuylc+akAE2NgUvpl3WUJ1Isw3n/fypSLc+lT0sh8xY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773965406; c=relaxed/simple; bh=wde4TF8CgNzn8si/JL9P12OCZloroRuFEPIxq/TcvgI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PR96nFr5Nu3tiPwdifCkX8JjPQzSpjh9tcgxRYXBga+tHXG4nVGaI7NcLOfSaysoqgf+SaFg0pb77FbTUYp1qgSDlLL/D5UhHsp5oQ/+WJY3gIN7w5PFX3b9dEog+2R/l159i2nSXmi57FW6S8PHowrg7+4DRvVDVa62zE307XU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PNFa2KsA; arc=none smtp.client-ip=74.125.82.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PNFa2KsA" Received: by mail-dl1-f45.google.com with SMTP id a92af1059eb24-128e4d0cc48so109770c88.1 for ; Thu, 19 Mar 2026 17:10:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773965405; x=1774570205; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TVHeDChmbK7H9JMCFb+9pqFytvxF0fdzrozCeGR4L7s=; b=PNFa2KsAuefw4vdeT0WGKNfO0QhJXFSjEvelmrVPgiCXb9ZTX7ZMvYF0hqiQpLmjXA kdH3VO7+cfrMpkvlFvt0qdtNitwvaFxPKV7igMbsb+mTO9dnrAK/mL9jcqmlnWLo4SIx 6iYRQSxj6E1r9NT5uCPseuemLWO+zF4lYQqBLHMAXUaVI73C8fFjVkVc0oBt5p+k8ae3 pan9EPvbZ62U9d0iygUeYdmg5Ee2pcHaAUQECB4AMwB9Zzu2oiQ/X3FsB2x56vffLedE AGkEEjLU8Zq0VGIqmy9UzzGOhJWWLKTe6p9gHPNkoJFRGCKvHsAZ15iinRKBRpMmHdzD 2Wkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773965405; x=1774570205; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TVHeDChmbK7H9JMCFb+9pqFytvxF0fdzrozCeGR4L7s=; b=rYTyH9KomQ1ZeS/AjoEY6e61PQ6qwb6EUwNW5c1X0psO0vrZabSMfXFulBDPhF+qGn xCwzbSpAIiVxggwL2BIPHTEe4+/tWeXfJXkhMyTpqcGWQfGhKaMZztDxqZwvaT60x1PQ abrxrv1fYTtt4v+w3XAmPvDaKUWZhqNDqmyVJS2jYtd7bgZB7cPX7iK3hYU8HTNyU2eI CKEZY+w3iY8cz5hOprFm/Mi6YAdVSyNa/JZ+IKNWQGc+PORKDolCepewyvUdm+84Nn5q OVtU40CCxpcxl3bG5IZIv0i6QN7END8JxCWDh32O1eqSNJqhH1sFlksi7IbWbqzbdNbv a4lA== X-Gm-Message-State: AOJu0YzCO2zslLBY/bHJQcqvXQKvxAi9tdytbtV+Xe350YNFA4JfGRhX y1i9V5zFnwc89G/7gI5vUlPvkerZEzN8inb0VoJ2f9g+THyvpPinaG7KTJRPIf9pdhs= X-Gm-Gg: ATEYQzx4l4wtQM4rzVQj247HQQ/7lnXH6VwxX3VJAs9KOeRDcWyoCIaNktqHSsR3utB eBb/YpALf7d99A6LTfAvUq8hvptx93H+64vfsgIxatPxNuumGIWLbB9lwqhKpKC3gB/p+gJEmth wMUBDdQs1blj+0BXT0AR+sni4fTiraKJht8rQqWwEiMwvdQlluIZSEghy8bdogJgVUBV+9AB50F RoVY78VkaM8E5yXuLSyh9jn7TcFMTL4MZBlj/XaZcKSM7hmM+WHzNJNreH3rQHLBoX2hhWbogW6 PojA7txFqtCBuJExd9ta4FbHAVo9V0/iGzmURXR2/2EQMPGx23hdBZ2SlH8v/XjES+XhoyKCKYU sPSzrtv9ms9B+XSnDrfkUpthdkVzgag8lbcy/xsfsj/wLZZdgBxbocs0Wj/QIgYlHkcaY2fFH/3 Bt3T2nC81q83Bsvpxoc288+xQPFMEkQV7d X-Received: by 2002:a05:7022:2216:b0:128:cf70:9042 with SMTP id a92af1059eb24-12a72691fdbmr635944c88.18.1773965404564; Thu, 19 Mar 2026 17:10:04 -0700 (PDT) Received: from TC-LAPTOP.lan ([209.76.64.37]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b3253d0sm927960eec.29.2026.03.19.17.10.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 17:10:04 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: linux-media@vger.kernel.org, platform-driver-x86@vger.kernel.org, lee@kernel.org, djrscally@gmail.com, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, Thierry Chatard Subject: [PATCH 4/5] media: ipu-bridge: add sensor configuration for OV8858 (INT3477) Date: Thu, 19 Mar 2026 17:09:32 -0700 Message-ID: <20260320000937.9177-5-tchatard@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260320000937.9177-1-tchatard@gmail.com> References: <20260320000937.9177-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Omnivision OV8858 is used as the rear camera in several Intel IPU3-based devices (e.g. Dell Latitude 5285 2-in-1). Its ACPI HID is INT3477. Add a sensor configuration entry with a link frequency of 360 MHz to allow ipu_bridge to create the firmware node for this sensor. Signed-off-by: Thierry Chatard --- drivers/media/pci/intel/ipu-bridge.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel= /ipu-bridge.c index fc6608e33..f51749d0f 100644 --- a/drivers/media/pci/intel/ipu-bridge.c +++ b/drivers/media/pci/intel/ipu-bridge.c @@ -63,6 +63,8 @@ static const struct ipu_sensor_config ipu_supported_senso= rs[] =3D { IPU_SENSOR_CONFIG("INT33F0", 1, 384000000), /* Omnivision OV2740 */ IPU_SENSOR_CONFIG("INT3474", 1, 180000000), + /* Omnivision OV8858 */ + IPU_SENSOR_CONFIG("INT3477", 1, 360000000), /* Omnivision OV5670 */ IPU_SENSOR_CONFIG("INT3479", 1, 422400000), /* Omnivision OV8865 */ --=20 2.51.0 From nobody Mon Apr 6 09:09:44 2026 Received: from mail-dy1-f178.google.com (mail-dy1-f178.google.com [74.125.82.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A634A1C2AA for ; Fri, 20 Mar 2026 00:10:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773965408; cv=none; b=bF4nj4p137weh4eFIwLp4d/c1+aq4pb6VKWqcsMuagYRuqMvhOIsK2bhugLXHpLJZE2iaaJHHuvujgqXmN7BkeZOUkrec0agLwVN+YhNn7+wQJEGfpKFGgW3kVFjOtTUgEV//F7o07NYTJru3zw1lpIwa0bmIPNk0BJJEAnaknQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773965408; c=relaxed/simple; bh=kn4gRyG2CWdohr2zODJVwJLXxsAV9GOcDFXCGFJSgyU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dKk7k4Rh1W6TlcNV4/RNyxjBmXCtWbHjheLkKPDKMVN93DI5HkOsrodIOEsuk3R2hrTRgRCILA9OhWa/B7kKIAGdS/p2IwdazW920bGzvbXAkuPB6W0NBSxOerohx9Z3kPy0HS90ZP5fdkrnVmL6I/kDZbBIz+kqofPmPjtDrEc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TEfI2I6i; arc=none smtp.client-ip=74.125.82.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TEfI2I6i" Received: by mail-dy1-f178.google.com with SMTP id 5a478bee46e88-2bdd40d3c61so132563eec.1 for ; Thu, 19 Mar 2026 17:10:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773965407; x=1774570207; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fItzBPGWBSGQf6v7HfvNDUYpHiJWqdhO3Tr8TUmXrPk=; b=TEfI2I6ilO80tW9Xbiu8tMde//mXla2kVH+ZKdr79mCUU/wmicYqYFKohM2U3/7uMD Ef8vrHnlF1ny4vehNWkgSe31jWxUkHdPzL9v/H0VjSypv3yR2UPGCWaEHo7mDZvZ/ZKn h29Az11Kp1mWgzwnSQQoDTRrJkyvBH1btq1+h7AREOOFC7mnNfmyjUc/uputGb7PSvus 0bKBvR2SmTRMvI4EZW2tQ+BxPcTVuetudjqNUZ8jPk4+ipSlf2zjpOZs9I1Bz2yWqrfq vPOQ20rFG4T5j2C9AkK85oDiL4xeOhkHnRRgX0NRD0UuKYgfEKZNCHu/vmc19nb26YYj h1rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773965407; x=1774570207; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fItzBPGWBSGQf6v7HfvNDUYpHiJWqdhO3Tr8TUmXrPk=; b=BXzruHmf36LCUI0JCBdAjHa8v8qMOkIa+3KH8lFxcQasGe1ZnBTh2XnFAIEIe2zRCP P6F8rMWCC7VLfISR0M6OixwaVE237R5G0zVorms5nkorRddsIKGmHV7jJ8G/nS6w4uei Hf0FZB/4EXvmvwgK89GpDL0Y2K24H9wcVSq86Eqj7kx1bnj+FHGC4MB4lLLKD6FQK8dz SPN5szc3uLPFvJxE73hMx1YK4YGTijWCi6tfMYzWygr9jZyeZQBZsQ1Ul9uXrkh6CfkX mxBYpOWQEGjgwtgcFIkBzMIzdLato85h5gsAqSK81AIRL6TfraBZboK4GvPbPhSy5MWJ SYEQ== X-Gm-Message-State: AOJu0YzHVtuQwguVoUctrpJYRFoT+YKSg7T0TLWGh8Fald+kvmT7FSPD /t2Ec9eIg31QoWTHvKvvo7AR1uJgUTC69j9HaGaWR6Zq+E35283eqYQiYNm/P060Aow= X-Gm-Gg: ATEYQzzYauuLzT2GTWYqe55UFWHx1JtqMJOyIR/7+Aigmr6aJ3R8CfG/0GEhazqXye6 gnJbsIqFXKjnxfDsNjGFmcGRP1NIlzDNktCo/NIC2nEJScF0giSguuYskryaCS3bSsXfmXFwv5n oihMU8qvtZwI2BknUM56b50jOSeoSiYbh1TFMO6EzCdyNYvD6S2DBIluk65T9rgoM1TmryIDUW6 OvKshptiEkICloDJuYZ1Z2iDcokp5wYhLG53Y5gbNpL94ucxmK5B4lJH82r7YhpfURPoqWi3xEl NXhF18XQZJQQZz2Gmp+YbkFtxqloEuJ1OgdyJhgG5Xlt4BjOmAHYkrYFyiv6HoiBF0lU+7Whwo9 qL/xwqEVOkp1OJiCaQ/Ba8Cwfrw+HArE8DM2a5LTPT3/KF1HUJadJnrKg7O4BWPfc1ACoGEfAyE 8WCideJsjObdIA3rj8lN5g2g== X-Received: by 2002:a05:7300:3252:b0:2c0:c482:805 with SMTP id 5a478bee46e88-2c1095fa724mr723316eec.15.1773965406563; Thu, 19 Mar 2026 17:10:06 -0700 (PDT) Received: from TC-LAPTOP.lan ([209.76.64.37]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b3253d0sm927960eec.29.2026.03.19.17.10.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 17:10:06 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: linux-media@vger.kernel.org, platform-driver-x86@vger.kernel.org, lee@kernel.org, djrscally@gmail.com, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, Thierry Chatard Subject: [PATCH 5/5] media: ov8858: add ACPI device ID INT3477 and vsio power supply Date: Thu, 19 Mar 2026 17:09:33 -0700 Message-ID: <20260320000937.9177-6-tchatard@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260320000937.9177-1-tchatard@gmail.com> References: <20260320000937.9177-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Omnivision OV8858 appears in ACPI firmware under the HID INT3477 on Intel IPU3-based platforms such as the Dell Latitude 5285 2-in-1. Add INT3477 to the ACPI match table so the driver binds when instantiated by ipu_bridge. On the Dell Latitude 5285 the OV8858 is powered through a TPS68470 PMIC. The TPS68470 VSIO regulator controls the S_I2C_CTL register (0x43) which enables I2C passthrough to the sensor. The board data for this machine maps VSIO to the supply name "vsio" for INT3477. Add "vsio" to ov8858_supply_names[] so the driver requests this regulator at probe time. The existing supply array had a duplicate "dvdd" entry; replace it with the new "vsio" entry and reorder to: avdd, dvdd, dovdd, vsio. Signed-off-by: Thierry Chatard --- drivers/media/i2c/ov8858.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov8858.c b/drivers/media/i2c/ov8858.c index 3f45f7fab..5bfea237b 100644 --- a/drivers/media/i2c/ov8858.c +++ b/drivers/media/i2c/ov8858.c @@ -79,8 +79,9 @@ =20 static const char * const ov8858_supply_names[] =3D { "avdd", /* Analog power */ - "dovdd", /* Digital I/O power */ "dvdd", /* Digital core power */ + "dovdd", /* Digital I/O power */ + "vsio", /* Secondary I2C / S_I2C_CTL enable */ }; =20 struct regval { @@ -1981,11 +1982,18 @@ static const struct of_device_id ov8858_of_match[] = =3D { }; MODULE_DEVICE_TABLE(of, ov8858_of_match); =20 +static const struct acpi_device_id ov8858_acpi_ids[] =3D { + { "INT3477" }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(acpi, ov8858_acpi_ids); + static struct i2c_driver ov8858_i2c_driver =3D { .driver =3D { .name =3D "ov8858", .pm =3D &ov8858_pm_ops, .of_match_table =3D ov8858_of_match, + .acpi_match_table =3D ACPI_PTR(ov8858_acpi_ids), }, .probe =3D ov8858_probe, .remove =3D ov8858_remove, --=20 2.51.0