From nobody Sat Apr 4 03:20:29 2026 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FB943D3CE1 for ; Fri, 20 Mar 2026 16:45:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774025149; cv=none; b=KzPR3Qcw33d7BgaX0I7JQIlrxpCrWAor5lg+cFThBvj42jLHizYaiUlqN8Au0vu6fqre3BnBO4OocQCiDhhhB2+USdD9byazoe5WLz22xernIml4mRx0cbZFy7wU9SIIpr/EV80PKob5bztcEpPLv6W2EsvI8EpNL2Qaecxc+mg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774025149; c=relaxed/simple; bh=TDGGomY91nN+1JyvI5TZ4EVzE30ok0VSWE41vwKqiD8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=B8Qr9S5Glk2XURrBeAj9nudilOmBzIgsKaTWF/PQ48HvMPfPq40RnJREHhAHP14BVXqW/3sBHm8B8BN3+zrZEJBI2qEkqwO2jf6R9S3BORFxTF6JFpJhyCD1ArsDIGMipn9snYbakXYoHWLuOi7RS0Oe/Ux/WISvsW6utknk7vo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D4C5h1c3; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D4C5h1c3" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-b9825ba7f9dso203091566b.0 for ; Fri, 20 Mar 2026 09:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774025145; x=1774629945; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j0j1VhXqL1sZ8EwZY7NLMpbNkl6FM/lHHiEwrtRqEHg=; b=D4C5h1c3OjwmIar1o1LvKWf45bI8Z62PgEO3mAk42Ke6vDUH7rDapPLufhh6ZLLo44 lK+qOPBklDCxqtzPjIh/qLme3MKwcEU26GjH3OZKWKGqcMFN059GdnA+sgJasj2Agx5Y ODNJy9R3i9wQaGRZA9UqMkoxxN3EN2ZsHrVduVQNwohiVIHlBnFi/1irwZZ7UlRKzuPG PI9z1Ty03tI9dWIvE9qpAqEt/uz/JUf3WKBMju8IC7sXMrWhSggSRGdO3Gv1rx0sLrma lLBDnyfu3dI9/WD3RandDaBSTIHxm/wEqQjnif55CApo80EDK3ubKSo1HBu8aSZxJohk 8jUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774025145; x=1774629945; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=j0j1VhXqL1sZ8EwZY7NLMpbNkl6FM/lHHiEwrtRqEHg=; b=mKm3oVZ49QcB95TF1dRSrsCY2qMv58VudNcBoXXZxXQrvj2Xv2SuGDADV5DFtIlhIS MrvmmVkG4jahZkHJ3AhpEzGujakwMvLWCWl+uBKBZYbFIWQGEMJjf6WPVwLsm+4b5PKq +6rxqmZrRsEUarw1/9boK3ePIz0eEo9on4yhCf4dY/3OQOmQdt2Ibw+aGZK0dz12CJV1 C736tmKPuMTJC0CVsUM8H6Tbzsli0Ja5B/aigP6NcQcJwAvxsCwzngxuCKjOuelSqoqe N0+mQUHJSoqdlMOsB24Gqi9CbTvUiAtlgbIug9ENnEM68VAAlkwQaQeGHlBJHCdskd3x QJOA== X-Forwarded-Encrypted: i=1; AJvYcCXBtlzTo3kFdIBw/slu65GkSnv+47VeoXQYuDLqnYJd88qkNSsuTn8+CB6YiroSDt46q9g8p7v2iU4uOUk=@vger.kernel.org X-Gm-Message-State: AOJu0YybCl+NRe/ZujHwgCkmw/mDFiddZT5hikg99yfQHtaLGPd+tuNG nFBxz1X6JDhdhK6rhAiZi93LiaswkAqPO9DuzQ5klCQZkDEQJIJ56lEX X-Gm-Gg: ATEYQzyVc+qHMpu9WrqCiwj+yTREyzqUT7qU3TdztQFZUas6HzMYl8hWuMGNwNbNzv9 e+Apf3Fn/irYlj4vjnHVFe3L5UsTFlcCCZQOb8vU20qk6pLu35HuKlOnvmNmD363XLcPdW05EHM 8DttPEUZlhBZFLBGgpSi4DhCzrcZfuFV4Ekwsj+jKoaszw9sbvpxpymPdFnuBsjkAtKT9L+R0xl S1xSl001Puq0tZGimYgMFbk2zlfDpys3ptBri17FMvoTNok3GgWWR2hZIdyaKIWaz2Wr2yJP0bf Ft8Ubg3/KdIDqnxAOcmJhKXq8pbZq/IbPJ0cOLFm8CfjChOp95Ga8vIEJBD6iyKADVphTjqrQbZ sfmR0qXYYwbEbkyGGIO2R2K9Oih+58W4zYP0+4alTAFMLuKzp48u+A48HscrQVtu6E2BwhdB7el TYcadnqmRVkHfmosXGyTqPRfac9w== X-Received: by 2002:a17:907:94c4:b0:b97:3376:7b5 with SMTP id a640c23a62f3a-b980fa62dabmr489218266b.21.1774025144508; Fri, 20 Mar 2026 09:45:44 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b98335f1747sm176730466b.33.2026.03.20.09.45.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 09:45:44 -0700 (PDT) From: Erikas Bitovtas Date: Fri, 20 Mar 2026 18:45:36 +0200 Subject: [PATCH v6 1/8] dt-bindings: iio: light: vcnl4000: add regulators Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260320-vcnl4000-regulators-v6-1-0d24d20b1a5b@gmail.com> References: <20260320-vcnl4000-regulators-v6-0-0d24d20b1a5b@gmail.com> In-Reply-To: <20260320-vcnl4000-regulators-v6-0-0d24d20b1a5b@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 These sensors can accept 2 supplies - one for the sensor and one for IR LED [1]. Add supply properties for the sensor - 2 for the sensors and one external, for their open drain interrupt line, to ensure the sensor is powered on before proceeding with setup. [1] https://www.vishay.com/docs/84274/vcnl4040.pdf Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas Reviewed-by: Andy Shevchenko Reviewed-by: Krzysztof Kozlowski --- .../devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 14 ++++++++++= ++++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.ya= ml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml index 2ba4d5de4ec4..516afef7a545 100644 --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml @@ -33,6 +33,17 @@ properties: interrupts: maxItems: 1 =20 + vdd-supply: + description: Regulator providing power to the "VDD" pin. + + vio-supply: + description: Regulator providing power for pull-up of the I/O lines. + Does not connect to the sensor directly, but is needed for the + correct operation of the I2C and interrupt lines. + + vled-supply: + description: Regulator providing power to the IR anode pin. + reg: maxItems: 1 =20 @@ -54,6 +65,9 @@ examples: compatible =3D "vishay,vcnl4200"; reg =3D <0x51>; proximity-near-level =3D <220>; + vdd-supply =3D <®_vdd>; + vio-supply =3D <®_vio>; + vled-supply =3D <®_vled>; }; }; ... --=20 2.53.0 From nobody Sat Apr 4 03:20:29 2026 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CF473D8123 for ; Fri, 20 Mar 2026 16:45:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774025148; cv=none; b=DarvleLyOt7eBN4/3hUWZJDW+JKaz2P5V564aN4E3kDKGuKLedO+uMuUAIf8FtO63+jURflQwVJlys7NP1Z3l6sIgIowcjzjAcMfQ73tMe+H2va9ghIH+Fnv8vDUl/BXKIImJysbPNk8tT1pekRYe/1GZrguMZ4QESgvm2FryWk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774025148; c=relaxed/simple; bh=FyYL7KjhfBkhq4Z8eKOH65vilPS2pr7+rN80jiOzQpc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Rw+Z2nyLJhbFEZnmqeAp1mpggzd9LPbcNNNsc+eXl8ZUOeygT5GGpC+9XQLodiLtBGxGV4B7eTE1VGTPi150U8GBCmu7RIXPOcR5LDm5HLc/nYyYHQ814KdRabIjhJ2F4jhTZ6F0syUc4OQpnaWfoxZAAHV4jN2F1n0QQ/Raseo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ggb+tcOd; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ggb+tcOd" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-65c4152313fso3155696a12.1 for ; Fri, 20 Mar 2026 09:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774025146; x=1774629946; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=AGTiQESNTxF+kqg9mPQcr06UPYRyUnWm55j6lAp7RWY=; b=ggb+tcOdscs9eAYb2e5tKZQk+kYeBWr0YUE4G3u/8CrB98na6hfC4/nlQ9YZY0vG4G J/qMUikmGXDksQECftmOJ7t34pgaEgTAXbN0Y0ViNimfZz01VakjTty+H74kwEPnZX2M mkcw8Ztd8WVUGaxIwHJ3doZ2+jCv/Pl0BWYcSTu+d7GXXdkmJOmR1KYGBauuWrt3Fmi5 TLkVcoQ5HLWg3S8Hnhje2IsFZDM2ZayW4ADGsN4dTeay8nxR1p3FAm3gDs0pN5r42L0k 6ejQDQVHWsL6j1i+Ldjica4ALzeKpVDxvuH9/PFeIb+2PNQQq5G7CUR35fSdj1OwNGZ+ VmFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774025146; x=1774629946; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=AGTiQESNTxF+kqg9mPQcr06UPYRyUnWm55j6lAp7RWY=; b=dS/7wU+xiv2F4wBIXK/A8tG3jBeR8PMMIIcsIOtz3/QYLjtRbzHNSD1W8+zftnwYCx QEWVN0mcRSH9Xmt69GFu/S8MQrzMArSQ0fLPInCRgnh18PDrmtHZmHIjiFKpBAwsj2E2 42vZWstS7tqjRGB/gfdAshdaZ9aGSA6/fNYnPO7W9JUC0OD5JOfwXkKg3b4Bw43/eXCL wWrmQP46GXN0bsIcLCjO2wRpVUYZn0ENd7mjbd07+T6i0bAe2vNsd+Si0ISELeDjX6u3 4FVZDjUrPIxQWgYI9IlZV8I+GaKNCuc2+s5pts9hWHgb8zuK9GxOdMBlqjpdZvvfBLkL vAsw== X-Forwarded-Encrypted: i=1; AJvYcCXnmdFGQbb8aw7SSzERwCBCi+CMl/l1n9iyVNYNejqsgJYzJmx1+B1WnCBMi9J2NGSZRKdV5Useim6GXg0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1txS37qS3sBwn0c6zZdEDJr00S8zSGLG/vXxW1RQGNTI6T7hN sHkRNccN32V/+czFP+Ux4/T6AcFpwBJIAuRX8RplwgECn30uSkinX+fo X-Gm-Gg: ATEYQzwdjerIzvc989ngCZIgqqF3giSHv65OMQKSUiQpMbDTLaDz83zHJVskZxDTzEi 5yULaIIMx6/JW+scv4/iit9ng0ujKnV1uV4mqL4c9mEktHXe8Ihc0VZBM1E5rPSNZmrYc/V7vXs F0GLeuvFHcPGN2bDDdk5bGLAFidQndc3rmj3jq06/ZVSRHA+irFQk8I+Pi3njIOz3HpsemVtQbg E8VidCpicevNLAgaZt20axBMw18o1V3dc+IviA73YiiJMPYQ0JbICUZD4HR9yoKizu1FJk4hV5I qNvfTAVOUB8ypgGteAgCbCvnRw6dAr6gWSv+IR2np0LrD4TDdUjepTwvAmPNom44hLpUHJMrMIh VFs81S0NooXxv9eOPZ2/fKnez4YHypyAplBl9yWnicMhj8bUMhKR3l3tOVqhd05qFf9HIFbGkhV Z1zQHOcvyXCM0DasGiOu3+UkcNrg== X-Received: by 2002:a17:907:c70c:b0:b96:eb7e:bc55 with SMTP id a640c23a62f3a-b982f1edf01mr278179666b.10.1774025145822; Fri, 20 Mar 2026 09:45:45 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b98335f1747sm176730466b.33.2026.03.20.09.45.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 09:45:45 -0700 (PDT) From: Erikas Bitovtas Date: Fri, 20 Mar 2026 18:45:37 +0200 Subject: [PATCH v6 2/8] iio: light: vcnl4000: sort includes by their name Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260320-vcnl4000-regulators-v6-2-0d24d20b1a5b@gmail.com> References: <20260320-vcnl4000-regulators-v6-0-0d24d20b1a5b@gmail.com> In-Reply-To: <20260320-vcnl4000-regulators-v6-0-0d24d20b1a5b@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 Sort include headers by file name for better readability. Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas Reviewed-by: Andy Shevchenko --- drivers/iio/light/vcnl4000.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 5e03c3d8874b..939ff2d65105 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -18,12 +18,12 @@ */ =20 #include -#include -#include -#include #include -#include +#include +#include #include +#include +#include #include =20 #include --=20 2.53.0 From nobody Sat Apr 4 03:20:29 2026 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB95A3DE45A for ; Fri, 20 Mar 2026 16:45:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774025150; cv=none; b=tqobc7cbTkanUzljqf16Wz3/kH9mymZDoRzG5HlY9eraq8aXRlCsbI6ZMyYtjqPt11dnmWJlstf74QYhm7Q/fvHTu4sIKGWh2telBvto6tfEueays7HX0Tsw2QaNUfN/8XfT+HBO2fQTEYAza4EaoZDuqD9XhRhFxZQG2cF79k4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774025150; c=relaxed/simple; bh=ZojnK09Mc+1usbeK5j9s42nV+91No9sdCY+jKtF7KAg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Bz5Yyt4IdR+smHj9eiB+V4U8R18s5/s03NvboRq1AEX0j5eej9T9fS0evGY6YSmjj5r9IGy/CwQadaxMpoO9lAldIFHNfzK9K/kp4/5ANzfWdYiRl3ULq9vCyANPaaWDB/QW1vCw+ITrXG+Ezfr/pwOyEYwGHNTUyefKctm1c5A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KEqnn9hf; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KEqnn9hf" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-b936331786dso219827666b.3 for ; Fri, 20 Mar 2026 09:45:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774025147; x=1774629947; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2Jvo2/D8IcbrXgv/nfUWpfBkPNW+8ec4futg+Nh84xo=; b=KEqnn9hfl/Zx5D98fCEqYbBoxP0HUxhsAXydwTMC7QqJgUsBy0Y48E6fzXH8gGjRho wND/w/918KEvsiSHDcH8iPtfmuj243HFANSLLP/3Qkfffy4Iq871eoaHIEzvQLQWuKef 5jj+R/2vzHRlSimnLj2AdKLjZBDHWG09OldGKzB752QH3QwgjioV6Os9+tzuR8eX650u oY+Ou84mlZ/HP+dJk1Z24UMYfGetSd7sn6GGJtTqzKqZPoeLACyODFxSuSb4KqlKJrNT xRyW9wSe51C/TYJxRVx30e2O1BN/G1Vw6TFXnTXEf6sUpUtcs+H+1kAGezMkGV/ZXs6A VyuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774025147; x=1774629947; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2Jvo2/D8IcbrXgv/nfUWpfBkPNW+8ec4futg+Nh84xo=; b=BVswyGK3A/WfiD9+Eh8rXNa5WjZnGC3tbVZMMxF/vIDLmvWikzfjS3H4LHqX26cp9M SuEWvWeDtKHb9RgXumXAINGI0U5f0EGeROijaI03Jzsm1wIqyxLelWnMMcmvyKeJ9eBx Bt+u+r4pX/IxfmVHq0T6uEoVuV+luRNRfHxMrH78NYuJZCM52amRrnIdby0hIhyAdhj6 G8d/AsExTMT3Giv9quZszPBD5pciSbbhuWGJxDD6TYRsKVaYfAEYfwc8C71LhBI/rP8g 97gQFcIOZC01tpbukJF+g5qERk8RmNd6aH4L8RXIvP/nhdBqPiS4QQmjhWTZM4AN8VV5 t6Cw== X-Forwarded-Encrypted: i=1; AJvYcCUhigrgrWyx3KrN8PHYRU+MNSJe8R6nUFZIIhlMPR0lbl/RKPqV9625M9USL7OflwDFKdsOLE3PJ9PNYHQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyP4UEDULj1yMSIExSCq+ls0fHYR1Xd4ZBTEeUTiBqrqRtN1AHT WGXKh77FLm5o3aRaC1q8Yd0K5whH1SjBs4QsX33bGKMVkRzZmuKEWGH0 X-Gm-Gg: ATEYQzxp0h8yYcGk6yCfBwVwlFdaYDJgdu+u71vszaMz5d4p548cAiYdJXVgrlOAglT 1CkmR/4Lyxau79az3LlU3MuwKQOs6Q9IzAcmDLXxjLgUNqWnWseiHCPCB3mInjkqi1u3+Pybiy6 Aua82IWh95Pg8lbyKI4qm0GytNg+w2V71Q2bUGatCwSjSF6RPk+QeEsxYEs5Y23kzmYcPnenZZV G/tjGuftKu9UCl7XTaazYd8tvzqxFQsipUNcDscRtM4URVjYYBDjj6JJW3wKcayjZBzHeJG5hx0 Xz/5F/tM0rIhxzZKP+o9+eKihcY2u4hR0xd+nTiOX6eRcljt2YxVTNO8AoEsPxGxgHZtUHzIMo9 WKxLLCMfB6DVS7Rl960jtrUqSWECcuaZ6rmSAGqQ6wVcS0lbS0DzWPD/KuQ5E7wnrAI00k2J9rF jcLwhPX3hB1c4P3bgI74nffHkXsw== X-Received: by 2002:a17:907:e107:b0:b97:bc30:1bd with SMTP id a640c23a62f3a-b982f1ff0eamr149690066b.21.1774025147086; Fri, 20 Mar 2026 09:45:47 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b98335f1747sm176730466b.33.2026.03.20.09.45.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 09:45:46 -0700 (PDT) From: Erikas Bitovtas Date: Fri, 20 Mar 2026 18:45:38 +0200 Subject: [PATCH v6 3/8] iio: light: vcnl4000: move power enablement from init to probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260320-vcnl4000-regulators-v6-3-0d24d20b1a5b@gmail.com> References: <20260320-vcnl4000-regulators-v6-0-0d24d20b1a5b@gmail.com> In-Reply-To: <20260320-vcnl4000-regulators-v6-0-0d24d20b1a5b@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 Given both vcnl4000_init() and vcnl4200_init() end with dev->chip_spec->set_power_state(), they can be called once from the probe to enable the sensors. Move the set_power_state function from init and call it after init function in probe. Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas Reviewed-by: Andy Shevchenko --- drivers/iio/light/vcnl4000.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 939ff2d65105..287ccd89cfb2 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -280,7 +280,7 @@ static int vcnl4000_init(struct vcnl4000_data *data) data->rev =3D ret & 0xf; data->al_scale =3D 250000; =20 - return data->chip_spec->set_power_state(data, true); + return 0; }; =20 static ssize_t vcnl4000_write_als_enable(struct vcnl4000_data *data, bool = en) @@ -425,10 +425,6 @@ static int vcnl4200_init(struct vcnl4000_data *data) if (ret < 0) return ret; =20 - ret =3D data->chip_spec->set_power_state(data, true); - if (ret < 0) - return ret; - return 0; }; =20 @@ -2003,6 +1999,10 @@ static int vcnl4000_probe(struct i2c_client *client) if (ret < 0) return ret; =20 + ret =3D data->chip_spec->set_power_state(data, true); + if (ret) + return ret; + dev_dbg(&client->dev, "%s Ambient light/proximity sensor, Rev: %02x\n", data->chip_spec->prod, data->rev); =20 --=20 2.53.0 From nobody Sat Apr 4 03:20:29 2026 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 202473D1CCF for ; Fri, 20 Mar 2026 16:45:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774025152; cv=none; b=fosVIEEIv+2p/itWKvRet51Ur3Xt4wXS6pPRXLTiE3EgJTTO0xS/nPXwT6zObd9kqUlaEqb/5TRMA08PBa0KBF/uhhMZEpALe4rQKlEA7noDEnRdunMnUVdwp+nqIZIReMdcXHKr0kas9o5f8l/viEww9nj6tiGolsLI1Hlsa1Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774025152; c=relaxed/simple; bh=o9yuL6PRLokAleeSzTGeuD72GREI4YTgIHEt7F+oLcQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WiF8NfVuw8+a8Isu9c+83xD2BO7/Y+BghhNLy4ZlbahFUgdkGZzkGLJ+FQ0Cv57quJDudbkkBln7YzI7x21xIdl2SyFZK/ZIVHrqha/pwwNb4mRW8VNGvLafI9+jk8m52AqpRn59sB/cTjXorfnJ54Dt3fGcggh69iLLZk2dotQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AeW33kT1; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AeW33kT1" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-b97bca3797dso277882366b.0 for ; Fri, 20 Mar 2026 09:45:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774025148; x=1774629948; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=u9tF8LrahXLfIcW+pium+UIUX/witzxrg1SajUiru84=; b=AeW33kT1roubZ8TdDxaMMszZGe4awa5fx0oQ1VEsE9y+2dCdEEA8c6faqnU1He6Psm ngxlm5VOdojvVIGqkhErHR08mzddnZjcTnf66EFU/wOxfNDEuMxWJDl3XsZJYH7B/3Z8 vthmZQdnaE0YaUZqFqWnnrJaqcEeXBBoM4rgFFyi/C6KnFGPZW6y8uoLMbLbdK8zdFc2 T4ir5dtRBIj2ay7yzi/X7oVNaUKZyiqg3jBrpBJ9lszua/WYoD2xO4HLSd/6ICcfXS8e 7CKLvbemsIlUDjbAHXXgSiNET9TAm+VUrGtbudAezzpt8oLcb6qiawcnGbW/DCJdHYDD wtDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774025148; x=1774629948; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=u9tF8LrahXLfIcW+pium+UIUX/witzxrg1SajUiru84=; b=TVitSmlbL/QvQzcq3xqJeFSG3r4JDJB7sjwC/VGBYTSw9nAXa6x7FAsdbqOa9/02Uc ruU99mDH77d8ZnG65CtTfuPFsoIOYEds56h310eYjEBrs4Xlx4J5QY0YiwriJytgxaUV 7GfwzHGIbGwTrxTDrtEF8vAsu6JXxaOTOTl03E+AawZ9kiedDyKfBHYoXOTAfxTrHvyY xzjrYoMb1xMvDASy3sEsM1/EtXb6cPS9Gnmd5VEwzZHWLaraoAWAOi59i5DYHwg5PPFz e8QZMUCjQgAgav1DRJeojnICW1mrew2PpzFOldPsTjgC9+HtQpeasqzxMkhrrYwind30 9cEQ== X-Forwarded-Encrypted: i=1; AJvYcCVFy1DjwqC3KvI/KtZ6jVQfJVkvL10pbo+uO4pEB09leF++smc0qxGD9/O//P+XnzIYWZ0px5VbqXxAvx0=@vger.kernel.org X-Gm-Message-State: AOJu0YzTgw8VHuHHB1Ra02L/uWlLTRKH1ZAMHJM1J+jxMZlWjlyZl6Jq Vyrmdx8FVAoWTEFdM2Xj5FFvn+pfWopGWTpdARi1q1+scYdxBz3bysya X-Gm-Gg: ATEYQzzIXjqpAgehb7bzYFDklFMakzzIhcphFcm3eP3rimd5YRHtP9uiApVWR6CtOHT V2dHnW27itC8awGSf6Ds1RXRCMmuRb80o9OcLzt4dL7pa2I8163VzQtyxjqYXPJ53kmpcIjvFCq wv5vkwWcErp4qIMIMe0PsfFLDrMEAx7q4jwCqi1qgGwRyju4KbReyYxBx7PqZD8hckPFnDEt6Jp 8R1nLGM8adfp0vVoNNgD563Kt//qghWoDoMCUhW7jAqsYXzsqrYq+kC2EY5xQyd242e5KYEERVU fVFwm53rqJlys4aFzkyyRYN3QJ1ZiZIOsYHZe/EJtgG9ozS5GRZKzGjGHCl+Vme3I6YkgpZIgy8 tDObe2U+1gnWwDD/r8+078DqyXCwMKRg7/mpbrf0abn5ucx7QOsGhnlPzVW1SAWT0aSyHe3IIZ4 66QmD7hIyN62I2S5jmsirSSg9/Ww== X-Received: by 2002:a17:907:170c:b0:b97:9139:738 with SMTP id a640c23a62f3a-b982f2f0c72mr221017566b.33.1774025148287; Fri, 20 Mar 2026 09:45:48 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b98335f1747sm176730466b.33.2026.03.20.09.45.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 09:45:47 -0700 (PDT) From: Erikas Bitovtas Date: Fri, 20 Mar 2026 18:45:39 +0200 Subject: [PATCH v6 4/8] iio: light: vcnl4000: replace mutex_init() with devm_mutex_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260320-vcnl4000-regulators-v6-4-0d24d20b1a5b@gmail.com> References: <20260320-vcnl4000-regulators-v6-0-0d24d20b1a5b@gmail.com> In-Reply-To: <20260320-vcnl4000-regulators-v6-0-0d24d20b1a5b@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 Replace mutex_init() used across the driver with its device-managed counterpart, so all assigned mutexes get destroyed. Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas Reviewed-by: Andy Shevchenko --- drivers/iio/light/vcnl4000.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 287ccd89cfb2..cd7e6ee42cc5 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -356,6 +356,8 @@ static int vcnl4200_set_power_state(struct vcnl4000_dat= a *data, bool on) =20 static int vcnl4200_init(struct vcnl4000_data *data) { + struct i2c_client *client =3D data->client; + struct device *dev =3D &client->dev; int ret, id; u16 regval; =20 @@ -400,8 +402,14 @@ static int vcnl4200_init(struct vcnl4000_data *data) } data->al_scale =3D data->chip_spec->ulux_step; data->ps_scale =3D 16; - mutex_init(&data->vcnl4200_al.lock); - mutex_init(&data->vcnl4200_ps.lock); + + ret =3D devm_mutex_init(dev, &data->vcnl4200_al.lock); + if (ret) + return ret; + + ret =3D devm_mutex_init(dev, &data->vcnl4200_ps.lock); + if (ret) + return ret; =20 /* Use 16 bits proximity sensor readings */ ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF1); @@ -1979,6 +1987,7 @@ static int vcnl4010_probe_trigger(struct iio_dev *ind= io_dev) static int vcnl4000_probe(struct i2c_client *client) { const struct i2c_device_id *id =3D i2c_client_get_device_id(client); + struct device *dev =3D &client->dev; struct vcnl4000_data *data; struct iio_dev *indio_dev; int ret; @@ -1993,7 +2002,9 @@ static int vcnl4000_probe(struct i2c_client *client) data->id =3D id->driver_data; data->chip_spec =3D &vcnl4000_chip_spec_cfg[data->id]; =20 - mutex_init(&data->vcnl4000_lock); + ret =3D devm_mutex_init(dev, &data->vcnl4000_lock); + if (ret) + return ret; =20 ret =3D data->chip_spec->init(data); if (ret < 0) --=20 2.53.0 From nobody Sat Apr 4 03:20:29 2026 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97FA63DF016 for ; Fri, 20 Mar 2026 16:45:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774025153; cv=none; b=RokEld+j5hd8BpDHEToRrRBDlhOPIRNLU2LZHP8oPkQh8cDmB3aEiD1Br++FoXJmO0UJVyVu/akRIwZ5nn3rBu61hAPyhhnIHW0jTiZHQPWhxdh7ZrDrVBrSLCdRu4HD16FnPoJnvZKf4+OcZ9aMSYm0uxlKjb0Ne643jlg8+SU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774025153; c=relaxed/simple; bh=F8JhpNRtISwTJCZ0mFH9huui70rVNKoYVUHt0NiS600=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JkhAFKiV4OL8l9FYIU6v0l6wqLITmuNS+t3sTVSMK3jdSJMf3wwSiPRkIqNzwotX94aE373duYuf51GqqtPrpv6SRF5JnmFIS8lTbbxbMk0w45hYlQJheKQgWJ0W5h1oVlK3DqoLXPksr1XtHen1romORDIce95Q9XsKuuy9VjY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f+nEe1f3; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f+nEe1f3" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-660a58841d4so1003950a12.0 for ; Fri, 20 Mar 2026 09:45:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774025150; x=1774629950; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NwqEwLydPXTJh37lAhGuKLAvUQ1T9VTG2r0Fov0v/5k=; b=f+nEe1f3ErO1LIWPXRYEoiq23dPDAGj4OPXPaRSy7c38rdcD8XFurp84DcTYUvdloL Et0OqPT64yw6/cOsj/sMQPA8Pg6iRH3aq5HY0IKgfq/ej8H/MnO0/tohbPTv0wPB+mN7 VHqap9T9fg/+M/Ei3HVkQkaazhYjoliXSEZrAbKisba9cCt5C53jmKcYYKKegIEHFzZZ lHJVmF9SmUzTLNWNdtrgCN13loIaTPcbi30Kz7kv6a+LE+DmOFaZ+wtTfAN2xC3VB3mW c/1O9iKPgeFeGEyZyY9LxLZkKT4Dqiphm5fzGSwIPVkS0LlHkUE3IMmJuTaS0cxFnIqs qv6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774025150; x=1774629950; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=NwqEwLydPXTJh37lAhGuKLAvUQ1T9VTG2r0Fov0v/5k=; b=cVstQXsM2EH5I6trZRTRJ4AaIPVLcvrbMZ7mAddCsAd+/zCj7OJI53FKLeGczwJ/DD ynaCg/QQFBkQlPnrxz2LeQndJytSr8MMY4SqBQlPR3clQknvqMNiok4LSZ7xGCB5K/x4 LfM+3KK04rqVvTIuVfmCGD1F9ovitAhF5omt7O8IQpjb3B4MVNlFrCG3ZPsh4Gxak/xf L9uSjlzOQQj1wDFprPgDlgwbtQBzFQt+12Fc9/jMw4qR7nXWzhlOs8WMpXfm22A7gifm GpjYy1VAfxAzMCc9WD41owxyrF8u7Kjko92o6v82npLl8Yh7aI4t4P44ZRjEmiY5Xd/D OuRw== X-Forwarded-Encrypted: i=1; AJvYcCXMzlpDjcNUYEuEI22LoUj5TFhwFCjiIkcy/GnWPqZ98zsdyhWA9nBOEdw4zihCWnlOL5M9avJVW0jcO2U=@vger.kernel.org X-Gm-Message-State: AOJu0YyESeHlvke4bAE2/zogdDrXE6FYBoPx7HHDeQ1A2uhtkRii5Z4R j/No5O5jf8tuL7xVJ7zM+LRq5at4tOV0FFetFudcbmJoLtE1Id9w4PLX X-Gm-Gg: ATEYQzzeL8EIJev5j4xXQk3+JvH7CyyQb8vE7iH03lDFNh1wsXjxVK4gnDPUXJSWuAe 32eXPTEJV9ICqpdbZgE94Ci88kenth9EsoQpBZinyWHQrNd39WFgwvrnCkJbXOhIEA/lJ4VlZDR DsBFEsoq8vIqeq0RpxOC0U5PkZh99okD0IzkFbrOkM2drn7jyO1vysG+m7efd2BHvCFVo2wEbLo dDrqGMd1yIry5n7nQmI069+IvE9LKYBJ2jQhcZd4XZIPnCyjMvBzF0Q3/EHYmqaND5jKQyXlFeg Iqvr08qNjJN+4BLnkRHU/Msrs0IlT4CK6jnru64MJW3fpwTsOhjKCtYddRC/V9IGEjfRvq0Zf7W PmXcc7jvd02pldKarc7CYGALfYgdB64CT0JB/V7BP3X8RFPr6DnVlhDJSWCN1d4mUr8jDMoKv8U 2G4AzwhT73SF+TLxUIsvI++9h3it/jx2lD0rmI X-Received: by 2002:a17:906:4107:b0:b98:baf:638e with SMTP id a640c23a62f3a-b982f220a6emr206784666b.13.1774025149534; Fri, 20 Mar 2026 09:45:49 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b98335f1747sm176730466b.33.2026.03.20.09.45.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 09:45:49 -0700 (PDT) From: Erikas Bitovtas Date: Fri, 20 Mar 2026 18:45:40 +0200 Subject: [PATCH v6 5/8] iio: light: vcnl4000: remove error messages for trigger and irq Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260320-vcnl4000-regulators-v6-5-0d24d20b1a5b@gmail.com> References: <20260320-vcnl4000-regulators-v6-0-0d24d20b1a5b@gmail.com> In-Reply-To: <20260320-vcnl4000-regulators-v6-0-0d24d20b1a5b@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 The error code is available in the log after return. In our case, attaching a triggered buffer can only fail if we are out of memory, as no other buffer is being attached. Remove duplicate error messages to reduce noise in dmesg. Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas Reviewed-by: Andy Shevchenko --- drivers/iio/light/vcnl4000.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index cd7e6ee42cc5..76aee16d479b 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -2033,11 +2033,8 @@ static int vcnl4000_probe(struct i2c_client *client) NULL, data->chip_spec->trig_buffer_func, data->chip_spec->buffer_setup_ops); - if (ret < 0) { - dev_err(&client->dev, - "unable to setup iio triggered buffer\n"); + if (ret < 0) return ret; - } } =20 if (client->irq && data->chip_spec->irq_thread) { @@ -2047,10 +2044,8 @@ static int vcnl4000_probe(struct i2c_client *client) IRQF_ONESHOT, "vcnl4000_irq", indio_dev); - if (ret < 0) { - dev_err(&client->dev, "irq request failed\n"); + if (ret < 0) return ret; - } =20 ret =3D vcnl4010_probe_trigger(indio_dev); if (ret < 0) --=20 2.53.0 From nobody Sat Apr 4 03:20:29 2026 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90F8B3DEFEF for ; Fri, 20 Mar 2026 16:45:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774025154; cv=none; b=BWTx/vDI3xL1ObcZ7Wwv9Jfd0DrW9Yt9k1zggn5L0RtsKcbNaoT+ShBETzlpX3jrtfA1bpI4eLtgeU6d1euFqZje358jtYEEd0U+2GS0PshV8Nl8UEeyQ97SPPnKqax826QDw4abT88nKVHeuaQ8TdoHLj6GbxrwJSY2TAd+O6U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774025154; c=relaxed/simple; bh=egKHr0hohoUF1Y46/QK4pbAPf8UkacKpEmSV/fnmdIg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=q5neexRn/Vx4ACcTiHzJ1caCTTcUVsB7N9FH1E54uucnj5Ucmh5nL9N31BqrGgYnEBe2o6aHh0WnaCuvYLY/wCbcHNIQzJXDdTs9w5//PRYWztM9HOuqPhdEs6Xcy42sdxzdja7a1CMSjdXpA4vSffQFXvTav/8WLH+ET1UrCGk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cZ2ErLKP; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cZ2ErLKP" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-660a58841d4so1003983a12.0 for ; Fri, 20 Mar 2026 09:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774025151; x=1774629951; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Dtlos7JIiB738v4Wa8FtbGBxNvY35k21oQSX4LVS2wk=; b=cZ2ErLKPimUcmzLxAc+5R73d16ByjHxAAdvHVg/rsd929ySKBDz1QipHHSe8PpUI7U USRPLL5wVkobakmSG2nQ0tIZXePNDI5klD+XYrOjDDuq4Uy2xqCe/z01Z+12Orc4PR2T XvaAPffabmlP/vY8AD8VTRTz++4bCbpS9hyv89JtCXBB/lDImpvHuQSDqCAvdBRbb+T5 6P6Nern3vI/fFkOQQOsmjJILtKSkh2pfrXU6oOrD4GKNOlM/Zm/seVlIRmIUUCx1t4jL G5LmUK9ye28Ee/x0yqpecqyZ683J0tvVut8uCIzYlOqTmzS1Yn7mDp5dcqUurO2T+lqS y4kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774025151; x=1774629951; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Dtlos7JIiB738v4Wa8FtbGBxNvY35k21oQSX4LVS2wk=; b=q2g3SwsMx8lL2WzN9LbVAtEUjxStBcNaH7gOEqcQFoAB/0omGcPgGmQd9pwjH6Wyip oHQXNQuXw5pK9ldNbc5ZWW30qmBD4/Bbkonuifj8fJJRge43HiGvneNp7ocj854pGRaM I/cwhpKB09TBuT9oB2GEGp4RxshUPl1huGDi42ruYet/kLvNa0ZTvpUprKORhtBspMZp NWCRT3psOQiE3fCAadgi6pG7qS/OaIaGWHBe4og4Ax6hJPEeCgKzoE7kXz4Bvo5/lEju MY/D1FYwv3Tacih33PQ79R32z5jTPXV2alNL3mCLfhv0syxg5xstp6qvqnus7hYYzN6M VNJQ== X-Forwarded-Encrypted: i=1; AJvYcCVCuwjMHjZ3x7vVBqX+Kx7WEYr0sd4jenaxv3Scs0g6vGqdiLwUwR8pVpRNB6OAKsIXowBEKMEgKa95jkA=@vger.kernel.org X-Gm-Message-State: AOJu0YwpjvTDkOEqKcomOh6iXAIf8ac/RtzYONmeqeWZrzWw4lFCd0Cg Et8/CzxrG1K+ZjvhiCqFY5+pYcr89sQl3tJDCYpyVu/0o/b2D0ne/SDj X-Gm-Gg: ATEYQzypWYilF1SyudRo2lizAy5aMa0SJWDw9dtornGqcmtXBmAgbnEDLeM8GNpORHl SlSmDztWwIA00fF14q76M+CnNCUHjKgFqS70qjtmYYMPkO1aPdDKOSnE5UHGxCNIuVVNPfkwpQ3 oWA2PVZzaXKV0G/XhRvZoiUa/3m51gFrFmVTHedQmCbJrrz0reLp4zSt0PTHphSrhSUJ6PjsD/K 5RRce/1rb4FAlDmasWGzd1+YW9nYUYbpeg+BMPU9BP8WU0W+x4vpPkaKwkqMpBuzjJvspQVF74H kh1f9mV0zcUts44LUeZN0YL94fsK7LEN1/ty8QUoqVYGSOt9GOKnwa/40fM1CYAVXsJfB4H0QHr 8X1wHmXo+cMxAZ7BS6MbWSJdFZ3ECeKtAhw5DNl4JU+0v8PMqdUMRn3IHmu2hcLrtfo0RE06aDC EhThcXwNXlKLWu7htruInoHTaFeRdMjWkUxXk3 X-Received: by 2002:a17:906:f19a:b0:b94:22b1:4aa9 with SMTP id a640c23a62f3a-b982f4f9326mr222976666b.53.1774025150861; Fri, 20 Mar 2026 09:45:50 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b98335f1747sm176730466b.33.2026.03.20.09.45.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 09:45:50 -0700 (PDT) From: Erikas Bitovtas Date: Fri, 20 Mar 2026 18:45:41 +0200 Subject: [PATCH v6 6/8] iio: light: vcnl4000: use variables for I2C client and device instances Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260320-vcnl4000-regulators-v6-6-0d24d20b1a5b@gmail.com> References: <20260320-vcnl4000-regulators-v6-0-0d24d20b1a5b@gmail.com> In-Reply-To: <20260320-vcnl4000-regulators-v6-0-0d24d20b1a5b@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 After moving data->client and client->dev into variables of their own, replace all instances of data->client and client->dev being used in vcnl4200_init() and vcnl4000_probe() by the said variables to reduce clutter. Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas Reviewed-by: Andy Shevchenko --- drivers/iio/light/vcnl4000.c | 35 ++++++++++++++++------------------- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 76aee16d479b..34b52725aff6 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -361,14 +361,14 @@ static int vcnl4200_init(struct vcnl4000_data *data) int ret, id; u16 regval; =20 - ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_DEV_ID); + ret =3D i2c_smbus_read_word_data(client, VCNL4200_DEV_ID); if (ret < 0) return ret; =20 id =3D ret & 0xff; =20 if (id !=3D VCNL4200_PROD_ID) { - ret =3D i2c_smbus_read_word_data(data->client, VCNL4040_DEV_ID); + ret =3D i2c_smbus_read_word_data(client, VCNL4040_DEV_ID); if (ret < 0) return ret; =20 @@ -378,7 +378,7 @@ static int vcnl4200_init(struct vcnl4000_data *data) return -ENODEV; } =20 - dev_dbg(&data->client->dev, "device id 0x%x", id); + dev_dbg(dev, "device id 0x%x", id); =20 data->rev =3D (ret >> 8) & 0xf; data->ps_int =3D 0; @@ -412,24 +412,22 @@ static int vcnl4200_init(struct vcnl4000_data *data) return ret; =20 /* Use 16 bits proximity sensor readings */ - ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF1); + ret =3D i2c_smbus_read_word_data(client, VCNL4200_PS_CONF1); if (ret < 0) return ret; =20 regval =3D ret | VCNL4040_PS_CONF2_PS_HD; - ret =3D i2c_smbus_write_word_data(data->client, VCNL4200_PS_CONF1, - regval); + ret =3D i2c_smbus_write_word_data(client, VCNL4200_PS_CONF1, regval); if (ret < 0) return ret; =20 /* Align proximity sensor sample rate to 16 bits data width */ - ret =3D i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF3); + ret =3D i2c_smbus_read_word_data(client, VCNL4200_PS_CONF3); if (ret < 0) return ret; =20 regval =3D ret | VCNL4040_CONF3_PS_SAMPLE_16BITS; - ret =3D i2c_smbus_write_word_data(data->client, VCNL4200_PS_CONF3, - regval); + ret =3D i2c_smbus_write_word_data(client, VCNL4200_PS_CONF3, regval); if (ret < 0) return ret; =20 @@ -1992,7 +1990,7 @@ static int vcnl4000_probe(struct i2c_client *client) struct iio_dev *indio_dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&client->dev, sizeof(*data)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*data)); if (!indio_dev) return -ENOMEM; =20 @@ -2014,7 +2012,7 @@ static int vcnl4000_probe(struct i2c_client *client) if (ret) return ret; =20 - dev_dbg(&client->dev, "%s Ambient light/proximity sensor, Rev: %02x\n", + dev_dbg(dev, "%s Ambient light/proximity sensor, Rev: %02x\n", data->chip_spec->prod, data->rev); =20 if (device_property_read_u32(&client->dev, "proximity-near-level", @@ -2029,8 +2027,7 @@ static int vcnl4000_probe(struct i2c_client *client) =20 if (data->chip_spec->trig_buffer_func && data->chip_spec->buffer_setup_ops) { - ret =3D devm_iio_triggered_buffer_setup(&client->dev, indio_dev, - NULL, + ret =3D devm_iio_triggered_buffer_setup(dev, indio_dev, NULL, data->chip_spec->trig_buffer_func, data->chip_spec->buffer_setup_ops); if (ret < 0) @@ -2038,8 +2035,8 @@ static int vcnl4000_probe(struct i2c_client *client) } =20 if (client->irq && data->chip_spec->irq_thread) { - ret =3D devm_request_threaded_irq(&client->dev, client->irq, - NULL, data->chip_spec->irq_thread, + ret =3D devm_request_threaded_irq(dev, client->irq, NULL, + data->chip_spec->irq_thread, IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "vcnl4000_irq", @@ -2052,7 +2049,7 @@ static int vcnl4000_probe(struct i2c_client *client) return ret; } =20 - ret =3D pm_runtime_set_active(&client->dev); + ret =3D pm_runtime_set_active(dev); if (ret < 0) goto fail_poweroff; =20 @@ -2060,9 +2057,9 @@ static int vcnl4000_probe(struct i2c_client *client) if (ret < 0) goto fail_poweroff; =20 - pm_runtime_enable(&client->dev); - pm_runtime_set_autosuspend_delay(&client->dev, VCNL4000_SLEEP_DELAY_MS); - pm_runtime_use_autosuspend(&client->dev); + pm_runtime_enable(dev); + pm_runtime_set_autosuspend_delay(dev, VCNL4000_SLEEP_DELAY_MS); + pm_runtime_use_autosuspend(dev); =20 return 0; fail_poweroff: --=20 2.53.0 From nobody Sat Apr 4 03:20:29 2026 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F23B63E0C40 for ; Fri, 20 Mar 2026 16:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774025155; cv=none; b=O3hSiJ+DqLgJ8pihXLrK2E98B9fivPi+zfrO3+sX1b2xIF/tVXT0BiOyFweBwGA7IbmnieAgdNjdTnoxuStdp6wJYP7t0rEUQAlQczYyF4ThdpI02/HZQTpvUPLDEbFIlaCPSUL/L97lN7mWRw6jMDUlNt/ev4s+CypikNBB2DI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774025155; c=relaxed/simple; bh=w5xtoSN57Gl+VyOZOhDTahGIJ0RwHfPPzLNAzvBUd4A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BVK3o9q7Rn7qskuSgyZdN9RFdSQmbbAoF9adHO6zJw4N8NQMP1wd3fUYgvT9XNtWfEBQzkxj08IVXexEG1d4kQn8wd4c+DcaIb1cgAkTurtyR2d1Hs1MjKuZAYp1fCktYjlaVvNYpHSlnBdqlRoNznK0f17oRL+ggG7abfl6n4w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lc4SFqw3; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lc4SFqw3" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b9825ba7f9dso203103266b.0 for ; Fri, 20 Mar 2026 09:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774025152; x=1774629952; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j0qPqA1xbNhE1Dv/S7BEHSx+8WdubNnnHdrMlRxqcOc=; b=lc4SFqw3tDDgj3o9HCXTb7+nXRJFpX4ZaiwTkJpTpIP/+Ly0xmWWzSbAZ1Xig3TD4t 6fz15OCBUoZRTO1YoKS/2eV42poQDniH+6bW49c5eb6C5xcPlSXkNgBEoUVMoqa8GApK IZMHdvOCpZT69AgQTztYkQwk5UBqM5umYZMhc2cu8t7bRofWimKcDo56KS/Mz9le7856 rQB7YsvAfS4T9hQds7rVBP3b5IACItFBDFix2ixAZMMLHygmb3KxgtasvuNh39MbRftT 9endyul2xwRpjC+2GLPaK2eBgY/F6gr7o5EUtyAtmT56xaCutbn7YPnj9JJi0PhWq/E4 uH+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774025152; x=1774629952; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=j0qPqA1xbNhE1Dv/S7BEHSx+8WdubNnnHdrMlRxqcOc=; b=Frmey10kFsZL1SKZDw/OVENLpj+g82ZXFBVSOCV3C2VDpVfRUnAZG1ttZKQsdEEKEx RmlY+/Qss1AlaVkL/Cn8N6BMV8P9z6H4MnQfHCEEEnXymS1bvJyAmhfLktLUrAlZz0/r qNhNnYGDSUnD+GznyL3Roq78vEXH3SK0exXg1zl7WwyuKqQAO/zSY/vskfEnvP6n1M/j TlN8iBn91pAZi5XL4O09HQbBKBNPyCR33P8pXdO686FxiWo3z3H7teIB/01MGNIn7r4X oPz42KgNBOVIfrNrfWlUV2OlRVCiv68GDtVSN+NnyU3Fs3POehBN0D/4cYlWI6s9WFKg YDvQ== X-Forwarded-Encrypted: i=1; AJvYcCXgJlvXxqArezQsiTF9sgZmrM6Vvlb3sbFjb+RuNmJvJMYnbXy7k0UFCfkwuSzg5yiGj8DHFDZ2dK8y+I0=@vger.kernel.org X-Gm-Message-State: AOJu0Yyes/mLcdS7b7rlTnOieBxuov8z9eH8E80ihXSX/Ht6nC7n7zx1 +vwwJUQ1cDlJiL2tYzkcCDqey0QhdG4AnQnP39TKSDSZP7buBfYie03u X-Gm-Gg: ATEYQzxezioQEYh5sdyhKFFJUbsJ5PVAYa+3mwt+SG4O5xPGrluYu1Dbb7YiYqdTETe QDisL7W53K/AzYQlFns/8dwI33MDq0WcPSrwaxtG4Ft7Pf9mLBIXKE5+IA2oW/+wM4uamHYKXqb e/kOWQQNFENXlsMusp8eJikl6oCRO69MVoLpZsl88D+2pYPVJF8q2YBZGDzgWkh3Vg9fa3pruvQ 0D9f6ZYucOm2d2dWv5xLk0lLQ61NtHa3nGaA5X2OdUe0s4Yyoa+ccwagTQboYHqp9GLTn2ZWhp2 OLoY4U3jQvVElSd2m4JipEjDcTlNY+UXgyGZQ0msxVDtEVgrA6MtcGpwsJe7nmRp7CqXF2tmyId HT+BUa36noz4gSuvveZDEG6WN35uAMedlDuv00jWkCbdztSCpN6hCbKdhfy4wh5CSkGiP+nCeeU Q/j5amxAMyZIwRmenRQjHxBfCNkbiJ+w6S1FCT X-Received: by 2002:a17:906:174f:b0:b98:42de:3700 with SMTP id a640c23a62f3a-b9842de3755mr92361166b.17.1774025151974; Fri, 20 Mar 2026 09:45:51 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b98335f1747sm176730466b.33.2026.03.20.09.45.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 09:45:51 -0700 (PDT) From: Erikas Bitovtas Date: Fri, 20 Mar 2026 18:45:42 +0200 Subject: [PATCH v6 7/8] iio: light: vcnl4000: remove redundant check for proximity-near-level Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260320-vcnl4000-regulators-v6-7-0d24d20b1a5b@gmail.com> References: <20260320-vcnl4000-regulators-v6-0-0d24d20b1a5b@gmail.com> In-Reply-To: <20260320-vcnl4000-regulators-v6-0-0d24d20b1a5b@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 The data->near_level variable is already assigned 0 during devm_kzalloc(), therefore checking if the property is present and then assigning it 0 is redundant. Remove the check for device tree property and let it fail silently if it is missing or invalid. Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas Reviewed-by: Andy Shevchenko --- drivers/iio/light/vcnl4000.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 34b52725aff6..0a4d82679cfe 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -2015,9 +2015,7 @@ static int vcnl4000_probe(struct i2c_client *client) dev_dbg(dev, "%s Ambient light/proximity sensor, Rev: %02x\n", data->chip_spec->prod, data->rev); =20 - if (device_property_read_u32(&client->dev, "proximity-near-level", - &data->near_level)) - data->near_level =3D 0; + device_property_read_u32(dev, "proximity-near-level", &data->near_level); =20 indio_dev->info =3D data->chip_spec->info; indio_dev->channels =3D data->chip_spec->channels; --=20 2.53.0 From nobody Sat Apr 4 03:20:29 2026 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 286593E1210 for ; Fri, 20 Mar 2026 16:45:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774025157; cv=none; b=md/2uGFg1yeIAhVjQh6Z8XzCabm6XfZc6T9+oyHj3+ISjeopWmo7D7eIeEc6yQ8RyUldDoqrfhMOb6XBMB+Gw/XlIXmi3J5f1kVJBG0UYb1FTL/3/6sjQ4x/p6SgiCrscNQ1Uzt7cSn6QdRB/37bo1htZPOAJSvF9MNyUBytUU4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774025157; c=relaxed/simple; bh=TzB0TDBcyModHlhscKkRyhu+DntXkSWYAGvIUGrcGVo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qFt5dOZmAbYixgzH+g1iePbJzf1nMuUqu1qFXx6kY51/8zVFK64SrdW6fqXLfJ97RK1zRdF9ogJ5JOOt6oOw3OoUMeoEKL0M89T1nCwxoSiW9Qq7BvzvaCtNkxkQDGi2jK4T30eFtKOmXhjs+bQCQO217wZ9StEhxwTba6qI1d4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YlUWndON; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YlUWndON" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b97bca3797dso277893666b.0 for ; Fri, 20 Mar 2026 09:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774025153; x=1774629953; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WUcQHeprPMeRllf18ooNN99GRIW3qgL3Mo3SFM1oI1s=; b=YlUWndONzOoH252UuKR4mPrWecWzZbY3hEXU3k4sXXZk6zyzicZPwNbhM3fvPZO0ER t0qt0VnOpFRqKPjMxftLTD+UEwncaZjI3m938uV1P9wiDmQv5+cY0V9rhR9cGTUPyRwy ei7C6/i/Sng9dWcvH9ASMfBkRjMllw3TKyVYAbrtVzHGhWXsCk904zNxfkQz9r7zB/fd aVd5Olcm/wAWqAD8EL0FYaERCfN9IVBGQVBdS+wzUwFXpIUar/a/xz8mdtUFBpbR4v5r xATi+IGhyt96biURW19ijTc2SaDiZp/MdSwjIgHcBbaEo+1peQoynkzXiv7OFwto8C2R V//A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774025153; x=1774629953; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=WUcQHeprPMeRllf18ooNN99GRIW3qgL3Mo3SFM1oI1s=; b=dhIki1bkA47b01vpRK+XEm0JgHKVZlZNkbbBTC+gMR16i0XzNwjcRRss7viwMoNwtM blvgdftxJJvdf/TdkyDPSvoujcZ/AIDd5nRU5yXKunDB1ZqbmcrQ8bTiyieNbjX64Q4y VTmUh0/Gfv9Bi0B3r1kwyJ85XmbfH0IkFQaWtaV6ZTjT7mGUQ5IQB1zLkB3oaMB0XAjd ihWLQvXhE9M+SmnGbd+fMp7HSZBKPvjvmE3P9/9FEQhifOPpQyyR1R45Y5IqwRQO+xOl BFaiMPd9qPwMYKi72Jfi6q3S8Qk+MXTmShq7ZySaU6wcVJ4z8cHDHsvha5DE/hSQE7s6 cIBg== X-Forwarded-Encrypted: i=1; AJvYcCX2aefsYb55q0xhzjfHDwbK6WVYU8QqEAt6L9Ee/4nTMG5bsvuz3X8UP/gMfRJJmHsaX7GSMA1XawwzcKM=@vger.kernel.org X-Gm-Message-State: AOJu0YyDdEu0CJBe/hUgESFueW4S4v3s4lZ+i7fPqpSSYD3uslnTOQi0 W3Nlto7JZqOkkyyiO/vliE7T08UjkDFicH0J4fUEIFRQYh4o7+5gYDa9 X-Gm-Gg: ATEYQzyY1y/YAzw88mCbGX09MkDWtT0dFLb+rJAVamSt4ILZZ2/xLYqcXpUIJkRB1Qr G0I2ab+B/EI6WjGOcw73txZxxTBxsOQhHMBPuW6CVYulK2mrL7f2vwy2KsKCFzCCAHFasVQNbte Pley0G/sfjMwjnCoAjBLzZHcCT4G0VRnIVHL8ucUXeXIybroMCW/mk5FClNao4X/ftziMhCmJQP UqbrgrLLBhBKu8jCbCgg5ay8kPOqFjeDFLJLC2P9sn9o0t7/d5jGuxhhkgHs1sHbaXH4TYAYxJK Cg/oyjmx+4eQp4uiLzhULHVcuubqKVSSjVJRflH3pgRq6f16hfq+Y8YioXfS8IPfMG4wI7Ixp9k h3o935SCkjnw2JD2W3kK9AaTnwjL8jm936sZ9mRqeM3w5cBO+jeGIR+IaAcqSeD76Ya3V4S1RfK RE9d4ynb1TvgrmPfs1ndHp/Egm5xHLNqD3Rpla X-Received: by 2002:a17:906:2092:b0:b96:eb74:3152 with SMTP id a640c23a62f3a-b982f21d50dmr180531966b.22.1774025153243; Fri, 20 Mar 2026 09:45:53 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b98335f1747sm176730466b.33.2026.03.20.09.45.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 09:45:52 -0700 (PDT) From: Erikas Bitovtas Date: Fri, 20 Mar 2026 18:45:43 +0200 Subject: [PATCH v6 8/8] iio: light: vcnl4000: add support for regulators Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260320-vcnl4000-regulators-v6-8-0d24d20b1a5b@gmail.com> References: <20260320-vcnl4000-regulators-v6-0-0d24d20b1a5b@gmail.com> In-Reply-To: <20260320-vcnl4000-regulators-v6-0-0d24d20b1a5b@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas , Raymond Hackley X-Mailer: b4 0.14.3 Add supply, I2C and cathode voltage regulators to the sensor and enable them. This keeps the sensor powered on even after its only supply shared by another device shuts down. Reported-by: Raymond Hackley Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas Reviewed-by: Andy Shevchenko --- drivers/iio/light/vcnl4000.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 0a4d82679cfe..9650dbc41f2b 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -24,6 +24,7 @@ #include #include #include +#include #include =20 #include @@ -1985,6 +1986,7 @@ static int vcnl4010_probe_trigger(struct iio_dev *ind= io_dev) static int vcnl4000_probe(struct i2c_client *client) { const struct i2c_device_id *id =3D i2c_client_get_device_id(client); + const char * const regulator_names[] =3D { "vdd", "vio", "vled" }; struct device *dev =3D &client->dev; struct vcnl4000_data *data; struct iio_dev *indio_dev; @@ -2000,6 +2002,11 @@ static int vcnl4000_probe(struct i2c_client *client) data->id =3D id->driver_data; data->chip_spec =3D &vcnl4000_chip_spec_cfg[data->id]; =20 + ret =3D devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(regulator_names), + regulator_names); + if (ret) + return ret; + ret =3D devm_mutex_init(dev, &data->vcnl4000_lock); if (ret) return ret; --=20 2.53.0