From nobody Mon Apr 6 10:46:14 2026 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FB2735AC07 for ; Fri, 20 Mar 2026 07:49:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773992959; cv=none; b=Gl0XAxKcydacKWFhg3XVwIEO9IX2fUnP6yqvuaEM5T64PainvVtwyMVTFFbUex10WmBxK/bdVw3bLLM59nphhKkazSsDiwVcWI2xQUVAeLwHH0/Dnh45l15hV6yN86I8S/TiuaAzU1gaSACBpS8eRGXBGB7ocmw7b4KZ/YU18s4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773992959; c=relaxed/simple; bh=dHOn47CxV3cioQiYZvZ36Ymk/HrieqiVTgJypVWy780=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=sL22IMGBYhNdfUvcPxwTBhjLFgWbBOgq1yghVWHfGHmR0Z7KfDSz0nYczIOxPXdYhc1csVfdbMMHxmDmKHFahLtz6XPobhYnm9xO/+CooaiB6qlKF1IDElItRNZlJClBfgAau9uCF80M7+7PRDjboDGIoRLe5ZitZQ5NBbu7WZo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=T2Y3PmmE; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="T2Y3PmmE" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-59dcdf60427so1782224e87.3 for ; Fri, 20 Mar 2026 00:49:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1773992951; x=1774597751; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=IABUD8O3WXGeDB/bSNbuo2NmXQhI4RO1dp9++xxBliA=; b=T2Y3PmmEEwOvKH5lj9elmQurMRuX+lS2KLLXLsM/vPIAxmrJ6kfXzDcXA5/Uyc7MFc Z6oHYhbF2Bsd+x5OqpsaSQNinxPYfPdiBLVaoWUDMDMfGmXqOFPUWEP9KcraboFtty0p 4lkDbTIKh3YzvqubkcuUtypQCiQqH5mWnQCuQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773992951; x=1774597751; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IABUD8O3WXGeDB/bSNbuo2NmXQhI4RO1dp9++xxBliA=; b=KrMe2BJFSOmu2+HZFp8BeAPXh/WSTSuASp7LyqPNN5apgmuBi5GiaJjPUlNCbMfNDV e3J7vw/Zo/NgmdPrNiRJ45VX2y8dDJXdtXQ8ACaHUHtdFHpp51fJlWa4bRfu8izV/ZI2 8HJ6fsmMtHzumb25J1r8bL4wWkhkcUCGHz0+vE3wYN2AWR4mmkJJ52l8y/3F1DN8CEVi mVWQ9k5wJSDxiAq66I+s8U1A3sudQUK+Dbu8ztSVO4GsepsTV/IJR5vLKbLCxUJmiMfQ qoVwlK0JwYD8iv6vYkvFJZauccKfuE83fiAn1+AR6cdmLdlvy7vyDc3VXHtY9uYzxpB6 tqJQ== X-Forwarded-Encrypted: i=1; AJvYcCUal0wECBtDwZmcPN58MjdD9S1zACKI31zhbjNNgfa+QDVCJPjANjrDKLwqat+qz27P9TdWQqAagGEkI2A=@vger.kernel.org X-Gm-Message-State: AOJu0Yzaq7t5CnNEd4khy0A/hNGp5Oc7UK+oHkbfZqSW9XHX+U5Wc/eh oouygwe0r07yNISImoqoXOVhQo9GoyYltuJ9uTpmsWSSXjMwEtRA2aps//5WAh98gw== X-Gm-Gg: ATEYQzy4Z5fTl6QKcyB4goGC+2yVFA/y0d80+dBz/IQBJI39mfG+JaB/2qbKraV5Dz0 6EPv59nF7FHcRr2IH7Ov1J/KWYJ7sNkAmttt4bDuDHt7l40mapw/jf8j5isSJEBkuaFLgQNo1vN pXjvkJ50KDsNcY9V+k8o4VJg4awp49fBS4jMlilP8JhhLQ23TFHIlvH0aUHWfoG/n0zUa+Jficb 86oH4Yyob7aKptbcpkUW0AtPNgkEEQYq0tc9hkaRi3+ECLm7oUj2VhUsU35D9Jkmya9lqPNZ7O1 wdKiVq/e/E7l0QueYo3Rb1UV5NMs5TyTFyrRL8t4nEf+a3707th05h8WHHcpplCUYbnvj7qHmaS 6So9CGEcVIbnWqFN92qMtF6nxnnOuhDIfcGWzMDOWutwdmZIxBe8PaBLXSxvi4L+g7bjoUHzI3r TKlS1sS1E4gJk5ccqZUDo2AyY+FlTL3q1Hi2/iuxdxWBniO8RxRT7vHEqEJe6Uc1N0xh2ZBtSqx 38QQfI= X-Received: by 2002:a05:6512:a96:b0:5a1:30b2:f2c with SMTP id 2adb3069b0e04-5a285b9c469mr641994e87.42.1773992951332; Fri, 20 Mar 2026 00:49:11 -0700 (PDT) Received: from ribalda.c.googlers.com (252.116.88.34.bc.googleusercontent.com. [34.88.116.252]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a28530ce68sm372272e87.80.2026.03.20.00.49.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 00:49:10 -0700 (PDT) From: Ricardo Ribalda Date: Fri, 20 Mar 2026 07:49:10 +0000 Subject: [PATCH] media: uvcvideo: Fix bug in error path of uvc_alloc_urb_buffers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260320-uvc-urb-free-error-v1-1-b12cc3762a19@chromium.org> X-B4-Tracking: v=1; b=H4sIAPX7vGkC/x3MOwqAMBBF0a3I1A7kAxHciliY+KLTqExQBHHvB stT3PtQgQoK9c1DikuK7FuFbRtK67QtYJmryRkXjHeGzyvxqZGzAgzVXRmdj3aONsBZquGhyHL /02F83w9RAs7mZAAAAA== X-Change-ID: 20260320-uvc-urb-free-error-e73b1db16e21 To: Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab , Hans Verkuil Cc: =?utf-8?q?Marek_Marczykowski-G=C3=B3recki?= , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.14.3 Recent cleanup introduced a bug in the error path of uvc_alloc_urb_buffers(). If there is not enough memory for the allocation the following error will be triggered: [ 739.196672] UBSAN: shift-out-of-bounds in mm/page_alloc.c:1403:22 [ 739.196710] shift exponent 52 is too large for 32-bit type 'int' Resulting in: [ 740.464422] BUG: unable to handle page fault for address: fffffac1c08000= 00 The reason for the bug is that usb_free_noncoherent is called with an invalid size (0) instead of the actual size of the urb. This patch takes care of that. Reported-by: Marek Marczykowski-G=C3=B3recki Closes: https://lore.kernel.org/linux-media/abycbXzYupZpGkvR@hyeyoo/T/#t Tested-by: Marek Marczykowski-G=C3=B3recki Fixes: c824345288d1 ("media: uvcvideo: Pass allocation size directly to uvc= _alloc_urb_buffer") Signed-off-by: Ricardo Ribalda Reviewed-by: Laurent Pinchart --- drivers/media/usb/uvc/uvc_video.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_= video.c index 40c76c051da2..f6c8e3223796 100644 --- a/drivers/media/usb/uvc/uvc_video.c +++ b/drivers/media/usb/uvc/uvc_video.c @@ -1751,7 +1751,8 @@ static void uvc_video_complete(struct urb *urb) /* * Free transfer buffers. */ -static void uvc_free_urb_buffers(struct uvc_streaming *stream) +static void uvc_free_urb_buffers(struct uvc_streaming *stream, + unsigned int size) { struct usb_device *udev =3D stream->dev->udev; struct uvc_urb *uvc_urb; @@ -1760,7 +1761,7 @@ static void uvc_free_urb_buffers(struct uvc_streaming= *stream) if (!uvc_urb->buffer) continue; =20 - usb_free_noncoherent(udev, stream->urb_size, uvc_urb->buffer, + usb_free_noncoherent(udev, size, uvc_urb->buffer, uvc_stream_dir(stream), uvc_urb->sgt); uvc_urb->buffer =3D NULL; uvc_urb->sgt =3D NULL; @@ -1820,7 +1821,7 @@ static int uvc_alloc_urb_buffers(struct uvc_streaming= *stream, =20 if (!uvc_alloc_urb_buffer(stream, uvc_urb, urb_size, gfp_flags)) { - uvc_free_urb_buffers(stream); + uvc_free_urb_buffers(stream, urb_size); break; } =20 @@ -1868,7 +1869,7 @@ static void uvc_video_stop_transfer(struct uvc_stream= ing *stream, } =20 if (free_buffers) - uvc_free_urb_buffers(stream); + uvc_free_urb_buffers(stream, stream->urb_size); } =20 /* --- base-commit: a93a51f42ac354425a252210183c4151d991f75d change-id: 20260320-uvc-urb-free-error-e73b1db16e21 Best regards, --=20 Ricardo Ribalda