From nobody Mon Apr 6 10:46:12 2026 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6266282F2B for ; Fri, 20 Mar 2026 13:35:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774013755; cv=none; b=Ulxkrcr3e7PzefPciTctDrju1zIBkA92u3xzmji9eQ228t8f4dG9dORw+zhx9CLhFJ6U+pH55KmTSbHToRhyf0quL61faBhtcN+PMwU0QlQPFsQp+F3ERUtEF72xBcsTQbhfh27zTwPmWZmDE7FBTM03+IT9ZOeKaSCuV6elvMI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774013755; c=relaxed/simple; bh=p/nfFc6jaqPmOl8LVm2o/szIl6PdJBQE6bZQXHDDaZ8=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=iMhuzTpJ3P33dSMXUyfCj9pKYtlDdQa/GZ9BtcOvJOpHcFGXB26b55mZYg1XlIaSYGs7zcNzwhkiKBOjmcSinAX1TEMwLRo2sU3yoaUMQFljS1wW2lC066GpS/FVogHyRInPb5jCK1c4QTR0L5AP2GLOeo0q6lOkTKaZsHb1DYM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=I+3kGhFw; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="I+3kGhFw" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5a0faa0d15cso1931164e87.0 for ; Fri, 20 Mar 2026 06:35:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1774013749; x=1774618549; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=LcF1YPc4Y6f7tDQasAIKkm8P8aE5YGWgMsq6kp+KiU8=; b=I+3kGhFwr5dGJjOsWyWznNt+XCIaN+CHY0fEXcrah4GyadhX+d3czeKBj20/rYtLod ulwr2flvTGxX24sYUOPp5Q7E2o9YcNHK+oU6Rnp8vGAnER2QLmV2R6S6qwXUs8dvYDJN CYickovB5w71oWepZm1HYfBW16jPYanXI/bT8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774013749; x=1774618549; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LcF1YPc4Y6f7tDQasAIKkm8P8aE5YGWgMsq6kp+KiU8=; b=kmQ3A2AD7+AUpsl1jQQ+XKkTnSp7MWP5Hx56hL5yoqEwvTIoZqU1qwFWyl0R1Z76Ec ohZHLBu7mPXRMiZlPRqhic83FCyQbAzXcI1MffSnVzUJ0yYFkSN9q3G81aH95EeUqKid Wwe3o7xvSkcM7pbRMpYxEmy6zCF8gMDrDGuYpwGuiFk87CevJQFBr4yXfhA6Xipc3E9t af6d3x3u/0wJfGayPNpo/pOESwoOu9CYeJ40a8p3FYkrM1M7/65HKbWDD2Y3xrtg0vXR EmH0TzizDttcb/sLvupUgdoygAJB89vf/fBTID9V1wYxgEa/sqtkgkOavMehIbZ0aEwN /gLQ== X-Forwarded-Encrypted: i=1; AJvYcCW7bA6l8+XhWCmtdXbKb3CWziAZeZjMDRbS9wZ9pmkv2kcmxvGhRcOF/JJQ8QP3tx1jqVarqvKdrFywkxQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzult3AHLnYD6RY6jlAnIySNqNu92v7YNnDFwJ0KWTrlcVyV2MG 3A9KXzRKdT7JrKKJLvA7SFt9Invbcoy3GB891h7/1F3g/QtNkspkDP21h7nJBACxrQ== X-Gm-Gg: ATEYQzwV9BI+5aeqK5SG6tQWFmVtABgYUVTgot8cJhbljw926IHpil9cosu0oRvgfHg Pc5nC8r/18Xa+0dfvUTiqqkHnFsK/Z8Nrvy5sYAG72JBnoBynHogix4FSBcfOf6cBszxlW7RUHK yinAHQeAMM5VGanwjZxUublgRqh9EnwFVSVG3cEklMSp3GuqM2eB7BifQ0THV2+w87bjurHm1gK Mco++00pRBVlMuOD+oZ3HeHAC1shIhkzrxY3QemTG+IS+zT663oMK4U3R/zF0WQH4IUc3wy8toZ NTORx0gn1NC1oMvYgFjlil7br7qI+PAylJyuqTbbhZMy7AyWrnWVjgIt2J8dayMth2pilhGq2EA sowRn+vgx/cFaofcDrE147+OwyfLkE18S8WKVtsaZOAxbQBIjHUo5bF8+Bf0Kz6nVSxXTvrl3Ft XgisTkqB6Wsj1Cm5Ecs63XkdRtIDz+M2YFk0X+iPS965ZYYoaf2PmGJR3zR71bvVVTUrRuEsT+v 5z/ijs= X-Received: by 2002:a05:6512:10c6:b0:5a1:3f6b:f61f with SMTP id 2adb3069b0e04-5a285b4df0bmr1277183e87.28.1774013749524; Fri, 20 Mar 2026 06:35:49 -0700 (PDT) Received: from ribalda.c.googlers.com (252.116.88.34.bc.googleusercontent.com. [34.88.116.252]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a28530cb91sm553112e87.77.2026.03.20.06.35.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 06:35:47 -0700 (PDT) From: Ricardo Ribalda Subject: [PATCH v4 0/2] media: uvcvideo: Fixes for frame sequence number Date: Fri, 20 Mar 2026 13:35:44 +0000 Message-Id: <20260320-uvc-fid-v4-0-f24f168ca2f9@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-B4-Tracking: v=1; b=H4sIADBNvWkC/23OSw6DIBSF4a0YxqUBLo/QUffRdKA8lIHaQCVtj HsvOtG0HZ4bvj/MKLkYXEKXakbR5ZDCOJTBTxUyXT20DgdbNmKESQKU4Ckb7IPFjjohOFeN9BS V14/ofHhtpdu97C6k5xjfWzjT9frbyBRTLBwoa8AowvjVdHHsw9Sfx9iiNZPZkcJOWaHgVa21t Jpw9YfCkcqdAibYKA1Q/i91I77osiwfR+SzmxcBAAA= X-Change-ID: 20260310-uvc-fid-e1e55447b6f1 To: Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Yunke Cao , Ricardo Ribalda , stable@kernel.org X-Mailer: b4 0.14.3 This series fixes a couple of corner cases where the frame sequence number is not properly handled. Please note that the second patch has not been tested in a camera without EOF. To emulate it I have used this: diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_= video.c index b66d701f2582d..097bed2f7845f 100644 --- a/drivers/media/usb/uvc/uvc_video.c +++ b/drivers/media/usb/uvc/uvc_video.c @@ -1360,6 +1360,8 @@ static void uvc_video_decode_end(struct uvc_streaming= *stream, { /* Mark the buffer as done if the EOF marker is set. */ if (data[1] & UVC_STREAM_EOF && buf->bytesused !=3D 0) { + printk(KERN_ERR "Ignoring EOF\n"); + return; uvc_dbg(stream->dev, FRAME, "Frame complete (EOF found)\n"); if (data[0] =3D=3D len) uvc_dbg(stream->dev, FRAME, "EOF in empty payload\n= "); Signed-off-by: Ricardo Ribalda --- Changes in v4 (Thanks Hans): - Fix 2/2 logic. - Link to v3: https://lore.kernel.org/r/20260316-uvc-fid-v3-0-c793354469b5@= chromium.org Changes in v3: - Fix typo in commit message. - Add new patch - Link to v2: https://lore.kernel.org/r/20260313-uvc-fid-v2-1-3f7a996d9047@= chromium.org Changes in v2 (Thanks Laurent): - Improve commit message. - Remove original timestamp and sequence assignment. It is not neeed - Link to v1: https://lore.kernel.org/r/20260310-uvc-fid-v1-1-5e37dc3c7024@= chromium.org --- Ricardo Ribalda (2): media: uvcvideo: Fix buffer sequence in frame gaps media: uvcvideo: Fix sequence number when no EOF drivers/media/usb/uvc/uvc_video.c | 66 +++++++++++++++++++++++------------= ---- 1 file changed, 39 insertions(+), 27 deletions(-) --- base-commit: a7da7fb57f2a787412da1a62292a17fa00fbfbdf change-id: 20260310-uvc-fid-e1e55447b6f1 Best regards, --=20 Ricardo Ribalda