From nobody Mon Apr 6 09:12:06 2026 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E42C3375AA6 for ; Fri, 20 Mar 2026 08:55:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773996921; cv=none; b=ZcXBkDm42Iw6VppYd/zZF9njBCxfVwHcNiaiXRWJnBr9LBKOQUIVAAZCPAS7j5LPngYSG4fZTn20zJ/mDgbF03QXYPMY7pvUDfZZeorDDkOy8FG2NFKUpBG0OlIaC+LkcC0RnXZ+38tJjp+V4mgowVE7w+3uKiC8jtOFtCORpOc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773996921; c=relaxed/simple; bh=GaK3fnyt6sUtJdGJ1MYlD0Zj97Sh5Zjn/UmRR+fsbns=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=VUcWOqNcASwKI6JZF6asKogAFmLmJ+T8drgUfIWeHs/DFQ5GAfg3PfKiYv7Kgn943idf3dCt9he8P3wECzMBhDaDSRxtwSuDO3KhM9HeuV9W3bfi91bzyogKD+96FFN6pI1T974nA1jriTwOMmZlYKlk5xGbjMR96Suqkv/7nNE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--khtsai.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=jIUegXOV; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--khtsai.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jIUegXOV" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-35b9894f9ceso1930577a91.2 for ; Fri, 20 Mar 2026 01:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1773996919; x=1774601719; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=WgV220nsjvXYUtCcSN6gGHf35gDIvTt1U7idg/3OBAg=; b=jIUegXOVMODGeq7BYevvelsOBx0iDFcukCVoxXqPAx1lvGDcVjngh3jzkgcXwAikrU v17PHO5tTHqnwkpnqWrRKhpvHtvIcNQ9nIlAbDT6HvZA3rtyWcTjXc2ewudEI2zgBjyD WTwAt8lAcNedTr/yYL6wu+I7ImbKsusnGS1C83eChbifDSGcafhAkbyXWXbnPIR2Jk8r 0kdNudl1ZMFAQPffrTxzR+AVlay75kPk5+gYgOaeD8qQyjPAmTeCg1pNFlfPc9CNTsca IZ22fP1m7wQOj9TrvgDp7rpZyCcN/gIicfbsAQlvMHXhy6od7AFXIhJ4HX3S4j677tX2 Mn2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773996919; x=1774601719; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WgV220nsjvXYUtCcSN6gGHf35gDIvTt1U7idg/3OBAg=; b=Vl+I0au5c9nh0x2MosIcjlxXYXtc1ZOxZd526AJTYScOY0A2diO+FvvQA2Mm0eUumB stUegENff/1nq419bCTNFSrJPHo+us1A8Ia633JcxJbNf1DTlM/yE4aPFYAGGbMCVvLo ziMCywtBaZylYuH8k4J4mTHUONzWBq6vg6ApeZbFYhKVn3vPiONMla9JQ74dVbKwhOj0 03w4zbif4G2P/jKGZtNSznDYBDxud0AuCxvvzcnjbZwwAgthl/qSkhuiSbB1hEGH/UvV jU06MoK3/WiYzF1CND104XrYP9IsRdaXVJmXaQTBZFZa+vznb2wsHdOGOqN6IOWXYT9l ZElA== X-Forwarded-Encrypted: i=1; AJvYcCXjHvQWnglsJD2hU4hHSm1PiiVPJgpzAASHxybtQ0Q1bFlVYgYarpYONiFwcHgn6/KK7WKZZtgexGZgJZY=@vger.kernel.org X-Gm-Message-State: AOJu0YzvXFr9nUKK7gpUhFbWLy9C8HUO6uDjx9uiXxUd3H9cH4Ek7Grv 6qvB8QpEVOonxJ4RnTukUpfaU9wtOrC2uJ4yyaFbgZARsJU2P5zlHAaLvvfdnDb/ZOXSiPVthzL Cquo2IA== X-Received: from pjzl15.prod.google.com ([2002:a17:90b:78f:b0:35b:9114:f5fe]) (user=khtsai job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:184c:b0:354:c593:b1a8 with SMTP id 98e67ed59e1d1-35bd2be16b5mr1830414a91.13.1773996919107; Fri, 20 Mar 2026 01:55:19 -0700 (PDT) Date: Fri, 20 Mar 2026 16:54:44 +0800 In-Reply-To: <20260320-usb-net-lifecycle-v1-0-4886b578161b@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260320-usb-net-lifecycle-v1-0-4886b578161b@google.com> X-Developer-Key: i=khtsai@google.com; a=ed25519; pk=abA4Pw6dY2ZufSbSXW9mtp7xiv1AVPtgRhCFWJSEqLE= X-Developer-Signature: v=1; a=ed25519-sha256; t=1773996915; l=1297; i=khtsai@google.com; s=20250916; h=from:subject:message-id; bh=GaK3fnyt6sUtJdGJ1MYlD0Zj97Sh5Zjn/UmRR+fsbns=; b=+/IvBeyEb1KCNPGCJl7fYirjn/sIcTPTyTsiNvrttl0wrz+0QELKMA77pGV/5JzGwEn4uyrqU 1JFgAyJdvwDAYFphJqt0GWYWcl0P/WoopApWoF1kDXk2/A0+tEL7oab X-Mailer: b4 0.14.3 Message-ID: <20260320-usb-net-lifecycle-v1-1-4886b578161b@google.com> Subject: [PATCH 1/7] usb: gadget: f_subset: Fix unbalanced refcnt in geth_free From: Kuen-Han Tsai To: Greg Kroah-Hartman , Kyungmin Park , Felipe Balbi , David Lechner Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kuen-Han Tsai , stable@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable geth_alloc() increments the reference count, but geth_free() fails to decrement it. This prevents the configuration of attributes via configfs after unlinking the function. Decrement the reference count in geth_free() to ensure proper cleanup. Fixes: 02832e56f88a ("usb: gadget: f_subset: add configfs support") Cc: stable@vger.kernel.org Signed-off-by: Kuen-Han Tsai --- drivers/usb/gadget/function/f_subset.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/gadget/function/f_subset.c b/drivers/usb/gadget/fu= nction/f_subset.c index 076072386e5e..74dc6da5c767 100644 --- a/drivers/usb/gadget/function/f_subset.c +++ b/drivers/usb/gadget/function/f_subset.c @@ -6,6 +6,7 @@ * Copyright (C) 2008 Nokia Corporation */ =20 +#include #include #include #include @@ -449,8 +450,13 @@ static struct usb_function_instance *geth_alloc_inst(v= oid) static void geth_free(struct usb_function *f) { struct f_gether *eth; + struct f_gether_opts *opts; + + opts =3D container_of(f->fi, struct f_gether_opts, func_inst); =20 eth =3D func_to_geth(f); + scoped_guard(mutex, &opts->lock) + opts->refcnt--; kfree(eth); } =20 --=20 2.53.0.959.g497ff81fa9-goog