From nobody Sat Apr 4 07:47:56 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCEB9282F30 for ; Fri, 20 Mar 2026 14:56:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774018603; cv=none; b=eDfghQB4EsKrMKtuocsEfM2g3ugLv3983RgSKfgcS2xlOWdr/phNb8jQzKWa4I2qP56QXKoTZXoRfFKoSfQb0hJOwRpq8Q479naGdvZEiIer0Pi5rYQBiV3Tp3gp/q01fjVb1ZWoNDP2sY40hwZ8Bg+Wr1GQGNCjrtX4N82N47o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774018603; c=relaxed/simple; bh=dTEF6bdzJt2V7+xYx3YhBkPgCvZNNJYAeLwsU1oWSB8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=gDNLAT/7JMKA8qCAxeTh6rrUiG+RpI5xz8rBC+NZXtNYKnkmTSL5ZsdyW8PMa2ZpUJA3sCdX9GIuD/a3Vs69M+6yexGnfdtCieGAzfxwe0hirhFbHD41ggJyQa8Lnnva6FMAbPXTUiKFpB2toYfOrcaK9prQyUYC6hkVIZnxOu8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fkTjX55j; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fkTjX55j" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2b04fc8851cso20621645ad.0 for ; Fri, 20 Mar 2026 07:56:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774018602; x=1774623402; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=wFetc6x2soh6YI39fkTNs8ZpWw8wHx4vhOBrBQajGIw=; b=fkTjX55j/fO7t4zMkgv6Hamw/Vzoov8IqIFi/GrBEGG8sF0HhT7Oto4o8s9psKUTr9 g1NfBx9jnuWJOCG4VXowgn69lhwLCAkGS8zz5eH6ftyJCGgA+/Edt51D/JYOCFPRwByV tbf0N5V7pdaxBK/L/NZH7IBjgp94AxAAn8XMIMpb3hN8kKUrU9R2dxmpef/P8ypoVMyA 7ufy+TuTsmJufSBEM4cxDrmdDrCGHmbwH+++lpRkFkj7fkzD3NT5x2OLSP6SYxZYH+td LObjY9NaKRswE1ObZemQOjD5drIMaiRRKFXY+XLI2ce7xoGuRC9j9vXbWHfKUToEnIIv ZqXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774018602; x=1774623402; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wFetc6x2soh6YI39fkTNs8ZpWw8wHx4vhOBrBQajGIw=; b=JJHj28m4nb+RbZMGx7PS/+wwWFDwWDYo19qhIDx+0EJgp0M7wEDa+nxX+5OECVGsCN z4VZhoOw9bTwQtCkM2VzbE6/QR6Ov8EQzisPjicNjXuK+UOdQyl67N1CrtcwrTl7Esmu TE3PaynGzXBriaNHQHRthbxe3JjRCJRIr0h1yCSE7o6yOvt+1N0il1wr0zsaG8DGR+kb j+OtLdL9ynAaQKmiraunSOWZLhsoyUgWv4h6XyNAjNMJ2Va/VNs2cU5679pcMG8RrkPS VJU09eVaAHVovAtl4zuKgYINPkXQyVMRGYUMbhsY6U2Nt9CVBbcx7Tk1dGzVjJuIzMb3 I4kw== X-Forwarded-Encrypted: i=1; AJvYcCVgeLLDs2brr8dosexL3zWgAv6ABiT2qojS8cailY2gfSqKKs2ywMWlPen9EMoAL7VdIdS+y5cMGfcIM44=@vger.kernel.org X-Gm-Message-State: AOJu0YxDffYqghVx4sJbO3JHTONjEO36zHq4Cm9xf0IRVv+Xutjsx6uW ak/xC8T+7IbIJNa8qC57PBHbJ/fV+KCR+k6g/i3rIpLIpkwYQMzk4uXU X-Gm-Gg: ATEYQzwEZH7uz3xkNm7/DoTcwsbLQ9lDNTuPfSJNP67jYcKxAoY6nXFmDyxmkbM5RF5 IdMMXGEEwON7Pz9ZkSj0NcRujH2ExMtD2q6O7+w+sIubyJR+EMv7L8JO4rtWuiWUXNkGMNoqmFu GyzNgWcYHBh65Gj+guxbQckZv3gVLO9LYO5kGwIz+ztSF37fC3KvhgN6aE/QQ9nT8vD1FLAeNJy 0VGHOZvlvfJOjX25EoDOcu5mcFL3sljDwmWIaReeQy8nW0uDlPo6wJBvR1J3IgrZG0CN710N5uF dmU10ZjtYFBjuUU5Pd6aYfS3Vebr0iYF1FZoI00PqOS9dCy/XTX7DPSnm7FSSLceDIm40TmCkTa CGbt+8vOX6PwSp+i9MnOmgxAgYxhRGrfAUFN+2GeeMfmH/3JZ9GdIi/Ig1sYcPKAA4CVYwymZa9 DaT1LCM/5BV2hRcYnZQqsy1Tlc06Y/eMN7m90h X-Received: by 2002:a17:903:2449:b0:2ae:59d3:27f8 with SMTP id d9443c01a7336-2b082724e99mr29516015ad.19.1774018602048; Fri, 20 Mar 2026 07:56:42 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b08354bce3sm32099775ad.32.2026.03.20.07.56.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 07:56:41 -0700 (PDT) From: Felix Gu Date: Fri, 20 Mar 2026 22:56:38 +0800 Subject: [PATCH] gpio: qixis-fpga: Fix error handling for devm_regmap_init_mmio() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260320-qixis-v1-1-a8efc22e8945@gmail.com> X-B4-Tracking: v=1; b=H4sIACVgvWkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDYyMD3cLMisxiXbPEpCQj05TUREszSyWg2oKi1LTMCrA50bG1tQCdT0f OVwAAAA== X-Change-ID: 20260320-qixis-6abb25dea969 To: Linus Walleij , Bartosz Golaszewski , Michael Walle , Frank Li , Ioana Ciornei Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774018600; l=1201; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=dTEF6bdzJt2V7+xYx3YhBkPgCvZNNJYAeLwsU1oWSB8=; b=FpMb8FisNCCxEePHeBXcUNiYu+dd27SRy9R57Lwaz2+LMCO63yAW/Qa7xNSKte6fBfvsocbe8 zHVLgQAQoGaBYMRwaEnV+hf/Dt/a17aoMNTeTFMzJ6wfMoZTPfSarEh X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= devm_regmap_init_mmio() returns an ERR_PTR() on failure, not NULL. The original code checked for NULL which would never trigger on error, potentially leading to an invalid pointer dereference. Use IS_ERR() and PTR_ERR() to properly handle the error case. Fixes: e88500247dc3 ("gpio: add QIXIS FPGA GPIO controller") Signed-off-by: Felix Gu --- drivers/gpio/gpio-qixis-fpga.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-qixis-fpga.c b/drivers/gpio/gpio-qixis-fpga.c index 6e67f43ac0bd..3ced47db1521 100644 --- a/drivers/gpio/gpio-qixis-fpga.c +++ b/drivers/gpio/gpio-qixis-fpga.c @@ -60,8 +60,8 @@ static int qixis_cpld_gpio_probe(struct platform_device *= pdev) return PTR_ERR(reg); =20 regmap =3D devm_regmap_init_mmio(&pdev->dev, reg, ®map_config_8r_8v); - if (!regmap) - return -ENODEV; + if (IS_ERR(regmap)) + return PTR_ERR(regmap); =20 /* In this case, the offset of our register is 0 inside the * regmap area that we just created. --- base-commit: b5d083a3ed1e2798396d5e491432e887da8d4a06 change-id: 20260320-qixis-6abb25dea969 Best regards, --=20 Felix Gu