From nobody Mon Apr 6 09:18:50 2026 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DED953E7144 for ; Fri, 20 Mar 2026 18:23:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774031025; cv=none; b=n1DSgPD9Rnoo4w2KJuM+tdXfMiCeRfV1exGav6MTW8hgW4qyuowYuVAktyk/ljMtXkIMMNj7nkAI76fIRoEfohPH1dpujKJjtZmQMNVboy8KO5EDCyKvRRRyKZPLttH2D6JfWRbALdXO8vKtJLvZDVexi1nFLzNLIM1lwBCUTbI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774031025; c=relaxed/simple; bh=zwyMVlSjuHoPdb+iTNGQwWL7nrH1MDn8wkgHSBaZaho=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=NXHOYdy7sid/32ZwbkVFgYO9dbNGCgwl1QGW07+im3ILrpJ+qE0C5BkT8P7CpnQcez1S0/ClPJPzw4L0w9HEoVPoxwec9GpLFHcfu3MKDmXC5NdZ9diio0WBNPrzH6o1fS9mSKjaIY9j7aGYMRfypFPj9ka2u/QaME8/LUli0AU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=GVc4Miqe; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GVc4Miqe" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-485375aa56eso8937465e9.1 for ; Fri, 20 Mar 2026 11:23:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774031022; x=1774635822; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Cwrx/w1VbhrLaNu5EmwvIE0sq6jjLjiDS144+1LBu5A=; b=GVc4MiqekOKql32QiJy3/VpKQeEuxmzF/dolty3lG7uNgGraO+RZHTHFqLVOv+5X99 dymYi/x5nbtaFGQED5JhvOLTBsdy5eC+nuguNTG6j8jRFw6r9Tyxv+shbNZQYlRCPGal dv7kdv0FR1cdSASGlJQpKpWLYQ13SVwYRAYDOBRUogvKNUawWsjqOHUk932DTWZPkXII zvJ879HTFuoT6GOg25XQm9+VFstssTQehORHLQ5Yo5ngdtkG7cTSJKE3FEDm++DY5nF6 zjvbXAznglnIzyAOLQvir1DqtJwqvcMCnWLSuQcnvSjMMiZh6FMiWFjgvkExLjJNZcCF rFqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774031022; x=1774635822; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Cwrx/w1VbhrLaNu5EmwvIE0sq6jjLjiDS144+1LBu5A=; b=BXu6lUs/TgDKDBn8/PfqtDr/w+naJ4/0+XL54DUFdlKY8PgaHJdo+a45wfIdze1aAz y+9kZWbQOpddKrcb5cgoQ9zWrMQ5hZ9fv3BljgZfkR1z72bvwSSaQNHgZ5+HB5GWtOAj az+FhbJKep5B5s//yGcKsI1vPTzeVxLaYCZL4S2jtk46ailM8cnOZPFf0qOboFr1S0Vj DFcvob854KNT7M6qlI5/xDuyRmIvjkcfnnREVHXdVSi9FpUvvUNf7EP6RHbHISuGx+U/ GtprjAwVjaBKwK+RDu/KuSeuA/d1aOFo5IJtGitTq+0phJdu/XWm9V6es1xZx8jtocQn q2Wg== X-Forwarded-Encrypted: i=1; AJvYcCUMmFuBiN0VAi3nf+N1/22y6aOSo9BHu9do+h3r9W9uP6kzgRboVFf/pKZG54SdRVAMAX+EhuvRrgTKPtQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyC6UjS9dS2RWByk8JxEEjZQisOGkmVRG265A3LLAh1fbP/KEHT UglUypAXO7+JlPHkBXDkvVZ4tANJ+KmjwrJ7UQvBZtwh18ekabs09fWKvINf/7Twkf+7gWRtkcf 3kmFCer8BGwEPdw== X-Received: from wmht22.prod.google.com ([2002:a05:600c:41d6:b0:485:3947:fd76]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:8b46:b0:485:3baa:af14 with SMTP id 5b1f17b1804b1-486fee0fc11mr60139015e9.18.1774031022187; Fri, 20 Mar 2026 11:23:42 -0700 (PDT) Date: Fri, 20 Mar 2026 18:23:27 +0000 In-Reply-To: <20260320-page_alloc-unmapped-v2-0-28bf1bd54f41@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260320-page_alloc-unmapped-v2-0-28bf1bd54f41@google.com> X-Mailer: b4 0.14.3 Message-ID: <20260320-page_alloc-unmapped-v2-3-28bf1bd54f41@google.com> Subject: [PATCH v2 03/22] x86/tlb: Expose some flush function declarations to modules From: Brendan Jackman To: Borislav Petkov , Dave Hansen , Peter Zijlstra , Andrew Morton , David Hildenbrand , Vlastimil Babka , Wei Xu , Johannes Weiner , Zi Yan , Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, rppt@kernel.org, Sumit Garg , derkling@google.com, reijiw@google.com, Will Deacon , rientjes@google.com, "Kalyazin, Nikita" , patrick.roy@linux.dev, "Itazuri, Takahiro" , Andy Lutomirski , David Kaplan , Thomas Gleixner , Brendan Jackman , Yosry Ahmed Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable In commit bfe3d8f6313d ("x86/tlb: Restrict access to tlbstate") some low-level logic (the important detail here is flush_tlb_info) was hidden from modules, along with functions associated with that data. Later, the set of functions defined here changed and there are now a bunch of flush_tlb_*() functions that do not depend on x86 internals like flush_tlb_info. This leads to some build fragility: KVM (which can be a module) cares about TLB flushing and includes {linux->asm}/mmu_context.h which includes asm/tlb.h and asm/tlbflush.h. This x86 TLB code expects these helpers to be defined (e.g. tlb_flush() calls flush_tlb_mm_range()). Modules probably shouldn't call these helpers - luckily this is already enforced by the lack of EXPORT_SYMBOL(). Therefore keep things simple and just expose the declarations anyway to prevent build failures. Signed-off-by: Brendan Jackman --- arch/x86/include/asm/tlbflush.h | 43 +++++++++++++++++++++----------------= ---- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflus= h.h index 0545fe75c3fa1..56cff03b65aa2 100644 --- a/arch/x86/include/asm/tlbflush.h +++ b/arch/x86/include/asm/tlbflush.h @@ -251,7 +251,6 @@ struct flush_tlb_info { u8 trim_cpumask; }; =20 -void flush_tlb_local(void); void flush_tlb_one_user(unsigned long addr); void flush_tlb_one_kernel(unsigned long addr); void flush_tlb_multi(const struct cpumask *cpumask, @@ -325,26 +324,6 @@ static inline void mm_clear_asid_transition(struct mm_= struct *mm) { } static inline bool mm_in_asid_transition(struct mm_struct *mm) { return fa= lse; } #endif /* CONFIG_BROADCAST_TLB_FLUSH */ =20 -#define flush_tlb_mm(mm) \ - flush_tlb_mm_range(mm, 0UL, TLB_FLUSH_ALL, 0UL, true) - -#define flush_tlb_range(vma, start, end) \ - flush_tlb_mm_range((vma)->vm_mm, start, end, \ - ((vma)->vm_flags & VM_HUGETLB) \ - ? huge_page_shift(hstate_vma(vma)) \ - : PAGE_SHIFT, true) - -extern void flush_tlb_all(void); -extern void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start, - unsigned long end, unsigned int stride_shift, - bool freed_tables); -extern void flush_tlb_kernel_range(unsigned long start, unsigned long end); - -static inline void flush_tlb_page(struct vm_area_struct *vma, unsigned lon= g a) -{ - flush_tlb_mm_range(vma->vm_mm, a, a + PAGE_SIZE, PAGE_SHIFT, false); -} - static inline bool arch_tlbbatch_should_defer(struct mm_struct *mm) { bool should_defer =3D false; @@ -513,4 +492,26 @@ static inline void __native_tlb_flush_global(unsigned = long cr4) native_write_cr4(cr4 ^ X86_CR4_PGE); native_write_cr4(cr4); } + +#define flush_tlb_mm(mm) \ + flush_tlb_mm_range(mm, 0UL, TLB_FLUSH_ALL, 0UL, true) + +#define flush_tlb_range(vma, start, end) \ + flush_tlb_mm_range((vma)->vm_mm, start, end, \ + ((vma)->vm_flags & VM_HUGETLB) \ + ? huge_page_shift(hstate_vma(vma)) \ + : PAGE_SHIFT, true) + +void flush_tlb_local(void); +extern void flush_tlb_all(void); +extern void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start, + unsigned long end, unsigned int stride_shift, + bool freed_tables); +extern void flush_tlb_kernel_range(unsigned long start, unsigned long end); + +static inline void flush_tlb_page(struct vm_area_struct *vma, unsigned lon= g a) +{ + flush_tlb_mm_range(vma->vm_mm, a, a + PAGE_SIZE, PAGE_SHIFT, false); +} + #endif /* _ASM_X86_TLBFLUSH_H */ --=20 2.51.2