From nobody Sat Apr 4 07:59:00 2026 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05C3136E499 for ; Fri, 20 Mar 2026 21:15:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774041325; cv=none; b=nUgGCwjACY84zpFdjuCpRq0dP1MAlGBchVUzjWVPrcuQwtpqweYvcysde5JMfavFvKPsyv8H78akDT7R5RvegZm9XLjsOoRAdJRNSJVadh7PI2oYSxVePgvU9z1LSgcVt7G2s0A7lkl9SvZIOnlM6cD5vveBdb7oJH6AeU/Ywqs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774041325; c=relaxed/simple; bh=hmCRybVAO3Ql9oQJS0F9EO4DcZ+ZoVfk6/BRBT+8IXY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Rq+ls+/IXkRize4iIPFegq73utw69oZg5Q28NNVGvxmCZ8KZ/jqNUkfybg3F7PAnbZUUpX6xTEsMNR5u528iqEB8wgNjkux9Zw+74UP+ev+fGzW6BtjYV1xU5ZmuFKkv+Go7HFtapFpP8ycPILQ5Yz3n75E6k8M8sJnfgnZl+78= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Xb2FKLJK; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Xb2FKLJK" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-439cd6b0aedso1588625f8f.1 for ; Fri, 20 Mar 2026 14:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774041322; x=1774646122; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FqbbWkZUelJgFW3AcjmoveTN0lUpeuVS4Adcj/4N1VM=; b=Xb2FKLJKatJr9lSUpdJt6aZGLvnk+Jg8uG7rnipd1UqQRp8SNKT+fMIpq3Oe8LNG72 CH8gftxzGOF6CVH5qn1qNPtRr0szxrZa5bkO7dIyV3GFx/XpCungfbHhNXCJ9RcIUMhU aWDhkd/nxVhqtCfNEU1GdRXi0dh4rJiESyQcdVWzOV4/QTfscYNW9zLPQIYktX3WJQCG /L1TElGL77sBBrI4KR5ddZ8DWIE3dKu3a6IsfhGXQOqCwS6sM69/ms+XZWIRJbZUXJMQ f3T2ElnyJaEJ2Ot6j3WNqY4BnE9QUTmh8g9j0c8+PYQOibkwuySi1Y9WHR2WYKZe0e/5 n+Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774041322; x=1774646122; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=FqbbWkZUelJgFW3AcjmoveTN0lUpeuVS4Adcj/4N1VM=; b=LPuAx66K3FeldNRPXA1OYSqaXl1YZqEK8LK+51ciEpo5aK4XdE2Vrh/IZNJBmyf/E1 TCzNpTUu4/ijviYs4p3mUBeB5wVLdtccXj2Rji9xLG2/1xzEKp8HK5we6spFjzSP2rgs oe+AHgXIc8Y4l0aNy4KrWvWdwrPIyg7ToZTfBp3Byio2kPmfHj5R14C4Sw4BUdSldoQW 7d+QxBXzYkUIyYXMoO6V2Rka1C1/36c7Taxiw2cDGWGaxfVw1mUamvcOOUFiI5pjx9kA TIJ7WTwWNKQ95s+kA9RXm8iPRKxE3w0i3I4duEAizyumSTnPXSZ415WJIJXIRksx8Tea 24XQ== X-Forwarded-Encrypted: i=1; AJvYcCXqaV+Sk2y2k5eQblujEd3tFgLvTzFGUGAsRpLjUhqMilZ/3FBWYqZbX8gCj7qZc9VQdhoZ9/d26eiq5fo=@vger.kernel.org X-Gm-Message-State: AOJu0YxbECXj7mSNYvcBHEQtiGeiO2hq8KCPb0zRrMYYnKgiXejbwcSC lbR2Uyf8DWG7nJmkkyAOydh1fCzfood5KnaNQRnkXGfh3afgK2MYxaSlZDZs6721ZmY= X-Gm-Gg: ATEYQzz9UwUwMrFWUJn7TvmZQSQ+g7nac/EzjHwN9dSiYnneycsZB+mrJjpprC8vNoj 9jpHIBhbNAcObCf+ibY7pN0Gv+bom3KlVGce4zMuO+jf5p7Oln6FffKc1ZvR5Sqqj3PYAwssc33 fm1nDD0IxzSa/TW0jxp1K/DLmqidFdf289So4E20SRcF1rMS+akb+UKFtax0c8eu7Lm1bOJm3Tf t5bjVTdO4j6dZ96AAXrk6ShcU0dL/bm4mNV0CCLnkSDckuaiB4mtcmn6a8r7HOodGelPU+14TkG NaGFbQatn25TLcAFsheKAgsZ+Jny+2kV06q4G5uHggDB/1FhE+H8eE1fyK8QF5QtZXMnX9NZznH ZOquj606sID7wCpdePtJEp3RDsl3DjQ6gi4VMgnaLabysuJ22o0dCmNgPI00POWHhCGXgN9UjRX /UfqveasYGo7AfH9cLKrvuBGoaDFkzFWOe6fLFTZUAcRu6WGBhldSnD6CvBcGi6A9bFbPwLzOZw v1QZQXO2bQoShw= X-Received: by 2002:a05:6000:248a:b0:43b:4921:8744 with SMTP id ffacd0b85a97d-43b64244339mr7400984f8f.22.1774041322360; Fri, 20 Mar 2026 14:15:22 -0700 (PDT) Received: from [127.0.1.1] ([94.4.193.72]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b64703c27sm9702401f8f.18.2026.03.20.14.15.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 14:15:21 -0700 (PDT) From: Alexey Klimov Date: Fri, 20 Mar 2026 21:15:16 +0000 Subject: [PATCH 4/5] mailbox: exynos: Add support for Exynos850 mailbox Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260320-exynos850-ap2apm-mailbox-v1-4-983eb3f296fc@linaro.org> References: <20260320-exynos850-ap2apm-mailbox-v1-0-983eb3f296fc@linaro.org> In-Reply-To: <20260320-exynos850-ap2apm-mailbox-v1-0-983eb3f296fc@linaro.org> To: Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Sam Protsenko , Michael Turquette , Stephen Boyd , Rob Herring , Conor Dooley , Tudor Ambarus , Jassi Brar Cc: Krzysztof Kozlowski , Peter Griffin , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Klimov X-Mailer: b4 0.14.3 Exynos850-based platforms support ACPM and has similar workflow of communicating with ACPM via mailbox, however mailbox controller registers are located at different offsets and writes/reads could be different. To distinguish between such different behaviours, the registers offsets for Exynos850 and the platform-specific data structs are introduced and configuration is described in such structs for gs101 and exynos850 based SoCs. Probe routine now selects the corresponding platform-specific data via device_get_match_data(). Signed-off-by: Alexey Klimov --- drivers/mailbox/exynos-mailbox.c | 65 ++++++++++++++++++++++++++++++++++++= ++-- 1 file changed, 62 insertions(+), 3 deletions(-) diff --git a/drivers/mailbox/exynos-mailbox.c b/drivers/mailbox/exynos-mail= box.c index 5f2d3b81c1db..3727e1ff0fc2 100644 --- a/drivers/mailbox/exynos-mailbox.c +++ b/drivers/mailbox/exynos-mailbox.c @@ -31,14 +31,59 @@ =20 #define EXYNOS_MBOX_CHAN_COUNT HWEIGHT32(EXYNOS_MBOX_INTGR1_MASK) =20 +#define EXYNOS850_MBOX_MCUCTRL 0x0 /* Mailbox Control Register */ +#define EXYNOS850_MBOX_INTGR0 0x8 /* Interrupt Generation Register 0 */ +#define EXYNOS850_MBOX_INTCR0 0x0C /* Interrupt Clear Register 0 */ +#define EXYNOS850_MBOX_INTMR0 0x10 /* Interrupt Mask Register 0 */ +#define EXYNOS850_MBOX_INTSR0 0x14 /* Interrupt Status Register 0 */ +#define EXYNOS850_MBOX_INTMSR0 0x18 /* Interrupt Mask Status Register 0 */ +#define EXYNOS850_MBOX_INTGR1 0x1C /* Interrupt Generation Register 1 */ +#define EXYNOS850_MBOX_INTMR1 0x24 /* Interrupt Mask Register 1 */ +#define EXYNOS850_MBOX_INTSR1 0x28 /* Interrupt Status Register 1 */ +#define EXYNOS850_MBOX_INTMSR1 0x2C /* Interrupt Mask Status Register 1 */ +#define EXYNOS850_MBOX_VERSION 0x70 + +#define EXYNOS850_MBOX_INTMR1_MASK GENMASK(15, 0) + +/** + * struct exynos_mbox_driver_data - platform-specific mailbox configuratio= n. + * @irq_doorbell_offset: offset to the IRQ generation register, doorbell + * to APM co-processor. + * @irq_doorbell_shift: shift to apply to the value written to IRQ + * generation register. + * @irq_mask_offset: offset to the IRQ mask register. + */ +struct exynos_mbox_driver_data { + u16 irq_doorbell_offset; + u16 irq_doorbell_shift; + u16 irq_mask_offset; + u16 irq_mask_value; +}; + /** * struct exynos_mbox - driver's private data. * @regs: mailbox registers base address. * @mbox: pointer to the mailbox controller. + * @data: pointer to driver platform-specific data. */ struct exynos_mbox { void __iomem *regs; struct mbox_controller *mbox; + const struct exynos_mbox_driver_data *data; +}; + +static const struct exynos_mbox_driver_data exynos850_mbox_data =3D { + .irq_doorbell_offset =3D EXYNOS850_MBOX_INTGR0, + .irq_doorbell_shift =3D 16, + .irq_mask_offset =3D EXYNOS850_MBOX_INTMR1, + .irq_mask_value =3D EXYNOS850_MBOX_INTMR1_MASK, +}; + +static const struct exynos_mbox_driver_data exynos_gs101_mbox_data =3D { + .irq_doorbell_offset =3D EXYNOS_MBOX_INTGR1, + .irq_doorbell_shift =3D 0, + .irq_mask_offset =3D EXYNOS_MBOX_INTMR0, + .irq_mask_value =3D EXYNOS_MBOX_INTMR0_MASK, }; =20 static int exynos_mbox_send_data(struct mbox_chan *chan, void *data) @@ -57,7 +102,8 @@ static int exynos_mbox_send_data(struct mbox_chan *chan,= void *data) return -EINVAL; } =20 - writel(BIT(msg->chan_id), exynos_mbox->regs + EXYNOS_MBOX_INTGR1); + writel(BIT(msg->chan_id) << exynos_mbox->data->irq_doorbell_shift, + exynos_mbox->regs + exynos_mbox->data->irq_doorbell_offset); =20 return 0; } @@ -87,13 +133,21 @@ static struct mbox_chan *exynos_mbox_of_xlate(struct m= box_controller *mbox, } =20 static const struct of_device_id exynos_mbox_match[] =3D { - { .compatible =3D "google,gs101-mbox" }, + { + .compatible =3D "google,gs101-mbox", + .data =3D &exynos_gs101_mbox_data + }, + { + .compatible =3D "samsung,exynos850-mbox", + .data =3D &exynos850_mbox_data + }, {}, }; MODULE_DEVICE_TABLE(of, exynos_mbox_match); =20 static int exynos_mbox_probe(struct platform_device *pdev) { + const struct exynos_mbox_driver_data *data; struct device *dev =3D &pdev->dev; struct exynos_mbox *exynos_mbox; struct mbox_controller *mbox; @@ -123,6 +177,11 @@ static int exynos_mbox_probe(struct platform_device *p= dev) return dev_err_probe(dev, PTR_ERR(pclk), "Failed to enable clock.\n"); =20 + data =3D device_get_match_data(&pdev->dev); + if (!data) + return -ENODEV; + + exynos_mbox->data =3D data; mbox->num_chans =3D EXYNOS_MBOX_CHAN_COUNT; mbox->chans =3D chans; mbox->dev =3D dev; @@ -137,7 +196,7 @@ static int exynos_mbox_probe(struct platform_device *pd= ev) platform_set_drvdata(pdev, exynos_mbox); =20 /* Mask out all interrupts. We support just polling channels for now. */ - writel(EXYNOS_MBOX_INTMR0_MASK, exynos_mbox->regs + EXYNOS_MBOX_INTMR0); + writel(data->irq_mask_value, exynos_mbox->regs + data->irq_mask_offset); =20 return devm_mbox_controller_register(dev, mbox); } --=20 2.51.0