From nobody Mon Apr 6 10:43:26 2026 Received: from mail-dl1-f73.google.com (mail-dl1-f73.google.com [74.125.82.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A1E840FD9C for ; Thu, 19 Mar 2026 23:24:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773962681; cv=none; b=GtN5EihXHq74q1ZTD8QvsBHWh8xLSMKY2P04I11NV3FpVcc0JU5urWkpBDaGy63qXogsdfMTF3fWm5gvsAt5PV1TPfsbcCzV4ntkU2TGzeOOT8P4VWPfzwhj9SBKB6RbfKT4f9IbjzsLSG9xYjtD37l94o4CMTlh94SmEUJ2vA0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773962681; c=relaxed/simple; bh=3xHkozfOBQ5O/0UIsbkAMpaM2l17KKcrX8h7fai6Z3Y=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=CydhCnMRGg0ir7ML3a0CUJ13CrGyKO5NPjunOG1tFsmbpzHh2XgY1TFctaO6x6JNoGm6pKZ6BbplEMqwUnRJJOlgWt2VrVqCmz/O9GkkhEPYH2//HuhERI0RNMnlu1ha9RR5DSsSzR1p0utSwi9HRWCnup413fPwKtGgVrzIrSw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ZSUd9PRe; arc=none smtp.client-ip=74.125.82.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ZSUd9PRe" Received: by mail-dl1-f73.google.com with SMTP id a92af1059eb24-1276e71652fso70502c88.0 for ; Thu, 19 Mar 2026 16:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1773962679; x=1774567479; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=j3NPJHDhmF9h/ESu+OU97vNzfzIxPr2OOmbu63IbKTw=; b=ZSUd9PReeo5S5vZ4jaL1l4GXzOoCoiFxPMRA4Ez32G0B/kd+8S7EjNQVuqokOao7YB x/v+3OtsKkyk1LT+29KMQ8USPRf2nRtcPGY33bMv+tnrpockvEgzm12awDEPRU4IZBdM 0ucUNBoxiCjDZmMC0zxfG0PPx/141KRx/Sw3njBeOq+xvsnv6hbq4nAWBYWpkyxer9yN rrxP6V3KRTG/alc1ZOuVGLKXWV1X9JwTGaTfCI9YqEyP4v3UvsCNdX7gMAmKQmxZJ9Rc yN1z1yp/EWYMc8+7FBDM76QpRJk3dRJBkn28gsuOUaNfpNTaeBIgjliEbBQKXYMFCdC7 L5FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773962679; x=1774567479; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j3NPJHDhmF9h/ESu+OU97vNzfzIxPr2OOmbu63IbKTw=; b=VV99qXV1pGIcDknK3/OnMp9dsfHhTbW/+kqa3tbtNCxcQ/BBZhGM0zAiz4Re6sQNxc p2rFE8J68QJXjmA5RgrXRhBJfD5ssjudyrK775u7hoxLreBHvub/96Hck8unF5Ruo9PR n8tCHaJvLjw7nHE5vuaYEHRqo6f2ewjqscs7WuCNgECOeOTh35kDB3TJBkETCS2Cau2I r5fLlxi6CB3I5svHnbfIhV1QD9lFx1g0WiKJ1oUUku2zZ7Wjk06MgKb/LVg0P6iQhqHI P2vN9rnTYQL8IsAjZkVUMJqO31bUboFmqrzeVOqfKsM7wu+OODtN2G89T/imDoyw3m7M xUbA== X-Forwarded-Encrypted: i=1; AJvYcCUB3KF0MZRMd8NRYMinXbRsGZGcGF1KyTmnXw+pbuFRJP5KpP3/DKKNNI3JM84jktA8sG/FVVINB/t91vc=@vger.kernel.org X-Gm-Message-State: AOJu0YwG5IfaRHWekw5YwzqgxqmPBZb1nYOs14nSneHiBQHvfW+6QkIT c/yqJEajjh3jG0AnF5t5q3g2wcxewQFUKCW2VLlpX74LTkD8J601fMVKdvptAn17pFDE1uVdp9E /dGD2KxlnAg== X-Received: from dlbsw9.prod.google.com ([2002:a05:7022:3a89:b0:128:f497:319c]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:31f:b0:127:5cfe:1ee0 with SMTP id a92af1059eb24-12a726b2844mr437271c88.21.1773962678957; Thu, 19 Mar 2026 16:24:38 -0700 (PDT) Date: Thu, 19 Mar 2026 16:23:26 -0700 In-Reply-To: <20260319232334.287517-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260209174032.4142096-1-irogers@google.com> <20260319232334.287517-1-irogers@google.com> X-Mailer: git-send-email 2.53.0.959.g497ff81fa9-goog Message-ID: <20260319232334.287517-18-irogers@google.com> Subject: [PATCH v2 17/25] perf kmem: Don't pass evsel with sample From: Ian Rogers To: acme@kernel.org, namhyung@kernel.org Cc: irogers@google.com, adrian.hunter@intel.com, ajones@ventanamicro.com, ak@linux.intel.com, alex@ghiti.fr, alexander.shishkin@linux.intel.com, anup@brainfault.org, aou@eecs.berkeley.edu, atrajeev@linux.ibm.com, blakejones@google.com, ctshao@google.com, dapeng1.mi@linux.intel.com, derek.foreman@collabora.com, dvyukov@google.com, howardchu95@gmail.com, hrishikesh123s@gmail.com, james.clark@linaro.org, jolsa@kernel.org, krzysztof.m.lopatowski@gmail.com, leo.yan@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux@treblig.org, mingo@redhat.com, nichen@iscas.ac.cn, palmer@dabbelt.com, peterz@infradead.org, pjw@kernel.org, ravi.bangoria@amd.com, swapnil.sapkal@amd.com, tanze@kylinos.cn, thomas.falcon@intel.com, tianyou.li@intel.com, yujie.liu@intel.com, zhouquan@iscas.ac.cn Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The sample contains the evsel and so it is unnecessary to pass the evsel as well. Signed-off-by: Ian Rogers --- tools/perf/builtin-kmem.c | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c index 19b12209fc08..ea2437971e8b 100644 --- a/tools/perf/builtin-kmem.c +++ b/tools/perf/builtin-kmem.c @@ -171,7 +171,7 @@ static int insert_caller_stat(unsigned long call_site, return 0; } =20 -static int evsel__process_alloc_event(struct evsel *evsel, struct perf_sam= ple *sample) +static int evsel__process_alloc_event(struct perf_sample *sample) { unsigned long ptr =3D perf_sample__intval(sample, "ptr"), call_site =3D perf_sample__intval(sample, "call_site"); @@ -198,7 +198,7 @@ static int evsel__process_alloc_event(struct evsel *evs= el, struct perf_sample *s * If the tracepoint contains the field "node" the tool stats the * cross allocation. */ - if (evsel__field(evsel, "node")) { + if (evsel__field(sample->evsel, "node")) { int node1, node2; =20 node1 =3D cpu__get_node((struct perf_cpu){.cpu =3D sample->cpu}); @@ -243,7 +243,7 @@ static struct alloc_stat *search_alloc_stat(unsigned lo= ng ptr, return NULL; } =20 -static int evsel__process_free_event(struct evsel *evsel __maybe_unused, s= truct perf_sample *sample) +static int evsel__process_free_event(struct perf_sample *sample) { unsigned long ptr =3D perf_sample__intval(sample, "ptr"); struct alloc_stat *s_alloc, *s_caller; @@ -751,8 +751,7 @@ static char *compact_gfp_string(unsigned long gfp_flags) return NULL; } =20 -static int parse_gfp_flags(struct evsel *evsel, struct perf_sample *sample, - unsigned int gfp_flags) +static int parse_gfp_flags(struct perf_sample *sample, unsigned int gfp_fl= ags) { struct tep_record record =3D { .cpu =3D sample->cpu, @@ -773,7 +772,7 @@ static int parse_gfp_flags(struct evsel *evsel, struct = perf_sample *sample, } =20 trace_seq_init(&seq); - tp_format =3D evsel__tp_format(evsel); + tp_format =3D evsel__tp_format(sample->evsel); if (tp_format) tep_print_event(tp_format->tep, &seq, &record, "%s", TEP_PRINT_INFO); =20 @@ -805,7 +804,7 @@ static int parse_gfp_flags(struct evsel *evsel, struct = perf_sample *sample, return 0; } =20 -static int evsel__process_page_alloc_event(struct evsel *evsel, struct per= f_sample *sample) +static int evsel__process_page_alloc_event(struct perf_sample *sample) { u64 page; unsigned int order =3D perf_sample__intval(sample, "order"); @@ -836,7 +835,7 @@ static int evsel__process_page_alloc_event(struct evsel= *evsel, struct perf_samp return 0; } =20 - if (parse_gfp_flags(evsel, sample, gfp_flags) < 0) + if (parse_gfp_flags(sample, gfp_flags) < 0) return -1; =20 callsite =3D find_callsite(sample); @@ -877,8 +876,7 @@ static int evsel__process_page_alloc_event(struct evsel= *evsel, struct perf_samp return 0; } =20 -static int evsel__process_page_free_event(struct evsel *evsel __maybe_unus= ed, - struct perf_sample *sample) +static int evsel__process_page_free_event(struct perf_sample *sample) { u64 page; unsigned int order =3D perf_sample__intval(sample, "order"); @@ -955,8 +953,7 @@ static bool perf_kmem__skip_sample(struct perf_sample *= sample) return false; } =20 -typedef int (*tracepoint_handler)(struct evsel *evsel, - struct perf_sample *sample); +typedef int (*tracepoint_handler)(struct perf_sample *sample); =20 static int process_sample_event(const struct perf_tool *tool __maybe_unuse= d, union perf_event *event, @@ -981,7 +978,7 @@ static int process_sample_event(const struct perf_tool = *tool __maybe_unused, =20 if (evsel->handler !=3D NULL) { tracepoint_handler f =3D evsel->handler; - err =3D f(evsel, sample); + err =3D f(sample); } =20 thread__put(thread); --=20 2.53.0.959.g497ff81fa9-goog