From nobody Mon Apr 6 09:18:49 2026 Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9EEA2F068C for ; Thu, 19 Mar 2026 19:13:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.68 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773947599; cv=none; b=iqLZGEg+deqDlDr+bk2I/T3epyTn0C9s1D7YWe2B34dotZCF2LOXlohXN7ljWEwUoipj8QbtVceuEF7xzjDgVd93LQElbjxMc+2Mul9OrX2WMpdMO49np3EoE9XXY/zzT6AvW1XyGXZ83P2i7W35pRTaVCssucVGzWmrzwx9/xc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773947599; c=relaxed/simple; bh=lv5Xv/85bNDiKbjkKI/HhUaW5UmNE4syAkD6pWkHeFk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZjEpKnLE1QkhEy14egxMfnLga9JJwaCt9dzTEK3NeWD3kNoyQfcLrU5voIcyH4uPQmcIeWWSTNJ3QKf/map5gv9vmqJKi6kF3bn2RpxOqcxzQHAbfGuD7Hw9piNc/AjImfru/n8CvaANCemf00um78f3Xp7ITkbf+akoUodwiLA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FzogKhtM; arc=none smtp.client-ip=209.85.216.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FzogKhtM" Received: by mail-pj1-f68.google.com with SMTP id 98e67ed59e1d1-354bc7c2c46so503745a91.0 for ; Thu, 19 Mar 2026 12:13:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773947597; x=1774552397; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zDb9mUds8vYh0FCRtY+ebDLgyM8o2TAv6Y9zp4khNXs=; b=FzogKhtMsfanKXfK7Sb88lpKM4T3QdftqDHd98N2I31LData730Mw8qJPWS0vFqOhz AZuKnEoO+ZYtW4vAWlNlZRfuyFEwXzFRcAlvipgP78tBjNIMrcnB08cIC0RfT9KZ1VlB 9i10Jct/V+0H8sX3JvJnM9nPZhS5bIzuMOiaQ7Gy72dNUAfH6+VllRtWnGurHhZ/1P9X lr/IvmhUIBg4Q+0VUGwWBJenkeKQS+1NvpdBPMT7HRN23ODL4t3/bo/wEyZ0kSpEyk+n yvMv3VF0iTso97am6egQ4Ce10z1XqMGOp4dA/WOJHP1Gy2tcIqztoP/rZ46c3pE38TUA lugQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773947597; x=1774552397; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zDb9mUds8vYh0FCRtY+ebDLgyM8o2TAv6Y9zp4khNXs=; b=lWYSW/J3UYNBcwbD9n+6wv1OPvDTb87qBaksg6lPwA+WMfCkBSDbp6cSw1BHhfOxL7 COyI/FiAnJNM1yWz9dZVpZ7wgCoFQgDyBjA3dgAxNE/3IzvUsKzOEUiPrYbhhFfNFdKg uWtjsV0fBsBt7yZ0MbQps8oITKcPBhiJgB2Mw45pGQNRG7zFuf4MGCNKvNxynzw5lheV bUXbc0Beik74fxBckYB5hNlh0RbcVjZhfbt02/PXtJRBYf6cSRAX2M19tR5V96OBJRvj Mb5sPM4YGhm+egw8KtMMCOLZGkcOubIvUXo/8iEY23LqOD89qSR+u4SBKm6A10XzPxMg re8A== X-Forwarded-Encrypted: i=1; AJvYcCWvxwE1/jn8aTNwktjzgJW7SkAeWaRI16HyvpgJQdzSjYjgTftbn+1bwQ2W33IEddvCzyVRTdxF69ewxLo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8M7avsfCK3bgp/bpqUC+NE0iMZBaI6+XihZ/e3nqBzG1CjhoR Yb+03Gr2mbk02MgLzlT9IqZUl8gfZ3m30j9saWVSXN2QIV0Fher491gUEOeIfINUN5ig1N9L X-Gm-Gg: ATEYQzwVYy26s4u772zSCCnN1aIvL5If1eZzIQa0beel7mRH2uw1g7yiDBwXUjmoc4L gHkW3oH6pjP7UUvnoLennxX8YXQxM4PHigen7mSq12KkncKLJwVzt4SpdxbEf/iQOEmE17n/EVi Fmgy9hayqRrcE9YQR97WVu1wjWLai2Nat8FBy/R095zovAJJw0OAXEu4P+U6FZ9wy3Q97U3cx+I TfHjQ4Sx8vdx0M+lT1ipdq693cyAqewgsruFF8tto2B3lyI86KegraH+tBDnew2MYkcn2wizpXD iOR+GJcZL4yjA5x+fBGrE4Iw3+oYlAHDjwu84qFL7Z2q9zJO3prSZ8mht7OrtJr7TpupFrgNFmc QLCqHa0k07galBqsD6w/XOMg361OxeZ/Fd3m7VReoXojtxm77tEB8378PygMCFhCeEY5JZ5GJhr Ro9bBAnCvKAeCna7ZN9IzXr18B+qXxx6DJ1jgbaO9qJf1zSBmaEr1fg/fHXrfmFMhWhUha/V00+ 9LQOcD7QQe/02loX3k= X-Received: by 2002:a17:90a:d44d:b0:35b:a7be:ae43 with SMTP id 98e67ed59e1d1-35bd2bb6857mr238865a91.9.1773947596888; Thu, 19 Mar 2026 12:13:16 -0700 (PDT) Received: from CN4GKQDX76.bytedance.net ([139.177.225.255]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bc610c1efsm3379921a91.14.2026.03.19.12.13.14 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Mar 2026 12:13:16 -0700 (PDT) From: Zile Xiong To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Zile Xiong Subject: [PATCH] staging: rtl8723bs: replace msleep(1) with fsleep() Date: Fri, 20 Mar 2026 03:13:09 +0800 Message-ID: <20260319191309.64198-1-xiongzile99@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" msleep(1) is not suitable for short delays due to scheduler granularity. Use fsleep(USEC_PER_MSEC) instead, which provides a more appropriate delay for 1 ms sleeps. Signed-off-by: Zile Xiong --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 5 +++-- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 3 ++- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 +++-- drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 3 ++- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 5 +++-- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 3 ++- 6 files changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging= /rtl8723bs/core/rtw_pwrctrl.c index f074ea6e0f38..5751584b0f18 100644 --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c @@ -4,6 +4,7 @@ * Copyright(c) 2007 - 2012 Realtek Corporation. All rights reserved. * *************************************************************************= *****/ +#include #include #include #include @@ -414,7 +415,7 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay= _ms) err =3D -1; break; } - msleep(1); + fsleep(USEC_PER_MSEC); } =20 return err; @@ -567,7 +568,7 @@ void LPS_Leave_check(struct adapter *padapter) if (jiffies_to_msecs(jiffies - start_time) > 100) break; =20 - msleep(1); + fsleep(USEC_PER_MSEC); } } =20 diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/r= tl8723bs/hal/hal_btcoex.c index 2a2dd60be8bb..596a775329d9 100644 --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c @@ -5,6 +5,7 @@ * *************************************************************************= *****/ =20 +#include #include #include #include @@ -98,7 +99,7 @@ static void halbtcoutsrc_LeaveLowPower(struct btc_coexist= *pBtCoexist) if (utime > timeout) break; =20 - msleep(1); + fsleep(USEC_PER_MSEC); } while (1); } =20 diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index e794fe3caf9d..8159ad278a6b 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -5,6 +5,7 @@ * *************************************************************************= *****/ =20 +#include #include #include #include @@ -28,7 +29,7 @@ static void _FWDownloadEnable(struct adapter *padapter, b= ool enable) if (tmp & 0x01) break; rtw_write8(padapter, REG_MCUFWDL, tmp|0x01); - msleep(1); + fsleep(USEC_PER_MSEC); } while (count++ < 100); =20 /* 8051 reset */ @@ -1157,7 +1158,7 @@ s32 rtl8723b_InitLLTTable(struct adapter *padapter) if (passing_time > 1000) break; =20 - msleep(1); + fsleep(USEC_PER_MSEC); } while (1); =20 return ret; diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/stag= ing/rtl8723bs/hal/rtl8723b_phycfg.c index 7fac1c2ba8e0..14a14eeaf9d2 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c @@ -5,6 +5,7 @@ * *************************************************************************= *****/ =20 +#include #include #include =20 @@ -391,7 +392,7 @@ int PHY_BBConfig8723B(struct adapter *Adapter) =20 rtw_write8(Adapter, REG_RF_CTRL, RF_EN|RF_RSTB|RF_SDMRSTB); =20 - msleep(1); + fsleep(USEC_PER_MSEC); =20 PHY_SetRFReg(Adapter, RF_PATH_A, 0x1, 0xfffff, 0x780); =20 diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_xmit.c index f50726d2ed0c..bb6d6d7544b7 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -5,6 +5,7 @@ * *************************************************************************= *****/ =20 +#include #include #include =20 @@ -23,7 +24,7 @@ static u8 rtw_sdio_wait_enough_TxOQT_space(struct adapter= *padapter, u8 agg_num) HalQueryTxOQTBufferStatus8723BSdio(padapter); =20 if ((++n % 60) =3D=3D 0) { - msleep(1); + fsleep(USEC_PER_MSEC); /* yield(); */ } } @@ -386,7 +387,7 @@ static s32 rtl8723bs_xmit_handler(struct adapter *padap= ter) /* here sleep 1ms will cause big TP loss of TX */ /* from 50+ to 40+ */ if (padapter->registrypriv.wifi_spec) - msleep(1); + fsleep(USEC_PER_MSEC); else yield(); goto next; diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index 7ba689f2dfc8..895c47e987c4 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -4,6 +4,7 @@ * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved. * *************************************************************************= *****/ +#include #include #include #include @@ -1091,7 +1092,7 @@ void rtw_suspend_common(struct adapter *padapter) pwrpriv->bInSuspend =3D true; =20 while (pwrpriv->bips_processing) - msleep(1); + fsleep(USEC_PER_MSEC); =20 if ((!padapter->bup) || (padapter->bDriverStopped) || (padapter->bSurpris= eRemoved)) return; --=20 2.39.5