From nobody Fri Apr 3 08:51:09 2026 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A2463F0754 for ; Thu, 19 Mar 2026 17:52:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773942765; cv=none; b=jzt9hn383CUpg7Et9cciSFQsPcUAfBISilO+OgiI7KSmsOSMXsIF/Dds4VKSKihPn5B/w40Bph7EWZ3i5Fc9p1z8EzLIaIDBtvCNYyz3oKyqZCbTqjNV7KGGlnGVdiA1cm2RzfSZ3rKdEZfN1+vsqVa3ani/90mgUBVzmlXhqwE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773942765; c=relaxed/simple; bh=gAJU4zC5x6JuY+pTVSWv+bDUwPqDdTnR5X4UgnLK29s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fzv7Cfno5N/vAyOhLxPPDUb0QCYLi4OwHwj9F21UXTiy1fBJDUZEH/1kWMPKG7tYN5TxvZD4Da+YbemLY0+z/AvGdZ18JTofwHZDf8IVF3GLSEKY+GFrPiAM1aG1VnQ8n4h9zBv9AKZEX6BI3Nb5jQFk8NN4//6ONORPh8CxEF0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ncsu.edu; spf=pass smtp.mailfrom=ncsu.edu; dkim=pass (2048-bit key) header.d=ncsu.edu header.i=@ncsu.edu header.b=Y8rWRQhR; arc=none smtp.client-ip=209.85.128.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ncsu.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ncsu.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ncsu.edu header.i=@ncsu.edu header.b="Y8rWRQhR" Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-79800183233so15633007b3.1 for ; Thu, 19 Mar 2026 10:52:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ncsu.edu; s=google; t=1773942759; x=1774547559; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NZL/wJBtZ7x/udHyrL9BfhVlsQqTeT94Yhy16V0LzLA=; b=Y8rWRQhRUClwGGujO5Wb6jF07Q9u03jtwmQN/ERSEjmuSALo4VmIHH+dtfnP7CD7kp /51opWM5fyKJStxxbIYTHo4/VTvZ6+nx4FpwT0vHzjFcbC4wuND8+BBUjK7LzhIGIe42 GeUsk59lRC7Al3gHqBQYcL/DIVOY1Pw98XGxu6ULQuXFsvRRbTYpOnInQLKEopO8jBKr wHqxVOSVovZTpuQxuT9fppx4z+WOPCnAhuO5xoCgXm74WIrVCLRlhw5UperhGFdhaOPs cX+T8L9qsqe2Xn6vhN4/9TwFbWR3jl/cxzEOtD5F2pLHeLcXjGJDgSWxPY5siFs2VXe6 a+2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773942759; x=1774547559; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NZL/wJBtZ7x/udHyrL9BfhVlsQqTeT94Yhy16V0LzLA=; b=Osx4TOfzpFuOf0Tfpy3rtyv8gSMh4BqN/hwMD87bsycE5TjEdCKb/Q75vxBWc6UuCS t4FBncv9SOqMJ38uZd6veMvrsf/aNzkqGAI6+m0U6Jdb6RJW5/W5bH466vOtI79gtigY hCPZQgSd11Xu/d+KwLAE48xAFBfpfhZ8NBjnxYTm2iXehLZbVtWOPA8rQwCnXNceC41N v2kW0c4pw7Mb2Fc509Yf/IZtEPge3X7l8dUTNZ3qvfLNzT+Can+y0cIZolG0wMZI4pCx jImVOyDj86ScEjDmP+8BGdrjSPmbJ2cAS90mhDIUur0+JsgpyoQz4AA+MWSMqcLtOqTQ blNg== X-Forwarded-Encrypted: i=1; AJvYcCXq0xFnWZgr5dD/y7fg+yV7AmS7eLdV5gNbHsrudh4bbTvmJO7WjyiBtOPshdHcp50Jct1HpakA7mx9Xfc=@vger.kernel.org X-Gm-Message-State: AOJu0YyOsSMYi3ZO6eNsffCAdjEUyNXl8Uq111mwd7gmFCEXGeg0VM1i YcAaBqHADe9tuTLs2tMczSjwYqkP02lTm4T1GxvERHsy3FOR5VM1xYLcoGC6NOAzzg== X-Gm-Gg: ATEYQzxnQki88zR2aYWxiydEn5VEcr0f8L8g8z7v5AlipLLvdFUHlnxlWSXPfkTzlfY +ro4DI2C+WLA1Dpf+hM0Y6ujwSQJO60nv1Qk/TxLPNJfhWiBZCZWe0CPU9v34iPvjb5nyUK5fJD vM3k7r+WDsaguFW02t7rSdTL0s8SAnrsEKnEDjMBuxJeqSBsJ1ISnVcm7XtWFdeCcUmB6wJRrzr co5o3Usy5NHg9/sbhM1d6OQfYq7oGyLji8g5L4FYWaZOPSy7LwyoPtjkwCj3uL3fBvPllGCwfJD F/d92D4Peit/c20uDD5Bk/nOj/o0MoNCFrnn8ccP90omoCVv4+OAAU0/xz1n01aqm4AcahfvYPu uu3nv52gtTowrsKH/6LEf9SdG9rcqEUx8xBo/byzEQejxe1DGHlw4b6O+vfBOSkibL12Jny0lHE b3J9GMiDRa3KPRbcRqbfL5TjdfKIhuSAwjj8W1NA7Pjb0NFYU/ER95W/bB X-Received: by 2002:a05:690c:e3c6:b0:798:6665:ca0d with SMTP id 00721157ae682-79a90484c37mr2266357b3.28.1773942759151; Thu, 19 Mar 2026 10:52:39 -0700 (PDT) Received: from um773-cachyos.sd.ncsu.edu ([152.7.255.206]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79a905bda3esm784667b3.47.2026.03.19.10.52.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 10:52:38 -0700 (PDT) From: Zecheng Li To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot Cc: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Rik van Riel , Chris Mason , Madadi Vineeth Reddy , Xu Liu , Blake Jones , Josh Don , Nilay Vaish , K Prateek Nayak , Andrew Morton , linux-kernel@vger.kernel.org, Zecheng Li , Zecheng Li Subject: [PATCH v9 RESEND 1/3] sched/fair: Co-locate cfs_rq and sched_entity in cfs_tg_state Date: Thu, 19 Mar 2026 13:52:13 -0400 Message-ID: <20260319175235.995183-2-zli94@ncsu.edu> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260319175235.995183-1-zli94@ncsu.edu> References: <20260319175235.995183-1-zli94@ncsu.edu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Zecheng Li Improve data locality and reduce pointer chasing by allocating struct cfs_rq and struct sched_entity together for non-root task groups. This is achieved by introducing a new combined struct cfs_tg_state that holds both objects in a single allocation. This patch: - Introduces struct cfs_tg_state that embeds cfs_rq, sched_entity, and sched_statistics together in a single structure. - Updates __schedstats_from_se() in stats.h to use cfs_tg_state for accessing sched_statistics from a group sched_entity. - Modifies alloc_fair_sched_group() and free_fair_sched_group() to allocate and free the new struct as a single unit. - Modifies the per-CPU pointers in task_group->se and task_group->cfs_rq to point to the members in the new combined structure. Signed-off-by: Zecheng Li Signed-off-by: Zecheng Li Reviewed-by: K Prateek Nayak Reviewed-by: Josh Don --- kernel/sched/fair.c | 18 ++++++------------ kernel/sched/sched.h | 12 ++++++++++++ kernel/sched/stats.h | 9 +-------- 3 files changed, 19 insertions(+), 20 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 0a35a82e4792..79160d419c9f 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -13877,8 +13877,6 @@ void free_fair_sched_group(struct task_group *tg) for_each_possible_cpu(i) { if (tg->cfs_rq) kfree(tg->cfs_rq[i]); - if (tg->se) - kfree(tg->se[i]); } =20 kfree(tg->cfs_rq); @@ -13887,6 +13885,7 @@ void free_fair_sched_group(struct task_group *tg) =20 int alloc_fair_sched_group(struct task_group *tg, struct task_group *paren= t) { + struct cfs_tg_state *state; struct sched_entity *se; struct cfs_rq *cfs_rq; int i; @@ -13903,16 +13902,13 @@ int alloc_fair_sched_group(struct task_group *tg,= struct task_group *parent) init_cfs_bandwidth(tg_cfs_bandwidth(tg), tg_cfs_bandwidth(parent)); =20 for_each_possible_cpu(i) { - cfs_rq =3D kzalloc_node(sizeof(struct cfs_rq), - GFP_KERNEL, cpu_to_node(i)); - if (!cfs_rq) + state =3D kzalloc_node(sizeof(*state), + GFP_KERNEL, cpu_to_node(i)); + if (!state) goto err; =20 - se =3D kzalloc_node(sizeof(struct sched_entity_stats), - GFP_KERNEL, cpu_to_node(i)); - if (!se) - goto err_free_rq; - + cfs_rq =3D &state->cfs_rq; + se =3D &state->se; init_cfs_rq(cfs_rq); init_tg_cfs_entry(tg, cfs_rq, se, i, parent->se[i]); init_entity_runnable_average(se); @@ -13920,8 +13916,6 @@ int alloc_fair_sched_group(struct task_group *tg, s= truct task_group *parent) =20 return 1; =20 -err_free_rq: - kfree(cfs_rq); err: return 0; } diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index b863bbda6de8..826f21fa3f36 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -2249,6 +2249,18 @@ static inline struct task_group *task_group(struct t= ask_struct *p) return p->sched_task_group; } =20 +#ifdef CONFIG_FAIR_GROUP_SCHED +/* + * Defined here to be available before stats.h is included, since + * stats.h has dependencies on things defined later in this file. + */ +struct cfs_tg_state { + struct cfs_rq cfs_rq; + struct sched_entity se; + struct sched_statistics stats; +} __no_randomize_layout; +#endif + /* Change a task's cfs_rq and parent entity if it moves across CPUs/groups= */ static inline void set_task_rq(struct task_struct *p, unsigned int cpu) { diff --git a/kernel/sched/stats.h b/kernel/sched/stats.h index a612cf253c87..ebe0a7765f98 100644 --- a/kernel/sched/stats.h +++ b/kernel/sched/stats.h @@ -89,19 +89,12 @@ static inline void rq_sched_info_depart (struct rq *rq= , unsigned long long delt =20 #endif /* CONFIG_SCHEDSTATS */ =20 -#ifdef CONFIG_FAIR_GROUP_SCHED -struct sched_entity_stats { - struct sched_entity se; - struct sched_statistics stats; -} __no_randomize_layout; -#endif - static inline struct sched_statistics * __schedstats_from_se(struct sched_entity *se) { #ifdef CONFIG_FAIR_GROUP_SCHED if (!entity_is_task(se)) - return &container_of(se, struct sched_entity_stats, se)->stats; + return &container_of(se, struct cfs_tg_state, se)->stats; #endif return &task_of(se)->stats; } --=20 2.53.0