From nobody Mon Apr 6 12:17:53 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 647EA3EDAD0 for ; Thu, 19 Mar 2026 16:48:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773938922; cv=none; b=QyxrxX9FB4zvnI5Y4XNWbLcVYXGoe0GNor3sYjpkFPiyb9MHhZ0ol1JOkAgXV5kSWQj8qOU9LVKB5WY8TvdE2TVShkGbehX0CclFWY1LvwY+2YMpN1oOVoYlBMJZ5zRozgdSTUDG7lh+L3j4Oc7vJ1CcQGco/HHVVtAyLgpkGTM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773938922; c=relaxed/simple; bh=wSrtoof78gY7cl0/kTqen6G7IMto9m9YkmvWmlpqlNg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aT54PIcqXtZkeS2tMcTW4pI+lYDCqP9BwW+GVuBb0UiKO3ypqP/7qBPZgBhCb3vXUp19kff+KNQ2XuWv7FowpyuRzlhzvqSUePWE2qdT7WYQesfsDmtY1LB+jbbfZ1N7U56YuP0BC4RkBD4mAeNpXEIcupDYZZ/UOUF8GCvfroI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L3mA3qet; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L3mA3qet" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-486fc4725f0so6680045e9.1 for ; Thu, 19 Mar 2026 09:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773938916; x=1774543716; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aIvSNKXz4qc5DB7Emu7Dw1mSZJPjUbF0QIFG+kNxKiA=; b=L3mA3qetVfn3JvgWmB2Cf1QnBoHJH46AeHIxw9WCw/VouIA6MAywnMjF95EjkMdEH9 d3sx9mf9hKqE118PPJvZjzmupAMDiq7zxmFRJxqjKbCcJJBhEeQ/+3eLR7su+n6gTeS2 qj7n71ibNBeETQAL+OpEaY8CGo7Ct22Rak0T1M/Zc6woYyroBIzaNoMzy4R1x9zdfVZc 53C8qZSs91tT4RWXH2er5sK9lfxpjtpwTqXzGMcIt6mhhf+NOUHDdAeEJui9UXS+/cVH oeesdEuwv7xR9Fv2EY2f4tcBP42rrWu1Er4uGR748vH+/sYfYHmHTWzACpJMZeeuxioc 2sww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773938916; x=1774543716; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aIvSNKXz4qc5DB7Emu7Dw1mSZJPjUbF0QIFG+kNxKiA=; b=rUluajgvoEtJrF8SMu5E5earQPzwAi0n3eOpJm1O+arfimxgurTfkFTz+7lYepanR/ oBIWNAJsSfqG9JzTNnCWYju/oYq0bt1b7aEhURHhsCcAsoWXrEim2cNmZYC7Kr4X8KDj ShE4v32/WQch50c50cANk9WOmHPjLRZxn7v4pBmPHZ1Xj8aRfyxafJX4V6reLV74yaM7 t2SYT14ird8JyXBEHxyJJHNzNnE8wdxbpRDpU4/KW42iks3px3vHthoXvI/lLXL3eRXt ZKmHQVHauCEBamvTH5R6CXLnCxF/lwuMuWYN2C+a7BmIzgSuyEHKjiTXHwVdAUPwpa/g M83A== X-Forwarded-Encrypted: i=1; AJvYcCV9il0YK92POwCz4yHNPj5IoAMdFsQtA6cS3DE5ybKq410Aer2EXJonLi+5nLEM/z8q/LO/ap37JMDFHKs=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1RIy0sYqBSQMSIRl4X45qRSgJU3WHRjuYd4ltGiNIxVZMJKMh nRVpIeMmdB60J5VujbpHWUKRc/QPk0HSZv7BbVj8bqvC79ckygT/S20R X-Gm-Gg: ATEYQzzFogB6Yy5ifaO9wv62GJSos+vb4IA6ns0BBAdZ+MoauTrzMNZJl1wV2yESbyq 2kc0WK0szmV788unGw9BodmNKoJwAazDrSgWyrBQ3SGfKxaU3LtAQAiuu4GwqNrKzVAuXreQOj9 jkajyXFvwJ71iHYPGqbiZSyc0XPFgx207SQ3vTwDaI6iKuDg7UZF4LQMnEUUZ5bNE4oc9LWmS1k U8JOJtyQYhqiUUG9sJ/D6kLbry/AKY3CKNBYrL8afNaoX+RoOhjRHTYC6zx7T6k4tkWKRb4FuqL lm/dqv8QwKz0yT1o+yqHgmcvl/w/HmUEmYk3LYKY7ErPxFXFLpOcqoHygUOSGHMPkKaoh6DoGHv j3L86lKn9yMw1TNZbGIw3RmZcNx9aNVsQNf/Ebrqcdt2I6vNAWaYYCzg1/77Il39kfCJX5VscmF 3cO21cSGjOA8OB+6rMHh+RPNgZIziw9+ysUvlLPN+57A== X-Received: by 2002:a05:600c:3e10:b0:485:3428:774c with SMTP id 5b1f17b1804b1-486fe8b0073mr521675e9.4.1773938916334; Thu, 19 Mar 2026 09:48:36 -0700 (PDT) Received: from biju.lan ([2a00:23c4:a758:8a01:8326:7b31:bf82:d2d0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe68ec05sm5238505e9.0.2026.03.19.09.48.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 09:48:36 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Biju Das , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Chris Brandt , Hugo Villeneuve , Laurent Pinchart , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , Biju Das , stable@vger.kernel.org Subject: [PATCH v2 1/4] drm: renesas: rzg2l_mipi_dsi: Move rzg2l_mipi_dsi_set_display_timing() Date: Thu, 19 Mar 2026 16:48:25 +0000 Message-ID: <20260319164833.409126-2-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260319164833.409126-1-biju.das.jz@bp.renesas.com> References: <20260319164833.409126-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das The RZ/G2L hardware manual (Rev. 1.50, May 2025), Section 34.4.2.4 Video-Input Operation, requires display timings to be set after the HS clock is started. Move rzg2l_mipi_dsi_set_display_timing() from rzg2l_mipi_dsi_atomic_pre_enable() to rzg2l_mipi_dsi_atomic_enable(), placing it after rzg2l_mipi_dsi_start_hs_clock(). Drop the unused ret variable from rzg2l_mipi_dsi_atomic_pre_enable(). Fixes: 5ce16c169a4c ("drm: renesas: rz-du: Add atomic_pre_enable") Fixes: 7a043f978ed1 ("drm: rcar-du: Add RZ/G2L DSI driver") Cc: stable@vger.kernel.org Signed-off-by: Biju Das --- v2: * New patch --- drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c b/drivers/gpu/d= rm/renesas/rz-du/rzg2l_mipi_dsi.c index a87a301326c7..ff95cb9a7de5 100644 --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c @@ -1025,29 +1025,33 @@ static void rzg2l_mipi_dsi_atomic_pre_enable(struct= drm_bridge *bridge, const struct drm_display_mode *mode; struct drm_connector *connector; struct drm_crtc *crtc; - int ret; =20 connector =3D drm_atomic_get_new_connector_for_encoder(state, bridge->enc= oder); crtc =3D drm_atomic_get_new_connector_state(state, connector)->crtc; mode =3D &drm_atomic_get_new_crtc_state(state, crtc)->adjusted_mode; =20 - ret =3D rzg2l_mipi_dsi_startup(dsi, mode); - if (ret < 0) - return; - - rzg2l_mipi_dsi_set_display_timing(dsi, mode); + rzg2l_mipi_dsi_startup(dsi, mode); } =20 static void rzg2l_mipi_dsi_atomic_enable(struct drm_bridge *bridge, struct drm_atomic_state *state) { struct rzg2l_mipi_dsi *dsi =3D bridge_to_rzg2l_mipi_dsi(bridge); + const struct drm_display_mode *mode; + struct drm_connector *connector; + struct drm_crtc *crtc; int ret; =20 ret =3D rzg2l_mipi_dsi_start_hs_clock(dsi); if (ret < 0) goto err_stop; =20 + connector =3D drm_atomic_get_new_connector_for_encoder(state, bridge->enc= oder); + crtc =3D drm_atomic_get_new_connector_state(state, connector)->crtc; + mode =3D &drm_atomic_get_new_crtc_state(state, crtc)->adjusted_mode; + + rzg2l_mipi_dsi_set_display_timing(dsi, mode); + ret =3D rzg2l_mipi_dsi_start_video(dsi); if (ret < 0) goto err_stop_clock; --=20 2.43.0