From nobody Mon Apr 6 10:45:19 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 647EA3EDAD0 for ; Thu, 19 Mar 2026 16:48:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773938922; cv=none; b=QyxrxX9FB4zvnI5Y4XNWbLcVYXGoe0GNor3sYjpkFPiyb9MHhZ0ol1JOkAgXV5kSWQj8qOU9LVKB5WY8TvdE2TVShkGbehX0CclFWY1LvwY+2YMpN1oOVoYlBMJZ5zRozgdSTUDG7lh+L3j4Oc7vJ1CcQGco/HHVVtAyLgpkGTM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773938922; c=relaxed/simple; bh=wSrtoof78gY7cl0/kTqen6G7IMto9m9YkmvWmlpqlNg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aT54PIcqXtZkeS2tMcTW4pI+lYDCqP9BwW+GVuBb0UiKO3ypqP/7qBPZgBhCb3vXUp19kff+KNQ2XuWv7FowpyuRzlhzvqSUePWE2qdT7WYQesfsDmtY1LB+jbbfZ1N7U56YuP0BC4RkBD4mAeNpXEIcupDYZZ/UOUF8GCvfroI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L3mA3qet; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L3mA3qet" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-486fc4725f0so6680045e9.1 for ; Thu, 19 Mar 2026 09:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773938916; x=1774543716; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aIvSNKXz4qc5DB7Emu7Dw1mSZJPjUbF0QIFG+kNxKiA=; b=L3mA3qetVfn3JvgWmB2Cf1QnBoHJH46AeHIxw9WCw/VouIA6MAywnMjF95EjkMdEH9 d3sx9mf9hKqE118PPJvZjzmupAMDiq7zxmFRJxqjKbCcJJBhEeQ/+3eLR7su+n6gTeS2 qj7n71ibNBeETQAL+OpEaY8CGo7Ct22Rak0T1M/Zc6woYyroBIzaNoMzy4R1x9zdfVZc 53C8qZSs91tT4RWXH2er5sK9lfxpjtpwTqXzGMcIt6mhhf+NOUHDdAeEJui9UXS+/cVH oeesdEuwv7xR9Fv2EY2f4tcBP42rrWu1Er4uGR748vH+/sYfYHmHTWzACpJMZeeuxioc 2sww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773938916; x=1774543716; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aIvSNKXz4qc5DB7Emu7Dw1mSZJPjUbF0QIFG+kNxKiA=; b=rUluajgvoEtJrF8SMu5E5earQPzwAi0n3eOpJm1O+arfimxgurTfkFTz+7lYepanR/ oBIWNAJsSfqG9JzTNnCWYju/oYq0bt1b7aEhURHhsCcAsoWXrEim2cNmZYC7Kr4X8KDj ShE4v32/WQch50c50cANk9WOmHPjLRZxn7v4pBmPHZ1Xj8aRfyxafJX4V6reLV74yaM7 t2SYT14ird8JyXBEHxyJJHNzNnE8wdxbpRDpU4/KW42iks3px3vHthoXvI/lLXL3eRXt ZKmHQVHauCEBamvTH5R6CXLnCxF/lwuMuWYN2C+a7BmIzgSuyEHKjiTXHwVdAUPwpa/g M83A== X-Forwarded-Encrypted: i=1; AJvYcCV9il0YK92POwCz4yHNPj5IoAMdFsQtA6cS3DE5ybKq410Aer2EXJonLi+5nLEM/z8q/LO/ap37JMDFHKs=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1RIy0sYqBSQMSIRl4X45qRSgJU3WHRjuYd4ltGiNIxVZMJKMh nRVpIeMmdB60J5VujbpHWUKRc/QPk0HSZv7BbVj8bqvC79ckygT/S20R X-Gm-Gg: ATEYQzzFogB6Yy5ifaO9wv62GJSos+vb4IA6ns0BBAdZ+MoauTrzMNZJl1wV2yESbyq 2kc0WK0szmV788unGw9BodmNKoJwAazDrSgWyrBQ3SGfKxaU3LtAQAiuu4GwqNrKzVAuXreQOj9 jkajyXFvwJ71iHYPGqbiZSyc0XPFgx207SQ3vTwDaI6iKuDg7UZF4LQMnEUUZ5bNE4oc9LWmS1k U8JOJtyQYhqiUUG9sJ/D6kLbry/AKY3CKNBYrL8afNaoX+RoOhjRHTYC6zx7T6k4tkWKRb4FuqL lm/dqv8QwKz0yT1o+yqHgmcvl/w/HmUEmYk3LYKY7ErPxFXFLpOcqoHygUOSGHMPkKaoh6DoGHv j3L86lKn9yMw1TNZbGIw3RmZcNx9aNVsQNf/Ebrqcdt2I6vNAWaYYCzg1/77Il39kfCJX5VscmF 3cO21cSGjOA8OB+6rMHh+RPNgZIziw9+ysUvlLPN+57A== X-Received: by 2002:a05:600c:3e10:b0:485:3428:774c with SMTP id 5b1f17b1804b1-486fe8b0073mr521675e9.4.1773938916334; Thu, 19 Mar 2026 09:48:36 -0700 (PDT) Received: from biju.lan ([2a00:23c4:a758:8a01:8326:7b31:bf82:d2d0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe68ec05sm5238505e9.0.2026.03.19.09.48.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 09:48:36 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Biju Das , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Chris Brandt , Hugo Villeneuve , Laurent Pinchart , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , Biju Das , stable@vger.kernel.org Subject: [PATCH v2 1/4] drm: renesas: rzg2l_mipi_dsi: Move rzg2l_mipi_dsi_set_display_timing() Date: Thu, 19 Mar 2026 16:48:25 +0000 Message-ID: <20260319164833.409126-2-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260319164833.409126-1-biju.das.jz@bp.renesas.com> References: <20260319164833.409126-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das The RZ/G2L hardware manual (Rev. 1.50, May 2025), Section 34.4.2.4 Video-Input Operation, requires display timings to be set after the HS clock is started. Move rzg2l_mipi_dsi_set_display_timing() from rzg2l_mipi_dsi_atomic_pre_enable() to rzg2l_mipi_dsi_atomic_enable(), placing it after rzg2l_mipi_dsi_start_hs_clock(). Drop the unused ret variable from rzg2l_mipi_dsi_atomic_pre_enable(). Fixes: 5ce16c169a4c ("drm: renesas: rz-du: Add atomic_pre_enable") Fixes: 7a043f978ed1 ("drm: rcar-du: Add RZ/G2L DSI driver") Cc: stable@vger.kernel.org Signed-off-by: Biju Das --- v2: * New patch --- drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c b/drivers/gpu/d= rm/renesas/rz-du/rzg2l_mipi_dsi.c index a87a301326c7..ff95cb9a7de5 100644 --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c @@ -1025,29 +1025,33 @@ static void rzg2l_mipi_dsi_atomic_pre_enable(struct= drm_bridge *bridge, const struct drm_display_mode *mode; struct drm_connector *connector; struct drm_crtc *crtc; - int ret; =20 connector =3D drm_atomic_get_new_connector_for_encoder(state, bridge->enc= oder); crtc =3D drm_atomic_get_new_connector_state(state, connector)->crtc; mode =3D &drm_atomic_get_new_crtc_state(state, crtc)->adjusted_mode; =20 - ret =3D rzg2l_mipi_dsi_startup(dsi, mode); - if (ret < 0) - return; - - rzg2l_mipi_dsi_set_display_timing(dsi, mode); + rzg2l_mipi_dsi_startup(dsi, mode); } =20 static void rzg2l_mipi_dsi_atomic_enable(struct drm_bridge *bridge, struct drm_atomic_state *state) { struct rzg2l_mipi_dsi *dsi =3D bridge_to_rzg2l_mipi_dsi(bridge); + const struct drm_display_mode *mode; + struct drm_connector *connector; + struct drm_crtc *crtc; int ret; =20 ret =3D rzg2l_mipi_dsi_start_hs_clock(dsi); if (ret < 0) goto err_stop; =20 + connector =3D drm_atomic_get_new_connector_for_encoder(state, bridge->enc= oder); + crtc =3D drm_atomic_get_new_connector_state(state, connector)->crtc; + mode =3D &drm_atomic_get_new_crtc_state(state, crtc)->adjusted_mode; + + rzg2l_mipi_dsi_set_display_timing(dsi, mode); + ret =3D rzg2l_mipi_dsi_start_video(dsi); if (ret < 0) goto err_stop_clock; --=20 2.43.0 From nobody Mon Apr 6 10:45:19 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AC8F3EE1E9 for ; Thu, 19 Mar 2026 16:48:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773938924; cv=none; b=sRWv72clR/UwlqSb3aeh4JcPmyWxyoTE9pH0YF8C1I+yfUFsH/o4YUo2jKRArj4W7XXTuch9DuvSRAt2VwtQvMcn8dY6FJrxkPKj8jttqW986ykePeCAG80zngkNbrVkK+FIDEzK+scXLooIvaNeZX58kGBWtl6pHy7dMxR7PFc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773938924; c=relaxed/simple; bh=lG7q/6k0q0qW2KK6r9Mb23Fu+RroCNbNZ7rN3IIIBjQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B0rkbQCxamITUiZ+pdM6k1E0WNsJIjVL6poxPS1CzLecYwraO06ZN45IbvYyu6gilLhH5J8CDPEwMe4jA1aZK5w+fVQjS0iFypZ3LDX9EndhPTtMgVzebMHvzBG1HP7aRGnjCf5mQcNQS6hjH9B/Ow/Sd/gQJ/imihrAK0qXGkQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Cys1qTs3; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cys1qTs3" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-48541edecf9so12766635e9.1 for ; Thu, 19 Mar 2026 09:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773938917; x=1774543717; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bng5/yZC9lrbuKxC9dU3uqE7D/V7iSIEJ7NDOj06TGk=; b=Cys1qTs3o5xUjdEgBxYpXHx1X+CLAXAkA3iVPOf3haNJCKVgT4nLzRwLFLSG690SFd R2k5PpXNe92Ki02g3IsJHOmCqRmrju0tj02NbTIJMYzIWLuMT64xJ8AOTiCtdUlTXDNH NQxEvKJ10OIMUuwFqgyD3pJ5aLFD+WcjXLwUVzaVxXEjz8hoQFUCo7WnYTQq32UpA+Pa d75GCmMOBkKlqvIJvFPu1njhUVH304ah0391HeM+BB3n8waC+a/oS6rNeNzJwYczfGWi 5eMVT4R7bCLC9Jl1VY7jkExOcSPqXUtGC/7WJxYVN8iE1wXJvyHwl33SYc+nTA5B3Bu3 Raog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773938917; x=1774543717; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Bng5/yZC9lrbuKxC9dU3uqE7D/V7iSIEJ7NDOj06TGk=; b=UbFZM1GD+wFXmjxg+yV0M3kJPi/ASd6E8K9JhFCzxxTqIKugmOEUtnKrxV+mFhITg4 BuW7vmpkoKueGHIubsOP/A+pQmNe8hQ0c7/nD6qONpZDF3yZbxSEfUfssb2tDVrXd3ig yrems29Q0l+5TPPF7eQI1A6Vd+wD4W/7ur+hPMR9KC1wxeqpJlgPNg7a3mfKu3edWdEn I8cj83evm+Kv/F/uiV2wg6ZF+LaNTVCvLnW+7NoUmUgFXRqUgs1TKC+fM6V3naYgTl0d nQDKDoyZ65Zsec9vuVqAJwg/MHywr/qcnlDgCDBOealS/fQP5XInhRpO+W3sZpfMJ0Ge dJoQ== X-Forwarded-Encrypted: i=1; AJvYcCW/9/eLt6RAE4rCiuS2k2W9LLuJL7Ft/lfP2Fm2coTdhdtuIc8aOruy8N0Qz3Czw812X14I7HQL2M1bYrA=@vger.kernel.org X-Gm-Message-State: AOJu0YyKhdcY5YjfXUDd4AR/luUxUsUdwQEbFPKt4nKE1SqEM+eiJfBj OmKKL2oXanjBZ62T71m2eQNk5YDNlL/om5MYOmajuvYnYGOg2SzVa06E X-Gm-Gg: ATEYQzwysm1/vnoMV5HL7UnNsqCYKS0c4CLxz6hMgJ/g9McitNTfPwDgiCR4rlo0+aT BPtpoE6tLT4pE6TkPW4IA4z8lS1vYyBkcUI95fN/BSSPB8MiZuG/GyVTm1pK+G6z0J9kzaOB/ig LKQVGzx+7av845V/IlwgJLh0Dq7Ga/sYnNtYd9knC2kkRs02a/xmoHSBnr8YA3dmXy5HiQ7BGME 1rc80jolRmPzFffgdxqhFyW1R1wky6Si8/XO1Mvu3WBQijABDWiVnFX4ZP9odyhuZrtvVTmPa6t 51PdVP1wTkMVYT3e5SLT5hxJCCx1y6aQo35R30H/gZuyMLSpIEsxdtS7CbWqgi+zEWB9amaWArA NyiGX+llFhpHKnoLM88ab/SofYM7eusxnGMKn3gv64PdIHz68ZvAgHfQ+h+offHsBrFDv72yCiW x27VYUw4AjQsBqLvZJIr+fn0ulhA5Lnh4= X-Received: by 2002:a05:600c:c490:b0:485:379b:57bb with SMTP id 5b1f17b1804b1-486f441bc19mr132327915e9.3.1773938916947; Thu, 19 Mar 2026 09:48:36 -0700 (PDT) Received: from biju.lan ([2a00:23c4:a758:8a01:8326:7b31:bf82:d2d0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe68ec05sm5238505e9.0.2026.03.19.09.48.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 09:48:36 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Biju Das , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Chris Brandt , Hugo Villeneuve , Laurent Pinchart , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , Biju Das , stable@vger.kernel.org Subject: [PATCH v2 2/4] drm: renesas: rzg2l_mipi_dsi: Fix assert of CMN_RSTB signal Date: Thu, 19 Mar 2026 16:48:26 +0000 Message-ID: <20260319164833.409126-3-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260319164833.409126-1-biju.das.jz@bp.renesas.com> References: <20260319164833.409126-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das The CMN_RSTB reset signal is not required for reading PHY registers in the probe. Move reset_control_assert() from rzg2l_mipi_dsi_dphy_exit() to rzg2l_mipi_dsi_stop(), placing it before the dphy_exit() call. Since this reset signal is optional for RZ/V2H, the call is a no-op on that SoC. Fixes: 2991c3f0ca86 ("drm: renesas: rz-du: mipi_dsi: Add OF data support") Fixes: 418bb3a69e13 ("drm: rcar-du: rzg2l_mipi_dsi: Enhance device lanes ch= eck") Cc: stable@vger.kernel.org Signed-off-by: Biju Das --- v2: * New patch --- drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c b/drivers/gpu/d= rm/renesas/rz-du/rzg2l_mipi_dsi.c index ff95cb9a7de5..d2da247abf05 100644 --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c @@ -541,8 +541,6 @@ static void rzg2l_mipi_dsi_dphy_exit(struct rzg2l_mipi_= dsi *dsi) =20 dphyctrl0 &=3D ~(DSIDPHYCTRL0_EN_LDO1200 | DSIDPHYCTRL0_EN_BGR); rzg2l_mipi_dsi_phy_write(dsi, DSIDPHYCTRL0, dphyctrl0); - - reset_control_assert(dsi->rstc); } =20 static int rzg2l_dphy_conf_clks(struct rzg2l_mipi_dsi *dsi, unsigned long = mode_freq, @@ -822,6 +820,7 @@ static int rzg2l_mipi_dsi_startup(struct rzg2l_mipi_dsi= *dsi, =20 static void rzg2l_mipi_dsi_stop(struct rzg2l_mipi_dsi *dsi) { + reset_control_assert(dsi->rstc); dsi->info->dphy_exit(dsi); pm_runtime_put(dsi->dev); } --=20 2.43.0 From nobody Mon Apr 6 10:45:19 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA6E6283FE6 for ; Thu, 19 Mar 2026 16:48:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773938928; cv=none; b=bQ+z30j4NsnqB1D7waUTNTBJtSbMHxqvLNMy5h96OuS6UBgd/0Et7gNzJtTJPByQ6Z9zVUQyG9FvmKQPxAk/KF7jBX5ZAmT2cXtVdRQfcD+qGP+Voag6y7k/1TT3zocf9SmkeJmKCnACcPKeyNAyFW9eo6NM83i9ZqvrzR0814E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773938928; c=relaxed/simple; bh=XEJxQY//7wzu4fXR+NaCWC3y47kwc0sWGgmZJ+SFGSw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZFXAAoSVRcS4dKCx5OZURgexE6ra/BeHuQXqYKHISK4dhS6di10pie8FcnUtafId1YM1fY3MgL0fDY8jILuiDBXN+2AMEeN3cYS6aUyIXjjc3BZJ+QxQH/CCppd3R8PfcgM2dQfUtnpcUBxsn72mdJCQEjdzz0dI0BkiPJ1yfxY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ctTNyC5f; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ctTNyC5f" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-486fd5360d4so5784695e9.1 for ; Thu, 19 Mar 2026 09:48:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773938918; x=1774543718; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3XyX5oy0M7FEG2yDPl7UIzv4+eTNG+m8Qc/og46NTtc=; b=ctTNyC5f031mM+ck55ZHEsMtSYBYgwhOEzeHSLnaGxIKTnZs33pdP0npxkjcTFMX47 7cTBQMxNvkdZfpNk6+Euj7gewzCUdEIUjhSQotKKrsIdX6jWucqgnbFEMYCQGHDHY2bV S3QTvgdVEM9vaqYVZ7LeLznsQoZuAleVIwXb5KE7KJDy62z7l8FX3zXuAEWIzTGMnSY8 TsbMUrrTsbbHGNNLdrV+I9xXpuDuf3/ESRx6ViPyxYNis1I90PS+B/nfS6OxP3msWoMl O4c3dmGLzGdcViWGG8p3etSkvoRS06bwfCWGhojRcZmsEK0Y8LXSp9CIupDEKSHYEijQ /sJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773938918; x=1774543718; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3XyX5oy0M7FEG2yDPl7UIzv4+eTNG+m8Qc/og46NTtc=; b=XEzWRDsY6hpS+Obs5qKBOg6Fg/Na6RnysGAwfswrAvRl+X7zQBgXUThiV9Oot2nMod haLdjymUC0h6ZTsR3rWDfEDOweef6wuDaAHwT/rncRV6A29yDZopw6FrKFJCDFyML3jq OKw7nz1Dmt60RGFKL2gROvRjhXwMFFQqDIWL7bl9CHL44YNuPKT8wBvdmS+MSnzphm4z pze/lgAIYaKyu/Ml7bNjGP5X5HAyG+OcvCsj3Vpr0FirLdGt3IKq0S7L7cQGekdaDv5g LnQhieKdtyN3y0brw//uAgHyLbI6XPwTMPehbDXsvxL2PiYSGNUUYkrI3wgkyWOj+ASp BqGw== X-Forwarded-Encrypted: i=1; AJvYcCWbW4SX9dejWPtFD0+17W2A5s/8PBRWMzSVAktwE+jCdZFl9E1zuTNpAiWw6kGY2ai+sASwlRpLTszDjbI=@vger.kernel.org X-Gm-Message-State: AOJu0YygYKRpQ+U8zqagsZt8JXSDTS1XBxB42EERsgB9AL7YIlTPq8Fh 0RWSIG8hws8IXPZscjLvPPc9G00D8Vgl7F2DYYeRy9uzVqWdlnOHOL/B X-Gm-Gg: ATEYQzwvx5VHx9QrAfVHWBm15TMcEKHnG6SVzYaigAUoWPtcJB7nzHVQnL4OefaPGOW kyB3YXhGxTrGENPf/bZKhIcwe6ORkBbK9uk6unkUH2bEB7/VwbNJ0JNhjJm0oEyY1QG8C2wBtHn 4FUkuqn+cIeYMAfbT3vYvJgRsWR1VUjV+rtois3vXsglLoty2jA5AL+fGCMQsHyFO+rHxk0enTk 0Ai3Y/SN+nLYh4aLGettrHGUnmUuRAUgpt811jXE6CmikjjuF2UdlQNUq03FHh/ZNj+nVoEmeH5 0l7DcbXmB6GlvDr6JvvNwRVDagNiEVRwjW4p2wfcd7xtUFmSIzyB/RlZyKHHOV0FRn9M1waa+t7 mcZO+S0F7MuzUceIHKBu90TNOTCyAnPlqQaYDtmG6o3bbyJ/eBzLSGmF18VpKSXUEifYMa3rPI/ 5SDLFrZbZhWuU3LjcQ3rj+SL51a99/84c= X-Received: by 2002:a05:600c:4fcb:b0:485:3f38:3de3 with SMTP id 5b1f17b1804b1-486f44384d4mr134219545e9.3.1773938917496; Thu, 19 Mar 2026 09:48:37 -0700 (PDT) Received: from biju.lan ([2a00:23c4:a758:8a01:8326:7b31:bf82:d2d0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe68ec05sm5238505e9.0.2026.03.19.09.48.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 09:48:37 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Biju Das , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Chris Brandt , Hugo Villeneuve , Laurent Pinchart , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , Biju Das Subject: [PATCH v2 3/4] drm: renesas: rzg2l_mipi_dsi: Fix deassert of CMN_RSTB signal Date: Thu, 19 Mar 2026 16:48:27 +0000 Message-ID: <20260319164833.409126-4-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260319164833.409126-1-biju.das.jz@bp.renesas.com> References: <20260319164833.409126-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das The RZ/G2L hardware manual (Rev. 1.50, May 2025), Section 34.4.2.1, requires deasserting the CMN_RSTB signal after setting the Link registers. Move the reset_control_deassert() call from rzg2l_mipi_dsi_dphy_init() to rzg2l_mipi_dsi_startup(), placing it after the Link register writes. This reset signal is optional for RZ/V2H SoCs, so add a NULL check. Drop the unused ret variable from rzg2l_mipi_dsi_dphy_init(). Signed-off-by: Biju Das --- v1->v2: * Updated commit header and description * Moved the code from rzg2l_mipi_dsi_dphy_init() to rzg2l_mipi_dsi_startup= () * Moved the check before calling reset_control_deassert(), so that it will= be skipped for RZ/V2H SoC --- drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c b/drivers/gpu/d= rm/renesas/rz-du/rzg2l_mipi_dsi.c index d2da247abf05..5020be0f72ac 100644 --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c @@ -484,7 +484,6 @@ static int rzg2l_mipi_dsi_dphy_init(struct rzg2l_mipi_d= si *dsi, u32 dphytim1; u32 dphytim2; u32 dphytim3; - int ret; =20 /* All DSI global operation timings are set with recommended setting */ for (i =3D 0; i < ARRAY_SIZE(rzg2l_mipi_dsi_global_timings); ++i) { @@ -524,12 +523,6 @@ static int rzg2l_mipi_dsi_dphy_init(struct rzg2l_mipi_= dsi *dsi, rzg2l_mipi_dsi_phy_write(dsi, DSIDPHYTIM2, dphytim2); rzg2l_mipi_dsi_phy_write(dsi, DSIDPHYTIM3, dphytim3); =20 - ret =3D reset_control_deassert(dsi->rstc); - if (ret < 0) - return ret; - - udelay(1); - return 0; } =20 @@ -809,6 +802,14 @@ static int rzg2l_mipi_dsi_startup(struct rzg2l_mipi_ds= i *dsi, FIELD_MODIFY(DSISETR_MRPSZ, &dsisetr, RZG2L_DCS_BUF_SIZE); rzg2l_mipi_dsi_link_write(dsi, DSISETR, dsisetr); =20 + if (dsi->rstc) { + ret =3D reset_control_deassert(dsi->rstc); + if (ret < 0) + goto err_phy; + + udelay(1); + } + return 0; =20 err_phy: --=20 2.43.0 From nobody Mon Apr 6 10:45:19 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73EDB28FFF6 for ; Thu, 19 Mar 2026 16:48:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773938927; cv=none; b=PoLxlLWCWCQcJfaucp3M7+lByXg2/Hq+wVgYplRA4qgVWET0D/3Ver4i8N9rcqb2/Xpn2lZzrEg5y1htN+pkDFaO3T/1pkS5wEQKaZ/96bOokpoQAeZ2rqBpjk50TAI/uxvv2h2LqtU324kvrSq5/NywMFJ3lKQmcft2HzY2dsg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773938927; c=relaxed/simple; bh=nkLAM0jYneFvgblemuHPCxzulla/HTvZwrV6G1SRgpk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U0ywdzZKt+KWKeorrZpqvHbnUoW1PXA8pF+2gLhitn1MrZ8ywHzyQxlhpD0jVSH7p3viPK3XaPDzUQS0rEbd0ESf1J7o5+46204+xss83XFJchcBP+JwfBH9kMxf8DCRK9VEy8f/9Q262/tJqzXmzrYFsG9qUSGPAO/Hu0uKwO8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nbMvglSI; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nbMvglSI" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-485392de558so7570275e9.1 for ; Thu, 19 Mar 2026 09:48:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773938918; x=1774543718; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ko0JSoqc92if9jLRax/3q0IGpdS1ahpKtbD0W9dlNH0=; b=nbMvglSIxHRVrz0xjMpQN53dP+k65cUw2jfjd0FtjdpzocSM5Pna+bXHWNfwlgEqyk LgNGxsIR88N3DokdheYXPtRDtPvI5F8yqT6UiTMVcD/rcO5oHwYUCIAApMBs23tMDWRt m0CXx5dYA+FIPR9/9wFIV5Bg06YzZXcnh+SpgZcVvASzTstwxrEnPh35f0yUC6EoA/Dn rOIAbNrc3TqqNrnfSiYHpz1GDqxneEwooL34/UmVyqvjwkmo83quPSr61CSSdXH9WvVm YMHEhgJG6X6G++mmFGz6VcMk+B0M17M0XGLE2l6TeGjq0Bfizm1Bz+bW/ZD7gvo5vva8 ZsEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773938918; x=1774543718; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ko0JSoqc92if9jLRax/3q0IGpdS1ahpKtbD0W9dlNH0=; b=sPdipsg6b7JlHaGv/TM46rTao78lW5vHgtrRcDTVES/lPlbyfQGQfHYZT4vA3kgK8J IN8uvmBWQGiHmTx7ndCiAavgjWYDf3688ZthLaERkTqxfSj54nQF8ANnhvL0Qg8WnrRY 26FBpYp4cCOcfWBTvHR1fg5cCi4/9RdwdHQBLy+2148QWqNwDLrZZbIfhnqIuHmdx9Ft od7TPi9k5wPXOX2Y+u9QEZ+2n7DHEMn/j0jART/HyzQBW44mATzPc3OBXy6cuimnjfbd 2qNeMKihXeRvqubwhb2aFnzigSO6vSkjSqfF81xiCzdtnqUIb6BNhFXqMF+ySdnDPWYD +1hw== X-Forwarded-Encrypted: i=1; AJvYcCUqqV9zbO4hdGDS0gONaa6xgZcRqX+xqwavFxuweVAA3/n/YjAsGncbgcxcmz2M7ncggHujvV9HoNyuQWU=@vger.kernel.org X-Gm-Message-State: AOJu0YzzBcdfZoARAgAsJlM4RKMIxTdoGTT9Xwic+YB2/R1INYf/zjGY ttktjH6SkmsphXyeI5KzjF1zH5ALsqSoUIO4ikB+IDa2YDCx2Om5Zb7E X-Gm-Gg: ATEYQzyKr3kY2zJ4XLL5t9DouFyFBXbo5ib9dKW5zTLWit6qmYxoTjAuTORBVfNOFHI gUkgNyva8mMn1I9dNayy7+RGZR/BejWvO76TNEuc+1DWJfhxfYbtrDBqwcRCNnYYK08MweWYm1f Im/C4HWfK4VeaKVduk0zP9buRLTPWqhrGhKEmwE3BhrgLScirsYnTUaHk1GFqol5u36TfyP2pLH QmEfOd0vrGwehfKcZXcnR6ApW3N+Hnvr5Tom1kBqoQ7eAbuIm57sjBeevLZSkNPNGYamrV43fbV V4aGQQBJ7d8jOuVc1H7fTGBy7qliBy4EiWH7scR81UQTUqkPlpNUB39M5CM0jtr7lYmP0z9lGxS Gyuc9f4tRpoIl0XDFbltISYx+T1VkACQZgNhb+zy8kSeBQZvyEGxowP7BQmSXBws559JpJ1lz2h J0XCCL22btQw0IaKXxHz6NzuFpup0mfAc= X-Received: by 2002:a05:600c:1d10:b0:485:3eba:ab96 with SMTP id 5b1f17b1804b1-486f4421c4cmr140167715e9.3.1773938918105; Thu, 19 Mar 2026 09:48:38 -0700 (PDT) Received: from biju.lan ([2a00:23c4:a758:8a01:8326:7b31:bf82:d2d0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe68ec05sm5238505e9.0.2026.03.19.09.48.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 09:48:37 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Biju Das , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Chris Brandt , Hugo Villeneuve , Laurent Pinchart , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , Biju Das Subject: [PATCH v2 4/4] drm: renesas: rzg2l_mipi_dsi: Increase reset deassertion delay to 1 msec Date: Thu, 19 Mar 2026 16:48:28 +0000 Message-ID: <20260319164833.409126-5-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260319164833.409126-1-biju.das.jz@bp.renesas.com> References: <20260319164833.409126-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das The RZ/G2L hardware manual (Rev. 1.50, May 2025), Section 34.4.2.1, requires waiting more than 1 msec after deasserting the CMN_RSTB signal before the DSI-Tx module is ready. Increase the delay from 1 usec to 1 msec by replacing udelay(1) with fsleep(1000). Signed-off-by: Biju Das --- v1->v2: * Updated commit header and description. --- drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c b/drivers/gpu/d= rm/renesas/rz-du/rzg2l_mipi_dsi.c index 5020be0f72ac..715872130780 100644 --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c @@ -807,7 +807,7 @@ static int rzg2l_mipi_dsi_startup(struct rzg2l_mipi_dsi= *dsi, if (ret < 0) goto err_phy; =20 - udelay(1); + fsleep(1000); } =20 return 0; --=20 2.43.0