From nobody Mon Apr 6 10:32:32 2026 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F0F3346E66 for ; Thu, 19 Mar 2026 16:30:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773937835; cv=none; b=r4MDMcy6Y7OkBRrryDGh1rWph2q2bVnUgoAIbcuD/maehHbtwVIFHzSdboFXgrkC2fnjKiV8Iuu1gEbGuwUj4V8R7wQte5cp6QNb6+MUdJ4wwIdIwnQbUGdTBGE4pCVcf2+qirUJzZRqnxmXCP7LM3/LmuT0JBZcH3souyVvu0o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773937835; c=relaxed/simple; bh=/0Inx82Sk167/SQ4akQAMhU1dM0KxkKRDf0EL0f/cHA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ig94mOkftI6CYwCpLi4RnVdoMqmQ8VTKa6EpNOgwUbGsO15rNnKz33XAEe9iH0wq/PK4ffkwBXcpcvpHjb//0h3EWspZSD3CirB5VytzUOdXtiW59M37z0hYzk4+kePaVBtCuYR4OdzV9/HJHzRIkP9Ew9uLuQEGnoUnR6wRUOQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=idWHtAhu; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="idWHtAhu" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c70bfef17a4so795220a12.2 for ; Thu, 19 Mar 2026 09:30:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773937829; x=1774542629; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7WbbIrQRZg+WI5V+d2UHHYYa3r1L0mKPW9kQXI1QdeY=; b=idWHtAhuddgzWeDHfTxj0eNK3z7kP0qI2k8cc4HdOVF1HZOn88SgGcmbWcDn+PkDh+ GqkU4mGe/ScBEh3qSat/x5oKqLktjm7NqfvYZwcGNTvh+s13jYgMAktEfjIG3Shp4NOT 3TSk+MSrUH98dMq8wkd9DE0agSXzTskngOiRktMbSqt5Crkmp1g5372loA0cLo5x1uXh kJod0G3JveBPX2V2HeEVzNZLCIVNmhxdiFz9PD4kl8rBp5ROkeU60JD2ftjGJkDecfL1 faU1Uut1BX9RnldxBOOTC7NufaPhLcKUIkEsVKTo901hsdzILeFJ74lAOK+/ephteT81 qZcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773937829; x=1774542629; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7WbbIrQRZg+WI5V+d2UHHYYa3r1L0mKPW9kQXI1QdeY=; b=XpH83Wz+68w578QNt59ek3X77aFcBIi0M0SeOTTtdf7g6tgJoANNUhtT/oeP206zYf b8pTku/5zeVm5kSYqQaxaBxVnMfR9PzGClktDKGQN5CJqJXlvDGoKWSM2DZ5cL+H8rYJ YL5kl8z03v7YvIcp2crwgWR+uyhz01IHiAc6lK+MJWIsQelllzllLNOP9VN7p/+5j0l2 Mx9+fGkqU+U2Yagwn7ugpeyc6+NQaSXCQw2hI70MQsUWd4+f0JCkGO6lL69L5GOZb7e8 2rTLQafoZkRaVFKy2Vg9fKDmXNsQ2cwANDL446WC4lNeusDRDnoboBas8FBxv6XlCDWl DboA== X-Forwarded-Encrypted: i=1; AJvYcCUeAhXJSfPQKcwqY2dcwBFwJx1Xq3Y9VNSTrh7JKFwnfgf6wdSagrV36pkp7ReCJQbIgEfPwLYmkBSC+aQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzmq7Q1hFBYeOezvFH7CXSWZ9DAdTmDY5D7EVETOhiENN7N8b5b hwuAqQoKk9ZsrBLPQ+St+eQ8YlCZ48NnTSPZdHUD6o3J2eV+GZv3ndkEvlAuLQx1 X-Gm-Gg: ATEYQzwRA2UrVEPH3wAf0PViSvFtfIw+L2eLfiH0evDo8OplSBSEmooXQq0UHu66zes AzuCB3hsXoQI/PrBN7l4YxYuPNvCQMwb3Aq+YSouL1ts9XBFdsVGs0xaaSgZgevS0nm/z+U6gzs A8MTXk1G8tL5ta8HfDlIFzPdsSE42KC/3eO0/tqBkJ+iRLj7BxcIsk9jNCthGst7Hb4I4ZweHUr kLHVdHLiWAWL0gzVJRCeaOLWnHMKBp1MoggxIlMcQbSl/DtNLcoJ+xAlB9hfkxQDbKBM8yXxK7h MR+G8CM0mpOR6rg/r5nUDEKAmEu6ykwg32kw5dOJaUD00BuWKC0qajmkCRY+y7VEKYfevnblMRe UBcjtveGBhlyL8e81aH4h4AI5R20oQmf+PVQjfIj+gJQGhnQNMRdin10Yy91HJ6gG2kfFKkkM4g jzdu9hHytFMy3+xG11xLARN0rAzjM= X-Received: by 2002:a17:903:17cb:b0:2b0:67a7:5c4b with SMTP id d9443c01a7336-2b06e3bd39bmr79715765ad.28.1773937829185; Thu, 19 Mar 2026 09:30:29 -0700 (PDT) Received: from ubuntu.. ([152.56.142.182]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b06f7e8290sm61584485ad.82.2026.03.19.09.30.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 09:30:28 -0700 (PDT) From: Anas Iqbal To: Chanwoo Choi , MyungJoo Ham , Heiko Stuebner Cc: Kyungmin Park , Sascha Hauer , Sebastian Reichel , Jonathan Cameron , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Anas Iqbal Subject: [PATCH] devfreq: event: rockchip-dfi: fix missing clk_disable_unprepare() on error Date: Thu, 19 Mar 2026 16:30:11 +0000 Message-ID: <20260319163011.18876-1-mohd.abd.6602@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Smatch reports: drivers/devfreq/event/rockchip-dfi.c:215 rockchip_dfi_enable() warn: 'dfi->clk' from clk_prepare_enable() not released. If rockchip_dfi_ddrtype_to_ctrl() fails after clk_prepare_enable(), the clock is not disabled, leading to a resource leak. Add clk_disable_unprepare() in the error path to properly release the clock. Fixes: d724f4a4581b ("PM / devfreq: rockchip-dfi: Prepare for multiple user= s") Signed-off-by: Anas Iqbal --- drivers/devfreq/event/rockchip-dfi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/r= ockchip-dfi.c index 5e6e7e900bda..8db0bceeded4 100644 --- a/drivers/devfreq/event/rockchip-dfi.c +++ b/drivers/devfreq/event/rockchip-dfi.c @@ -185,8 +185,10 @@ static int rockchip_dfi_enable(struct rockchip_dfi *df= i) } =20 ret =3D rockchip_dfi_ddrtype_to_ctrl(dfi, &ctrl); - if (ret) + if (ret) { + clk_disable_unprepare(dfi->clk); goto out; + } =20 for (i =3D 0; i < dfi->max_channels; i++) { =20 --=20 2.43.0