From nobody Mon Apr 6 10:32:52 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06F963D7D60 for ; Thu, 19 Mar 2026 15:22:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773933735; cv=none; b=ZECwHGm4OqsIcV6LwlJEMEQwOsIC+weljVd7pQUnYg68Yd1IwZ+4mwlFASAqZhUVfxojzK5YGyZJFtbViTInivIXL8yxSImApPwkQWwpddQ35b+jh3VcOLx5X2a914d/sEcoGNVC5N1cgYfeqht2OHSyGht7yBg/MXVcG6Kbzak= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773933735; c=relaxed/simple; bh=53PD+YgOWvG+t6jY0mYLmozhCc3JR2zLfkumITTClGU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=guJqcdQ6O31mkHYdv/LGW2wS93GD6o7ws+HFSbbVCIoxy8IbKYG9nRUNyUL1q2XDyN0vcZD12xPQ8DRQ5JmLDtSaRWh1q8n8UdAeDhT8IfJbUdd/n4gjtvHKQbLdSXg+UK4Nxbu4AXf0wzX9Hyvsy5OXVjj3HJsi5V9tDu4SGYw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Aju1jS2h; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Aju1jS2h" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-486b96760easo11833765e9.2 for ; Thu, 19 Mar 2026 08:22:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773933732; x=1774538532; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GgzhtROcSy0GjSIJM9ZevJQSmFHvUeLdqzObywMZV+Q=; b=Aju1jS2hi6dqyyehWyNnGiY8mPUafsNFaDVZRmNZfNpS6rbkUcN4XbSDJ3dnM4kC4h /O3s7gCoKOLq1RMP696UU+2DVuQa6VWQlu+QF+0WKOCoau1pXR6rP+YV2NV0x0UIs7SZ q1/63Tq6tuwmNFp4FmfVaFdlxvc7g/C/aoFYAjNvdbOT7Gtcrk/9RM43fC0TLukwF5fl V1XQsaqi+qx9BCJ3tTJ9LH7BVORwI7unMf8Ka7dZJqdLW3b6qu3B4gTfGDekJsjWhuts CFHSv36QgffV8SeifF6twtmwRXXQ6Xd7UQGYRW84TcoQb1vlGZ2UT94aRYoUMl/w74D3 8Y5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773933732; x=1774538532; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GgzhtROcSy0GjSIJM9ZevJQSmFHvUeLdqzObywMZV+Q=; b=CQtoZqCsu8c2mHDQeFsuHae/jp4aAwK1A+Ih2btKTRRw5oE5V3gAzpYnDEvY/COG2/ g7uZlF5+Z/PfmLF7Z4SNg3w4hMtcyExkg3tRmHAD3ZBeoNQ4qBWDk/66ThLsnMi+z7va ARfjFq84KIHD2jfduMpJPYs49q3UP8R322ik9Oj40qNRZ9IoBYVGzeFIiv/ktk7jH3eb tMcMMbS388qfUPHqY98HjVli8mGw0n6NOSLU+cncG2CrhcssS3/hskc36zKanok0iM41 d1rMI0I2be5gAAZAzgvFfrVaZJgR1YE2MQPXgjQBEdOSjUzDuj8/VWMdgrhyUTqbi/nj aXgQ== X-Forwarded-Encrypted: i=1; AJvYcCWBbwMqTYRyW28S81vu9ORNn/IbzrUOtDyY8ZpQ5yezK73elOILFFlkY0RGdRawAPXdbfdvmagLxKMRGNQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yya+dmfEDOaL+JwGViePFo4fbIZaPdizyvSR/Q2XQv9BtkpMELP o9TVsgCyry3wMCv0z6Cp1D0dD/kVObxGOcqttJGYeVl7kWLfH1b2VP0X X-Gm-Gg: ATEYQzw8ej7oPejZaUX6Wa9tLVGdLIItHtN7l6BbHzwr5KK4kCTOhw00w5m4jNLgwMG Tb6+Fo3XxeBi6I852vs+d9bQf18/wVRxQoiE75EaCMmwxakBdoWOWTi1QLbJN0vqakdo1JOHml2 KKbbFk/cRztBrWS7v0qQAJMv94XHZQIddYaRNWjgqTL8KeEtMoPLCeB9avCm/bE9uVDA/omx5nH 1J8WqPxMWazKNjkW5fTZ6Tfek4bI0q6dFqpgDEAjHcMwONcaJT5R0uddoJYIS0M39k6GZ6Yq+aL PIqnbEeDSeF1IgTrYmjvRjoNe0l7qHIC0mK+3VzLhnK2c2nJzl1pBoR2qtheVjNvnfqUy5Zbu6S 3HF6YJuvPQbwUGNTwGcmFsCTCK2xPWV9frexLIHpbyhuzbF7oV5UsD06LTqcRILnc0730XTITgN PcZ0glXVMqQyy3nJkOWybCH1RAXnknxl9efBX1++qL8+iRbS6i9CwX X-Received: by 2002:a05:600c:6c0a:b0:485:3471:cffb with SMTP id 5b1f17b1804b1-486f4446343mr100334615e9.15.1773933732137; Thu, 19 Mar 2026 08:22:12 -0700 (PDT) Received: from aldo-conte-t14.tailf68ad9.ts.net ([217.61.173.50]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b51852097sm16808860f8f.9.2026.03.19.08.22.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 08:22:11 -0700 (PDT) From: Aldo Conte To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, tglx@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com Cc: mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, james.clark@linaro.org, hpa@zytor.com, x86@kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org Subject: [PATCH] perf/x86/intel/p4: Fix unused variable warning in p4_pmu_init() Date: Thu, 19 Mar 2026 16:22:10 +0100 Message-ID: <20260319152210.210854-1-aldocontelk@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Build the kernel with make W=3D1 generates the following warning: arch/x86/events/intel/p4.c: In function =E2=80=98p4_pmu_init=E2=80=99: arch/x86/events/intel/p4.c:1370:27: error: variable =E2=80=98high=E2=80= =99 set but not used [-Werror=3Dunused-but-set-variable] 1370 | unsigned int low, high; | ^~~~ This happens because, although both variables are declared and initialized by rdmsr, only `low` is used in the subsequent if statement. This patch prints the full content of Model-Specific Register via `pr_cont` and so both the low and high part. It is also very useful to have the contents of MSR_IA32_MISC_ENABLE in dmesg for debugging purposes. Running `make W=3D1` again resolves the error. I was unable to test the patch because i do not have the hardware. Signed-off-by: Aldo Conte --- arch/x86/events/intel/p4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/events/intel/p4.c b/arch/x86/events/intel/p4.c index e5fd7367e45d..dc2866ed2495 100644 --- a/arch/x86/events/intel/p4.c +++ b/arch/x86/events/intel/p4.c @@ -1383,7 +1383,7 @@ __init int p4_pmu_init(void) memcpy(hw_cache_event_ids, p4_hw_cache_event_ids, sizeof(hw_cache_event_ids)); =20 - pr_cont("Netburst events, "); + pr_cont("Netburst events, (misc_enable: %08x:%08x), ", high, low); =20 x86_pmu =3D p4_pmu; =20 --=20 2.53.0