From nobody Mon Apr 6 10:32:52 2026 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC5BA18FDBD for ; Thu, 19 Mar 2026 14:18:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773929909; cv=none; b=sQsl7I/zhpmFePNbGL0I6X/289a4aqEdneDAc9zTbh4hwn899neExpQWs6eMa5OIhpKVrSR7qKzVbA6uv+v+3bDY8cSMigcgCkWm0MsjK/uLKwx1S5396rTbp5lQznSacCFVUW3On3gzOF1gdo7aApbOEpZeW/f9/MbipPhnpOY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773929909; c=relaxed/simple; bh=EHz3OH4NQl+5kez4lALoytwa8lBXo9ZxXlJ92g4WOaw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n9I4fwSzHA7SR/DDQvDvhM7KKapbkVrtB3CEb7HFn6oAm/4dH5pvZPo+5cFwtyNGw8yBHgpW3eQnGEn7HBxVOjGattXqnc64HJavFUixq9PSyf93OhLbhNlwS3FovNyrUIXi2sg4fbZIdEl1bDBj5nRgshsM6Ij7NLUCzA4Jhek= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QthIRceE; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QthIRceE" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-c736261ee8dso365815a12.1 for ; Thu, 19 Mar 2026 07:18:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773929908; x=1774534708; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QTUhuvZrbPLi65P2qC19uSSj7YWJnMpGLDgt32EXjPU=; b=QthIRceETLukmKKBdysq6v4mVf8gyYz/MndXnuVZN0LxnHPjGbytk6zyTL8nDTQhRo GMIUcIz8UI8MTRQBvyLR3PkJZFkb3Ef2QdsaxIukkAPvBM7/ySfQtbLX7JSeL3xuWCh5 64gfo7a95A4sh/BAFNJyXODtPWnM2oJHLO8gKRd//a/3vBi4nV8dqkiWslQO+FjUhrFG shwGRcJS3jmI6WYbNk/py8y5Dzq2dhWo6D3vdvco4Cev7sVilawz4GLWqO5pm8VrgzzY /44XX3n11aeuFXvFDUsN2ismaYWDC75AUMd2codSiJeGHqSWREbiGqjdyhvRvAwee/HL cK5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773929908; x=1774534708; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QTUhuvZrbPLi65P2qC19uSSj7YWJnMpGLDgt32EXjPU=; b=hVMaiF7Qv43o74Cf1iOXMSLiH1EqxbgB3bkqV5k5PGx7Im2coOjDzMZTPItVNEJb+d vyUELudc0XbhmH0tzwxEWrwDnUaDHun6g503+RhTELe8CRkRhRcfPN6mhvyUm5+keF59 oXouxhqfdFwx6YYw+LvAfB09/A2iqYF4VoSGNqm9qaiEdiVfoBx103BPCr9DOZON7tdK Td+vapf5r+LOqhNeaj8F/PrEEx3AN0iJfRZi/n7YkrshP6vllasui5j8YKhBlcAUtF/P RVyDWevGVKHwcN6VDp8f5s2tYfSXWiDNTtgNsHnEo+eH/BEj2AAa+9SY9luJcGSDUA/B +Psw== X-Forwarded-Encrypted: i=1; AJvYcCXxOP/3sCugCZFpaPL0jP1+J3ti0phfBr83tlZjunPH3lKuNVm1tlTQCJPiiWfb6ipFmwwKqX6Ynf0JClA=@vger.kernel.org X-Gm-Message-State: AOJu0YwiXtVzgtYoxTPywSK9V9xUVE/AlbNiFX7ew4YmMs/mrKLB9tNl ZqBE8r/ermIWeXNDosZ6Y3ntxuvkgZdmyvRbpFU3Oz3u7bl6H8jpZKko X-Gm-Gg: ATEYQzyeVerw9UKMPNmcc8BVLLmVWRuWHRYV1P6ehSG8NijJf/rm9tq8DBOSRCv1sC0 1MSwkxtY6yIvleHdfcQoW44Hfl1/nUFt77w/1Tai+CFsvlStFM/VHp74HPWqeye0oI7SxJFadvJ 5LnRvWx18FOMmWsG/88sBF9bfF50JLgyENKAGEYAeYDHjvLZWC+y3AH4n8x4wptLxy+5bR1YRUv Rx7GYKI26OcTYP5YPXG1vDuqmICYuaAOo20QqOpq5bRusTMAm1CQ9onYlWTlJG6B5FJNCz7LnUj k2Jvdhwye02dRpvS/qdf8/6DlEy6DWQmI86hoTAel7Ki3YemBIeyErwwMFRge49hjqEt10OPN2E 3hg52V2lLi+layCBV7Cjzl/Shnf1j+KCdT3oKZnEi1tCmtQ2mjtMWwimZFaJ5r/vX5oKdY3vVsy vTIFoyU+MSi0TTUxE2pOEiis+5aXcAE3rmeQ== X-Received: by 2002:a05:6a20:748b:b0:39b:8dcb:f37e with SMTP id adf61e73a8af0-39b99f674f8mr6811452637.34.1773929907892; Thu, 19 Mar 2026 07:18:27 -0700 (PDT) Received: from aadarsh.. ([2409:40d0:11f4:e9ce:f110:1acf:6031:3b39]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-c741e0b32bdsm5350077a12.3.2026.03.19.07.18.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 07:18:27 -0700 (PDT) From: Aadarsh Mandal To: gregkh@linuxfoundation.org Cc: aadarshmandal9354@gmail.com, luka.gejak@linux.dev, ethantidmore06@gmail.com, dan.carpenter@linaro.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, straube.linux@gmail.com Subject: [PATCH v4] staging: rtl8723bs: removed dead code Date: Thu, 19 Mar 2026 19:48:18 +0530 Message-ID: <20260319141818.7735-1-aadarshmandal9354@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <2A37C741-68A1-47E2-AB3D-833593B5C392@linux.dev> References: <2A37C741-68A1-47E2-AB3D-833593B5C392@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" - removed the dead code. Signed-off-by: Aadarsh Mandal Reviewed-by: Luka Gejak --- v4: - removed the space insertion. - deleted the commented codes. v3: - added the extra space that count as insertion. - removed unwanted addition. v2: - accidently deleted the braces for the standalone code blocks {}. - deleted the reindented comment code, extra space. v1: - reindented comment code,extra space remained. drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 063a0737933e..96a0c8e304da 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -481,9 +481,6 @@ static void _initSdioAggregationSetting(struct adapter = *padapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - /* Tx aggregation setting */ -/* sdio_AggSettingTxUpdate(padapter); */ - /* Rx aggregation setting */ HalRxAggr8723BSdio(padapter); @@ -635,9 +632,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) return _SUCCESS; } - /* Disable Interrupt first. */ -/* rtw_hal_disable_interrupt(padapter); */ - ret =3D _InitPowerOn_8723BS(padapter); if (ret =3D=3D _FAIL) return _FAIL; @@ -656,8 +650,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) rtl8723b_InitializeFirmwareVars(padapter); -/* SIC_Init(padapter); */ - if (pwrctrlpriv->reg_rfoff) pwrctrlpriv->rf_pwrstate =3D rf_off; @@ -740,11 +732,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel, CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET_= DONT_CARE); - /* Record original value for template. This is arough data, we can only = use the data */ - /* for power adjust. The value can not be adjustde according to differen= t power!!! */ -/* pHalData->OriginalCckTxPwrIdx =3D pHalData->CurrentCckTxPwrIdx; */ -/* pHalData->OriginalOfdm24GTxPwrIdx =3D pHalData->CurrentOfdm24GTxPwrIdx;= */ - rtl8723b_InitAntenna_Selection(padapter); /* */ @@ -786,8 +773,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* ack for xmit mgmt frames. */ rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ= _CTRL) | BIT(12)); -/* pHalData->PreRpwmVal =3D SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRP= WM1) & 0x80; */ - { pwrctrlpriv->rf_pwrstate =3D rf_on; @@ -1075,8 +1060,6 @@ static void _ReadPROMContent(struct adapter *padapter) pEEPROM->EepromOrEfuse =3D (eeValue & BOOT_FROM_EEPROM) ? true : false; pEEPROM->bautoload_fail_flag =3D (eeValue & EEPROM_EN) ? false : true; -/* pHalData->EEType =3D IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPR= OM_BOOT_EFUSE; */ - _ReadEfuseInfo8723BS(padapter); } -- 2.43.0