From nobody Mon Apr 6 10:32:51 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1DEB30F7FB for ; Thu, 19 Mar 2026 14:13:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773929597; cv=none; b=cIfj2//qxUlSVabVNr++rfA3DJJS6+Ar/rlvX9f51B1r7UZ9Mlq0SO+PzYguQrH4+FXkc3NDtD6byuhE9EAOyA0lxU5K/nJN9lgOOiq8fvK2OFdStLSWVEuplUpAx3wlpgH3Ju1EotZZkXhLKgadC0jDmha73iCnOj7jCsNPrsQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773929597; c=relaxed/simple; bh=EHz3OH4NQl+5kez4lALoytwa8lBXo9ZxXlJ92g4WOaw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OYaaHvdELEPY4MTIbXCs4zYElnbNxnc18G9NiGYkD2Yi4bHnuqQaW0WK+lF4twsyo7MxUinfTsnIj/YzexwSVlc3Z+iCbacR2h4EZ5OlyOR+4E/zmb4lCRQkJyIjE1HeYlgSYCiwahypqiMUMnGy0Jy4GWu7BfabMOccM+nyxTM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SZAbuQWn; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SZAbuQWn" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-359fea895b5so739523a91.0 for ; Thu, 19 Mar 2026 07:13:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773929596; x=1774534396; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QTUhuvZrbPLi65P2qC19uSSj7YWJnMpGLDgt32EXjPU=; b=SZAbuQWnmAcsu128nADO503b9HxJnrezAz/AgkUbt2cPrhA1VFbFJoaBpzd6WcFlXp aVR6kX8M9/qDGPa67935a+qpCnq6st3FXAYqL16bCxxTI5uVIAWAPXh/k0sbQpHkXb/8 /IUtZ5OCR4le2LyGOMbYptAzmPzfdOlLPA6cbQwsUgxKdGBPxs5F6emM6SXo/WqZ6e/v D2Y+DMxVc0aKsgOp5/+4C+i0KoM9EhQa5OsyxQtSMjQCHnSJMSFYwvjJfVjL6GzF/rM5 JUsfKodv65xLAwdxAVLtWWMFHelwVJ+25YghmOnPy3ibQqNQZPG+MR6RbKpnxIj2rNpY Og9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773929596; x=1774534396; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QTUhuvZrbPLi65P2qC19uSSj7YWJnMpGLDgt32EXjPU=; b=eBOwUGEA43v9OlZTq9mVdAOhMZ8qpe1+I82bRkX/lVxRZ2ajh17hsAeKc1g0cqybUV I1Gizlh8oZSvyPaRlRJSD+ojzL/HvkhgnNKW919JxJVcrCg6KqZO7CWbcMVxZKU6sqdR 85P25Ss7f8jKFCOt9+jFeFxG/Xq4PgXKks70b3HIL6TKxlZQNMDqHgadqfr2rUBc+27/ /tsUDJ15U+VwyfjyLxMq9OlsAIFEr4/bIDXVm2ahMERvRjNViT5OmqOTwfj+T50mP3Kj ShUXu/B+v4MTtDWpQwD900Zo0ehPEpt+OkUSx1Fw5s/KXdcitkfEVkasKwUyx9/PDRR7 uwcg== X-Forwarded-Encrypted: i=1; AJvYcCXh5yz0pL4JiU9vN4Mx4bmkV9/t4zZ7KYqOKETgy/hY9gNeZhPSjXa7VIAnIRkQimnc1TAMs++JyN/UZvg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz882/QrV5UWaBS7a+ICT+4odQd87qXvHQY067TugYOE9h7YNfp vbYfOh7VX1HfN3lyC3ZvuPP9PBOTbzYgj546yv8xsMowRHJaGwoKl3WE X-Gm-Gg: ATEYQzxkxCNPI6Tql5xYeHaqHqHETLtXonWFSrj56isgFtZ385Myt89gw2zPd40tr50 OM5Kh5PzlYORP4verP1mFSJZi5vpewgnv1NxHFA5QlrKoAWpc5EdAnLIKh3uMilRy2sqj9/gvgp YNzA9xk+WexPT0nN03B7NlPXhhaOcSVxai/bsn2PwEmutpOD0z/OCdLUe+nm2bxxLS5tZLKo9bt 6Py62C6oPwvLRiyaKUqmY4DARXSCGqFyliwylr6SYlpbE2+p4RCKvgXR7PD3RtweAuyjejjlaZK /hgYVV+WfF5/bQz1N06J1DGKaAGofaYyvBgCUXfiauAJ7ljTMMYmO0VpvJNZTlGGlwymnkrRbeW fmiNLpcWsaU9s95Yj8kQrOr9SL0MKV57go67kvNbtQPrO4z1TPVwXGCq66Y+bxCTrWQ6HIh7fdt JlxnDhrTFr3GGqLGHZ431vvHLh8WF8inOjUQ== X-Received: by 2002:a17:90b:528b:b0:359:1130:1047 with SMTP id 98e67ed59e1d1-35bb9ef2e60mr6081395a91.17.1773929595832; Thu, 19 Mar 2026 07:13:15 -0700 (PDT) Received: from aadarsh.. ([2409:40d0:11f4:e9ce:f110:1acf:6031:3b39]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-c741e543d25sm5298264a12.20.2026.03.19.07.13.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 07:13:15 -0700 (PDT) From: Aadarsh Mandal To: dan.carpenter@linaro.org Cc: aadarshmandal9354@gmail.com, luka.gejak@linux.dev, ethantidmore06@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, straube.linux@gmail.com Subject: [PATCH v4] staging: rtl8723bs: removed dead code Date: Thu, 19 Mar 2026 19:42:58 +0530 Message-ID: <20260319141258.7332-1-aadarshmandal9354@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <2A37C741-68A1-47E2-AB3D-833593B5C392@linux.dev> References: <2A37C741-68A1-47E2-AB3D-833593B5C392@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" - removed the dead code. Signed-off-by: Aadarsh Mandal --- v4: - removed the space insertion. - deleted the commented codes. v3: - added the extra space that count as insertion. - removed unwanted addition. v2: - accidently deleted the braces for the standalone code blocks {}. - deleted the reindented comment code, extra space. v1: - reindented comment code,extra space remained. drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 063a0737933e..96a0c8e304da 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -481,9 +481,6 @@ static void _initSdioAggregationSetting(struct adapter = *padapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - /* Tx aggregation setting */ -/* sdio_AggSettingTxUpdate(padapter); */ - /* Rx aggregation setting */ HalRxAggr8723BSdio(padapter); @@ -635,9 +632,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) return _SUCCESS; } - /* Disable Interrupt first. */ -/* rtw_hal_disable_interrupt(padapter); */ - ret =3D _InitPowerOn_8723BS(padapter); if (ret =3D=3D _FAIL) return _FAIL; @@ -656,8 +650,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) rtl8723b_InitializeFirmwareVars(padapter); -/* SIC_Init(padapter); */ - if (pwrctrlpriv->reg_rfoff) pwrctrlpriv->rf_pwrstate =3D rf_off; @@ -740,11 +732,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel, CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET_= DONT_CARE); - /* Record original value for template. This is arough data, we can only = use the data */ - /* for power adjust. The value can not be adjustde according to differen= t power!!! */ -/* pHalData->OriginalCckTxPwrIdx =3D pHalData->CurrentCckTxPwrIdx; */ -/* pHalData->OriginalOfdm24GTxPwrIdx =3D pHalData->CurrentOfdm24GTxPwrIdx;= */ - rtl8723b_InitAntenna_Selection(padapter); /* */ @@ -786,8 +773,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* ack for xmit mgmt frames. */ rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ= _CTRL) | BIT(12)); -/* pHalData->PreRpwmVal =3D SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRP= WM1) & 0x80; */ - { pwrctrlpriv->rf_pwrstate =3D rf_on; @@ -1075,8 +1060,6 @@ static void _ReadPROMContent(struct adapter *padapter) pEEPROM->EepromOrEfuse =3D (eeValue & BOOT_FROM_EEPROM) ? true : false; pEEPROM->bautoload_fail_flag =3D (eeValue & EEPROM_EN) ? false : true; -/* pHalData->EEType =3D IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPR= OM_BOOT_EFUSE; */ - _ReadEfuseInfo8723BS(padapter); } -- 2.43.0